Re: [tor-bugs] #25607 [Core Tor/Tor]: On restart-in-process, do the right thing with thread-local storage

[Tor Bug Tracker & Wiki]

#25607: On restart-in-process, do the right thing with thread-local storage
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-triage-20180328, |  Actual Points:
  034-included-20180405, 034-roadmap-subticket,  |
  035-roadmap-subtask, 035-triaged-in-20180711   |
Parent ID:  #25510   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gaba):

 * keywords:
 s8-api, 034-triage-20180328, 034-included-20180405, 034-roadmap-
 subticket, 035-roadmap-subtask, 035-triaged-in-20180711
 =>
 034-triage-20180328, 034-included-20180405, 034-roadmap-subticket, 035
 -roadmap-subtask, 035-triaged-in-20180711
 * sponsor:  Sponsor8 =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25607 [Core Tor/Tor]: On restart-in-process, do the right thing with thread-local storage

[Tor Bug Tracker & Wiki]

#25607: On restart-in-process, do the right thing with thread-local storage
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  s8-api, 034-triage-20180328, |  Actual Points:
  034-included-20180405 034-roadmap-subticket,   |
  035-roadmap-subtask|
Parent ID:  #25510   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by nickm):

 * keywords:
 s8-api, 034-triage-20180328, 034-included-20180405 034-roadmap-
 subticket
 =>
 s8-api, 034-triage-20180328, 034-included-20180405 034-roadmap-
 subticket, 035-roadmap-subtask


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25607 [Core Tor/Tor]: On restart-in-process, do the right thing with thread-local storage

[Tor Bug Tracker & Wiki]

#25607: On restart-in-process, do the right thing with thread-local storage
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  s8-api, 034-triage-20180328, |  Actual Points:
  034-included-20180405 034-roadmap-subticket|
Parent ID:  #25510   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by nickm):

 * milestone:  Tor: 0.3.4.x-final => Tor: 0.3.5.x-final


Comment:

 This is looking to be a larger issue than I want to do post-freeze.

 Briefly: we can't clean up the thread-local storage until all the worker
 threads are done, and the main thread doesn't currently check whether the
 worker threads are done.

 We need to add the following generic mechanisms to compat_*threads:
   - A way to register a resource to get cleaned up on thread exit.
   - Some way to make sure thread-local pointers get freed on thread exit,
 on windows.  (For pthreads, we can use the native mechanism)
   - A way to check whether a thread is completed
   - A way to join a thread

 We need to use the above mechanisms in workqueue.c

 We need to shut down the workqueue on exiting the main thread.

 Once all the workqueue threads are shut down, we can delete the thread-
 local storage.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25607 [Core Tor/Tor]: On restart-in-process, do the right thing with thread-local storage

[Tor Bug Tracker & Wiki]

#25607: On restart-in-process, do the right thing with thread-local storage
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  s8-api, 034-triage-20180328, |  Actual Points:
  034-included-20180405 034-roadmap-subticket|
Parent ID:  #25510   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-

Comment (by nickm):

 (This is a must-do, since this bug represents a slow resource leak on
 embedded Tors)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25607 [Core Tor/Tor]: On restart-in-process, do the right thing with thread-local storage

[Tor Bug Tracker & Wiki]

#25607: On restart-in-process, do the right thing with thread-local storage
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  s8-api, 034-triage-20180328, |  Actual Points:
  034-included-20180405 034-roadmap-subticket|
Parent ID:  #25510   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8
-+-
Changes (by nickm):

 * keywords:  s8-api, 034-triage-20180328, 034-removed-20180328 =>
 s8-api, 034-triage-20180328, 034-included-20180405 034-roadmap-
 subticket
 * parent:   => #25510


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25607 [Core Tor/Tor]: On restart-in-process, do the right thing with thread-local storage

[Tor Bug Tracker & Wiki]

#25607: On restart-in-process, do the right thing with thread-local storage
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  s8-api
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:  Sponsor8  |
--+
 We use thread-local storage in one or two places; we should make sure that
 when tor shuts down, it's dropped, and when tor starts up again in the
 same process, it's created as an independent key.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs