Re: [tor-bugs] #25787 [Core Tor/Tor]: geoip_load_file() tests don't work on all window build environments

[Tor Bug Tracker & Wiki]

#25787: geoip_load_file() tests don't work on all window build environments
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  034-must regression tests win32  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged to 0.3.4 and forward!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25787 [Core Tor/Tor]: geoip_load_file() tests don't work on all window build environments

[Tor Bug Tracker & Wiki]

#25787: geoip_load_file() tests don't work on all window build environments
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-must regression tests win32  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by dgoulet):

 * status:  needs_review => merge_ready
 * reviewer:   => dgoulet


Comment:

 lgtm;

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25787 [Core Tor/Tor]: geoip_load_file() tests don't work on all window build environments

[Tor Bug Tracker & Wiki]

#25787: geoip_load_file() tests don't work on all window build environments
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-must regression tests win32  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 I think I fixed that with the fixup commit, though?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25787 [Core Tor/Tor]: geoip_load_file() tests don't work on all window build environments

[Tor Bug Tracker & Wiki]

#25787: geoip_load_file() tests don't work on all window build environments
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-must regression tests win32  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 clang (from travis) doesn't seem very happy with the PR :S ... https
 ://travis-ci.org/torproject/tor/jobs/390995401

 {{{
 src/test/test_geoip.c:386:12: error: no previous extern declaration for
   non-static variable 'GEOIP_CONTENT'
   [-Werror,-Wmissing-variable-declarations]
 const char GEOIP_CONTENT[] =
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25787 [Core Tor/Tor]: geoip_load_file() tests don't work on all window build environments

[Tor Bug Tracker & Wiki]

#25787: geoip_load_file() tests don't work on all window build environments
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-must regression tests win32  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * cc: juga (added)
 * status:  accepted => needs_review


Comment:

 Please see branch `bug25787` with PR at
 https://github.com/torproject/tor/pull/143 .

 The fix here IMO is to just cut the Gordian Knot and generate the files we
 need ourself rather than trying at build-time to generate paths that
 Windows tests at run-time will accept.

 cc'ing juga because juga has seen these tests since the beginning, and
 ought to see it when we admit failure :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25787 [Core Tor/Tor]: geoip_load_file() tests don't work on all window build environments

[Tor Bug Tracker & Wiki]

#25787: geoip_load_file() tests don't work on all window build environments
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  034-must regression tests win32  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  043-must regression tests win32 => 034-must regression tests
 win32


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25787 [Core Tor/Tor]: geoip_load_file() tests don't work on all window build environments

[Tor Bug Tracker & Wiki]

#25787: geoip_load_file() tests don't work on all window build environments
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  043-must regression tests win32  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 I've added a temporary fix as 8eb4a32a4dc4e9ecccb162a70b5212a9a2d3f80c ,
 but we should come up with a better one.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25787 [Core Tor/Tor]: geoip_load_file() tests don't work on all window build environments

[Tor Bug Tracker & Wiki]

#25787: geoip_load_file() tests don't work on all window build environments
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core |Version:
  Tor/Tor|
 Severity:  Normal   |   Keywords:  043-must regression tests win32
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 These tests assume that when the test binary is run, it can see the
 contents of the builddir at the same location as the original build
 process.  But that isn't always true for windows builds.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs