Re: [tor-bugs] #25939 [Core Tor/Tor]: A Tor commit seems to have broken creation of V3 onion services with stem

[Tor Bug Tracker & Wiki]

#25939: A Tor commit seems to have broken creation of V3 onion services with 
stem
+--
 Reporter:  maqp|  Owner:  dgoulet
 Type:  defect  | Status:  closed
 Priority:  High|  Milestone:  Tor:
|  0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Major   | Resolution:  fixed
 Keywords:  034-must regression tor-hs  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  asn |Sponsor:
+--
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 woo; merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25939 [Core Tor/Tor]: A Tor commit seems to have broken creation of V3 onion services with stem

[Tor Bug Tracker & Wiki]

#25939: A Tor commit seems to have broken creation of V3 onion services with 
stem
+--
 Reporter:  maqp|  Owner:  dgoulet
 Type:  defect  | Status:  merge_ready
 Priority:  High|  Milestone:  Tor:
|  0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Major   | Resolution:
 Keywords:  034-must regression tor-hs  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  asn |Sponsor:
+--
Changes (by asn):

 * status:  needs_revision => merge_ready


Comment:

 Good point. Pushed changes file to `bug25939_034_01` in my repo.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25939 [Core Tor/Tor]: A Tor commit seems to have broken creation of V3 onion services with stem

[Tor Bug Tracker & Wiki]

#25939: A Tor commit seems to have broken creation of V3 onion services with 
stem
+--
 Reporter:  maqp|  Owner:  dgoulet
 Type:  defect  | Status:  needs_revision
 Priority:  High|  Milestone:  Tor:
|  0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Major   | Resolution:
 Keywords:  034-must regression tor-hs  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  asn |Sponsor:
+--
Changes (by nickm):

 * status:  merge_ready => needs_revision


Comment:

 Looks okay, needs a changes file.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25939 [Core Tor/Tor]: A Tor commit seems to have broken creation of V3 onion services with stem

[Tor Bug Tracker & Wiki]

#25939: A Tor commit seems to have broken creation of V3 onion services with 
stem
+--
 Reporter:  maqp|  Owner:  dgoulet
 Type:  defect  | Status:  merge_ready
 Priority:  High|  Milestone:  Tor:
|  0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Major   | Resolution:
 Keywords:  034-must regression tor-hs  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  asn |Sponsor:
+--
Changes (by asn):

 * status:  needs_review => merge_ready
 * reviewer:   => asn


Comment:

 LGTM!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25939 [Core Tor/Tor]: A Tor commit seems to have broken creation of V3 onion services with stem

[Tor Bug Tracker & Wiki]

#25939: A Tor commit seems to have broken creation of V3 onion services with 
stem
+--
 Reporter:  maqp|  Owner:  dgoulet
 Type:  defect  | Status:  needs_review
 Priority:  High|  Milestone:  Tor:
|  0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Major   | Resolution:
 Keywords:  034-must regression tor-hs  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by maqp):

 dgoulet: Confirming the fix works for me
 [https://gist.github.com/maqp/78978698493ea41903005e40a7eaf059 (bash
 script)].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25939 [Core Tor/Tor]: A Tor commit seems to have broken creation of V3 onion services with stem

[Tor Bug Tracker & Wiki]

#25939: A Tor commit seems to have broken creation of V3 onion services with 
stem
+--
 Reporter:  maqp|  Owner:  dgoulet
 Type:  defect  | Status:  needs_review
 Priority:  High|  Milestone:  Tor:
|  0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Major   | Resolution:
 Keywords:  034-must regression tor-hs  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by dgoulet):

 * status:  accepted => needs_review


Comment:

 The onion address is missing in the `HS_DESC CREATED` event for an
 ephemeral v3 service.

 This was introduced by commit `f7633c1fcaefe72bf97c001bab9062132c919996`
 (in `tor-0.3.4.1-alpha`)

 With the work on #25500 (reducing CPU client usage), the HS service main
 loop callback is enabled as soon as the HS service map changes which
 happens when registering a new service. Unfortunately, for ephemeral
 services, we are building the onion address *after* the registration
 leading to the `service->onion_address` to be empty. Even in the tor logs,
 we had an empty string.

 Fix is trivial, we simply need to build the address before registration.

 Branch: `bug25939_034_01`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25939 [Core Tor/Tor]: A Tor commit seems to have broken creation of V3 onion services with stem

[Tor Bug Tracker & Wiki]

#25939: A Tor commit seems to have broken creation of V3 onion services with 
stem
+--
 Reporter:  maqp|  Owner:  dgoulet
 Type:  defect  | Status:  accepted
 Priority:  High|  Milestone:  Tor:
|  0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Major   | Resolution:
 Keywords:  034-must regression tor-hs  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by dgoulet):

 * status:  new => accepted
 * sponsor:  Sponsor8 =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25939 [Core Tor/Tor]: A Tor commit seems to have broken creation of V3 onion services with stem

[Tor Bug Tracker & Wiki]

#25939: A Tor commit seems to have broken creation of V3 onion services with 
stem
+--
 Reporter:  maqp|  Owner:  dgoulet
 Type:  defect  | Status:  new
 Priority:  High|  Milestone:  Tor:
|  0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Major   | Resolution:
 Keywords:  034-must regression tor-hs  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:  Sponsor8
+--

Comment (by maqp):

 Atagar: Just confirming we get the same error message.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25939 [Core Tor/Tor]: A Tor commit seems to have broken creation of V3 onion services with stem

[Tor Bug Tracker & Wiki]

#25939: A Tor commit seems to have broken creation of V3 onion services with 
stem
+--
 Reporter:  maqp|  Owner:  dgoulet
 Type:  defect  | Status:  new
 Priority:  High|  Milestone:  Tor:
|  0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Major   | Resolution:
 Keywords:  034-must regression tor-hs  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:  Sponsor8
+--
Changes (by atagar):

 * status:  needs_information => new


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25939 [Core Tor/Tor]: A Tor commit seems to have broken creation of V3 onion services with stem

[Tor Bug Tracker & Wiki]

#25939: A Tor commit seems to have broken creation of V3 onion services with 
stem
+--
 Reporter:  maqp|  Owner:  dgoulet
 Type:  defect  | Status:
|  needs_information
 Priority:  High|  Milestone:  Tor:
|  0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Major   | Resolution:
 Keywords:  034-must regression tor-hs  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:  Sponsor8
+--
Changes (by atagar):

 * component:  Core Tor/Stem => Core Tor/Tor


Comment:

 Hi maqp, think I see the issues. When I run the following...

 {{{
 import stem.control

 with stem.control.Controller.from_port() as controller:
   controller.authenticate()

   result = controller.create_ephemeral_hidden_service(80, key_content =
 'ED25519-V3', await_publication = True)
   print('service established at %s.onion\n' % result.service_id)
   raw_input('press any key to quit...')
 }}}

 I get...

 {{{
 Exception in thread Event Notifier:
 Traceback (most recent call last):
   File "/usr/lib/python2.7/threading.py", line 801, in __bootstrap_inner
 self.run()
   File "/usr/lib/python2.7/threading.py", line 754, in run
 self.__target(*self.__args, **self.__kwargs)
   File "/home/atagar/Desktop/stem/stem/control.py", line 966, in
 _event_loop
 self._handle_event(event_message)
   File "/home/atagar/Desktop/stem/stem/control.py", line 3830, in
 _handle_event
 stem.response.convert('EVENT', event_message, arrived_at =
 time.time())
   File "/home/atagar/Desktop/stem/stem/response/__init__.py", line 124, in
 convert
 message._parse_message(**kwargs)
   File "/home/atagar/Desktop/stem/stem/response/events.py", line 66, in
 _parse_message
 self._parse()
   File "/home/atagar/Desktop/stem/stem/response/events.py", line 683, in
 _parse
 raise stem.ProtocolError("HS_DESC's directory doesn't match a
 ServerSpec: %s" % self)
 ProtocolError: HS_DESC's directory doesn't match a ServerSpec: HS_DESC
 CREATED  UNKNOWN UNKNOWN nZ5mr9/xASJHx/Fo7JpHialB5E0kC7jFJtaAXNgkPqY
 }}}

 Note the two spaces between 'CREATED' and 'UNKNOWN'. The problem here is
 that tor is filling in an empty string for the HS_DESC's 'Action'. It
 should be...

 {{{
 Action =  "REQUESTED" / "UPLOAD" / "RECEIVED" / "UPLOADED" / "IGNORE" /
   "FAILED" / "CREATED"
 }}}

 This in turn causes Stem to think that the DescriptorID value is the
 fourth field, and it is invalid as the HsDir.

 Sending this back over to tor.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25939 [Core Tor/Tor]: A Tor commit seems to have broken creation of V3 onion services with stem

[Tor Bug Tracker & Wiki]

#25939: A Tor commit seems to have broken creation of V3 onion services with 
stem
+--
 Reporter:  maqp|  Owner:  dgoulet
 Type:  defect  | Status:  reopened
 Priority:  High|  Milestone:  Tor:
|  0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Major   | Resolution:
 Keywords:  034-must regression tor-hs  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:  Sponsor8
+--
Changes (by maqp):

 * status:  closed => reopened
 * resolution:  implemented =>


Comment:

 I'm reopening the ticket. Please close it and let me know if you want me
 to create a new one for the new bug.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25939 [Core Tor/Tor]: A Tor commit seems to have broken creation of V3 onion services with stem

[Tor Bug Tracker & Wiki]

#25939: A Tor commit seems to have broken creation of V3 onion services with 
stem
+--
 Reporter:  maqp|  Owner:  dgoulet
 Type:  defect  | Status:  closed
 Priority:  High|  Milestone:  Tor:
|  0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Major   | Resolution:  implemented
 Keywords:  034-must regression tor-hs  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:  Sponsor8
+--

Comment (by maqp):

 Hi everyone, thank you for reacting so quickly. Unfortunately the fixed
 version now throws another error.
 [https://gist.github.com/maqp/f806be94640f0c3c7d52f36d1faff74c Here] is
 the traceback. You can reproduce it by commenting out both `git reset`
 lines in the bash script above (which then defaults to Tor's master
 branch).

 atagar: Thank you so much for the advice, it really helped me simplify the
 code I'm using.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25939 [Core Tor/Tor]: A Tor commit seems to have broken creation of V3 onion services with stem

[Tor Bug Tracker & Wiki]

#25939: A Tor commit seems to have broken creation of V3 onion services with 
stem
+--
 Reporter:  maqp|  Owner:  dgoulet
 Type:  defect  | Status:  closed
 Priority:  High|  Milestone:  Tor:
|  0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Major   | Resolution:  implemented
 Keywords:  034-must regression tor-hs  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:  Sponsor8
+--
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => implemented


Comment:

 This looks like an okay fix for me; it's probably simplest just to rescan
 the whole list.

 Merging to master!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25939 [Core Tor/Tor]: A Tor commit seems to have broken creation of V3 onion services with stem

[Tor Bug Tracker & Wiki]

#25939: A Tor commit seems to have broken creation of V3 onion services with 
stem
+--
 Reporter:  maqp|  Owner:  dgoulet
 Type:  defect  | Status:  needs_review
 Priority:  High|  Milestone:  Tor:
|  0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Major   | Resolution:
 Keywords:  034-must regression tor-hs  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:  Sponsor8
+--
Changes (by dgoulet):

 * status:  accepted => needs_review


Comment:

 See branch: `bug25939_034_01`.
 https://github.com/torproject/tor/pull/63

 Three commits in there. First one is to support a rescan of the event list
 from the unit tests without it being initialized. Most unit tests don't
 need to deal with this list.

 Second commit is the fix for which I took the approach of rescanning the
 event list down in the stack instead for instance from the control port
 `ADD/DEL_ONION` command. The reason is that I wanted to avoid any future
 changes to bother with enabling the event. Bottom line is that if we have
 a service in our global map, the event *needs* to be enabled, period. One
 can argue here that we could instead implementa  way to only enable the
 HS_SERVICE role event(s) instead of fully rescanning the list? Like a
 `periodic_event_enable_by_role(r)` call?

 Third commit is a unit test.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25939 [Core Tor/Tor]: A Tor commit seems to have broken creation of V3 onion services with stem

[Tor Bug Tracker & Wiki]

#25939: A Tor commit seems to have broken creation of V3 onion services with 
stem
+--
 Reporter:  maqp|  Owner:  dgoulet
 Type:  defect  | Status:  accepted
 Priority:  High|  Milestone:  Tor:
|  0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Major   | Resolution:
 Keywords:  034-must regression tor-hs  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:  Sponsor8
+--
Changes (by dgoulet):

 * owner:  (none) => dgoulet
 * cc: dgoulet (removed)
 * status:  new => accepted
 * keywords:  034-must regression => 034-must regression tor-hs


Comment:

 Oh good catch.

 This is caused because the HS service main loop event (that basically
 handles the entire HS subsystem) is not enabled if you have no service
 configured. And it gets enabled if you configure one through the torrc.

 However, it fails to be enabled through `ADD_ONION` on the control port...
 I can fix that asap. Thanks for the report!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25939 [Core Tor/Tor]: A Tor commit seems to have broken creation of V3 onion services with stem

[Tor Bug Tracker & Wiki]

#25939: A Tor commit seems to have broken creation of V3 onion services with 
stem
-+
 Reporter:  maqp |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Major| Resolution:
 Keywords:  034-must regression  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:  Sponsor8
-+
Changes (by asn):

 * cc: asn (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25939 [Core Tor/Tor]: A Tor commit seems to have broken creation of V3 onion services with stem

[Tor Bug Tracker & Wiki]

#25939: A Tor commit seems to have broken creation of V3 onion services with 
stem
-+
 Reporter:  maqp |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Major| Resolution:
 Keywords:  034-must regression  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:  Sponsor8
-+

Comment (by atagar):

 Thanks maqp! Quick note from the peanut gallery regarding
 
[https://gist.githubusercontent.com/maqp/bf2d14ec625556997ae075d2084b4a4c/raw/6a4353336a76350b7511bd65dcc6183efb6bf215/v3_onion_test.py
 your script] - you might want to take a peek at stem.process. There's no
 need to manually write a torrc yourself. :)

 
https://stem.torproject.org/api/process.html#stem.process.launch_tor_with_config

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25939 [Core Tor/Tor]: A Tor commit seems to have broken creation of V3 onion services with stem

[Tor Bug Tracker & Wiki]

#25939: A Tor commit seems to have broken creation of V3 onion services with 
stem
-+
 Reporter:  maqp |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Major| Resolution:
 Keywords:  034-must regression  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:  Sponsor8
-+
Changes (by nickm):

 * priority:  Medium => High
 * cc: dgoulet (added)
 * sponsor:   => Sponsor8
 * keywords:   => 034-must regression
 * milestone:   => Tor: 0.3.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25939 [Core Tor/Tor]: A Tor commit seems to have broken creation of V3 onion services with stem

[Tor Bug Tracker & Wiki]

#25939: A Tor commit seems to have broken creation of V3 onion services with 
stem
--+
 Reporter:  maqp  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Major |   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 The commit in question is
 
[https://gitweb.torproject.org/tor.git/commit/?id=a4fcdc5decfe60bbd95aee2e5586e90c40b73225
 this].

 [https://gist.github.com/maqp/5ea6cf41a836c290b22ec302213d8a00 Here] is a
 bash script that helps reproduce the bug. By default the script uses the
 
[https://gitweb.torproject.org/tor.git/commit/?id=ed89bb32535fbf354b406a36f3176380a4e226bf
 last working commit]. Comment line 22 and uncomment line 23 and run it
 again to see how the
 
[https://gist.githubusercontent.com/maqp/bf2d14ec625556997ae075d2084b4a4c/raw/6a4353336a76350b7511bd65dcc6183efb6bf215/v3_onion_test.py
 python script] launched by the bash script is unable to bring V3 onion
 service online with stem.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs