Re: [tor-bugs] #26156 [Core Tor/Tor]: Undefined references to EVP_CIPHER_CTX_cleanup() with OpenSSL 1.1.0 no-deprecated

[Tor Bug Tracker & Wiki]

#26156: Undefined references to EVP_CIPHER_CTX_cleanup() with OpenSSL 1.1.0 no-
deprecated
+
 Reporter:  laomaiweng  |  Owner:  nickm
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.4.1-alpha
 Severity:  Normal  | Resolution:  fixed
 Keywords:  openssl tor-crypto  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:  SponsorZ
+
Changes (by nickm):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 Please feel free to reopen this ticket if there is a remaining problem
 here, but if you do, please explain what the problem is.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26156 [Core Tor/Tor]: Undefined references to EVP_CIPHER_CTX_cleanup() with OpenSSL 1.1.0 no-deprecated

[Tor Bug Tracker & Wiki]

#26156: Undefined references to EVP_CIPHER_CTX_cleanup() with OpenSSL 1.1.0 no-
deprecated
+
 Reporter:  laomaiweng  |  Owner:  nickm
 Type:  defect  | Status:  reopened
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.4.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  openssl tor-crypto  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:  SponsorZ
+

Comment (by nickm):

 Why did you reopen this ticket?  Is there a remaining bug here?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26156 [Core Tor/Tor]: Undefined references to EVP_CIPHER_CTX_cleanup() with OpenSSL 1.1.0 no-deprecated

[Tor Bug Tracker & Wiki]

#26156: Undefined references to EVP_CIPHER_CTX_cleanup() with OpenSSL 1.1.0 no-
deprecated
+
 Reporter:  laomaiweng  |  Owner:  nickm
 Type:  defect  | Status:  reopened
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.4.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  openssl tor-crypto  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:  SponsorZ
+
Changes (by hitman47):

 * status:  closed => reopened
 * resolution:  fixed =>
 * sponsor:   => SponsorZ


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26156 [Core Tor/Tor]: Undefined references to EVP_CIPHER_CTX_cleanup() with OpenSSL 1.1.0 no-deprecated

[Tor Bug Tracker & Wiki]

#26156: Undefined references to EVP_CIPHER_CTX_cleanup() with OpenSSL 1.1.0 no-
deprecated
+
 Reporter:  laomaiweng  |  Owner:  nickm
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.4.1-alpha
 Severity:  Normal  | Resolution:  fixed
 Keywords:  openssl tor-crypto  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Okay -- merged to master!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26156 [Core Tor/Tor]: Undefined references to EVP_CIPHER_CTX_cleanup() with OpenSSL 1.1.0 no-deprecated

[Tor Bug Tracker & Wiki]

#26156: Undefined references to EVP_CIPHER_CTX_cleanup() with OpenSSL 1.1.0 no-
deprecated
+
 Reporter:  laomaiweng  |  Owner:  nickm
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.4.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  openssl tor-crypto  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+

Comment (by laomaiweng):

 Works fine for me both with OpenSSL 1.1.0 and 1.0.1.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26156 [Core Tor/Tor]: Undefined references to EVP_CIPHER_CTX_cleanup() with OpenSSL 1.1.0 no-deprecated

[Tor Bug Tracker & Wiki]

#26156: Undefined references to EVP_CIPHER_CTX_cleanup() with OpenSSL 1.1.0 no-
deprecated
+
 Reporter:  laomaiweng  |  Owner:  nickm
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.4.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  openssl tor-crypto  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+
Changes (by nickm):

 * status:  accepted => needs_review


Comment:

 I've tried the approach you suggest in my branch `bug26156_034`; pull
 request at https://github.com/torproject/tor/pull/120

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26156 [Core Tor/Tor]: Undefined references to EVP_CIPHER_CTX_cleanup() with OpenSSL 1.1.0 no-deprecated

[Tor Bug Tracker & Wiki]

#26156: Undefined references to EVP_CIPHER_CTX_cleanup() with OpenSSL 1.1.0 no-
deprecated
+
 Reporter:  laomaiweng  |  Owner:  nickm
 Type:  defect  | Status:  accepted
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.4.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  openssl tor-crypto  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+
Changes (by nickm):

 * status:  new => accepted
 * owner:  (none) => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26156 [Core Tor/Tor]: Undefined references to EVP_CIPHER_CTX_cleanup() with OpenSSL 1.1.0 no-deprecated

[Tor Bug Tracker & Wiki]

#26156: Undefined references to EVP_CIPHER_CTX_cleanup() with OpenSSL 1.1.0 no-
deprecated
+
 Reporter:  laomaiweng  |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.4.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  openssl tor-crypto  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+
Changes (by asn):

 * keywords:  openssl => openssl tor-crypto
 * milestone:   => Tor: 0.3.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26156 [Core Tor/Tor]: Undefined references to EVP_CIPHER_CTX_cleanup() with OpenSSL 1.1.0 no-deprecated

[Tor Bug Tracker & Wiki]

#26156: Undefined references to EVP_CIPHER_CTX_cleanup() with OpenSSL 1.1.0 no-
deprecated
--+
 Reporter:  laomaiweng|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.3.4.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  openssl   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by laomaiweng):

 By the way thanks for all the work on OpenSSL 1.1 support in #19429. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26156 [Core Tor/Tor]: Undefined references to EVP_CIPHER_CTX_cleanup() with OpenSSL 1.1.0 no-deprecated

[Tor Bug Tracker & Wiki]

#26156: Undefined references to EVP_CIPHER_CTX_cleanup() with OpenSSL 1.1.0 no-
deprecated
--+
 Reporter:  laomaiweng|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.3.4.1-alpha
 Severity:  Normal|   Keywords:  openssl
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 On my machine with OpenSSL 1.1.0 `no-deprecated', Tor 0.3.4.1-alpha fails
 to build. The failure happens when linking several utilities, with the
 following error:

 {{{
 src/common/libor-crypto.a(aes.o): In function `aes_cipher_free_':
 /home/quentin/Security/Code/Tor/tor/src/common/aes.c:121: undefined
 reference to `EVP_CIPHER_CTX_cleanup'
 }}}

 This appears to be due to ''src/common/aes.c'' not #include-ing
 "compat_openssl.h", and thus not having the OPENSSL_1_1_API #define.
 Simply adding {{{#include "compat_openssl.h"}}} in ''aes.c'' fixes the
 build.
 I have also checked that building still succeeds against OpenSSL 1.0.1 and
 1.0.2 with this modification.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs