Re: [tor-bugs] #26245 [Core Tor/Tor]: Unused Rust code warnings

2018-06-16 Thread Tor Bug Tracker & Wiki 
#26245: Unused Rust code warnings
+
 Reporter:  teor|  Owner:  catalyst
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.4.1-alpha
 Severity:  Normal  | Resolution:  implemented
 Keywords:  034-must, rust  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  isis|Sponsor:
+
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => implemented


Comment:

 lgtm for 0.3.4.  Merged, added a changes file, merged forward.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26245 [Core Tor/Tor]: Unused Rust code warnings

2018-06-15 Thread Tor Bug Tracker & Wiki 
#26245: Unused Rust code warnings
+
 Reporter:  teor|  Owner:  catalyst
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.4.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  034-must, rust  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  isis|Sponsor:
+

Comment (by isis):

 Okay, catalyst's code looks good to me. I've added some patches on top of
 their code in my `bug26245` branch to fix the warnings/errors.

 Could someone else please review my additional changes?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26245 [Core Tor/Tor]: Unused Rust code warnings

2018-06-15 Thread Tor Bug Tracker & Wiki 
#26245: Unused Rust code warnings
+
 Reporter:  teor|  Owner:  catalyst
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.4.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  034-must, rust  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  isis|Sponsor:
+
Changes (by isis):

 * reviewer:   => isis


Comment:

 I'll review and add patches for removing the `smartlist_t` definition and
 `N_DIGEST_ALGORITHMS` (which it appears we don't use in the C code
 either?).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26245 [Core Tor/Tor]: Unused Rust code warnings

2018-06-15 Thread Tor Bug Tracker & Wiki 
#26245: Unused Rust code warnings
+
 Reporter:  teor|  Owner:  catalyst
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.4.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  034-must, rust  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+
Changes (by catalyst):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26245 [Core Tor/Tor]: Unused Rust code warnings

2018-06-15 Thread Tor Bug Tracker & Wiki 
#26245: Unused Rust code warnings
+
 Reporter:  teor|  Owner:  catalyst
 Type:  defect  | Status:  assigned
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.4.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  034-must, rust  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+
Changes (by catalyst):

 * owner:  isis => catalyst


Comment:

 Patch for `--enable-fatal-warnings` in
 https://github.com/tlyu/tor/tree/bug26245

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26245 [Core Tor/Tor]: Unused Rust code warnings

2018-06-02 Thread Tor Bug Tracker & Wiki 
#26245: Unused Rust code warnings
+
 Reporter:  teor|  Owner:  isis
 Type:  defect  | Status:  assigned
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.4.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  034-must, rust  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+
Changes (by nickm):

 * owner:  (none) => isis
 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26245 [Core Tor/Tor]: Unused Rust code warnings

2018-06-02 Thread Tor Bug Tracker & Wiki 
#26245: Unused Rust code warnings
+
 Reporter:  teor|  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.4.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  034-must, rust  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+

Comment (by isis):

 Replying to [comment:2 nickm]:
 > Replying to [comment:1 catalyst]:
 > > Do we want to make warnings fatal when building Rust? Maybe only if
 `--enable-fatal-warnings` is set?
 >
 > +1

 +2

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26245 [Core Tor/Tor]: Unused Rust code warnings

2018-06-02 Thread Tor Bug Tracker & Wiki 
#26245: Unused Rust code warnings
+
 Reporter:  teor|  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.4.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  034-must, rust  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+
Changes (by isis):

 * keywords:  034-must-maybe, rust => 034-must, rust


Comment:

 Unclobbering the keywords.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26245 [Core Tor/Tor]: Unused Rust code warnings

2018-06-02 Thread Tor Bug Tracker & Wiki 
#26245: Unused Rust code warnings
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.4.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  034-must-maybe, rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by isis):

 * keywords:  034-must, rust => 034-must-maybe, rust


Comment:

 I suspect this is caused by #26267.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26245 [Core Tor/Tor]: Unused Rust code warnings

2018-06-02 Thread Tor Bug Tracker & Wiki 
#26245: Unused Rust code warnings
+
 Reporter:  teor|  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.4.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  034-must, rust  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+
Changes (by nickm):

 * keywords:  034-must-maybe, rust => 034-must, rust


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26245 [Core Tor/Tor]: Unused Rust code warnings

2018-05-31 Thread Tor Bug Tracker & Wiki 
#26245: Unused Rust code warnings
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.4.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  034-must-maybe, rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 Replying to [comment:1 catalyst]:
 > Do we want to make warnings fatal when building Rust? Maybe only if
 `--enable-fatal-warnings` is set?

 +1

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26245 [Core Tor/Tor]: Unused Rust code warnings

2018-05-31 Thread Tor Bug Tracker & Wiki 
#26245: Unused Rust code warnings
--+
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.4.1-alpha
 Severity:  Normal| Resolution:
 Keywords:  034-must-maybe, rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by catalyst):

 Do we want to make warnings fatal when building Rust? Maybe only if
 `--enable-fatal-warnings` is set?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26245 [Core Tor/Tor]: Unused Rust code warnings

2018-05-30 Thread Tor Bug Tracker & Wiki 
#26245: Unused Rust code warnings
--+--
 Reporter:  teor  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.4.1-alpha
 Severity:  Normal|   Keywords:  034-must-maybe, rust
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 Recent Rust versions (1.26.1) report the following warnings on master:
 {{{
 warning: constant item is never used: `N_DIGEST_ALGORITHMS`
   --> external/crypto_digest.rs:74:1
|
 74 | const N_DIGEST_ALGORITHMS: usize = DIGEST_SHA3_512 as usize + 1;
| 
|
= note: #[warn(dead_code)] on by default

 warning: type alias is never used: `smartlist_t`
--> external/crypto_digest.rs:120:1
 |
 120 | type smartlist_t = Stringlist;
 | ^^
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs