Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201808,  |  Actual Points:
  TorBrowserTeam201808   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_information => new


Comment:

 Not setting `LLVM_RUSTLLVM` does not change things as you expected. So, I
 *could* do the LLVM bisecting with LLVM built during the rust compilation
 to give us a better hint at what is going wrong. However, I'd like to
 avoid that as it's probably a tedious pain in the rear and while the LLVM
 upgrade is triggering the bug it's probably nothing we should fix on the
 LLVM side. I'll think about something smarter and will go back to this bug
 after we got Tor Browser 8 out.

 We might stick to just building LLVM outside of rust for macOS cross-
 compilation for the time being to move around this issue.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201808,  |  Actual Points:
  TorBrowserTeam201808   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by alexcrichton):

 Hm so if LLVM is compiled exactly the same way that is indeed a little
 worrisome. One other thing we do is that if we're compiling an in-tree
 LLVM we specify the `LLVM_RUSTLLVM` define for C++ code (here -
 https://github.com/rust-
 
lang/rust/blob/bf1e461173e3936e4014cc951dfbdd7d9ec9190b/src/bootstrap/compile.rs#L736-L740).
 That's used for a few minor features but none that should touch the
 reproducibility of the build in theory...

 I'm running out of ideas unfortunately :(

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201808,  |  Actual Points:
  TorBrowserTeam201808   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:34 alexcrichton]:
 > Nice! Bisecting to the LLVM upgrade definitely makes sense to me. That
 was a massive LLVM upgrade though (from LLVM 4.0 to LLVM 6.0), so that
 would be quite the bisection range for a regression to be introduced in :(
 >
 > If it works, though, when you build LLVM yourself that's quite curious.
 The command we use to build LLVM though is pretty huge. Looking at one of
 our  recent builds (https://travis-ci.org/rust-lang/rust/builds/411219658)
 the command we use on OSX is:
 >
 > {{{
 > "cmake" "/Users/travis/build/rust-lang/rust/src/llvm"
 "-DLLVM_ENABLE_ASSERTIONS=OFF"
 
"-DLLVM_TARGETS_TO_BUILD=X86;ARM;AArch64;Mips;PowerPC;SystemZ;MSP430;Sparc;NVPTX;Hexagon"
 "-DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD=WebAssembly;RISCV"
 "-DLLVM_INCLUDE_EXAMPLES=OFF" "-DLLVM_INCLUDE_TESTS=OFF"
 "-DLLVM_INCLUDE_DOCS=OFF" "-DLLVM_ENABLE_ZLIB=OFF" "-DWITH_POLLY=OFF"
 "-DLLVM_ENABLE_TERMINFO=OFF" "-DLLVM_ENABLE_LIBEDIT=OFF"
 "-DLLVM_ENABLE_LIBXML2=OFF" "-DLLVM_PARALLEL_COMPILE_JOBS=4"
 "-DLLVM_TARGET_ARCH=x86_64" "-DLLVM_DEFAULT_TARGET_TRIPLE=x86_64-apple-
 darwin" "-DLLVM_OCAML_INSTALL_PATH=usr/lib/ocaml"
 "-DCMAKE_EXE_LINKER_FLAGS=-static-libstdc++" "-DCMAKE_C_COMPILER=sccache"
 "-DCMAKE_C_COMPILER_ARG1=/Users/travis/build/rust-
 lang/rust/clang+llvm-6.0.0-x86_64-apple-darwin/bin/clang"
 "-DCMAKE_CXX_COMPILER=sccache"
 "-DCMAKE_CXX_COMPILER_ARG1=/Users/travis/build/rust-
 lang/rust/clang+llvm-6.0.0-x86_64-apple-darwin/bin/clang++"
 "-DCMAKE_C_FLAGS=-ffunction-sections -fdata-sections -fPIC --target=x86_64
 -apple-darwin -stdlib=libc++" "-DCMAKE_CXX_FLAGS=-ffunction-sections
 -fdata-sections -fPIC --target=x86_64-apple-darwin -stdlib=libc++"
 "-DCMAKE_INSTALL_PREFIX=/Users/travis/build/rust-lang/rust/build/x86_64
 -apple-darwin/llvm" "-DCMAKE_BUILD_TYPE=Release"
 > }}}
 >
 > I wonder if perhaps the way we compile LLVM is affecting this? Maybe
 some flag or maybe our own compiler we use on automation is introducing
 bugs? Or maybe it has to do with the C++ standard library and which is
 used?

 Well, I dont't know whether the problem we have is happening when using
 the "official" binaries. This is happening when cross-compiling rust
 ourselves for macOS. That said, I think I can exclude 1) from comment:33.
 I compiled LLVM with exactly the same arguments as used during the rust
 build (using the same runc container, compiler etc.) which are:
 {{{
 cmake .. -G "Unix Makefiles" -DLLVM_ENABLE_ASSERTIONS=OFF
 
-DLLVM_TARGETS_TO_BUILD="X86;ARM;AArch64;Mips;PowerPC;SystemZ;MSP430;Sparc;NVPTX;Hexagon"
 -DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD=WebAssembly
 -DLLVM_INCLUDE_EXAMPLES=OFF -DLLVM_INCLUDE_TESTS=OFF
 -DLLVM_INCLUDE_DOCS=OFF -DLLVM_ENABLE_ZLIB=OFF -DWITH_POLLY=OFF
 -DLLVM_ENABLE_TERMINFO=OFF -DLLVM_ENABLE_LIBEDIT=OFF
 -DLLVM_PARALLEL_COMPILE_JOBS=4 -DLLVM_TARGET_ARCH=x86_64
 -DLLVM_DEFAULT_TARGET_TRIPLE=x86_64-unknown-linux-gnu
 -DLLVM_LINK_LLVM_DYLIB=ON -DCMAKE_C_COMPILER=cc -DCMAKE_CXX_COMPILER=c++
 -DCMAKE_C_FLAGS="-ffunction-sections -fdata-sections -fPIC -m64"
 -DCMAKE_CXX_FLAGS="-ffunction-sections -fdata-sections -fPIC -m64"
 -DCMAKE_INSTALL_PREFIX=$distdir -DCMAKE_BUILD_TYPE:String=Release
 -DLLVM_INSTALL_UTILS=on $LLVM_HOME
 }}}
 (`-DLLVM_INSTALL_UTILS=on` is only used when compiling LLVM outside of the
 rust compilation but I doubt this would make a difference with respect to
 this bug)

 and used it with `--llvm-root` and the test script is running fine.

 Which leaves 2). I reverted the `dlmalloc` and `libcompiler_builtins
 /compiler-rt` submodule updates but compiling LLVM during the rust build
 still exhibits the failing test script. Thus, I think those updates does
 not cause this bug. I wonder what else is different between the in-tree
 LLVM compilation and the one outside of it (I am just tarring up src/llvm,
 excluding `.git`, using that tarball for compilation)...

--
Ticket URL: 
Tor Bug Tracker & Wiki 

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201808,  |  Actual Points:
  TorBrowserTeam201808   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by alexcrichton):

 Nice! Bisecting to the LLVM upgrade definitely makes sense to me. That was
 a massive LLVM upgrade though (from LLVM 4.0 to LLVM 6.0), so that would
 be quite the bisection range for a regression to be introduced in :(

 If it works, though, when you build LLVM yourself that's quite curious.
 The command we use to build LLVM though is pretty huge. Looking at one of
 our  recent builds (https://travis-ci.org/rust-lang/rust/builds/411219658)
 the command we use on OSX is:

 {{{
 "cmake" "/Users/travis/build/rust-lang/rust/src/llvm"
 "-DLLVM_ENABLE_ASSERTIONS=OFF"
 
"-DLLVM_TARGETS_TO_BUILD=X86;ARM;AArch64;Mips;PowerPC;SystemZ;MSP430;Sparc;NVPTX;Hexagon"
 "-DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD=WebAssembly;RISCV"
 "-DLLVM_INCLUDE_EXAMPLES=OFF" "-DLLVM_INCLUDE_TESTS=OFF"
 "-DLLVM_INCLUDE_DOCS=OFF" "-DLLVM_ENABLE_ZLIB=OFF" "-DWITH_POLLY=OFF"
 "-DLLVM_ENABLE_TERMINFO=OFF" "-DLLVM_ENABLE_LIBEDIT=OFF"
 "-DLLVM_ENABLE_LIBXML2=OFF" "-DLLVM_PARALLEL_COMPILE_JOBS=4"
 "-DLLVM_TARGET_ARCH=x86_64" "-DLLVM_DEFAULT_TARGET_TRIPLE=x86_64-apple-
 darwin" "-DLLVM_OCAML_INSTALL_PATH=usr/lib/ocaml"
 "-DCMAKE_EXE_LINKER_FLAGS=-static-libstdc++" "-DCMAKE_C_COMPILER=sccache"
 "-DCMAKE_C_COMPILER_ARG1=/Users/travis/build/rust-
 lang/rust/clang+llvm-6.0.0-x86_64-apple-darwin/bin/clang"
 "-DCMAKE_CXX_COMPILER=sccache"
 "-DCMAKE_CXX_COMPILER_ARG1=/Users/travis/build/rust-
 lang/rust/clang+llvm-6.0.0-x86_64-apple-darwin/bin/clang++"
 "-DCMAKE_C_FLAGS=-ffunction-sections -fdata-sections -fPIC --target=x86_64
 -apple-darwin -stdlib=libc++" "-DCMAKE_CXX_FLAGS=-ffunction-sections
 -fdata-sections -fPIC --target=x86_64-apple-darwin -stdlib=libc++"
 "-DCMAKE_INSTALL_PREFIX=/Users/travis/build/rust-lang/rust/build/x86_64
 -apple-darwin/llvm" "-DCMAKE_BUILD_TYPE=Release"
 }}}

 I wonder if perhaps the way we compile LLVM is affecting this? Maybe some
 flag or maybe our own compiler we use on automation is introducing bugs?
 Or maybe it has to do with the C++ standard library and which is used?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, GeorgKoppen201808,  |  Actual Points:
  TorBrowserTeam201808   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Alright, so, the problematic commit is
 6b7b6b63a928479a29d9fc1282e553e409c66934. I tried to bisect LLVM to find
 out the bad revision. I compiled just LLVM separately and used `--llvm-
 root` to point to it during the rust build. It turns out that doing that,
 even with just the llvm code copied out of rust/src/llvm being on commit
 6b7b6b63a928479a29d9fc1282e553e409c66934 is fine. However, double-
 checking, building LLVM during the usual rust build (i.e. without `--llvm-
 root`) still reproduces the bug.

 Thus, I can only think of two reasons causing the reprouducibility issue:

 1) The LLVM part is compiled differently within rust than I did. The
 compiler used is the same, though, not sure what other flags could cause
 this. I am doing
 {{{
 cmake .. -G "Unix Makefiles" -DCMAKE_INSTALL_PREFIX=$distdir
 -DCMAKE_BUILD_TYPE:STRING=Release -DLLVM_INSTALL_UTILS=on $LLVM_HOME
 }}}
 in the `--llvm-root` build which seems to be not overly fancy.

 2) There are additional pieces getting compiled in/used during the LLVM
 compilation done during the rust build that are causing the problem.

 I need to think more about how to proceed but, Alex, if you have any ideas
 that would be appreciated. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201807,   |  Actual Points:
  GeorgKoppen201807  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:29 alexcrichton]:
 > Hm fascinating! That's a good data point towards "maybe fixed" in LLVM
 but only accidentally for one platform rather than across the board?

 I actually think the issue glandium had and we have are not the same but
 probably related: the macOS one is happening with the upgrade to LLVM 6 (I
 am about to start bisecting those changes) while Linux is unaffected by
 that. But I'll have clues for the latter as well, but macOS first.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201807,   |  Actual Points:
  GeorgKoppen201807  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by alexcrichton):

 Hm fascinating! That's a good data point towards "maybe fixed" in LLVM but
 only accidentally for one platform rather than across the board?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201807,   |  Actual Points:
  GeorgKoppen201807  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Interesting, look what I get after trying to run the repro script for the
 macOS target after the bump to LLVM 7 (i.e. with the nightly from
 2017-07-13):
 {{{
 + for i in `seq 1 100`
 + rm -rf a b
 + mkdir a b
 + rustc /dev/stdin -O -C lto -C panic=abort -C codegen-units=1 --emit
 llvm-ir,obj --crate-type staticlib --out-dir a --target x86_64-apple-
 darwin
 + rustc /dev/stdin -O -C lto -C panic=abort -C codegen-units=1 --emit
 llvm-ir,obj --crate-type staticlib --out-dir b --target x86_64-apple-
 darwin
 ++ md5sum a/stdin.ll
 ++ awk '{print $1}'
 + a=d3665a14a5cf9bf1c4630c001e8d4dfc
 ++ md5sum b/stdin.ll
 ++ awk '{print $1}'
 + b=4d3336f9f9c5bc4b91653c1fc51d0bf6
 + '[' d3665a14a5cf9bf1c4630c001e8d4dfc '!='
 4d3336f9f9c5bc4b91653c1fc51d0bf6 ']'
 + echo IR is different
 IR is different
 + exit 1
 }}}
 Linux is fine (which is probably what glandium found).

 FWIW: I see different objects for macOS with the repro script when using
 the nightly from 2018-07-11, so, indeed, I did not do enough Firefox
 compilations to trigger the problem for macOS there.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201807,   |  Actual Points:
  GeorgKoppen201807  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:23 gk]:
 > Replying to [comment:22 alexcrichton]:
 > > Hm interesting! I wonder if this is perhaps related to
 https://github.com/rust-lang/rust/issues/52044? That claims it was fixed
 with the most recent LLVM upgrade. Are you able to reproduce the non-
 determinism on the most recent nightly?

 [snip]

 > Trying to figure out where all this started, I am pretty sure that
 2018-02-15 is good and 2018-03-07 is bad.

 So, here is another interesting bit: While running the script
 (https://github.com/rust-lang/rust/issues/52044#issuecomment-402349038) on
 a Linux box does replicate the issue for a Linux build using the nightly
 from 2018-07-11, it does not replicate it using the nightly from
 2018-03-07 (I ran the script a couple of times). On the other hand, using
 the nightly from 2018-03-07 to generate a Firefox build for macOS does
 show differences (while, as mentioned above, I seemingly can't reproduce
 the problem with the nightly from 2018-07-11 anymore when cross-compiling
 for macOS).

 To test better I adapted your repro script and added a respective
 `--target x86_64-apple-darwin` and with that setup it's easy to see the
 bug with the nightly from 2018-03-07.

 So, to sum up, the problem is not just bumping the LLVM version but it
 seems to be somewhat target dependent, too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201807,   |  Actual Points:
  GeorgKoppen201807  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by alexcrichton):

 Ah yeah for the LLVM 7 change we're gonna let that ride the trains (aka
 not backport). If you can temporarily use a nightly that'd work but
 otherwise this may have to wait until that's released.

 Knowing for sure though what was causing the nondeterminism in LLVM would
 be great!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201807,   |  Actual Points:
  GeorgKoppen201807  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:23 gk]:
 > Replying to [comment:22 alexcrichton]:
 > > Hm interesting! I wonder if this is perhaps related to
 https://github.com/rust-lang/rust/issues/52044? That claims it was fixed
 with the most recent LLVM upgrade. Are you able to reproduce the non-
 determinism on the most recent nightly?
 >
 > Aha! That sounds promising and I certainly feel glandium's "This is
 driving me crazy", so this should be the issue then, right? ;)
 >
 > That said, I compiled the nightly from 2018-07-13 which should contain
 the LLVM upgrade and I can't reproduce the problem anymore. However, I
 can't either when compiling the one from from 2018-07-11 which should
 *not* contain the LLVM upgrade (it's based on commit
 e5f6498d3d5c9dac841009d7b49738923826af75). So, it seem the LLVM uprade
 (alone) is not enough to explain this bug, or am I missing something?

 On the other hand testing your script from https://github.com/rust-
 lang/rust/issues/52044#issuecomment-402349038 shows easily that the one
 from 2018-07-13 is good while the one from 2018-07-11 is not. I guess I
 tried the Firefox build just not often enough with 2018-07-11...

 So, what's the suggested way to fix that? What until a new stable compiler
 with a fix for it is out (I guess that's 1.28.0) and use that one?

 Althought, tbh, it's scary to hope this is finally fixed without exactly
 knowing what the issue was. I might try to look closer at it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201807,   |  Actual Points:
  GeorgKoppen201807  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 I wonder if building from scratch is important here (which I do and
 glandium did as well).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201807,   |  Actual Points:
  GeorgKoppen201807  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:22 alexcrichton]:
 > Hm interesting! I wonder if this is perhaps related to
 https://github.com/rust-lang/rust/issues/52044? That claims it was fixed
 with the most recent LLVM upgrade. Are you able to reproduce the non-
 determinism on the most recent nightly?

 Aha! That sounds promising and I certainly feel glandium's "This is
 driving me crazy", so this should be the issue then, right? ;)

 That said, I compiled the nightly from 2018-07-13 which should contain the
 LLVM upgrade and I can't reproduce the problem anymore. However, I can't
 either when compiling the one from from 2018-07-11 which should *not*
 contain the LLVM upgrade (it's based on commit
 e5f6498d3d5c9dac841009d7b49738923826af75). So, it seem the LLVM uprade
 (alone) is not enough to explain this bug, or am I missing something?

 Trying to figure out where all this started, I am pretty sure that
 2018-02-15 is good and 2018-03-07 is bad.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201807,   |  Actual Points:
  GeorgKoppen201807  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by alexcrichton):

 Hm interesting! I wonder if this is perhaps related to https://github.com
 /rust-lang/rust/issues/52044? That claims it was fixed with the most
 recent LLVM upgrade. Are you able to reproduce the non-determinism on the
 most recent nightly?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201807,   |  Actual Points:
  GeorgKoppen201807  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * Attachment "disassemble_gkrust-d3a9de07b53ab691.gkrust0.rcgu.o_diff"
 added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201807,   |  Actual Points:
  GeorgKoppen201807  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Bisecting seems tricky as I get intermittent differences which sometimes
 go away if one just tries several times. I've attached the disassmebly
 diff of `gkrust-d3a9de07b53ab691.gkrust0.rcgu.o` as it might help a bit
 narrowing things down. I wonder whether we actually got the differences
 due to an LLVM update...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201807,   |  Actual Points:
  GeorgKoppen201807  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 The first bad commit `git bisect` gives me is commit
 2079a084df08c38eb4dbfc5c8de5c0245170c3d9 which is a merge. So, I need to
 dig deeper it seems...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201807,   |  Actual Points:
  GeorgKoppen201807  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Okay, some good news here: I double-checked my setup and it seems I made a
 mistake which led to no bad nightly being found. I fixed that and the last
 nightly that is good is the one from March 07. Then there are no nightly
 sources between 03/08 and 03/14 (inclusive) and the nightly from March 15
 is the first bad one.

 I fought a bit with using the repo for bisecting (I need to vendor all the
 crates before creating a tarball, making sure that I really have all the
 submodules initialized and updated, no `.git` dirs bundled bit
 `.gitmodules` files available etc.) but it seems to work now. Bisecting...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201806,   |  Actual Points:
  GeorgKoppen201806  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by alexcrichton):

 Ok sure yeah, you may want to go via git bisection in the repo perhaps?
 That'll need to download other sources but they're done via lock files and
 such so you shouldn't be downloading or using any different sources than
 we used to build the releases

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201806,   |  Actual Points:
  GeorgKoppen201806  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:14 alexcrichton]:
 > Oh dear that is indeed worrisome! The only difference between nightly
 and stable builds is `--release-channel` passed to `./configure` so you
 should already be emulating our stable builds. It looks like you're cross-
 compiling rustc from Linux though? For us we compile natively on OSX and I
 wonder if that causes differences?

 I avoided that by taking the respective nightly sources and compiled them
 as we compile the stable compiler.

 So, the plan right now is to take the nightly sources that are closest to
 1.26.1 and remove parts of the diff until I find the problem.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201806,   |  Actual Points:
  GeorgKoppen201806  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by alexcrichton):

 Oh dear that is indeed worrisome! The only difference between nightly and
 stable builds is `--release-channel` passed to `./configure` so you should
 already be emulating our stable builds. It looks like you're cross-
 compiling rustc from Linux though? For us we compile natively on OSX and I
 wonder if that causes differences?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201806,   |  Actual Points:
  GeorgKoppen201806  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Okay, I tried the nightlies from 2018-02-25, 2018-03-28, and 2018-05-08 to
 find a regression range but to my surprise they all are good, meaning I
 get the same result on different build machines (which does not happen
 with stable versions > 1.25.0). So, it seems there is something in the
 stable code but not in the nightlies what is causing this which is
 confusing to me. We build with
 {{{
 --enable-local-rust --enable-vendor --enable-extended --release-
 channel=stable --sysconfdir=etc --target=x86_64-apple-darwin
 --set=target.x86_64-apple-darwin.cc=x86_64-apple-darwin-clang
 }}}
 but it seems that should not make a difference for nightly vs. stable
 builds. So, hrm...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201806,   |  Actual Points:
  GeorgKoppen201806  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by manish.earth):

 There's also this tool, which is kinda like mozregression

 https://github.com/rust-lang-nursery/cargo-bisect-rustc

 It works off of the tarballs.

 I've never tried it with Firefox though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201806,   |  Actual Points:
  GeorgKoppen201806  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by alexcrichton):

 If you're ok downloading prebuilt artifacts I'd recommend bisection via
 nightlies which rustup can download. Otherwise there's nightly source
 tarballs as well at urls like https://static.rust-lang.org/dist/2018-06-29
 /rustc-nightly-src.tar.gz

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201806,   |  Actual Points:
  GeorgKoppen201806  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  assigned => needs_information


Comment:

 So, I tried for a while to get the bisecting going but it seems non-
 trivial. Alex: What is the recommended way of doing rust compiler
 bisecting? What I tried was using `git bisect` with the commit for 1.25.0
 and 1.26.1, updating the sub modules and tarring the result up + using it
 on my build machines, but that breaks for different reasons (first one is
 no properly vendored crates are included (we compile with --enable-
 vendor); trying to get crates via crates.io-index fails with an SSL
 error...).

 Maybe easier: Are there somewhere nightly source tarballs available (like
 they are for the official releases) which I could test? I did not find any
 so far but that might already narrow down the problem sufficiently.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  assigned
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201806,   |  Actual Points:
  GeorgKoppen201806  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_information => assigned


Comment:

 Replying to [comment:8 alexcrichton]:
 > I know of https://github.com/rust-lang/rust/issues/47086 as an macOS-
 only deterministic compilation problem, but other than that I
 unfortunately don't know of any macOS-specific deterministic compilation
 issues as part of the toolchain itself.

 Okay, than let's try to track the issue down...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201806,   |  Actual Points:
  GeorgKoppen201806  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by alexcrichton):

 I know of https://github.com/rust-lang/rust/issues/47086 as an macOS-only
 deterministic compilation problem, but other than that I unfortunately
 don't know of any macOS-specific deterministic compilation issues as part
 of the toolchain itself.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26475 [Applications/Tor Browser]: ESR60-based .dmg images are not built reproducibly with Stylo enabled using rustc > 1.25.0 (was: ESR60-based .dmg images are not built reproducibly wi

[Tor Bug Tracker & Wiki]

#26475: ESR60-based .dmg images are not built reproducibly with Stylo enabled 
using
rustc > 1.25.0
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201806,   |  Actual Points:
  GeorgKoppen201806  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  new => needs_information
 * cc: manishearth@…, acrichton@… (added)


Comment:

 As I expected this is a problem introduced by us switching to 1.26.1.
 Using version 1.25.0 of the Rust compiler `XUL` is still reproducible. So,
 to sum up:

 Starting with the switch to Rust 1.26.1 Tor Browser for macOS (and only
 for that platform) is not being built reproducibly anymore, once we enable
 Stylo. There are small differences visible in `XUL` stemming from `gkrust`
 (see: comment:1 and comment:4). Using either Rust 1.25.0 or disabling
 Stylo (what we are doing right now) is "solving" this problem.

 Alex, Manish: Do you know of any commit that could have caused this? If
 not, I can bisect I guess.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs