Re: [tor-bugs] #28325 [Applications/Tor Browser]: Use go 1.11 module versioning support

[Tor Bug Tracker & Wiki]

#28325: Use go 1.11 module versioning support
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-maint,  |  Actual Points:
  TorBrowserTeam202004   |
Parent ID:   | Points:  3
 Reviewer:  sysrqb   |Sponsor:
-+-
Changes (by gk):

 * status:  assigned => new
 * priority:  High => Medium
 * sponsor:  Sponsor58 =>
 * parent:  #33659 =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28325 [Applications/Tor Browser]: Use go 1.11 module versioning support

[Tor Bug Tracker & Wiki]

#28325: Use go 1.11 module versioning support
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, tbb-maint,  |  Actual Points:
  TorBrowserTeam202004   |
Parent ID:  #33659   | Points:  3
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58
-+-
Changes (by gk):

 * keywords:  tbb-rbm, ReleaseTrainMigration, TorBrowserTeam202004 => tbb-
 rbm, tbb-maint, TorBrowserTeam202004


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28325 [Applications/Tor Browser]: Use go 1.11 module versioning support

[Tor Bug Tracker & Wiki]

#28325: Use go 1.11 module versioning support
-+-
 Reporter:  boklm|  Owner:  boklm
 Type:  task | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ReleaseTrainMigration,  |  Actual Points:
  TorBrowserTeam202004   |
Parent ID:  #33659   | Points:  3
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58
-+-

Comment (by cypherpunks):

 After upgrading to Go 1.14 only:
 "Module support in the go command is now ready for production use"

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28325 [Applications/Tor Browser]: Use go 1.11 module versioning support

[Tor Bug Tracker & Wiki]

#28325: Use go 1.11 module versioning support
-+-
 Reporter:  boklm|  Owner:  boklm
 Type:  task | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ReleaseTrainMigration,  |  Actual Points:
  TorBrowserTeam202004   |
Parent ID:  #33659   | Points:  3
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58
-+-

Comment (by gk):

 Okay, just for the dependency update I created #33953 to disentangle some
 pieces that got move into this ticket, too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28325 [Applications/Tor Browser]: Use go 1.11 module versioning support

[Tor Bug Tracker & Wiki]

#28325: Use go 1.11 module versioning support
-+-
 Reporter:  boklm|  Owner:  boklm
 Type:  task | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ReleaseTrainMigration,  |  Actual Points:
  TorBrowserTeam202004   |
Parent ID:  #33659   | Points:  3
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58
-+-
Changes (by pili):

 * parent:   => #33659


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28325 [Applications/Tor Browser]: Use go 1.11 module versioning support

[Tor Bug Tracker & Wiki]

#28325: Use go 1.11 module versioning support
-+-
 Reporter:  boklm|  Owner:  boklm
 Type:  task | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ReleaseTrainMigration,  |  Actual Points:
  TorBrowserTeam202004   |
Parent ID:   | Points:  3
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58
-+-
Changes (by pili):

 * reviewer:   => sysrqb


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28325 [Applications/Tor Browser]: Use go 1.11 module versioning support

[Tor Bug Tracker & Wiki]

#28325: Use go 1.11 module versioning support
-+-
 Reporter:  boklm|  Owner:  boklm
 Type:  task | Status:
 |  assigned
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ReleaseTrainMigration,  |  Actual Points:
  TorBrowserTeam202003   |
Parent ID:   | Points:  3
 Reviewer:   |Sponsor:
 |  Sponsor58
-+-
Changes (by pili):

 * sponsor:   => Sponsor58


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28325 [Applications/Tor Browser]: Use go 1.11 module versioning support

[Tor Bug Tracker & Wiki]

#28325: Use go 1.11 module versioning support
---+--
 Reporter:  boklm  |  Owner:  boklm
 Type:  task   | Status:  assigned
 Priority:  High   |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam202002  |  Actual Points:
Parent ID: | Points:  3
 Reviewer: |Sponsor:
---+--

Comment (by boklm):

 An other option I think is to take the script dcf made for #28942 and
 improve it:
 https://trac.torproject.org/projects/tor/attachment/ticket/28942/gomodtorbm

 I think one possible improvement would be to define all go dependencies
 projects completely in the `input_files` section without creating them in
 the `projects/` directory.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28325 [Applications/Tor Browser]: Use go 1.11 module versioning support

[Tor Bug Tracker & Wiki]

#28325: Use go 1.11 module versioning support
---+--
 Reporter:  boklm  |  Owner:  boklm
 Type:  task   | Status:  assigned
 Priority:  High   |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam202002  |  Actual Points:
Parent ID: | Points:  3
 Reviewer: |Sponsor:
---+--
Changes (by sysrqb):

 * keywords:  tbb-rbm, TorBrowserTeam202001 => tbb-rbm, TorBrowserTeam202002


Comment:

 Replying to [comment:9 boklm]:
 > It seems this issue is similar to #31588.
 >
 > One option to fix this would be to add a special build step where we
 allow network access in the container, and run `go mod vendor` and create
 a vendor tarball that we later use in the build.

 I like this idea, and I think this is the easiest and most obvious
 solution. It should be reusable for rust, too.

 [ticket:32027#comment:2 dcf]'s comment is useful here, as well.

 This FAQ https://github.com/golang/go/wiki/Modules#how-do-i-use-vendoring-
 with-modules-is-vendoring-going-away and the entry two below it are
 helpful, too.

 My main concern with this is it becomes difficult detecting when a sub-
 dependency (dependency-of-a-dependency) is modified. This should not be a
 problem, because the chain of hashes for each dependency should prevent
 this. However, I'd prefer a defense-in-depth approach and not take
 unnecessary risks. We can pin the expected hash of the vendored tarball,
 and we can at least detect when any of the files change (this is assuming
 the output from `go mod vendor` is deterministic, of course), but it will
 require manual investigation to identify which dependency caused the
 failure.

 I'm moving this to February, but we should really, really implement a
 solution for this soon. boklm, I'm putting this on your plate, too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28325 [Applications/Tor Browser]: Use go 1.11 module versioning support

[Tor Bug Tracker & Wiki]

#28325: Use go 1.11 module versioning support
---+--
 Reporter:  boklm  |  Owner:  boklm
 Type:  task   | Status:  assigned
 Priority:  High   |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201912  |  Actual Points:
Parent ID: | Points:  3
 Reviewer: |Sponsor:
---+--
Changes (by pili):

 * points:   => 3


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28325 [Applications/Tor Browser]: Use go 1.11 module versioning support

[Tor Bug Tracker & Wiki]

#28325: Use go 1.11 module versioning support
---+--
 Reporter:  boklm  |  Owner:  boklm
 Type:  task   | Status:  assigned
 Priority:  High   |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201911  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by boklm):

 It seems this issue is similar to #31588.

 One option to fix this would be to add a special build step where we allow
 network access in the container, and run `go mod vendor` and create a
 vendor tarball that we later use in the build.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28325 [Applications/Tor Browser]: Use go 1.11 module versioning support

[Tor Bug Tracker & Wiki]

#28325: Use go 1.11 module versioning support
---+--
 Reporter:  boklm  |  Owner:  tbb-team
 Type:  task   | Status:  new
 Priority:  High   |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201911  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by gk):

 * cc: boklm (added)
 * keywords:  tbb-rbm => tbb-rbm, TorBrowserTeam201911


Comment:

 Let's pick this up for November.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28325 [Applications/Tor Browser]: Use go 1.11 module versioning support

[Tor Bug Tracker & Wiki]

#28325: Use go 1.11 module versioning support
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * priority:  Medium => High


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28325 [Applications/Tor Browser]: Use go 1.11 module versioning support

[Tor Bug Tracker & Wiki]

#28325: Use go 1.11 module versioning support
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by boklm):

 I am still not sure how we should support fetching of sources for go
 modules in our build. In order to not block progress on using pion, if it
 has too many dependencies to manually create one project for each
 dependency, I think an other option is to run `go mod vendor` to fetch all
 dependencies, create a tarball of the `vendor` directory it created, then
 put the tarball online somewhere and use it as a dependency for the pion
 build.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28325 [Applications/Tor Browser]: Use go 1.11 module versioning support

[Tor Bug Tracker & Wiki]

#28325: Use go 1.11 module versioning support
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cohosh):

 Replying to [comment:2 gk]:
 > Replying to [comment:1 cohosh]:
 > > We could really use this for the snowflake reproducible build. Our
 solution to the Windows build issue is to use a different webrtc library
 (which will probably be less painful for us down the road anyway).
 However, that library has 30+ dependencies and is a pain to build right
 now (see
 https://trac.torproject.org/projects/tor/ticket/28942#comment:39).
 > >
 > > Is this item roadmapped or is there some information on how difficult
 this task would be?
 >
 > It's not roadmapped as we did not have any prio to do this so far. Not
 sure how difficult it would be but my guess it not too difficult. Is that
 ticket blocking you? Or, asked differently: by when would you need this
 solved?

 I'm still unfamiliar with what exactly we need for reproducible builds. If
 all we need is a commit hash for every go library that snowflake depends
 on, I could probably spend a day or two writing a messy build script for
 the pion go version of snowflake. It's annoying but doable.

 I think the pion version is becoming more and more necessary given #31446
 and us wanting to roll out support for windows users. So my answer is: if
 a hacky build script as described above would work, it's not necessary. If
 not, then we are blocked on this for moving away from the messy chromium
 webrtc sources.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28325 [Applications/Tor Browser]: Use go 1.11 module versioning support

[Tor Bug Tracker & Wiki]

#28325: Use go 1.11 module versioning support
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 https://blog.golang.org/migrating-to-go-modules

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28325 [Applications/Tor Browser]: Use go 1.11 module versioning support

[Tor Bug Tracker & Wiki]

#28325: Use go 1.11 module versioning support
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 Replying to [comment:1 cohosh]:
 > We could really use this for the snowflake reproducible build. Our
 solution to the Windows build issue is to use a different webrtc library
 (which will probably be less painful for us down the road anyway).
 However, that library has 30+ dependencies and is a pain to build right
 now (see
 https://trac.torproject.org/projects/tor/ticket/28942#comment:39).
 >
 > Is this item roadmapped or is there some information on how difficult
 this task would be?

 It's not roadmapped as we did not have any prio to do this so far. Not
 sure how difficult it would be but my guess it not too difficult. Is that
 ticket blocking you? Or, asked differently: by when would you need this
 solved?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28325 [Applications/Tor Browser]: Use go 1.11 module versioning support

[Tor Bug Tracker & Wiki]

#28325: Use go 1.11 module versioning support
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by cohosh):

 * cc: cohosh (added)


Comment:

 We could really use this for the snowflake reproducible build. Our
 solution to the Windows build issue is to use a different webrtc library
 (which will probably be less painful for us down the road anyway).
 However, that library has 30+ dependencies and is a pain to build right
 now (see
 https://trac.torproject.org/projects/tor/ticket/28942#comment:39).

 Is this item roadmapped or is there some information on how difficult this
 task would be?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28325 [Applications/Tor Browser]: Use go 1.11 module versioning support

[Tor Bug Tracker & Wiki]

#28325: Use go 1.11 module versioning support
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-rbm
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 Go 1.11 is adding preliminary support for Go modules, replacing the
 GOPATH-based approach.

 obfs4 is adding `go.mod` and `go.sum` files, which use the Go modules
 support to fetch the dependencies. We disable that in #28310 as the go
 libraries we build are not currently recognized as Go modules.

 We should change how we build our Go libraries so that they can be used as
 Go modules.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs