Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202004R  |
Parent ID:  #28704   | Points:  1
 Reviewer:  boklm|Sponsor:
-+-

Comment (by gk):

 Replying to [comment:34 boklm]:
 > Replying to [comment:33 sysrqb]:
 > > I opened #33915 for enabling rust. Overall, this looks okay to me.
 > >
 > > boklm, do you see anything that should be changed?
 >
 > This looks good to me too. This is now commit
 `7894190b275b412c8d4f9cf7cad281601594da24` on master.

 I don't think ZSTD is enabled for Android. I've filed #34219 to fix that.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202004R  |
Parent ID:  #28704   | Points:  1
 Reviewer:  boklm|Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-mobile, tbb-rbm, tbb-parity, TorBrowserTeam202004 => tbb-
 mobile, tbb-rbm, tbb-parity, TorBrowserTeam202004R
 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:33 sysrqb]:
 > I opened #33915 for enabling rust. Overall, this looks okay to me.
 >
 > boklm, do you see anything that should be changed?

 This looks good to me too. This is now commit
 `7894190b275b412c8d4f9cf7cad281601594da24` on master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202004   |
Parent ID:  #28704   | Points:  1
 Reviewer:  boklm|Sponsor:
-+-

Comment (by sysrqb):

 I opened #33915 for enabling rust. Overall, this looks okay to me.

 boklm, do you see anything that should be changed?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202004   |
Parent ID:  #28704   | Points:  1
 Reviewer:  boklm|Sponsor:
-+-

Comment (by sisbell):

 Made the following changes:
 * removed xz/lzma support for android
 * removed pkg-config symlink and added flag to disable check
 * added '--disable-system-torrc' and '--disable-systemd' for android
 builds
 * removed duplicate of zlib setup
 * moved extracting of openssl and libevent projects to after the platform
 conditional extracting blocks (small readability cleanup)

 https://github.com/sisbell/tor-browser-build/commits/bug-28766-7

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202004   |
Parent ID:  #28704   | Points:  1
 Reviewer:  boklm|Sponsor:
-+-
Changes (by sisbell):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202004   |
Parent ID:  #28704   | Points:  1
 Reviewer:  boklm|Sponsor:
-+-

Comment (by sysrqb):

 {{{
 +  - name: xz
 +project: xz
 +enable: '[% c("var/android") %]'
 +  - name: zstd
 +project: zstd
 +enable: '[% c("var/android") %]'
 }}}

 I chatted with gk and ahf about enabling xz and zstd. gk pointed me at
 #22341, as well, where they previously decided only starting with zstd
 seemed smart. Let's stick with that idea and only enable zstd (and zlib)
 now.

 Therefore, please delete the `xz` parts from this patch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202004   |
Parent ID:  #28704   | Points:  1
 Reviewer:  boklm|Sponsor:
-+-
Changes (by boklm):

 * status:  needs_review => needs_revision
 * keywords:  tbb-mobile, tbb-rbm, tbb-parity, TorBrowserTeam202004R => tbb-
 mobile, tbb-rbm, tbb-parity, TorBrowserTeam202004


Comment:

 Replying to [comment:28 sisbell]:
 > I added the libevent version change for tor in #31499.
 >
 > This new commit uses that change, otherwise is the same as before
 >
 > https://github.com/sisbell/tor-browser-build/commits/bug-28766-6

 * It seems we duplicate the lines for extracting zlib and setting
 `zlibdir`. I think we can them just one time behind a `[% IF
 c("var/windows") || c("var/android") %]`
 * The pkg-config symlink can be avoided by setting the `--disable-tool-
 name-check` configure flag
 * Looking at https://github.com/torproject/tor/pull/1408 other flags we
 can set are `--disable-system-torrc` and `--disable-systemd`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202004R  |
Parent ID:  #28704   | Points:  1
 Reviewer:  boklm|Sponsor:
-+-
Changes (by sisbell):

 * keywords:  tbb-mobile, tbb-rbm, tbb-parity, TorBrowserTeam202004 => tbb-
 mobile, tbb-rbm, tbb-parity, TorBrowserTeam202004R
 * status:  needs_revision => needs_review


Comment:

 I added the libevent version change for tor in #31499.

 This new commit uses that change, otherwise is the same as before

 https://github.com/sisbell/tor-browser-build/commits/bug-28766-6

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202004   |
Parent ID:  #28704   | Points:  1
 Reviewer:  boklm|Sponsor:
-+-
Changes (by boklm):

 * status:  needs_review => needs_revision
 * keywords:  tbb-mobile, tbb-rbm, tbb-parity, TorBrowserTeam202004R => tbb-
 mobile, tbb-rbm, tbb-parity, TorBrowserTeam202004


Comment:

 Replying to [comment:26 sisbell]:
 > Fixed copying of libevent for linux
 >
 > https://github.com/sisbell/tor-browser-build/commits/bug-28766-5

 The file change from `libevent-2.1.so.6` to `libevent-2.1.so.7` is caused
 by the libevent update to version 2.1.11. So this should be done in the
 commit for #31499. There is also no reason to change `libstdc++.so.6` to
 `libstdc++.so.7`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202004R  |
Parent ID:  #28704   | Points:  1
 Reviewer:  boklm|Sponsor:
-+-

Comment (by sisbell):

 Fixed copying of libevent for linux

 https://github.com/sisbell/tor-browser-build/commits/bug-28766-5

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202004R  |
Parent ID:  #28704   | Points:  1
 Reviewer:  boklm|Sponsor:
-+-
Changes (by pili):

 * reviewer:   => boklm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202003R  |
Parent ID:  #28704   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by sisbell):

 * status:  needs_information => needs_review


Comment:

 I added zlib support

 https://github.com/sisbell/tor-browser-build/commits/bug-28766-3

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202003R  |
Parent ID:  #28704   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * status:  needs_review => needs_information


Comment:

 In ticket:28763#comment:2 gk asked a question about `zlib` support:
 > What about `zlib` support which we currently have on desktop?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202003R  |
Parent ID:  #28704   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by sisbell):

 * cc: hans@… (removed)
 * cc: sysrqb, boklm (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202003R  |
Parent ID:  #28704   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by sisbell):

 * keywords:  tbb-mobile, tbb-rbm, tbb-parity, TorBrowserTeam202002 => tbb-
 mobile, tbb-rbm, tbb-parity, TorBrowserTeam202003R
 * status:  needs_revision => needs_review


Comment:

 I added the configure_opt_project var to the build

 https://github.com/sisbell/tor-browser-build/commits/bug-28766-2

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * status:  needs_review => needs_revision


Comment:

 When looking at commit 4f636796fb728ce614e3223780dbdab86892eabf, I see
 that `var/configure_opt` containing options for android is defined in 3
 places: tor, xz, libevent.

 Instead I think we should define it only one time, in rbm.conf, as I said
 in ticket:28704#comment:14:
 > it seems we could have a var/configure_opt for android in `rbm.conf`
 containing something like `CC=clang --host=[% c("var/host") %] [%
 c("var/configure_opt_project") %]`, where `var/configure_opt_project` is
 defined in each project to define options specific to this project

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by sisbell):

 * status:  needs_revision => needs_review


Comment:

 Made the following changes:

  * Set TORCONFIGDIR using original code
  * Use install command
  * Use general tar command
  * Various cleanup

 https://github.com/sisbell/tor-browser-build/commits/bug-28766-1

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by sysrqb):

 I should mention this is based on commit
 `b00b0d40320431abd0d13a4fa959ce53407b35e9` from ticket:28704#comment:23.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity, |  Actual Points:
  TorBrowserTeam202002   |
Parent ID:  #28704   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * status:  assigned => needs_revision


Comment:

 {{{
 -cp $distdir/share/tor/geoip $TORCONFIGDIR
 -cp $distdir/share/tor/geoip6 $TORCONFIGDIR
 -
 +[% IF !c("var/android") -%]
 +  cp $distdir/share/tor/geoip $TORCONFIGDIR
 +  cp $distdir/share/tor/geoip6 $TORCONFIGDIR
 +[% END -%]
 }}}
 Can you set `TORCONFIGDIR=assets/common` and use the original code
 instead?

 In the build script, please use `install` instead of `cp` (see how files
 are copied within the other platform blocks).

 {{{
 +[% IF c("var/android") %]
 +  libsdir=jniLibs/[% c("var/abi") %]
 +  mkdir -p $libsdir assets/common
 +  # Copy tor using naming convention that Android will recognize
 +  cp bin/tor $libsdir/libTor.so
 }}}
 There's a trailing space after 'recognize'

 Can you move the `tar` command into the general platform-specific tar/zip
 block that immediately follows the android block?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201912, tbb-parity   |
Parent ID:  #28704   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * cc: tbb-team (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  sisbell
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201912, tbb-parity   |
Parent ID:  #28704   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * status:  new => assigned
 * owner:  tbb-team => sisbell
 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam201812, tbb-parity => tbb-
 mobile, tbb-rbm, TorBrowserTeam201912, tbb-parity


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201812, tbb-parity   |
Parent ID:  #28704   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Replying to [comment:10 eighthave]:
 > That ''configure.ac'' patch is now here for #31882:
 > * https://github.com/torproject/tor/pull/1408
 >
 > I just got the gitlab-ci job for r17b working, so I can confirm that tor
 with my changes builds with NDK r17b, but this job does not include lzma
 or zstd.

 I'm assuming we need to open new tickets for building these libraries? Or
 is this something we can live without for now?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201812, tbb-parity   |
Parent ID:  #28704   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by eighthave):

 That ''configure.ac'' patch is now here for #31882:
 * https://github.com/torproject/tor/pull/1408

 I just got the gitlab-ci job for r17b working, so I can confirm that tor
 with my changes builds with NDK r17b, but this job does not include lzma
 or zstd.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201812, tbb-parity   |
Parent ID:  #28704   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Do we know if this patch works with Android NDK 17b?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201812, tbb-parity   |
Parent ID:  #28704   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * points:  0.25 => 1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201812, tbb-parity   |
Parent ID:  #28704   | Points:  0.25
 Reviewer:   |Sponsor:
-+-
Changes (by sysrqb):

 * points:   => 0.25


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201812, tbb-parity   |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by eighthave):

 I just added a patch to move key Android configuration to `./configure
 --enable-android` so that it is shared across all the builds.  There is
 more stuff that can be moved there, that is not yet:

 * Android NDK version detection and enforcement (e.g. `>= r19` or only
 exactly `r20`)
 *  `CFLAGS` and `LDFLAGS` to find parity with Android NDK builds done with
 `ndk-build`, which automatically sets things there.
 * Perhaps the state of `--disable-linker-hardening` and `--disable-gcc-
 hardening` could also be maintained there, since we're all building with
 the Android NDK's clang.

 The patch is attached, here's the diff:
 {{{
 diff --git a/configure.ac b/configure.ac
 index a639ffaf3..afee6940c 100644
 --- a/configure.ac
 +++ b/configure.ac
 @@ -88,6 +88,27 @@ else
  [Defined if we're building with OpenSSL or LibreSSL])
  fi

 +dnl Enable Android only features.
 +AC_ARG_ENABLE(android,
 + AS_HELP_STRING(--enable-android, [build with Android features
 enabled]))
 +AM_CONDITIONAL([USE_ANDROID], [test "x$enable_android" = "xyes"])
 +
 +if test "x$enable_android" = "xyes"; then
 +  AC_DEFINE([USE_ANDROID], [1], [Compile with Android specific features
 enabled])
 +
 +  dnl Check if the Android log library is available.
 +  AC_CHECK_HEADERS([android/log.h])
 +  AC_SEARCH_LIBS(__android_log_write, [log])
 +
 +  asciidoc=false
 +  enable_html_manual=no
 +  enable_manpage=no
 +  enable_pic=yes
 +  enable_system_torrc=no
 +  enable_tool_name_check=no
 +  have_systemd=no
 +fi
 +
  if test "$enable_static_tor" = "yes"; then
enable_static_libevent="yes";
enable_static_openssl="yes";
 @@ -117,7 +138,7 @@ AC_ARG_ENABLE(asciidoc,
  "yes") asciidoc=true ;;
  "no")  asciidoc=false ;;
  *) AC_MSG_ERROR(bad value for --disable-asciidoc) ;;
 -  esac], [asciidoc=true])
 +  esac], [test "x$asciidoc" = "xtrue" && asciidoc=true])

  # systemd notify support
  AC_ARG_ENABLE(systemd,
 @@ -227,20 +248,6 @@ if test x$enable_event_tracing_debug = xyes; then
AC_DEFINE([TOR_EVENT_TRACING_ENABLED], [1], [Compile the event tracing
 instrumentation])
  fi

 -dnl Enable Android only features.
 -AC_ARG_ENABLE(android,
 - AS_HELP_STRING(--enable-android, [build with Android features
 enabled]))
 -AM_CONDITIONAL([USE_ANDROID], [test "x$enable_android" = "xyes"])
 -
 -if test "x$enable_android" = "xyes"; then
 -  AC_DEFINE([USE_ANDROID], [1], [Compile with Android specific features
 enabled])
 -
 -  dnl Check if the Android log library is available.
 -  AC_CHECK_HEADERS([android/log.h])
 -  AC_SEARCH_LIBS(__android_log_write, [log])
 -
 -fi
 -
  dnl ---
  dnl Tor modules options. These options are namespaced with --disable-
 module-XXX
  dnl ---
 --
 2.20.1

 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201812, tbb-parity   |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by eighthave):

 * Attachment "0001-move-Android-build-setup-into-enable-android-
 flag.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201812, tbb-parity   |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by eighthave):

 * cc: hans@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201812   |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:2 boklm]:
 > For the linux nightly build, we build rust 1.28.0. Maybe we can do the
 same.
 >
 > We can also start by building Tor without rust (like on Windows and
 macOS).

 Yes, let's start without building Tor on Android with the newer Rust.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201812   |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 For the linux nightly build, we build rust 1.28.0. Maybe we can do the
 same.

 We can also start by building Tor without rust (like on Windows and
 macOS).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam201812   |
Parent ID:  #28704   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by sisbell):

 Tor needs rust 1.28. However for android we are using 1.26.1. How should
 we handle this?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #28766 [Applications/Tor Browser]: Tor Build for Android

[Tor Bug Tracker & Wiki]

#28766: Tor Build for Android
-+-
 Reporter:  sisbell  |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  tbb-mobile, tbb-rbm,
 Severity:  Normal   |  TorBrowserTeam201812
Actual Points:   |  Parent ID:  #28704
   Points:   |   Reviewer:
  Sponsor:   |
-+-


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs