Re: [tor-bugs] #30316 [Core Tor/Tor]: Vote's 'bandwidth-file-headers' is in wrong order

[Tor Bug Tracker & Wiki]

#30316: Vote's 'bandwidth-file-headers' is in wrong order
-+-
 Reporter:  atagar   |  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  035-backport, 040-backport,  |  Actual Points:  0
  dgoulet-merge  |
Parent ID:   | Points:  0
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * points:   => 0
 * resolution:   => fixed


Comment:

 Backported to 0.3.5.
 Merged with the other 0.3.5 and 0.4.0 backports on 2019-08-12.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30316 [Core Tor/Tor]: Vote's 'bandwidth-file-headers' is in wrong order

[Tor Bug Tracker & Wiki]

#30316: Vote's 'bandwidth-file-headers' is in wrong order
-+-
 Reporter:  atagar   |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  035-backport, 040-backport,  |  Actual Points:  0
  dgoulet-merge  |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by nickm):

 * milestone:  Tor: 0.4.0.x-final => Tor: 0.3.5.x-final


Comment:

 Backported to 0.4.0

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30316 [Core Tor/Tor]: Vote's 'bandwidth-file-headers' is in wrong order

[Tor Bug Tracker & Wiki]

#30316: Vote's 'bandwidth-file-headers' is in wrong order
-+-
 Reporter:  atagar   |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  035-backport, 040-backport,  |  Actual Points:  0
  dgoulet-merge  |
Parent ID:   | Points:
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by dgoulet):

 * keywords:  035-backport dgoulet-merge => 035-backport, 040-backport,
 dgoulet-merge


Comment:

 Merged into 041! Keeping it in 040 for backport!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30316 [Core Tor/Tor]: Vote's 'bandwidth-file-headers' is in wrong order

[Tor Bug Tracker & Wiki]

#30316: Vote's 'bandwidth-file-headers' is in wrong order
+--
 Reporter:  atagar  |  Owner:  nickm
 Type:  defect  | Status:  merge_ready
 Priority:  High|  Milestone:  Tor:
|  0.4.0.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  035-backport dgoulet-merge  |  Actual Points:  0
Parent ID:  | Points:
 Reviewer:  ahf |Sponsor:
+--
Changes (by nickm):

 * keywords:  035-backport => 035-backport dgoulet-merge


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30316 [Core Tor/Tor]: Vote's 'bandwidth-file-headers' is in wrong order

[Tor Bug Tracker & Wiki]

#30316: Vote's 'bandwidth-file-headers' is in wrong order
--+
 Reporter:  atagar|  Owner:  nickm
 Type:  defect| Status:  merge_ready
 Priority:  High  |  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  035-backport  |  Actual Points:  0
Parent ID:| Points:
 Reviewer:  ahf   |Sponsor:
--+
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 Looks good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30316 [Core Tor/Tor]: Vote's 'bandwidth-file-headers' is in wrong order

[Tor Bug Tracker & Wiki]

#30316: Vote's 'bandwidth-file-headers' is in wrong order
--+
 Reporter:  atagar|  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  High  |  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  035-backport  |  Actual Points:  0
Parent ID:| Points:
 Reviewer:  ahf   |Sponsor:
--+
Changes (by asn):

 * reviewer:   => ahf


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30316 [Core Tor/Tor]: Vote's 'bandwidth-file-headers' is in wrong order

[Tor Bug Tracker & Wiki]

#30316: Vote's 'bandwidth-file-headers' is in wrong order
--+
 Reporter:  atagar|  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  High  |  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  035-backport  |  Actual Points:  0
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 Branches fixed and force-pushed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30316 [Core Tor/Tor]: Vote's 'bandwidth-file-headers' is in wrong order

[Tor Bug Tracker & Wiki]

#30316: Vote's 'bandwidth-file-headers' is in wrong order
--+
 Reporter:  atagar|  Owner:  nickm
 Type:  defect| Status:  needs_revision
 Priority:  High  |  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  035-backport  |  Actual Points:  0
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 whoops, doesn't compile. half a moment...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30316 [Core Tor/Tor]: Vote's 'bandwidth-file-headers' is in wrong order

[Tor Bug Tracker & Wiki]

#30316: Vote's 'bandwidth-file-headers' is in wrong order
--+
 Reporter:  atagar|  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  High  |  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  035-backport  |  Actual Points:  0
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by atagar):

 Thanks Nick! For what it's worth looks good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30316 [Core Tor/Tor]: Vote's 'bandwidth-file-headers' is in wrong order

[Tor Bug Tracker & Wiki]

#30316: Vote's 'bandwidth-file-headers' is in wrong order
--+
 Reporter:  atagar|  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  High  |  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  035-backport  |  Actual Points:  0
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  accepted => needs_review
 * actualpoints:   => 0


Comment:

 See my branch `bug30316_035`.

 0.3.5 PR: https://github.com/torproject/tor/pull/987
 0.4.0 PR: [fixes conflict and also moves bandwidth-file-digest]
 https://github.com/torproject/tor/pull/988

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30316 [Core Tor/Tor]: Vote's 'bandwidth-file-headers' is in wrong order

[Tor Bug Tracker & Wiki]

#30316: Vote's 'bandwidth-file-headers' is in wrong order
--+
 Reporter:  atagar|  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  High  |  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  035-backport  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  new => accepted
 * keywords:   => 035-backport
 * owner:  (none) => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30316 [Core Tor/Tor]: Vote's 'bandwidth-file-headers' is in wrong order

[Tor Bug Tracker & Wiki]

#30316: Vote's 'bandwidth-file-headers' is in wrong order
--+
 Reporter:  atagar|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * milestone:   => Tor: 0.4.0.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30316 [Core Tor/Tor]: Vote's 'bandwidth-file-headers' is in wrong order

[Tor Bug Tracker & Wiki]

#30316: Vote's 'bandwidth-file-headers' is in wrong order
--+
 Reporter:  atagar|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by atagar):

 * Attachment "moria1_vote.txt" added.

 Cropped copy of moria1's vote.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #30316 [Core Tor/Tor]: Vote's 'bandwidth-file-headers' is in wrong order

[Tor Bug Tracker & Wiki]

#30316: Vote's 'bandwidth-file-headers' is in wrong order
--+
 Reporter:  atagar|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  High  |  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 Hi network team. Moria1's present vote places its "bandwidth-file-headers"
 in the wrong location.

 Tor's dir-spec says: "**Status documents contain a preamble, an authority
 section, a list of router status entries, and one or more footer
 signature, in that order.**"

 The trouble is that our bandwidth-file-headers field is specified as being
 part of the preamble, whereas moria1 places it **after** its authority
 section. Header fields appear in the following order...

 * flag-thresholds (preamble)
 * params (preamble)
 * dir-source (authority section)
 * contact (authority section)
 * shared-rand-participate (authority section)
 * shared-rand-commit (authority section, multiple)
 * shared-rand-previous-value (authority section)
 * shared-rand-current-value (authority section)
 * **bandwidth-file-headers (preamble)**
 * dir-key-certificate-version (key certificate)
 * ... etc...

 As a result Stem does not parse this field: #30282

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs