Re: [tor-bugs] #30687 [Core Tor/Tor]: Implement a generic counter token bucket

[Tor Bug Tracker & Wiki]

#30687: Implement a generic counter token bucket
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  enhancement   | Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  asn-merge |  Actual Points:
Parent ID:  #15516| Points:  0.1
 Reviewer:  nickm |Sponsor:  Sponsor27-must
--+
Changes (by asn):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged to 042.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30687 [Core Tor/Tor]: Implement a generic counter token bucket

[Tor Bug Tracker & Wiki]

#30687: Implement a generic counter token bucket
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  enhancement   | Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  asn-merge |  Actual Points:
Parent ID:  #15516| Points:  0.1
 Reviewer:  nickm |Sponsor:  Sponsor27-must
--+
Changes (by dgoulet):

 * status:  needs_revision => merge_ready


Comment:

 Pushed

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30687 [Core Tor/Tor]: Implement a generic counter token bucket

[Tor Bug Tracker & Wiki]

#30687: Implement a generic counter token bucket
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  asn-merge |  Actual Points:
Parent ID:  #15516| Points:  0.1
 Reviewer:  nickm |Sponsor:  Sponsor27-must
--+
Changes (by asn):

 * status:  merge_ready => needs_revision


Comment:

 Missing a changes file.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30687 [Core Tor/Tor]: Implement a generic counter token bucket

[Tor Bug Tracker & Wiki]

#30687: Implement a generic counter token bucket
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  enhancement   | Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  asn-merge |  Actual Points:
Parent ID:  #15516| Points:  0.1
 Reviewer:  nickm |Sponsor:  Sponsor27-must
--+
Changes (by dgoulet):

 * keywords:   => asn-merge


Comment:

 Reminder: 042 merge window not open yet.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30687 [Core Tor/Tor]: Implement a generic counter token bucket

[Tor Bug Tracker & Wiki]

#30687: Implement a generic counter token bucket
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  enhancement   | Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #15516| Points:  0.1
 Reviewer:  nickm |Sponsor:  Sponsor27-must
--+
Changes (by nickm):

 * status:  needs_review => merge_ready


Comment:

 CI passes, code lgtm. Let's take it in 0.4.2.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30687 [Core Tor/Tor]: Implement a generic counter token bucket

[Tor Bug Tracker & Wiki]

#30687: Implement a generic counter token bucket
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #15516| Points:  0.1
 Reviewer:  nickm |Sponsor:  Sponsor27-must
--+
Changes (by dgoulet):

 * status:  needs_revision => needs_review


Comment:

 Made the fixes. CI is running but so far so good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30687 [Core Tor/Tor]: Implement a generic counter token bucket

[Tor Bug Tracker & Wiki]

#30687: Implement a generic counter token bucket
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #15516| Points:  0.1
 Reviewer:  nickm |Sponsor:  Sponsor27-must
--+
Changes (by nickm):

 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30687 [Core Tor/Tor]: Implement a generic counter token bucket

[Tor Bug Tracker & Wiki]

#30687: Implement a generic counter token bucket
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #15516| Points:  0.1
 Reviewer:  nickm |Sponsor:  Sponsor27-must
--+

Comment (by nickm):

 Looks mostly good, but CI is failing with compilation warnings.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #30687 [Core Tor/Tor]: Implement a generic counter token bucket

[Tor Bug Tracker & Wiki]

#30687: Implement a generic counter token bucket
--+
 Reporter:  dgoulet   |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #15516| Points:  0.1
 Reviewer:  nickm |Sponsor:  Sponsor27-must
--+
Changes (by dgoulet):

 * status:  new => needs_review
 * reviewer:   => nickm


Comment:

 Branch: `ticket30687_042_01`
 https://github.com/torproject/tor/pull/1058

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #30687 [Core Tor/Tor]: Implement a generic counter token bucket

[Tor Bug Tracker & Wiki]

#30687: Implement a generic counter token bucket
+
 Reporter:  dgoulet |  Owner:  (none)
 Type:  enhancement | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  |   Keywords:
Actual Points:  |  Parent ID:  #15516
   Points:  0.1 |   Reviewer:
  Sponsor:  Sponsor27-must  |
+
 We have the `_raw_t` interface and a `_rw_t` specialized one. Many use
 cases only need a single counter like for instance the circuit creation
 DoS defense would use that. Or #15516 introduce2 rate limiting.

 After a discussion with nickm, it would be wise if we can simply implement
 a generic counter token bucket:

 {{{
 token_bucket_ctr_t
 }}}

 ... with a single bucket in it and thus could generically be used by many
 subsystems.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs