Re: [tor-bugs] #31601 [Applications/Tor Browser]: Don't let Mozilla recommend extensions again

[Tor Bug Tracker & Wiki]

#31601: Don't let Mozilla recommend extensions again
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  TorBrowserTeam201909R, tbb-9.0   |  Actual Points:  0.2
  -must-alpha, ff68-esr  |
Parent ID:   | Points:  0.25
 Reviewer:   |Sponsor:
-+-
Changes (by acat):

 * actualpoints:   => 0.2


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31601 [Applications/Tor Browser]: Don't let Mozilla recommend extensions again

[Tor Bug Tracker & Wiki]

#31601: Don't let Mozilla recommend extensions again
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  TorBrowserTeam201909R, tbb-9.0   |  Actual Points:
  -must-alpha, ff68-esr  |
Parent ID:   | Points:  0.25
 Reviewer:   |Sponsor:
-+-

Comment (by Thorin):

 Replying to [comment:5 acat]:
 > Thanks. I think `extensions.htmlaboutaddons.recommendations.enabled` is
 enough.

 Yes. Sorry about that. the `.enabled` pref wasn't added until after 68.0b9
 and I already had the other two pegged (because I'm that efficient!). They
 are indeed redundant

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31601 [Applications/Tor Browser]: Don't let Mozilla recommend extensions again

[Tor Bug Tracker & Wiki]

#31601: Don't let Mozilla recommend extensions again
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  TorBrowserTeam201909R, tbb-9.0   |  Actual Points:
  -must-alpha, ff68-esr  |
Parent ID:   | Points:  0.25
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good. Cherry-picked onto `tor-browser-68.1.0esr-9.0-2` (commit
 e489c5048b762b3226db23b6ea9ffc440617615e).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31601 [Applications/Tor Browser]: Don't let Mozilla recommend extensions again

[Tor Bug Tracker & Wiki]

#31601: Don't let Mozilla recommend extensions again
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201909R, tbb-9.0   |  Actual Points:
  -must-alpha, ff68-esr  |
Parent ID:   | Points:  0.25
 Reviewer:   |Sponsor:
-+-
Changes (by acat):

 * keywords:  TorBrowserTeam201909, tbb-9.0-must-alpha, ff68-esr =>
 TorBrowserTeam201909R, tbb-9.0-must-alpha, ff68-esr
 * status:  new => needs_review


Comment:

 Thanks. I think `extensions.htmlaboutaddons.recommendations.enabled` is
 enough.

 `extensions.htmlaboutaddons.discover.enabled` is used in
 [https://searchfox.org/mozilla-
 esr68/source/toolkit/mozapps/extensions/content/extensions.js#854], but
 the old `extensions.getAddons.showPane` should cover that.

 Patch for review: https://www.github.com/acatarineu/tor-
 browser/commit/31601.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31601 [Applications/Tor Browser]: Don't let Mozilla recommend extensions again

[Tor Bug Tracker & Wiki]

#31601: Don't let Mozilla recommend extensions again
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201909, tbb-9.0-must-  |  Actual Points:
  alpha, ff68-esr|
Parent ID:   | Points:  0.25
 Reviewer:   |Sponsor:
-+-

Comment (by Thorin):

 All new prefs added in FF68

 {{{
 user_pref("extensions.getAddons.discovery.api_url", "");
 user_pref("extensions.htmlaboutaddons.discover.enabled", false);
 user_pref("extensions.htmlaboutaddons.recommendations.enabled", false);
 }}}

 This disables recommendations in about:addons' Extensions and Themes panes
 and removes/hides any leftover UI bits and bobs

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31601 [Applications/Tor Browser]: Don't let Mozilla recommend extensions again

[Tor Bug Tracker & Wiki]

#31601: Don't let Mozilla recommend extensions again
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201909, tbb-9.0-must-  |  Actual Points:
  alpha, ff68-esr|
Parent ID:   | Points:  0.25
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  TorBrowserTeam201909, tbb-9.0-must-alpha =>
 TorBrowserTeam201909, tbb-9.0-must-alpha, ff68-esr


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31601 [Applications/Tor Browser]: Don't let Mozilla recommend extensions again

[Tor Bug Tracker & Wiki]

#31601: Don't let Mozilla recommend extensions again
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201909, tbb-9.0-must-  |  Actual Points:
  alpha  |
Parent ID:   | Points:  0.25
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * owner:  (none) => tbb-team
 * component:  - Select a component => Applications/Tor Browser


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs