Re: [tor-bugs] #31626 [Core Tor/Tor]: Move confparse.[ch] into lib/confmgt

[Tor Bug Tracker & Wiki]

#31626: Move confparse.[ch] into lib/confmgt
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  042-should dgoulet-merge  |  Actual Points:  .1
Parent ID:  #29211| Points:  0
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+
Changes (by dgoulet):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31626 [Core Tor/Tor]: Move confparse.[ch] into lib/confmgt

[Tor Bug Tracker & Wiki]

#31626: Move confparse.[ch] into lib/confmgt
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-should dgoulet-merge  |  Actual Points:  .1
Parent ID:  #29211| Points:  0
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+
Changes (by nickm):

 * status:  needs_revision => merge_ready
 * keywords:  042-should => 042-should dgoulet-merge


Comment:

 > We also rectified some unrelated include paths in this patch.
 > I'm ok with that.
 > But if you want to put them in a separate commit, that might be nice.

 I think I'd rather leave them in a single commit -- IMO splitting it up
 loses some of the point of having these commits be automatically
 generated.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31626 [Core Tor/Tor]: Move confparse.[ch] into lib/confmgt

[Tor Bug Tracker & Wiki]

#31626: Move confparse.[ch] into lib/confmgt
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-should|  Actual Points:  .1
Parent ID:  #29211| Points:  0
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+

Comment (by teor):

 Let's avoid issues like this in future, by implementing #31713.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31626 [Core Tor/Tor]: Move confparse.[ch] into lib/confmgt

[Tor Bug Tracker & Wiki]

#31626: Move confparse.[ch] into lib/confmgt
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-should|  Actual Points:  .1
Parent ID:  #29211| Points:  0
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 We also rectified some unrelated include paths in this patch.
 I'm ok with that.
 But if you want to put them in a separate commit, that might be nice.

 Feel free to put this ticket in merge_ready if you don't think that's
 worth the effort.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31626 [Core Tor/Tor]: Move confparse.[ch] into lib/confmgt

[Tor Bug Tracker & Wiki]

#31626: Move confparse.[ch] into lib/confmgt
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-should|  Actual Points:  .1
Parent ID:  #29211| Points:  0
 Reviewer:  teor  |Sponsor:  Sponsor31-can
--+
Changes (by nickm):

 * status:  assigned => needs_review
 * reviewer:   => teor
 * actualpoints:   => .1


Comment:

 CI has passed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31626 [Core Tor/Tor]: Move confparse.[ch] into lib/confmgt

[Tor Bug Tracker & Wiki]

#31626: Move confparse.[ch] into lib/confmgt
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  042-should|  Actual Points:
Parent ID:  #29211| Points:  0
 Reviewer:|Sponsor:  Sponsor31-can
--+

Comment (by nickm):

 Branch is `ticket31626`; PR at https://github.com/torproject/tor/pull/1319
 .  I'll wait for CI to pass before I put this in needs_review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31626 [Core Tor/Tor]: Move confparse.[ch] into lib/confmgt

[Tor Bug Tracker & Wiki]

#31626: Move confparse.[ch] into lib/confmgt
---+
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:  #29211
   Points:  0  |   Reviewer:
  Sponsor:  Sponsor31-can  |
---+
 This should now be a simple task, since confparse.[ch] no longer depends
 on anything higher-level than lib.  But it will conflict with other
 things, so we should do it at some point when there are not other pending
 commits.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs