Re: [tor-bugs] #31657 [Core Tor/Tor]: Rephrase "missing descriptors" notice log to be less confusing

[Tor Bug Tracker & Wiki]

#31657: Rephrase "missing descriptors" notice log to be less confusing
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0421, fast-  |  implemented
  fix, log, tor-guard, tor-bridge, tor-client,   |  Actual Points:  0.1
  BugSmashFund, 042-should 041-backport? |
  040-backport? 035-backport?|
Parent ID:  #21969   | Points:  0.1
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Backporting to 0.3.5 and forward.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31657 [Core Tor/Tor]: Rephrase "missing descriptors" notice log to be less confusing

[Tor Bug Tracker & Wiki]

#31657: Rephrase "missing descriptors" notice log to be less confusing
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0421, fast-  |  Actual Points:  0.1
  fix, log, tor-guard, tor-bridge, tor-client,   |
  BugSmashFund, 042-should 041-backport? |
  040-backport? 035-backport?|
Parent ID:  #21969   | Points:  0.1
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by ahf):

 * reviewer:  asn => ahf


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31657 [Core Tor/Tor]: Rephrase "missing descriptors" notice log to be less confusing

[Tor Bug Tracker & Wiki]

#31657: Rephrase "missing descriptors" notice log to be less confusing
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0421, fast-  |  Actual Points:  0.1
  fix, log, tor-guard, tor-bridge, tor-client,   |
  BugSmashFund, 042-should 041-backport? |
  040-backport? 035-backport?|
Parent ID:  #21969   | Points:  0.1
 Reviewer:  asn  |Sponsor:
-+-
Changes (by teor):

 * keywords:
 fast-fix, log, tor-guard, tor-bridge, tor-client, BugSmashFund,
 042-should 041-backport? 040-backport? 035-backport?
 =>
 consider-backport-after-0421, fast-fix, log, tor-guard, tor-bridge,
 tor-client, BugSmashFund, 042-should 041-backport? 040-backport?
 035-backport?


Comment:

 If a backport stops us getting one more bug report, I think the cost of
 the backport would be worthwhile.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31657 [Core Tor/Tor]: Rephrase "missing descriptors" notice log to be less confusing

[Tor Bug Tracker & Wiki]

#31657: Rephrase "missing descriptors" notice log to be less confusing
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, log, tor-guard, tor-   |  Actual Points:  0.1
  bridge, tor-client, BugSmashFund, 042-should   |
  041-backport? 040-backport? 035-backport?  |
Parent ID:  #21969   | Points:  0.1
 Reviewer:  asn  |Sponsor:
-+-
Changes (by nickm):

 * keywords:
 fast-fix, log, tor-guard, tor-bridge, tor-client, BugSmashFund,
 042-should
 =>
 fast-fix, log, tor-guard, tor-bridge, tor-client, BugSmashFund,
 042-should 041-backport? 040-backport? 035-backport?
 * milestone:  Tor: 0.4.2.x-final => Tor: 0.4.1.x-final


Comment:

 Merged to master; marking for possible backport, though I don't have
 strong feelings either way.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31657 [Core Tor/Tor]: Rephrase "missing descriptors" notice log to be less confusing

[Tor Bug Tracker & Wiki]

#31657: Rephrase "missing descriptors" notice log to be less confusing
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, log, tor-guard, tor-   |  Actual Points:  0.1
  bridge, tor-client, BugSmashFund, 042-should   |
Parent ID:  #21969   | Points:  0.1
 Reviewer:  asn  |Sponsor:
-+-

Comment (by teor):

 Let's deal with the UX / behaviour in #31707.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31657 [Core Tor/Tor]: Rephrase "missing descriptors" notice log to be less confusing

[Tor Bug Tracker & Wiki]

#31657: Rephrase "missing descriptors" notice log to be less confusing
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, log, tor-guard, tor-   |  Actual Points:  0.1
  bridge, tor-client, BugSmashFund, 042-should   |
Parent ID:  #21969   | Points:  0.1
 Reviewer:  asn  |Sponsor:
-+-
Changes (by teor):

 * status:  needs_revision => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31657 [Core Tor/Tor]: Rephrase "missing descriptors" notice log to be less confusing

[Tor Bug Tracker & Wiki]

#31657: Rephrase "missing descriptors" notice log to be less confusing
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, log, tor-guard, tor-   |  Actual Points:  0.1
  bridge, tor-client, BugSmashFund, 042-should   |
Parent ID:  #21969   | Points:  0.1
 Reviewer:  asn  |Sponsor:
-+-

Comment (by asn):

 Replying to [comment:6 teor]:
 > How do we reliably detect pathological cases?
 > Suppress the message, until it occurs a few times within a short
 timeframe?

 That's a good question I don't have an answer for.

 Unfortunately, I don't think that's the kind of message that occurs
 multiple times, looking at #30746 (and friends) this seems to be able to
 cause havoc with just a single repeatition.

 I'm not sure why this is the case, since `router_have_minimum_dir_info()`
 seems to be called all the time and that should eventually call
 `entry_guards_get_err_str_if_dir_info_missing()` which is the source of
 the log message... Things are kinda messy between these two functions tho,
 so it's kinda hard to understand what's the issue.

 Perhaps we can merge this patch for now since it does not seem to make the
 situation worse, and we can think in the future how to improve the UX? If
 you agree, feel free to toggle this into merge_ready since the patch LGTM.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31657 [Core Tor/Tor]: Rephrase "missing descriptors" notice log to be less confusing

[Tor Bug Tracker & Wiki]

#31657: Rephrase "missing descriptors" notice log to be less confusing
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, log, tor-guard, tor-   |  Actual Points:  0.1
  bridge, tor-client, BugSmashFund   |
Parent ID:  #21969   | Points:  0.1
 Reviewer:  asn  |Sponsor:
-+-

Comment (by teor):

 How do we reliably detect pathological cases?
 Suppress the message, until it occurs a few times within a short
 timeframe?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31657 [Core Tor/Tor]: Rephrase "missing descriptors" notice log to be less confusing

[Tor Bug Tracker & Wiki]

#31657: Rephrase "missing descriptors" notice log to be less confusing
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, log, tor-guard, tor-   |  Actual Points:  0.1
  bridge, tor-client, BugSmashFund   |
Parent ID:  #21969   | Points:  0.1
 Reviewer:  asn  |Sponsor:
-+-
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 I'm OK with the change, but if the log message should not be acted upon,
 why should we expose it to the users as a [notice]?

 Is it so that if we ever get issues like (#30746/#21969) again we know
 that this is the underlying issue? In this case, could we just output this
 message just in pathological cases?

 I'm marking this as needs_revision to hear teor's opinion.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31657 [Core Tor/Tor]: Rephrase "missing descriptors" notice log to be less confusing

[Tor Bug Tracker & Wiki]

#31657: Rephrase "missing descriptors" notice log to be less confusing
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.3.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  BugSmash, fast-fix, log, tor-guard,  |  Actual Points:  0.1
  tor-bridge, tor-client |
Parent ID:  #21969   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:  fast-fix, log, doc?, tor-guard, tor-bridge, tor-client =>
 BugSmash, fast-fix, log, tor-guard, tor-bridge, tor-client
 * status:  assigned => needs_review
 * version:  Tor: 0.3.0.6 => Tor: 0.3.3.1-alpha
 * actualpoints:   => 0.1


Comment:

 See my pull request:
 * 0.3.5: https://github.com/torproject/tor/pull/1300

 I added a short explanation to the existing log message, and updated the
 test that depends on that message.

 The merge forward was clean.
 Here are the test branches for merging forwards:
 * https://github.com/teor2345/tor/branches/all?query=bug31657_

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31657 [Core Tor/Tor]: Rephrase "missing descriptors" notice log to be less confusing

[Tor Bug Tracker & Wiki]

#31657: Rephrase "missing descriptors" notice log to be less confusing
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.0.6
 Severity:  Normal   | Resolution:
 Keywords:  fast-fix, log, doc?, tor-guard,  |  Actual Points:
  tor-bridge, tor-client |
Parent ID:  #21969   | Points:  0.1
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 * It's normal for microdescs to expire once a week, so if we have 3
 primary guards, we will see an expiry every few days

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31657 [Core Tor/Tor]: Rephrase "missing descriptors" notice log to be less confusing

[Tor Bug Tracker & Wiki]

#31657: Rephrase "missing descriptors" notice log to be less confusing
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core |Version:  Tor: 0.3.0.6
  Tor/Tor|   Keywords:  fast-fix, log, doc?, tor-guard,
 Severity:  Normal   |  tor-bridge, tor-client
Actual Points:   |  Parent ID:  #21969
   Points:  0.1  |   Reviewer:
  Sponsor:   |
-+-
 Some operators are confused or alarmed by these logs:
 {{{
 Sep 05 03:22:50.000 [notice] Our directory information is no longer up-to-
 date enough to build circuits: We're missing descriptors for 1/3 of our
 primary entry guards (total microdescriptors: 6515/6541).
 Sep 05 03:22:50.000 [notice] I learned some more directory information,
 but not enough to build a circuit: We're missing descriptors for 1/3 of
 our primary entry guards (total microdescriptors: 6515/6541).
 }}}

 We should rephrase them or document that:
 * tor tries to keep active 3 primary guards for anonymity and safety
 * we'll try to get new microdescs soon
 * tor usually recovers quickly from this issue

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs