Re: [tor-bugs] #31713 [Core Tor/Tor]: Automatically rectify include paths before every commit

[Tor Bug Tracker & Wiki]

#31713: Automatically rectify include paths before every commit
--+--
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #29226| Points:
 Reviewer:|Sponsor:  Sponsor31-can
--+--

Comment (by teor):

 Yes, let's do that, and then we'll shake out a lot of the bugs in
 autostyling before the big restyle.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31713 [Core Tor/Tor]: Automatically rectify include paths before every commit

[Tor Bug Tracker & Wiki]

#31713: Automatically rectify include paths before every commit
--+--
 Reporter:  teor  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #29226| Points:
 Reviewer:|Sponsor:  Sponsor31-can
--+--

Comment (by nickm):

 Another possibility here is to run "make autostyle", which runs
 rectify_include_paths and several other autoformatters.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31713 [Core Tor/Tor]: Automatically rectify include paths before every commit

[Tor Bug Tracker & Wiki]

#31713: Automatically rectify include paths before every commit
---+--
 Reporter:  teor   |  Owner:  (none)
 Type:  enhancement| Status:  new
 Priority:  Medium |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor   |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:  #29226
   Points: |   Reviewer:
  Sponsor:  Sponsor31-can  |
---+--
 Let's try out our auto-formatting workflow by running:
 scripts/maint/rectify_include_paths.py .
 before every commit.

 We occasionally miss include paths:
 
https://github.com/torproject/tor/pull/1319/commits/a90d1918af5d2b6c6e6dd2c0797f8a63d4042bfa

 We should only ever run auto-formatting on master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs