Re: [tor-bugs] #31780 [Circumvention/BridgeDB]: Write a specification for BridgeDB's metrics

[Tor Bug Tracker & Wiki]

#31780: Write a specification for BridgeDB's metrics
+---
 Reporter:  phw |  Owner:  phw
 Type:  task| Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:  implemented
 Keywords:  |  Actual Points:  0.7
Parent ID:  | Points:  0.5
 Reviewer:  cohosh  |Sponsor:  Sponsor30-can
+---
Changes (by phw):

 * actualpoints:   => 0.7


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31780 [Circumvention/BridgeDB]: Write a specification for BridgeDB's metrics

[Tor Bug Tracker & Wiki]

#31780: Write a specification for BridgeDB's metrics
+---
 Reporter:  phw |  Owner:  phw
 Type:  task| Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:  implemented
 Keywords:  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  cohosh  |Sponsor:  Sponsor30-can
+---
Changes (by phw):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 I merged the patch in
 
[https://gitweb.torproject.org/bridgedb.git/commit/?h=develop=0751ad7148447f30df7c015c77853d58b6077f71
 0751ad7].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31780 [Circumvention/BridgeDB]: Write a specification for BridgeDB's metrics

[Tor Bug Tracker & Wiki]

#31780: Write a specification for BridgeDB's metrics
+---
 Reporter:  phw |  Owner:  phw
 Type:  task| Status:  merge_ready
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  cohosh  |Sponsor:  Sponsor30-can
+---

Comment (by phw):

 Replying to [comment:11 karsten]:
 > Replying to [comment:9 phw]:
 > > Here's an implementation quirk that I just realised: When I restart
 BridgeDB (e.g., to update to the latest version), it does not write its
 unfinished metrics to disk, which means that we are losing  up to 24 hours
 worth of metrics after each restart. I filed #31936 for this issue.
 >
 > Relays have the same issue. The downside of writing unfinished metrics
 to disk is that having non-sanitized metrics on disk can be a security
 problem. This is why relays keep non-sanitized statistics in memory, then
 sanitize them, and then write them to disk. Of course it's unfortunate to
 lose up to 24 hours worth of metrics because of a restart, but for relays
 this hasn't caused major trouble in the past. Maybe this is different with
 BridgeDB, though.
 [[br]]
 Thanks for the context, that's helpful to know.
 [[br]]
 > Anyway, this is unrelated to making BridgeDB stats/metrics available,
 right? If so, I'd continue with adding these stats/metrics to metrics-lib
 and CollecTor.
 [[br]]
 Yes, it is.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31780 [Circumvention/BridgeDB]: Write a specification for BridgeDB's metrics

[Tor Bug Tracker & Wiki]

#31780: Write a specification for BridgeDB's metrics
+---
 Reporter:  phw |  Owner:  phw
 Type:  task| Status:  merge_ready
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  cohosh  |Sponsor:  Sponsor30-can
+---

Comment (by phw):

 Replying to [comment:10 karsten]:
 > Can I update the code to this new spec now, or do you expect to make any
 further changes to version 1?
 [[br]]
 There will be no further changes to version 1, so please update the code.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31780 [Circumvention/BridgeDB]: Write a specification for BridgeDB's metrics

[Tor Bug Tracker & Wiki]

#31780: Write a specification for BridgeDB's metrics
+---
 Reporter:  phw |  Owner:  phw
 Type:  task| Status:  merge_ready
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  cohosh  |Sponsor:  Sponsor30-can
+---

Comment (by karsten):

 Replying to [comment:9 phw]:
 > Here's an implementation quirk that I just realised: When I restart
 BridgeDB (e.g., to update to the latest version), it does not write its
 unfinished metrics to disk, which means that we are losing  up to 24 hours
 worth of metrics after each restart. I filed #31936 for this issue.

 Relays have the same issue. The downside of writing unfinished metrics to
 disk is that having non-sanitized metrics on disk can be a security
 problem. This is why relays keep non-sanitized statistics in memory, then
 sanitize them, and then write them to disk. Of course it's unfortunate to
 lose up to 24 hours worth of metrics because of a restart, but for relays
 this hasn't caused major trouble in the past. Maybe this is different with
 BridgeDB, though.

 Anyway, this is unrelated to making BridgeDB stats/metrics available,
 right? If so, I'd continue with adding these stats/metrics to metrics-lib
 and CollecTor.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31780 [Circumvention/BridgeDB]: Write a specification for BridgeDB's metrics

[Tor Bug Tracker & Wiki]

#31780: Write a specification for BridgeDB's metrics
+---
 Reporter:  phw |  Owner:  phw
 Type:  task| Status:  merge_ready
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  cohosh  |Sponsor:  Sponsor30-can
+---

Comment (by karsten):

 Replying to [comment:8 phw]:
 > Replying to [comment:7 karsten]:
 > > Just one question: can we somehow make these changes to existing
 `bridgedb-metrics.log*` files, either on polyanthum or on colchicifolium?
 It would be sad to lose a month of files just because of cosmetic changes
 to the spec. If so, do you prefer editing files yourself, or shall I do
 that?
 > [[br]]
 > I will modify all the files that are currently on polyanthum but you'll
 have to modify the ones that were already synced to colchicifolium.

 Looks like all files on colchicifolium are already updated. Nothing left
 to do for me, unless I'm overlooking something.

 > Other than that, does the spec look good to you?

 Sure, it looks fine to me. My main concern was that we'd have to update
 existing files and code, but it's much easier to do this now than later,
 so I'm okay with that.

 Can I update the code to this new spec now, or do you expect to make any
 further changes to version 1?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31780 [Circumvention/BridgeDB]: Write a specification for BridgeDB's metrics

[Tor Bug Tracker & Wiki]

#31780: Write a specification for BridgeDB's metrics
+---
 Reporter:  phw |  Owner:  phw
 Type:  task| Status:  merge_ready
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  cohosh  |Sponsor:  Sponsor30-can
+---

Comment (by phw):

 Replying to [comment:8 phw]:
 > Replying to [comment:7 karsten]:
 > > Just one question: can we somehow make these changes to existing
 `bridgedb-metrics.log*` files, either on polyanthum or on colchicifolium?
 It would be sad to lose a month of files just because of cosmetic changes
 to the spec. If so, do you prefer editing files yourself, or shall I do
 that?
 > [[br]]
 > I will modify all the files that are currently on polyanthum but you'll
 have to modify the ones that were already synced to colchicifolium.
 [[br]]
 Ok, this is done. The updated files should soon be synced to
 colchicifolium.

 Here's an implementation quirk that I just realised: When I restart
 BridgeDB (e.g., to update to the latest version), it does not write its
 unfinished metrics to disk, which means that we are losing  up to 24 hours
 worth of metrics after each restart. I filed #31936 for this issue.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31780 [Circumvention/BridgeDB]: Write a specification for BridgeDB's metrics

[Tor Bug Tracker & Wiki]

#31780: Write a specification for BridgeDB's metrics
+---
 Reporter:  phw |  Owner:  phw
 Type:  task| Status:  merge_ready
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  cohosh  |Sponsor:  Sponsor30-can
+---

Comment (by phw):

 Replying to [comment:7 karsten]:
 > Just one question: can we somehow make these changes to existing
 `bridgedb-metrics.log*` files, either on polyanthum or on colchicifolium?
 It would be sad to lose a month of files just because of cosmetic changes
 to the spec. If so, do you prefer editing files yourself, or shall I do
 that?
 [[br]]
 I will modify all the files that are currently on polyanthum but you'll
 have to modify the ones that were already synced to colchicifolium.

 Other than that, does the spec look good to you?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31780 [Circumvention/BridgeDB]: Write a specification for BridgeDB's metrics

[Tor Bug Tracker & Wiki]

#31780: Write a specification for BridgeDB's metrics
+---
 Reporter:  phw |  Owner:  phw
 Type:  task| Status:  merge_ready
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  cohosh  |Sponsor:  Sponsor30-can
+---

Comment (by karsten):

 Just one question: can we somehow make these changes to existing
 `bridgedb-metrics.log*` files, either on polyanthum or on colchicifolium?
 It would be sad to lose a month of files just because of cosmetic changes
 to the spec. If so, do you prefer editing files yourself, or shall I do
 that?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31780 [Circumvention/BridgeDB]: Write a specification for BridgeDB's metrics

[Tor Bug Tracker & Wiki]

#31780: Write a specification for BridgeDB's metrics
+---
 Reporter:  phw |  Owner:  phw
 Type:  task| Status:  merge_ready
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  cohosh  |Sponsor:  Sponsor30-can
+---

Comment (by karsten):

 Sorry for the delay. I'll take a look today!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31780 [Circumvention/BridgeDB]: Write a specification for BridgeDB's metrics

[Tor Bug Tracker & Wiki]

#31780: Write a specification for BridgeDB's metrics
+---
 Reporter:  phw |  Owner:  phw
 Type:  task| Status:  merge_ready
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  cohosh  |Sponsor:  Sponsor30-can
+---

Comment (by phw):

 Replying to [comment:4 cohosh]:
 > These revisions look good to me!
 [[br]]
 Thanks. I'll wait a bit before merging because karsten mentioned he'll
 take a look too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31780 [Circumvention/BridgeDB]: Write a specification for BridgeDB's metrics

[Tor Bug Tracker & Wiki]

#31780: Write a specification for BridgeDB's metrics
+---
 Reporter:  phw |  Owner:  phw
 Type:  task| Status:  merge_ready
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  cohosh  |Sponsor:  Sponsor30-can
+---
Changes (by cohosh):

 * status:  needs_review => merge_ready


Comment:

 These revisions look good to me!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31780 [Circumvention/BridgeDB]: Write a specification for BridgeDB's metrics

[Tor Bug Tracker & Wiki]

#31780: Write a specification for BridgeDB's metrics
+---
 Reporter:  phw |  Owner:  phw
 Type:  task| Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  cohosh  |Sponsor:  Sponsor30-can
+---
Changes (by phw):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:2 cohosh]:
 > I left a few comments on the commit.
 [[br]]
 Thanks! I addressed your feedback
 
[https://github.com/NullHypothesis/torspec/compare/8e49989519ca9f38955cc5f240e5c7cb6fb9a7c7...ce028be583a6810fd8866868beea1adf84ee7043
 here].
 [[br]]
 > Also note that the snowflake metrics spec exists in the snowflake
 repository and not in torspec (as suggested in
 https://trac.torproject.org/projects/tor/ticket/28942#comment:65)
 > I know there's already a spec for bridgedb in torspec so appending this
 to that makes sense to me. Just noting the difference here.
 [[br]]
 Good point. BridgeDB's specification is outdated to a point where it may
 do more harm than good and if somebody's interested in the metrics spec,
 they are more likely to search for it in BridgeDB's repo. I think we
 should move it.
 
[https://github.com/NullHypothesis/bridgedb/commit/e6908a8f11ad5db24d47b5dccc9ee1368495a404
 Here's a patch] that adds the spec to BridgeDB's repo and updates the code
 to be consistent with the spec. (The spec includes the revisions, so you
 don't have to re-review it.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31780 [Circumvention/BridgeDB]: Write a specification for BridgeDB's metrics

[Tor Bug Tracker & Wiki]

#31780: Write a specification for BridgeDB's metrics
+
 Reporter:  phw |  Owner:  phw
 Type:  task| Status:  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  cohosh  |Sponsor:  Sponsor30-can
+
Changes (by cohosh):

 * status:  needs_review => needs_revision


Comment:

 I left a few comments on the commit.

 Also note that the snowflake metrics spec exists in the snowflake
 repository and not in torspec (as suggested in
 https://trac.torproject.org/projects/tor/ticket/28942#comment:65)
 I know there's already a spec for bridgedb in torspec so appending this to
 that makes sense to me. Just noting the difference here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31780 [Circumvention/BridgeDB]: Write a specification for BridgeDB's metrics

[Tor Bug Tracker & Wiki]

#31780: Write a specification for BridgeDB's metrics
+---
 Reporter:  phw |  Owner:  phw
 Type:  task| Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  cohosh  |Sponsor:  Sponsor30-can
+---
Changes (by phw):

 * cc: karsten (added)
 * reviewer:   => cohosh
 * status:  assigned => needs_review


Comment:

 I
 
[https://github.com/NullHypothesis/torspec/commit/8e49989519ca9f38955cc5f240e5c7cb6fb9a7c7
 wrote a patch] that adds BridgeDB's metrics format to the torspec
 repository.

 Note that the patch differs from our current implementation in its version
 number. Our current implementation uses `1.0` while the spec uses `1`. I
 would like to update the implementation because a single number number
 seems simpler.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31780 [Circumvention/BridgeDB]: Write a specification for BridgeDB's metrics

[Tor Bug Tracker & Wiki]

#31780: Write a specification for BridgeDB's metrics
+--
 Reporter:  phw |  Owner:  phw
 Type:  task| Status:  assigned
 Priority:  Medium  |  Milestone:
Component:  Circumvention/BridgeDB  |Version:
 Severity:  Normal  |   Keywords:
Actual Points:  |  Parent ID:
   Points:  0.5 |   Reviewer:
  Sponsor:  Sponsor30-can   |
+--
 Now that BridgeDB exports metrics (#9316), it's time to specify the format
 of these metrics, allowing third parties to write parsers.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs