Re: [tor-bugs] #32451 [Core Tor/Tor]: test/parseconf: Add support for required log messages on success

[Tor Bug Tracker & Wiki]

#32451: test/parseconf: Add support for required log messages on success
---+---
 Reporter:  teor   |  Owner:  teor
 Type:  enhancement| Status:  closed
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:  implemented
 Keywords:  network-team-roadmap-november  |  Actual Points:  1.1
Parent ID:  #29211 | Points:  0.5
 Reviewer:  nickm  |Sponsor:  Sponsor31-can
---+---
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => implemented


Comment:

 Merged to master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32451 [Core Tor/Tor]: test/parseconf: Add support for required log messages on success

[Tor Bug Tracker & Wiki]

#32451: test/parseconf: Add support for required log messages on success
---+---
 Reporter:  teor   |  Owner:  teor
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  network-team-roadmap-november  |  Actual Points:  1.1
Parent ID:  #29211 | Points:  0.5
 Reviewer:  nickm  |Sponsor:  Sponsor31-can
---+---

Comment (by nickm):

 I've looked the branch over, and it seems good to me. I especially like
 the fact that you included conf_failures to verify that `test_parseconf`
 really tests things.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32451 [Core Tor/Tor]: test/parseconf: Add support for required log messages on success

[Tor Bug Tracker & Wiki]

#32451: test/parseconf: Add support for required log messages on success
---+---
 Reporter:  teor   |  Owner:  teor
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  network-team-roadmap-november  |  Actual Points:  1.1
Parent ID:  #29211 | Points:  0.5
 Reviewer:  nickm  |Sponsor:  Sponsor31-can
---+---
Changes (by teor):

 * status:  needs_revision => needs_review
 * reviewer:   => nickm
 * actualpoints:  0.6 => 1.1


Comment:

 See my PR:
 * master: https://github.com/torproject/tor/pull/1531

 It contains:
 * expected_log support, for checking log messages when the config is
 successful
 * better diagnostics
 * common test_parseconf.sh failure cases, in a separate conf_failures
 directory
 * refactoring to remove duplicate code

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32451 [Core Tor/Tor]: test/parseconf: Add support for required log messages on success

[Tor Bug Tracker & Wiki]

#32451: test/parseconf: Add support for required log messages on success
---+---
 Reporter:  teor   |  Owner:  teor
 Type:  enhancement| Status:
   |  needs_revision
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  network-team-roadmap-november  |  Actual Points:  0.6
Parent ID:  #29211 | Points:  0.5
 Reviewer: |Sponsor:  Sponsor31-can
---+---
Changes (by teor):

 * actualpoints:  0.3 => 0.6


Comment:

 Another update, refactoring is finished.

 Still need to do tests and a changes file.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32451 [Core Tor/Tor]: test/parseconf: Add support for required log messages on success

[Tor Bug Tracker & Wiki]

#32451: test/parseconf: Add support for required log messages on success
---+---
 Reporter:  teor   |  Owner:  teor
 Type:  enhancement| Status:
   |  needs_revision
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  network-team-roadmap-november  |  Actual Points:  0.3
Parent ID:  #29211 | Points:  0.5
 Reviewer: |Sponsor:  Sponsor31-can
---+---
Changes (by teor):

 * status:  assigned => needs_revision
 * actualpoints:   => 0.3


Comment:

 Here's my draft pull request, I discovered #32468 while writing it.

 * master: https://github.com/torproject/tor/pull/1531

 I still need to:
 * refactor the script to remove duplicate code
 * make most tests use expected_log
 * write a changes file

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32451 [Core Tor/Tor]: test/parseconf: Add support for required log messages on success

[Tor Bug Tracker & Wiki]

#32451: test/parseconf: Add support for required log messages on success
---+---
 Reporter:  teor   |  Owner:  teor
 Type:  enhancement| Status:  assigned
 Priority:  Medium |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal |   Keywords:  network-team-roadmap-november
Actual Points: |  Parent ID:  #29211
   Points:  0.5|   Reviewer:
  Sponsor:  Sponsor31-can  |
---+---
 We want to test that the "obsolete" log message includes the name of the
 option. But test_parseconf.sh doesn't check for log content on success.

 Similarly, our lzma, zstd, and nss tests should also test for logs from a
 successful launch. At the moment, they force a failure, then check the
 logs.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs