Re: [tor-bugs] #32455 [Core Tor/Tor]: Run "make doxygen" in a travis builder

[Tor Bug Tracker & Wiki]

#32455: Run "make doxygen" in a travis builder
---+---
 Reporter:  nickm  |  Owner:  rl1987
 Type:  task   | Status:  closed
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:  implemented
 Keywords:  doxygen tor-ci 043-should  |  Actual Points:
Parent ID: | Points:  .3
 Reviewer:  nickm  |Sponsor:  Sponsor31-can
---+---
Changes (by nickm):

 * status:  needs_revision => closed
 * resolution:   => implemented


Comment:

 Oh, you're right!  I had thought incorrectly that there was a `make all`
 invocation that `SKIP_MAKE_CHECK` didn't skip.  I think this patch is
 fine, then.  Merged, and thanks for your patience!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32455 [Core Tor/Tor]: Run "make doxygen" in a travis builder

[Tor Bug Tracker & Wiki]

#32455: Run "make doxygen" in a travis builder
---+---
 Reporter:  nickm  |  Owner:  rl1987
 Type:  task   | Status:  needs_revision
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  doxygen tor-ci 043-should  |  Actual Points:
Parent ID: | Points:  .3
 Reviewer:  nickm  |Sponsor:  Sponsor31-can
---+---

Comment (by rl1987):

 But it does not recompile Tor binary (`SKIP_MAKE_CHECK` is set to true)?
 Above example build took 1 min. 33 seconds to complete.

 I can move `make doxygen` command to the end of coverage build though.
 This would be slightly faster, as we wouldn't need to rerun `configure`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32455 [Core Tor/Tor]: Run "make doxygen" in a travis builder

[Tor Bug Tracker & Wiki]

#32455: Run "make doxygen" in a travis builder
---+---
 Reporter:  nickm  |  Owner:  rl1987
 Type:  task   | Status:  needs_revision
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  doxygen tor-ci 043-should  |  Actual Points:
Parent ID: | Points:  .3
 Reviewer:  nickm  |Sponsor:  Sponsor31-can
---+---

Comment (by teor):

 Replying to [comment:5 nickm]:
 > I wonder if we can add this to an existing builder, instead of making a
 new builder?  Using a separate builder here makes us recompile Tor
 unnecessarily, which I would expect would slow down CI.

 I suggest the coverage build, in case we ever want to do documentation
 coverage.

 We could also add a new builder, but run "make doxygen" instead of "make"
 or "make src/app/tor". Linux builders only cost us a few 10s of seconds to
 start up and clone tor.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32455 [Core Tor/Tor]: Run "make doxygen" in a travis builder

[Tor Bug Tracker & Wiki]

#32455: Run "make doxygen" in a travis builder
---+---
 Reporter:  nickm  |  Owner:  rl1987
 Type:  task   | Status:  needs_revision
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  doxygen tor-ci 043-should  |  Actual Points:
Parent ID: | Points:  .3
 Reviewer:  nickm  |Sponsor:  Sponsor31-can
---+---
Changes (by nickm):

 * status:  assigned => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32455 [Core Tor/Tor]: Run "make doxygen" in a travis builder

[Tor Bug Tracker & Wiki]

#32455: Run "make doxygen" in a travis builder
---+---
 Reporter:  nickm  |  Owner:  rl1987
 Type:  task   | Status:  assigned
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  doxygen tor-ci 043-should  |  Actual Points:
Parent ID: | Points:  .3
 Reviewer:  nickm  |Sponsor:  Sponsor31-can
---+---
Changes (by nickm):

 * status:  needs_revision => assigned
 * owner:  (none) => rl1987


Comment:

 Setting owner.

 Rl1987, please let us know if you won't be revising this in the next month
 or so?  I'd like to get it into 0.4.3 if possible.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32455 [Core Tor/Tor]: Run "make doxygen" in a travis builder

[Tor Bug Tracker & Wiki]

#32455: Run "make doxygen" in a travis builder
---+---
 Reporter:  nickm  |  Owner:  (none)
 Type:  task   | Status:  needs_revision
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  doxygen tor-ci 043-should  |  Actual Points:
Parent ID: | Points:  .3
 Reviewer:  nickm  |Sponsor:  Sponsor31-can
---+---
Changes (by nickm):

 * status:  needs_review => needs_revision
 * reviewer:   => nickm


Comment:

 I wonder if we can add this to an existing builder, instead of making a
 new builder?  Using a separate builder here makes us recompile Tor
 unnecessarily, which I would expect would slow down CI.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32455 [Core Tor/Tor]: Run "make doxygen" in a travis builder

[Tor Bug Tracker & Wiki]

#32455: Run "make doxygen" in a travis builder
---+---
 Reporter:  nickm  |  Owner:  (none)
 Type:  task   | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  doxygen tor-ci 043-should  |  Actual Points:
Parent ID: | Points:  .3
 Reviewer: |Sponsor:  Sponsor31-can
---+---
Changes (by rl1987):

 * status:  new => needs_review


Comment:

 https://github.com/torproject/tor/pull/1680

 Example run (on unsquashed branch): https://travis-
 
ci.org/rl1987/tor/jobs/640408146?utm_medium=notification_source=github_status

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32455 [Core Tor/Tor]: Run "make doxygen" in a travis builder

[Tor Bug Tracker & Wiki]

#32455: Run "make doxygen" in a travis builder
---+---
 Reporter:  nickm  |  Owner:  (none)
 Type:  task   | Status:  new
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  doxygen tor-ci 043-should  |  Actual Points:
Parent ID: | Points:  .3
 Reviewer: |Sponsor:  Sponsor31-can
---+---
Changes (by nickm):

 * keywords:  doxygen tor-ci => doxygen tor-ci 043-should


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32455 [Core Tor/Tor]: Run "make doxygen" in a travis builder

[Tor Bug Tracker & Wiki]

#32455: Run "make doxygen" in a travis builder
+
 Reporter:  nickm   |  Owner:  (none)
 Type:  task| Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  doxygen tor-ci  |  Actual Points:
Parent ID:  | Points:  .3
 Reviewer:  |Sponsor:  Sponsor31-can
+
Changes (by nickm):

 * parent:  #29214 =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32455 [Core Tor/Tor]: Run "make doxygen" in a travis builder

[Tor Bug Tracker & Wiki]

#32455: Run "make doxygen" in a travis builder
---+
 Reporter:  nickm  |  Owner:  (none)
 Type:  task   | Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal |   Keywords:  doxygen tor-ci
Actual Points: |  Parent ID:
   Points:  .3 |   Reviewer:
  Sponsor:  Sponsor31-can  |
---+
 With #32385, we now have --enable-fatal-warnings behave sensibly with
 doxygen warnings.  We can prevent ourselves from introducing new doxygen
 warnings by having a travis builder that does "make doxygen".

 This won't apply to warnings about missing documentation: those are off by
 default, since we have a few thousand of them.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs