Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0435,|  Actual Points:  1.1
  043-should, ipv6, 035-backport, 041-backport,  |
  042-backport, 043-backport, network-team-  |
  roadmap-2020Q1 |
Parent ID:  #33048   | Points:  1
 Reviewer:  nickm, teor  |Sponsor:
 |  Sponsor55-must
-+-

Comment (by teor):

 Replying to [comment:44 teor]:
 > 0.4.1 and 0.4.2 failed on Travis, but they pass locally.
 >
 > And Travis is having a database downtime, so I can't check why. See:
 > https://www.traviscistatus.com/

 These errors appear to be Travis macOS hangs, due to #32804.

 I have restarted the relevant builds.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0435,|  Actual Points:  1.1
  043-should, ipv6, 035-backport, 041-backport,  |
  042-backport, 043-backport |
Parent ID:  #33048   | Points:  1
 Reviewer:  nickm, teor  |Sponsor:
 |  Sponsor55-must
-+-
Changes (by nickm):

 * milestone:  Tor: 0.4.4.x-final => Tor: 0.4.3.x-final


Comment:

 Okay, I'm merging this to master and marking for a 0.4.3 backport.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0435,|  Actual Points:  1.1
  043-should, ipv6, 035-backport, 041-backport,  |
  042-backport, 043-backport |
Parent ID:  #33048   | Points:  1
 Reviewer:  nickm, teor  |Sponsor:
 |  Sponsor55-must
-+-

Comment (by teor):

 0.4.1 and 0.4.2 failed on Travis, but they pass locally.

 And Travis is having a database downtime, so I can't check why. See:
 https://www.traviscistatus.com/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0435,|  Actual Points:  1.1
  043-should, ipv6, 035-backport, 041-backport,  |
  042-backport, 043-backport |
Parent ID:  #33048   | Points:  1
 Reviewer:  nickm, teor  |Sponsor:
 |  Sponsor55-must
-+-
Changes (by teor):

 * status:  needs_revision => merge_ready


Comment:

 I squashed my changes, nick's changes, my extra tests, and some minor test
 fixes.

 See my PRs:
 * 0.3.5: https://github.com/torproject/tor/pull/1827
 * 0.4.1: https://github.com/torproject/tor/pull/1828
 * 0.4.3: https://github.com/torproject/tor/pull/1829
 * master: https://github.com/torproject/tor/pull/1830

 Test branches are here:
 * https://github.com/teor2345/tor/branches/all?query=32588

 Anyone can merge after CI passes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-0435,|  Actual Points:  1.1
  043-should, ipv6, 035-backport, 041-backport,  |
  042-backport, 043-backport |
Parent ID:  #33048   | Points:  1
 Reviewer:  nickm, teor  |Sponsor:
 |  Sponsor55-must
-+-
Changes (by teor):

 * keywords:
 043-should, ipv6, memory-safety, security-low, 035-backport,
 040-backport, 041-backport, 042-backport
 =>
 consider-backport-after-0435, 043-should, ipv6, 035-backport,
 041-backport, 042-backport, 043-backport
 * actualpoints:  1 => 1.1
 * milestone:  Tor: 0.4.3.x-final => Tor: 0.4.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  043-should, ipv6, memory-safety, |  Actual Points:  1
  security-low, 035-backport, 040-backport,  |
  041-backport, 042-backport |
Parent ID:  #33048   | Points:  1
 Reviewer:  nickm, teor  |Sponsor:
 |  Sponsor55-must
-+-

Comment (by teor):

 I tweaked a few of the tests, and fixed the changes file.

 See my PR:
 * 0.3.5: https://github.com/torproject/tor/pull/1826

 I'll squash and create merge forward branches after the tests pass.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  043-should, ipv6, memory-safety, |  Actual Points:  1
  security-low, 035-backport, 040-backport,  |
  041-backport, 042-backport |
Parent ID:  #33048   | Points:  1
 Reviewer:  ahf  |Sponsor:
 |  Sponsor55-must
-+-
Changes (by teor):

 * status:  accepted => assigned
 * owner:  nickm => teor


Comment:

 Thanks, this is exactly what I wanted to test. Honestly, I was a bit stuck
 trying to work out how.

 I'll do a few tweaks, and then merge.

 Thanks so much!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  043-should, ipv6, memory-safety, |  Actual Points:  1
  security-low, 035-backport, 040-backport,  |
  041-backport, 042-backport |
Parent ID:  #33048   | Points:  1
 Reviewer:  nickm, teor  |Sponsor:
 |  Sponsor55-must
-+-
Changes (by teor):

 * status:  assigned => needs_revision
 * reviewer:  ahf => nickm, teor


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  nickm
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  043-should, ipv6, memory-safety, |  Actual Points:  1
  security-low, 035-backport, 040-backport,  |
  041-backport, 042-backport |
Parent ID:  #33048   | Points:  1
 Reviewer:  ahf  |Sponsor:
 |  Sponsor55-must
-+-

Comment (by teor):

 Replying to [comment:35 nickm]:
 > FWIW, this isn't an "uninitialized RAM" bug: The reason it says 94 is
 that the "ipv6_port" field in the cfg_port_t is set to CFG_AUTO_PORT,
 which is 0xc4005e in hex.  Once that's cast to a uint16_t, we get 0x5e,
 which is 94.

 That makes sense! I misread the hex constant as 0x405e, so I couldn't work
 out how the cast was doing that, without some memory misalignment.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  nickm
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  043-should, ipv6, memory-safety, |  Actual Points:  0.8
  security-low, 035-backport, 040-backport,  |
  041-backport, 042-backport |
Parent ID:  #33048   | Points:  1
 Reviewer:  ahf  |Sponsor:
 |  Sponsor55-must
-+-

Comment (by nickm):

 I wrote some tests on top of your branch, in a branch called
 `bug32588_035_tests.  I made a PR at
 https://github.com/torproject/tor/pull/1811 .  There will be merge
 conflicts later on here, but they look to be straightforward.  Please let
 me know if you want help with those: I'm going under the assumption you
 might want to edit this branch some more.

 I don't know whether this is everything you wanted to test or not.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  nickm
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  043-should, ipv6, memory-safety, |  Actual Points:  1
  security-low, 035-backport, 040-backport,  |
  041-backport, 042-backport |
Parent ID:  #33048   | Points:  1
 Reviewer:  ahf  |Sponsor:
 |  Sponsor55-must
-+-
Changes (by nickm):

 * actualpoints:  0.8 => 1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  nickm
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  043-should, ipv6, memory-safety, |  Actual Points:  0.8
  security-low, 035-backport, 040-backport,  |
  041-backport, 042-backport |
Parent ID:  #33048   | Points:  1
 Reviewer:  ahf  |Sponsor:
 |  Sponsor55-must
-+-

Comment (by nickm):

 FWIW, this isn't an "uninitialized RAM" bug: The reason it says 94 is that
 the "ipv6_port" field in the cfg_port_t is set to CFG_AUTO_PORT, which is
 0xc4005e in hex.  Once that's cast to a uint16_t, we get 0x5e, which is
 94.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  nickm
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  043-should, ipv6, memory-safety, |  Actual Points:  0.8
  security-low, 035-backport, 040-backport,  |
  041-backport, 042-backport |
Parent ID:  #33048   | Points:  1
 Reviewer:  ahf  |Sponsor:
 |  Sponsor55-must
-+-
Changes (by nickm):

 * status:  needs_revision => accepted
 * owner:  teor => nickm


Comment:

 I'll try doing the tests here to take some load off teor.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  043-should, ipv6, memory-safety, |  Actual Points:  0.8
  security-low, 035-backport, 040-backport,  |
  041-backport, 042-backport |
Parent ID:  #33048   | Points:  1
 Reviewer:  ahf  |Sponsor:
 |  Sponsor55-must
-+-
Changes (by teor):

 * status:  assigned => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  043-should, ipv6, memory-safety, |  Actual Points:  0.8
  security-low, 035-backport, 040-backport,  |
  041-backport, 042-backport |
Parent ID:  #33048   | Points:  1
 Reviewer:  ahf  |Sponsor:
 |  Sponsor55-must
-+-
Changes (by teor):

 * owner:  ahf => teor
 * reviewer:   => ahf
 * status:  needs_revision => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  ahf
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  043-should, ipv6, memory-safety, |  Actual Points:  0.8
  security-low, 035-backport, 040-backport,  |
  041-backport, 042-backport |
Parent ID:  #33048   | Points:  1
 Reviewer:   |Sponsor:
 |  Sponsor55-must
-+-
Changes (by teor):

 * sponsor:   => Sponsor55-must
 * parent:   => #33048


Comment:

 I'm going to need the new function in this branch for Sponsor 55,
 Objective 1.1.

 ahf, do you think you can get the remaining tests done this week?

 If not, I can take this task back.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  ahf
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  043-should, ipv6, memory-safety, |  Actual Points:  0.8
  security-low, 035-backport, 040-backport,  |
  041-backport, 042-backport |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by ahf):

 * status:  assigned => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  ahf
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  043-should, ipv6, memory-safety, |  Actual Points:  0.8
  security-low, 035-backport, 040-backport,  |
  041-backport, 042-backport |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by ahf):

 * owner:  (none) => ahf
 * status:  needs_revision => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  043-should, ipv6, memory-safety, |  Actual Points:  0.8
  security-low, 035-backport, 040-backport,  |
  041-backport, 042-backport |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  assigned => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  (none)
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  043-should, ipv6, memory-safety, |  Actual Points:  0.8
  security-low, 035-backport, 040-backport,  |
  041-backport, 042-backport |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * owner:  teor => (none)
 * status:  needs_revision => assigned


Comment:

 This fix should go in 0.4.3, someone just needs to write a unit test or a
 script test.

 Or we can decide that it's too hard to test, and the reviewer can just
 check it manually.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  043-should, ipv6, memory-safety, |  Actual Points:  0.8
  security-low, 035-backport, 040-backport,  |
  041-backport, 042-backport |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * actualpoints:  0.6 => 0.8


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  043-should, ipv6, memory-safety, |  Actual Points:  0.6
  security-low, 035-backport, 040-backport,  |
  041-backport, 042-backport |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Replying to [comment:23 teor]:
 > I made some fixes suggested by dgoulet in #32822, and squashed them in
 to a new PR:
 > * 0.3.5: https://github.com/torproject/tor/pull/1654

 I added some tests for auto port parsing. They don't actually trigger this
 bug, but they do increase the auto port config code coverage:

 * master: https://github.com/torproject/tor/pull/1660

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  043-should, ipv6, memory-safety, |  Actual Points:  0.6
  security-low, 035-backport, 040-backport,  |
  041-backport, 042-backport |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => needs_revision
 * keywords:
 ipv6, memory-safety, security-low, 035-backport, 040-backport,
 041-backport, 042-backport
 =>
 043-should, ipv6, memory-safety, security-low, 035-backport,
 040-backport, 041-backport, 042-backport


Comment:

 I made some fixes, but I still need to do unit tests, so I'm leaving it in
 needs_revision.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, memory-safety, security-low,   |  Actual Points:  0.6
  035-backport, 040-backport, 041-backport,  |
  042-backport   |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:
 ipv6, memory-safety, security-low, 035-backport, 040-backport,
 041-backport, 042-backport 043-should
 =>
 ipv6, memory-safety, security-low, 035-backport, 040-backport,
 041-backport, 042-backport


Comment:

 I made some fixes suggested by dgoulet in #32822, and squashed them in to
 a new PR:
 * 0.3.5: https://github.com/torproject/tor/pull/1654

 The fixup commits are in the old PR.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, memory-safety, security-low,   |  Actual Points:  0.6
  035-backport, 040-backport, 041-backport,  |
  042-backport 043-should|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  teor
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, memory-safety, security-low,   |  Actual Points:  0.6
  035-backport, 040-backport, 041-backport,  |
  042-backport 043-should|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => assigned
 * owner:  (none) => teor


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, memory-safety, security-low,   |  Actual Points:  0.6
  035-backport, 040-backport, 041-backport,  |
  042-backport 043-should|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by neel):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  (none)
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, memory-safety, security-low,   |  Actual Points:  0.6
  035-backport, 040-backport, 041-backport,  |
  042-backport 043-should|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by neel):

 * status:  needs_review => assigned
 * owner:  neel => (none)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  neel
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, memory-safety, security-low,   |  Actual Points:  0.6
  035-backport, 040-backport, 041-backport,  |
  042-backport 043-should|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:
 ipv6, memory-safety, security-low, 035-backport, 040-backport,
 041-backport, 042-backport
 =>
 ipv6, memory-safety, security-low, 035-backport, 040-backport,
 041-backport, 042-backport 043-should


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  neel
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, memory-safety, security-low,   |  Actual Points:  0.6
  035-backport, 040-backport, 041-backport,  |
  042-backport   |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  needs_revision => needs_review
 * actualpoints:  0.4 => 0.6


Comment:

 Replying to [comment:13 dgoulet]:
 > Hmmm CI exploded for _one_ specific builds with interesting stacktrace:
 >
 > https://travis-ci.org/torproject/tor/jobs/627571176

 I forgot to check for a NULL IPv6 address.

 I re-did the patch, and split the commits into:
 * bug fix (and code movement)
 * refactoring

 I still need to write some tests, but I'd like a review :-)
 I also need to fix up #32822, because it's based on this branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  neel
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, memory-safety, security-low,   |  Actual Points:  0.4
  035-backport, 040-backport, 041-backport,  |
  042-backport   |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by dgoulet):

 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  neel
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, memory-safety, security-low,   |  Actual Points:  0.4
  035-backport, 040-backport, 041-backport,  |
  042-backport   |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by neel):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  neel
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, memory-safety, security-low,   |  Actual Points:  0.4
  035-backport, 040-backport, 041-backport,  |
  042-backport   |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by neel):

 * cc: neel (removed)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  neel
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, memory-safety, security-low,   |  Actual Points:  0.4
  035-backport, 040-backport, 041-backport,  |
  042-backport   |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 Hmmm CI exploded for _one_ specific builds with interesting stacktrace:

 https://travis-ci.org/torproject/tor/jobs/627571176

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  neel
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, memory-safety, security-low,   |  Actual Points:  0.4
  035-backport, 040-backport, 041-backport,  |
  042-backport   |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 Test branches are here:
 * https://github.com/teor2345/tor/branches/all?query=bug32588_

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
-+-
 Reporter:  arma |  Owner:  neel
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.3.9-alpha
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, memory-safety, security-low,   |  Actual Points:  0.4
  035-backport, 040-backport, 041-backport,  |
  042-backport   |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:  ipv6, memory-safety, security-low =>
 ipv6, memory-safety, security-low, 035-backport, 040-backport,
 041-backport, 042-backport
 * points:   => 1
 * version:  Tor: 0.4.1.6 => Tor: 0.2.3.9-alpha
 * actualpoints:   => 0.4


Comment:

 See my PR:
 * 0.3.5: https://github.com/torproject/tor/pull/1625

 I'd like an initial review.

 I will try to write some unit tests on Monday.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
---+---
 Reporter:  arma   |  Owner:  neel
 Type:  defect | Status:
   |  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.3.x-final
Component:  Core Tor/Tor   |Version:  Tor:
   |  0.4.1.6
 Severity:  Normal | Resolution:
 Keywords:  ipv6, memory-safety, security-low  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by teor):

 * Attachment "relay.sh" added.

 Tor test script for IPv6 ORPort auto bug

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
---+---
 Reporter:  arma   |  Owner:  neel
 Type:  defect | Status:
   |  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.3.x-final
Component:  Core Tor/Tor   |Version:  Tor:
   |  0.4.1.6
 Severity:  Normal | Resolution:
 Keywords:  ipv6, memory-safety, security-low  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by teor):

 * status:  needs_information => needs_review


Comment:

 Here's a draft PR:
 * don't merge: https://github.com/torproject/tor/pull/1624

 I still need to:
 * check how far to backport
 * make a changes file
 * open a separate ticket for the related authority change

 I'll attach the test script I was using.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
---+---
 Reporter:  arma   |  Owner:  neel
 Type:  defect | Status:
   |  needs_information
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.3.x-final
Component:  Core Tor/Tor   |Version:  Tor:
   |  0.4.1.6
 Severity:  Normal | Resolution:
 Keywords:  ipv6, memory-safety, security-low  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---

Comment (by arma):

 Anybody should be able to reproduce the bug with the initial instructions
 -- set two orports and a dirport, and then you can look at your descriptor
 on your local dirport.

 When I set my ORPort to [::2]:auto it still publishes
 {{{
 or-address [::2]:94
 }}}
 in its descriptor.

 Same with [::5] and [::10].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
---+---
 Reporter:  arma   |  Owner:  neel
 Type:  defect | Status:
   |  needs_information
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.3.x-final
Component:  Core Tor/Tor   |Version:  Tor:
   |  0.4.1.6
 Severity:  Normal | Resolution:
 Keywords:  ipv6, memory-safety, security-low  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Description changed by arma:

Old description:

> Start your Tor with
> {{{
> ORPort 9001
> ORPort [2a01:238:43e4:2b00:ae5a:a980:1f63:cc5e]:auto nolisten
> DirPort 9030
> }}}
> and let it start up. Then go to http://127.0.0.1/tor/server/authority and
> check out how it has the line
> {{{
> or-address [2a01:238:43e4:2b00:ae5a:a980:1f63:cc5e]:94
> }}}
>
> First: How did it pick that number? It's a weird choice for a port.
>
> Second: If this is actually your ipv6 address, you can leave out the
> nolisten, and that's where things get interesting. Your logs will say
> something like
> {{{
> Nov 24 01:53:42 v4 tor[10988]: Nov 24 01:53:42.001 [notice] Opening OR
> listener on [2a01:238:43e4:2b00:ae5a:a980:1f63:cc5e]:0
> Nov 24 01:53:42 v4 tor[10988]: Nov 24 01:53:42.002 [notice] Opened OR
> listener on [2a01:238:43e4:2b00:ae5a:a980:1f63:cc5e]:41535
> }}}
>
> but then your descriptor will still say :94.
>
> This is happening right now to relay "Testbit": they have set :auto for
> their ipv6 address in their ORPort, they get the above line about how
> it's opened on port 41535, and yet their descriptor says it's on port 94.

New description:

 Start your Tor with
 {{{
 ORPort 9001
 ORPort [2a01:238:43e4:2b00:ae5a:a980:1f63:cc5e]:auto nolisten
 DirPort 9030
 }}}
 and let it start up. Then go to http://127.0.0.1:9030/tor/server/authority
 and check out how it has the line
 {{{
 or-address [2a01:238:43e4:2b00:ae5a:a980:1f63:cc5e]:94
 }}}

 First: How did it pick that number? It's a weird choice for a port.

 Second: If this is actually your ipv6 address, you can leave out the
 nolisten, and that's where things get interesting. Your logs will say
 something like
 {{{
 Nov 24 01:53:42 v4 tor[10988]: Nov 24 01:53:42.001 [notice] Opening OR
 listener on [2a01:238:43e4:2b00:ae5a:a980:1f63:cc5e]:0
 Nov 24 01:53:42 v4 tor[10988]: Nov 24 01:53:42.002 [notice] Opened OR
 listener on [2a01:238:43e4:2b00:ae5a:a980:1f63:cc5e]:41535
 }}}

 but then your descriptor will still say :94.

 This is happening right now to relay "Testbit": they have set :auto for
 their ipv6 address in their ORPort, they get the above line about how it's
 opened on port 41535, and yet their descriptor says it's on port 94.

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
---+---
 Reporter:  arma   |  Owner:  neel
 Type:  defect | Status:
   |  needs_information
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.3.x-final
Component:  Core Tor/Tor   |Version:  Tor:
   |  0.4.1.6
 Severity:  Normal | Resolution:
 Keywords:  ipv6, memory-safety, security-low  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---

Comment (by teor):

 It's also worth noting that we're getting 0x5e = 94 in the output, and not
 0xcc5e or 0x5ecc. So it's just a one byte overflow. And it's happening
 some time after the port is opened, but before the relay descriptor is
 built.

 And it only seems to affect auto IPv6 ORPorts.

 Does the issue still happen if the IPv6 address is much shorter than the
 maximum length?
 For example, does "ORPort [::1]:auto" give you a port of 1?
 You might need to set some custom directory authorities to be allowed to
 listen on an internal address.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
---+---
 Reporter:  arma   |  Owner:  neel
 Type:  defect | Status:
   |  needs_information
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.3.x-final
Component:  Core Tor/Tor   |Version:  Tor:
   |  0.4.1.6
 Severity:  Normal | Resolution:
 Keywords:  ipv6, memory-safety, security-low  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by teor):

 * keywords:  ipv6 => ipv6, memory-safety, security-low
 * status:  assigned => needs_information


Comment:

 The IPv6 descriptor code can never work for auto ports:
 https://github.com/torproject/tor/blob/master/src/feature/relay/router.c#L1991

 It should be like the IPv4 descriptor port code:
 https://github.com/torproject/tor/blob/master/src/feature/relay/router.c#L1978
 And call router_get_advertised_or_port_by_af() to get the IPv6 ORPort.

 Ideally, we should add a new router_get_advertised_ipv6_or_port()
 function, which searches for an address like this:
 https://github.com/torproject/tor/blob/master/src/feature/relay/router.c#L1991

 But searches for a port like this: (if the discovered port is 0)
 router_get_advertised_or_port_by_af(… , AF_INET6).

 I still can't work out how the port ends up being 94. Maybe we're
 overwriting some memory somewhere?
 I think we should try to find the memory issue, before we call this bug
 "fixed".

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
--+
 Reporter:  arma  |  Owner:  neel
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.4.1.6
 Severity:  Normal| Resolution:
 Keywords:  ipv6  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by neel):

 * cc: neel (added)
 * owner:  (none) => neel
 * status:  new => assigned
 * keywords:   => ipv6


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
--+
 Reporter:  arma  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.4.1.6
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * milestone:   => Tor: 0.4.3.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
--+--
 Reporter:  arma  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.4.1.6
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by arma):

 Replying to [comment:2 nickm]:
 > I agree that this is a bug.
 >
 > But another issue is that "auto" and "nolisten" don't make a lot of
 sense together.  "Auto" is "pick a port for me"; "nolisten" is "don't
 actually listen on this address, I'll set it up in a firewall rule or
 something".

 No, the NoListen is just here so you can reproduce the bug. The bug exists
 when you say :auto on your IPv6 ORPort -- the log tells you what port it
 picked, and it listens on that port, and then it puts the wrong number in
 your descriptor.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
--+--
 Reporter:  arma  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.4.1.6
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by nickm):

 I agree that this is a bug.

 But another issue is that "auto" and "nolisten" don't make a lot of sense
 together.  "Auto" is "pick a port for me"; "nolisten" is "don't actually
 listen on this address, I'll set it up in a firewall rule or something".

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
--+--
 Reporter:  arma  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.4.1.6
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 last two bytes parsed as portnumber

 0x5e = 94 in decimal :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32588 [Core Tor/Tor]: Setting ORPort [ipv6]:auto mistakenly advertises port 94

[Tor Bug Tracker & Wiki]

#32588: Setting ORPort [ipv6]:auto mistakenly advertises port 94
--+--
 Reporter:  arma  |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.4.1.6
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 Start your Tor with
 {{{
 ORPort 9001
 ORPort [2a01:238:43e4:2b00:ae5a:a980:1f63:cc5e]:auto nolisten
 DirPort 9030
 }}}
 and let it start up. Then go to http://127.0.0.1/tor/server/authority and
 check out how it has the line
 {{{
 or-address [2a01:238:43e4:2b00:ae5a:a980:1f63:cc5e]:94
 }}}

 First: How did it pick that number? It's a weird choice for a port.

 Second: If this is actually your ipv6 address, you can leave out the
 nolisten, and that's where things get interesting. Your logs will say
 something like
 {{{
 Nov 24 01:53:42 v4 tor[10988]: Nov 24 01:53:42.001 [notice] Opening OR
 listener on [2a01:238:43e4:2b00:ae5a:a980:1f63:cc5e]:0
 Nov 24 01:53:42 v4 tor[10988]: Nov 24 01:53:42.002 [notice] Opened OR
 listener on [2a01:238:43e4:2b00:ae5a:a980:1f63:cc5e]:41535
 }}}

 but then your descriptor will still say :94.

 This is happening right now to relay "Testbit": they have set :auto for
 their ipv6 address in their ORPort, they get the above line about how it's
 opened on port 41535, and yet their descriptor says it's on port 94.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs