Re: [tor-bugs] #32700 [Applications/Tor Browser]: No need to disable GeckoDriver in Windows mozconfig files

[Tor Bug Tracker & Wiki]

#32700: No need to disable GeckoDriver in Windows mozconfig files
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  TorBrowserTeam202001R,   |  Actual Points:
  GeorgKoppen201912  |
Parent ID:   | Points:  0.1
 Reviewer:  boklm|Sponsor:
-+-
Changes (by boklm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:1 gk]:
 > `bug_32700` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_32700=40502c9d0abb4e2c6b732162536fd2ea26bfe35b)
 has the patch for review.

 This looks good to me. I merged the patch to master with commit
 `b1690c3404c0454cb805a01e94e7d45e74ad17e0`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32700 [Applications/Tor Browser]: No need to disable GeckoDriver in Windows mozconfig files

[Tor Bug Tracker & Wiki]

#32700: No need to disable GeckoDriver in Windows mozconfig files
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam202001R,   |  Actual Points:
  GeorgKoppen201912  |
Parent ID:   | Points:  0.1
 Reviewer:  boklm|Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:2 cypherpunks]:
 > Child of #4280.
 >
 > `ac_add_options --enable-default-toolkit=cairo-windows` is not needed
 too.
 >
 > `mk_add_options MOZ_APP_DISPLAYNAME="Tor Browser"` -
 [https://searchfox.org/mozilla-
 esr68/rev/74b6d30c45dbe3702b882873e07815f85fb72d67/old-configure.in#2984
 Mozilla] and TBA don't set it that way, and you should not.

 Please open separate tickets for those issues.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32700 [Applications/Tor Browser]: No need to disable GeckoDriver in Windows mozconfig files

[Tor Bug Tracker & Wiki]

#32700: No need to disable GeckoDriver in Windows mozconfig files
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam202001R,   |  Actual Points:
  GeorgKoppen201912  |
Parent ID:   | Points:  0.1
 Reviewer:  boklm|Sponsor:
-+-
Changes (by boklm):

 * reviewer:   => boklm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32700 [Applications/Tor Browser]: No need to disable GeckoDriver in Windows mozconfig files

[Tor Bug Tracker & Wiki]

#32700: No need to disable GeckoDriver in Windows mozconfig files
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam202001R,   |  Actual Points:
  GeorgKoppen201912  |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  TorBrowserTeam202001R, GeorgKoppen202001 =>
 TorBrowserTeam202001R, GeorgKoppen201912


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32700 [Applications/Tor Browser]: No need to disable GeckoDriver in Windows mozconfig files

[Tor Bug Tracker & Wiki]

#32700: No need to disable GeckoDriver in Windows mozconfig files
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201912R,   |  Actual Points:
  GeorgKoppen201912  |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Child of #4280.

 `ac_add_options --enable-default-toolkit=cairo-windows` is not needed too.

 `mk_add_options MOZ_APP_DISPLAYNAME="Tor Browser"` -
 [https://searchfox.org/mozilla-
 esr68/rev/74b6d30c45dbe3702b882873e07815f85fb72d67/old-configure.in#2984
 Mozilla] and TBA don't set it that way, and you should not.

 A new line is needed after `ac_add_options --disable-eme`, because of the
 comment above it.

 `# Disable telemetry`->`# Disable telemetry reporting`. `# Disable
 telemetry` is #32493.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32700 [Applications/Tor Browser]: No need to disable GeckoDriver in Windows mozconfig files

[Tor Bug Tracker & Wiki]

#32700: No need to disable GeckoDriver in Windows mozconfig files
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201912R,   |  Actual Points:
  GeorgKoppen201912  |
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  new => needs_review
 * keywords:  TorBrowserTeam201912, GeorgKoppen201912 =>
 TorBrowserTeam201912R, GeorgKoppen201912


Comment:

 `bug_32700` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_32700=40502c9d0abb4e2c6b732162536fd2ea26bfe35b)
 has the patch for review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32700 [Applications/Tor Browser]: No need to disable GeckoDriver in Windows mozconfig files

[Tor Bug Tracker & Wiki]

#32700: No need to disable GeckoDriver in Windows mozconfig files
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  TorBrowserTeam201912,
 Severity:  Normal   |  GeorgKoppen201912
Actual Points:   |  Parent ID:
   Points:  0.1  |   Reviewer:
  Sponsor:   |
-+-
 We compile with `--disable-tests` on Windows which [https://searchfox.org
 /mozilla-esr68/source/toolkit/moz.configure#1006 automatically disables
 GeckoDriver]. Thus, we can clean up our mozconfig files a bit.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs