Re: [tor-bugs] #32830 [Core Tor]: Relay_extended - hash and padding - specs are wrong or unclear

[Tor Bug Tracker & Wiki]

#32830: Relay_extended - hash and padding - specs are wrong or unclear
--+
 Reporter:  Aymeric   |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  044-can   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * keywords:  043-can => 044-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32830 [Core Tor]: Relay_extended - hash and padding - specs are wrong or unclear

[Tor Bug Tracker & Wiki]

#32830: Relay_extended - hash and padding - specs are wrong or unclear
--+
 Reporter:  Aymeric   |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  043-can   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * keywords:  043-deferred => 043-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32830 [Core Tor]: Relay_extended - hash and padding - specs are wrong or unclear

[Tor Bug Tracker & Wiki]

#32830: Relay_extended - hash and padding - specs are wrong or unclear
--+
 Reporter:  Aymeric   |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  new => accepted
 * owner:  (none) => nickm
 * milestone:   => Tor: 0.4.3.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32830 [Core Tor]: Relay_extended - hash and padding - specs are wrong or unclear

[Tor Bug Tracker & Wiki]

#32830: Relay_extended - hash and padding - specs are wrong or unclear
--+
 Reporter:  Aymeric   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by Aymeric):

 Maybe it's me because rereading it I find it clear now but I
 misinterpreted "cell's entire payload" with "stream payload"

 So, maybe, it does not harm to add something like:

 "the 'digest' field is computed as the first four bytes of the running
 digest of all the bytes that have been destined for this hop of the
 circuit or originated from this hop of the circuit, seeded from Df or Db
 respectively (obtained in section 5.2 above), and including this RELAY
 cell's entire payload (including padding bytes and taken with the digest
 field set to zero)."

 Why is there this 4 zero bytes separator before padding bytes? (is it
 somewhere in the specs?)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32830 [Core Tor]: Relay_extended - hash and padding - specs are wrong or unclear

[Tor Bug Tracker & Wiki]

#32830: Relay_extended - hash and padding - specs are wrong or unclear
--+
 Reporter:  Aymeric   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 Do you have a suggested change to the specs? I'd like to take a patch to
 make this more clear.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #32830 [Core Tor]: Relay_extended - hash and padding - specs are wrong or unclear

[Tor Bug Tracker & Wiki]

#32830: Relay_extended - hash and padding - specs are wrong or unclear
--+
 Reporter:  Aymeric   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by Aymeric):

 You can close it, apparently it was more a problem on my side and the
 whole stream content must be processed (but still not clear in the specs
 where the payload is mentionned)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #32830 [Core Tor]: Relay_extended - hash and padding - specs are wrong or unclear

[Tor Bug Tracker & Wiki]

#32830: Relay_extended - hash and padding - specs are wrong or unclear
-+--
 Reporter:  Aymeric  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Component:  Core Tor
  Version:   |   Severity:  Normal
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
 I noticed recently plenty of 'unrecognized' relay_extended messages for
 node-Tor project while everything was working fine in the past after I
 updated the code and made it modular (and some abnormal delays to
 establish circuits), see also http://peersm.com/peersm2 this is temporary
 but I had to put a lot of debug stuff to find out what was going on

 Finally I figured out why: unlike what is writen in the main Tor specs the
 hash is calculated not only with the real payload of the relay_extended
 messages but includes also the padding (apparently starting with ,
 not sure where it comes from neither where it is specified)

 This looks quite strange, what is the rationale for this, is it a bug, why
 is it not documented and does it impact other types of messages?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs