Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  merge_ready
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
 |  Sponsor58-must
-+-
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 `541eb200e06c1c55ab3c8facdfd02a9ae70e` was reviewed as part of the
 review for #33973.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb, ahf  |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202005, GeorgKoppen202005
 => tbb-mobile, tbb-rbm, TorBrowserTeam202005R, GeorgKoppen202005
 * status:  needs_revision => needs_review
 * reviewer:  sysrqb => sysrqb, ahf


Comment:

 This should be in `needs_review`. The commit has not changed. The latest
 version is on `bug_33559_v2` (https://gitweb.torproject.org/user/gk/tor-
 browser-
 build.git/commit/?h=bug_33559_v2=541eb200e06c1c55ab3c8facdfd02a9ae70e)
 (among other branches)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005, GeorgKoppen202005|
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202005R, GeorgKoppen202005
 => tbb-mobile, tbb-rbm, TorBrowserTeam202005, GeorgKoppen202005
 * status:  needs_review => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by gx):

 https://bugzilla.mozilla.org/show_bug.cgi?id=1525999

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202005, GeorgKoppen202005
 => tbb-mobile, tbb-rbm, TorBrowserTeam202005R, GeorgKoppen202005
 * status:  needs_revision => needs_review


Comment:

 Okay, `fenix_toolchain3` (https://gitweb.torproject.org/user/gk/tor-
 browser-
 
build.git/commit/?h=fenix_toolchain3=4e6b194109ed0aef2b8d1b46c97a4b038aba8858)
 has a better fix I believe.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005, GeorgKoppen202005|
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202005R, GeorgKoppen202005
 => tbb-mobile, tbb-rbm, TorBrowserTeam202005, GeorgKoppen202005
 * status:  needs_review => needs_revision


Comment:

 One annoying part I just realize is that we have `$CROSS_PREFIX-ranlib`,
 `$CROSS_PREFIX-ar`, `$CROSS_PREFIX-ld` etc. for `aarch64`, `x86`, and
 `x86_64` which is why we can easily use `var/configure_host` for them,
 even for the clang part which has an `$API` included additionally.

 Now, this does unfortunately not hold for `armv7`. There we have `arm-
 linux-androideabi` as `CROSS_PREFIX` but `armv7a-linux-androideabi$ARCH-
 clang` being used for the compiler.

 Here is what we can do:

 1) Work around that for the armv7 case (as done e.g. in the
 [https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=fenix_toolchain=c2c988bec9242fece4287dafdcf90f63cdb3b7f1
 patch for #33833]
 2) We could define yet another variable in `rbm.conf` making sure we have
 `arm-linux-androideabi` and `armv7a-linux-androideabi` available.
 3) We could just symlink the `CROSS_PREFIX` for `armv7` (currently `arm-
 linux-androideabi`) to `armv7-linux-androideabi`

 I think I'll do 3) and use `cross_prefix` instead of `configure_host` as
 the former seems to be clearer than the latter.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, tbb-rbm, TorBrowserTeam202005, GeorgKoppen202005
 => tbb-mobile, tbb-rbm, TorBrowserTeam202005R, GeorgKoppen202005
 * status:  assigned => needs_review


Comment:

 I think this is ready for review on my branch `fenix_toolchain`
 (https://gitweb.torproject.org/user/gk/tor-browser-
 
build.git/commit/?h=fenix_toolchain=c843a4c9b993a9fb76d82effa8aae12d23b2c022)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  gk
 Type:  task | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005, GeorgKoppen202005|
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * cc: sysrqb, boklm (removed)
 * cc: tbb-team (added)
 * owner:  tbb-team => gk
 * status:  needs_revision => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, tbb-rbm, |  Actual Points:
  TorBrowserTeam202005, GeorgKoppen202005|
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * keywords:  tbb-mobile, Android, TorBrowserTeam202004 => tbb-mobile, tbb-
 rbm, TorBrowserTeam202005, GeorgKoppen202005


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, Android, |  Actual Points:
  TorBrowserTeam202004   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by gk):

 Replying to [comment:20 sysrqb]:
 > https://firefox-source-
 docs.mozilla.org/build/buildsystem/toolchains.html#firefox-for-android-
 with-gradle
 >
 > {{{
 > To build Firefox for Android with Gradle in automation, archives
 containing both
 > the Gradle executable and a Maven repository comprising the exact build
 > dependencies are produced and uploaded to an internal Mozilla server.
 The build
 > automation will download, verify, and extract these archive before
 building. These
 > archives provide a self-contained Gradle and Maven repository so that
 machines
 > don’t need to fetch additional Maven dependencies at build time.
 > }}}
 >
 > I wonder if (and how) we can re-use this. `./mach android gradle-
 dependencies` is the starting point.

 Yes, seems like an interesting approach. I've opened #34110 so we can
 consider it at some point.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, Android, |  Actual Points:
  TorBrowserTeam202004   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by cypherpunks):

 > The more I think the more do I feel we could and should do the same for
 the different Gradle versions used.
 Just file a follow-up ticket to
 https://bugzilla.mozilla.org/show_bug.cgi?id=1522795 about "
 Upgrade Android Gradle plugin to 3.6.*" (requires Gradle 5.6.4), and they
 will bump it for you.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, Android, |  Actual Points:
  TorBrowserTeam202004   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by gk):

 Replying to [comment:14 gk]:
 > Or maybe we can just ship both SDKs in our `android-toolchain` project
 and the respective code picks the one it needs somehow...

 The more I think the more do I feel we could and should do the same for
 the different Gradle versions used. The overhead is worth it if we can be
 sure to use the proper tools for each Mozilla projects to build, given
 that we are now a tiny team and weird bugs due to toolchain issues are
 hitting us even harder now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, Android, |  Actual Points:
  TorBrowserTeam202004   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by sysrqb):

 https://firefox-source-docs.mozilla.org/build/buildsystem/toolchains.html
 #firefox-for-android-with-gradle

 {{{
 To build Firefox for Android with Gradle in automation, archives
 containing both
 the Gradle executable and a Maven repository comprising the exact build
 dependencies are produced and uploaded to an internal Mozilla server. The
 build
 automation will download, verify, and extract these archive before
 building. These
 archives provide a self-contained Gradle and Maven repository so that
 machines
 don’t need to fetch additional Maven dependencies at build time.
 }}}

 I wonder if (and how) we can re-use this. `./mach android gradle-
 dependencies` is the starting point.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, Android, |  Actual Points:
  TorBrowserTeam202004   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by cypherpunks):

 platform-tools (android.sdk.configure): no need to use anything different
 from the latest 29.0.6
 sdk-tools: "SDK Tools package is deprecated and no longer receiving
 updates. Instead, please use the new command-line tools package."
 > Another hard requirement is ndk r20
  https://bugzilla.mozilla.org/show_bug.cgi?id=1266263#c6
 clang: 10+ anyways
 Everything will be enforced up to 29 by Google (August 1) ;)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, Android, |  Actual Points:
  TorBrowserTeam202004   |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  tbb-mobile, Android, TorBrowserTeam202004R => tbb-mobile,
 Android, TorBrowserTeam202004


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, Android, |  Actual Points:
  TorBrowserTeam202004R  |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by gk):

 Okay, I started to look over the requirements for the different projects
 we need to build here comes what I have so far and where to find the
 information:

 m-c requirements

 build-tools 29.0.3 (android-sdk.configure)
 platform-29 (android.sdk.configure) (compileSdkVersion, tragetSdkVersion)
 platform-tools(?)
 android ndk r20 (1577220 android.py)
 min android 16 (64bit 21) (android-ndk.configure)
 min sdk 16 (confvars.sh) (minSdkVersion)
 gradle 5.1.1 (gradle-wrapper.properties)
 rust 1.41.1 (mozboot/mozboot/base.py MODERN_RUST_VERSION)
 cbindgen 0.14.1 (moz.configure/bindgen.configure)
 nasm 2.14 (mozboot/mozboot/base.py MODERN_NASM_VERSION)
 clang 9.0.1
 node v10.19 (taskcluster/scripts/misc/repack-node.sh)

 Fenix requiremenets

 platform-28 (app/build.gradle;buildSrc/src/main/java/Config.kt)
 (compileSdkVersion, targetSdkVersion)
 min sdk 21 (buildSrc/src/main/java/Config.kt) (minSdkVersion)
 gradle 5.6.4 (gradle-wrapper.properties)

 android-components requirements

 platform-29 (buildSrc/src/main/java/Config.kt) (compileSdkVersion,
 targetSdkVersion = 28)
 min sdk 21 (buildSrc/src/main/java/Config.kt) (minSdkVersion)
 gradle 5.6.4 (gradle-wrapper.properties)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, Android, |  Actual Points:
  TorBrowserTeam202004R  |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by gk):

 Another hard requirement is ndk r20 for geckoview. So, let's stick to that
 one instead of r21 assuming other projects don't require r21? (In that
 case we could think about shipping both as well, and then pointing the NDK
 path to the one actually needed for a project).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, Android, |  Actual Points:
  TorBrowserTeam202004R  |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by cypherpunks):

 https://bugzilla.mozilla.org/show_bug.cgi?id=1627354

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, Android, |  Actual Points:
  TorBrowserTeam202004R  |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by gk):

 Or maybe we can just ship both SDKs in our `android-toolchain` project and
 the respective code picks the one it needs somehow...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, Android, |  Actual Points:
  TorBrowserTeam202004R  |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by gk):

 Replying to [comment:9 sisbell]:
 > Another issue I encountered is that android-components and fenix use
 different version of the Android SDK, Fenix is on 28 and android-
 components is on 29. I'll need to bring these into alignment (up to 29 for
 fenix)

 That does not seem so easy. Right now Fenix is broken with our toolchain.
 It breaks during compilation like:
 {{{
 > Task :app:compileGeckoBetaDebugKotlin
 e: /var/tmp/build/fenix-
 
943d3837b243/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkController.kt:
 (81, 9): Val cannot be reassigned
 e: /var/tmp/build/fenix-
 
943d3837b243/app/src/main/java/org/mozilla/fenix/library/history/HistoryController.kt:
 (76, 9): Val cannot be reassigned
 e: /var/tmp/build/fenix-
 943d3837b243/app/src/main/java/org/mozilla/fenix/utils/ClipboardHandler.kt:
 (32, 13): Val cannot be reassigned
 }}}
 That does not happen if I use our current toolchain. I can compile Fenix
 successfully with it.

 I wonder if we should try harder to match what Mozilla is currently using
 toolchain-wise. That is whether we should bite the bullet and use
 different ones for Fenix and android-components...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, Android, |  Actual Points:
  TorBrowserTeam202003R  |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
 |  Sponsor58-must
-+-

Comment (by sisbell):

 This update sets the correct path to the toolchain

 https://github.com/sisbell/tor-browser-build/commits/bug-33557a

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, Android, |  Actual Points:
  TorBrowserTeam202003R  |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
-+-

Comment (by sisbell):

 Another issue I encountered is that android-components and fenix use
 different version of the Android SDK, Fenix is on 28 and android-
 components is on 29. I'll need to bring these into alignment (up to 29 for
 fenix)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, Android, |  Actual Points:
  TorBrowserTeam202003R  |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
-+-

Comment (by sisbell):

 Replying to [comment:7 gk]:
 > Replying to [comment:2 sisbell]:
 > > I've updated to handle toolchain used by fenix (and android-
 components). The standalone toolchain script is no longer supported. The
 following link covers the changes we need to make. On the plus side, the
 tar file will be smaller.
 > >
 > > https://developer.android.com/ndk/guides/other_build_systems
 > >
 > > In the config, I made more param versions configurable, as I expect we
 will need to upgrade frequently as fenix is in rapid development. I also
 added gradle to the path which means we don't need to specify full-path in
 projects.
 > >
 > > The Commit:
 > >
 > > https://github.com/sisbell/tor-browser-build/commits/bug-33557
 >
 > I've not looked closely at how Fenix is built but isn't Mozilla using
 their own `clang` here? As we are doing for Fennec-based builds currently
 as well? If so, then we should bump the clang version to what Mozilla
 uses. And the Rust version, too. I don't see any child bugs for those in
 the list for the parent one and those two components are kind of toolchain
 components, so I figured you might want to deal with them in this ticket.
 :) But child bugs for #33184 would be fine, too, I think...

 From what I can tell working through the build, fenix project itself is
 not doing any rust or native builds.  This is handled by Mozillas
 application-services project and geckoview project

 In regards to application-services, these deal with cloud services which
 we don't want to support.

 https://github.com/mozilla/application-services

 This is project is built by Mozilla and is downloaded by fenix as an aar,
 which native libraries.

 https://maven.mozilla.org/maven2/org/mozilla/appservices/full-
 megazord/0.53.0/full-megazord-0.53.0.aar

 Looking through the components, they are largely related to sync and
 firefox accounts, which I don't believe we want to support. I'm in the
 process of creating patches to remove these projects. I want to see what
 breaks without the application-service components.

 The second part I see for native is is geckoview

 https://searchfox.org/mozilla-central/source/mobile/android

 This downloads as
 https://maven.mozilla.org/maven2/org/mozilla/geckoview/geckoview-
 beta/74.0.20200227210932/geckoview-beta-74.0.20200227210932.aar

 But yes, we do need an issue for this project (I'll open that). And this
 support will likely require some changes to the toolchain.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, Android, |  Actual Points:
  TorBrowserTeam202003R  |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:2 sisbell]:
 > I've updated to handle toolchain used by fenix (and android-components).
 The standalone toolchain script is no longer supported. The following link
 covers the changes we need to make. On the plus side, the tar file will be
 smaller.
 >
 > https://developer.android.com/ndk/guides/other_build_systems
 >
 > In the config, I made more param versions configurable, as I expect we
 will need to upgrade frequently as fenix is in rapid development. I also
 added gradle to the path which means we don't need to specify full-path in
 projects.
 >
 > The Commit:
 >
 > https://github.com/sisbell/tor-browser-build/commits/bug-33557

 I've not looked closely at how Fenix is built but isn't Mozilla using
 their own `clang` here? As we are doing for Fennec-based builds currently
 as well? If so, then we should bump the clang version to what Mozilla
 uses. And the Rust version, too. I don't see any child bugs for those in
 the list for the parent one and those two components are kind of toolchain
 components, so I figured you might want to deal with them in this ticket.
 :) But child bugs for #33184 would be fine, too, I think...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, Android, |  Actual Points:
  TorBrowserTeam202003R  |
Parent ID:  #33184   | Points:
 Reviewer:  sysrqb   |Sponsor:
-+-
Changes (by sysrqb):

 * reviewer:   => sysrqb


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
-+-
 Reporter:  sisbell  |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile, Android, |  Actual Points:
  TorBrowserTeam202003R  |
Parent ID:  #33184   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-mobile, Android => tbb-mobile, Android,
 TorBrowserTeam202003R
 * type:  defect => task


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
--+--
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, Android   |  Actual Points:
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:
--+--
Changes (by eighthave):

 * cc: eighthave (removed)


Comment:

 It should be possible to build the NDK from source without too much pain.
 Building Gradle and Android SDK without using mystery "prebuilt" binaries
 is very difficult.  The Debian packages are the only project I'm aware of
 that is doing this.

 FYI, F-Droid is running binary transparency logs for Gradle and Android
 SDK binaries, with an available static JSON URL:
 * https://gitlab.com/fdroid/gradle-transparency-log
 * https://gitlab.com/fdroid/android-sdk-transparency-log

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
--+--
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, Android   |  Actual Points:
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:
--+--

Comment (by sisbell):

 I've updated to handle toolchain used by fenix (and android-components).
 The standalone toolchain script is no longer supported. The following link
 covers the changes we need to make. On the plus side, the tar file will be
 smaller.

 https://developer.android.com/ndk/guides/other_build_systems

 In the config, I made more param versions configurable, as I expect we
 will need to upgrade frequently as fenix is in rapid development. I also
 added gradle to the path which means we don't need to specify full-path in
 projects.

 The Commit:

 https://github.com/sisbell/tor-browser-build/commits/bug-33557

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
--+--
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, Android   |  Actual Points:
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:
--+--
Changes (by sisbell):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
--+--
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-mobile, Android   |  Actual Points:
Parent ID:  #33184| Points:
 Reviewer:|Sponsor:
--+--

Comment (by sisbell):

 Require support for

  * API: Platform 29
  * NDK 21
  * Gradle 5.6.4
  * Build Tools and Platform Tools: 28.0.3

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #33557 [Applications/Tor Browser]: Update Android Toolchain for Fenix

[Tor Bug Tracker & Wiki]

#33557: Update Android Toolchain for Fenix
--+
 Reporter:  sisbell   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-mobile,
  |  Android
Actual Points:|  Parent ID:  #33184
   Points:|   Reviewer:
  Sponsor:|
--+
 Fenix uses an updated Android SDK and NDK.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs