Re: [tor-bugs] #34216 [Metrics/Onionperf]: Split visualizations into public server vs. v2 onion server vs. v3 onion server measurements

[Tor Bug Tracker & Wiki]

#34216: Split visualizations into public server vs. v2 onion server vs. v3 onion
server measurements
---+
 Reporter:  karsten|  Owner:  karsten
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:  0.5
Parent ID:  #33327 | Points:  0.3
 Reviewer:  acute  |Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * status:  merge_ready => closed
 * points:   => 0.3
 * resolution:   => fixed
 * actualpoints:   => 0.5


Comment:

 Thanks for the detailed review! Merged to master as
 
[https://gitweb.torproject.org/onionperf.git/commit/?id=dbd7b5040c97f12ca79e23a72a7172696de6f6e1
 commit dbd7b50].

 Adding my 0.5 actual points and the 0.3 points I had originally estimated
 and not written down here. Feel free to add your actual points for the
 review. Closing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34216 [Metrics/Onionperf]: Split visualizations into public server vs. v2 onion server vs. v3 onion server measurements

[Tor Bug Tracker & Wiki]

#34216: Split visualizations into public server vs. v2 onion server vs. v3 onion
server measurements
---+
 Reporter:  karsten|  Owner:  karsten
 Type:  defect | Status:  merge_ready
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #33327 | Points:
 Reviewer:  acute  |Sponsor:  Sponsor59-must
---+
Changes (by acute):

 * status:  needs_review => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34216 [Metrics/Onionperf]: Split visualizations into public server vs. v2 onion server vs. v3 onion server measurements

[Tor Bug Tracker & Wiki]

#34216: Split visualizations into public server vs. v2 onion server vs. v3 onion
server measurements
---+
 Reporter:  karsten|  Owner:  karsten
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #33327 | Points:
 Reviewer:  acute  |Sponsor:  Sponsor59-must
---+

Comment (by acute):

 The code reads well, and the graphs and csv files produced are as
 expected. Setting to ready_for_merge.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34216 [Metrics/Onionperf]: Split visualizations into public server vs. v2 onion server vs. v3 onion server measurements

[Tor Bug Tracker & Wiki]

#34216: Split visualizations into public server vs. v2 onion server vs. v3 onion
server measurements
---+
 Reporter:  karsten|  Owner:  karsten
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #33327 | Points:
 Reviewer:  acute  |Sponsor:  Sponsor59-must
---+

Comment (by karsten):

 Or maybe just review the rebased, squashed version which is in
 
[https://gitweb.torproject.org/user/karsten/onionperf.git/commit/?h=task-34216-2=96cf57f8862b5341d1e0724aecef2c294fe81f3b
 commit 96cf57f in my task-34216-2 branch].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34216 [Metrics/Onionperf]: Split visualizations into public server vs. v2 onion server vs. v3 onion server measurements

[Tor Bug Tracker & Wiki]

#34216: Split visualizations into public server vs. v2 onion server vs. v3 onion
server measurements
---+
 Reporter:  karsten|  Owner:  karsten
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #33327 | Points:
 Reviewer:  acute  |Sponsor:  Sponsor59-must
---+

Comment (by karsten):

 Please also review
 
[https://gitweb.torproject.org/user/karsten/onionperf.git/commit/?h=task-34216=8fccbea816bafad75981169fe1704391572ced8b
 fixup commit 8fccbea].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34216 [Metrics/Onionperf]: Split visualizations into public server vs. v2 onion server vs. v3 onion server measurements

[Tor Bug Tracker & Wiki]

#34216: Split visualizations into public server vs. v2 onion server vs. v3 onion
server measurements
---+
 Reporter:  karsten|  Owner:  karsten
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #33327 | Points:
 Reviewer:  acute  |Sponsor:  Sponsor59-must
---+

Comment (by karsten):

 Looks like we need to try harder to distinguish public and onion service
 measurements. The current branch above has a bug very similar to I just
 learned that the branch above has a bug very similar to
 [https://gitweb.torproject.org/metrics-
 web.git/commit/?id=82aa20a17cb8ff827873e6d0a776b9e2967197bb this one].
 I'll post a fixup commit later today or early tomorrow.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34216 [Metrics/Onionperf]: Split visualizations into public server vs. v2 onion server vs. v3 onion server measurements

[Tor Bug Tracker & Wiki]

#34216: Split visualizations into public server vs. v2 onion server vs. v3 onion
server measurements
---+
 Reporter:  karsten|  Owner:  karsten
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #33327 | Points:
 Reviewer:  acute  |Sponsor:  Sponsor59-must
---+
Changes (by acute):

 * reviewer:   => acute


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34216 [Metrics/Onionperf]: Split visualizations into public server vs. v2 onion server vs. v3 onion server measurements

[Tor Bug Tracker & Wiki]

#34216: Split visualizations into public server vs. v2 onion server vs. v3 onion
server measurements
---+
 Reporter:  karsten|  Owner:  karsten
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #33327 | Points:
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * status:  accepted => needs_review


Comment:

 Finally. Please review
 
[https://gitweb.torproject.org/user/karsten/onionperf.git/commit/?h=task-34216=0f183acabf893a4590f4acd45a9fe11827e0ca3b
 commit 0f183ac in my task-34216 branch].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #34216 [Metrics/Onionperf]: Split visualizations into public server vs. v2 onion server vs. v3 onion server measurements

[Tor Bug Tracker & Wiki]

#34216: Split visualizations into public server vs. v2 onion server vs. v3 onion
server measurements
---+
 Reporter:  karsten|  Owner:  karsten
 Type:  defect | Status:  accepted
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID:  #33327 | Points:
 Reviewer: |Sponsor:  Sponsor59-must
---+
Changes (by karsten):

 * owner:  metrics-team => karsten
 * status:  new => accepted


Comment:

 Working on this next.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #34216 [Metrics/Onionperf]: Split visualizations into public server vs. v2 onion server vs. v3 onion server measurements

[Tor Bug Tracker & Wiki]

#34216: Split visualizations into public server vs. v2 onion server vs. v3 onion
server measurements
---+--
 Reporter:  karsten|  Owner:  metrics-team
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Metrics/Onionperf  |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor:  Sponsor59-must |
---+--
 Right now, OnionPerf visualizations contain all measurements found in a
 data set. This can be very confusing, because this includes measurements
 performed via exits, via v2 onion service, and via v3 onion service. We
 should split visualizations, or we should provide a filter and only graph
 one subset of measurements at a time.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs