Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 |  implemented
 Keywords:  tor-bwauth, 035-triaged-in-20180711  |  Actual Points:
Parent ID:  #25925   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Okay; I've merged this to master.  Thanks for the clarification!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-bwauth, 035-triaged-in-20180711  |  Actual Points:
Parent ID:  #25925   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by teor):

 Replying to [comment:42 juga]:
 > Replying to [comment:40 nickm]:
 > > I mean, would we ever want to have a field that would be part of the
 bandwidth file, but _not_ copied into the vote?
 >
 > i can not find a reason for that right now. I guess if we need it at
 some point, we would need to change the spec and this code again.

 The current headers don't contain any sensitive information:
 https://gitweb.torproject.org/torspec.git/tree/bandwidth-file-
 spec.txt#n105

 Also, we want to make the entire bandwidth file public, see #21377 and:
 https://gitweb.torproject.org/torspec.git/tree/proposals/296-expose-
 bandwidth-files.txt

 But before we make the entire file public, we need to work out if the
 individual relay bandwidths make it easier to run attacks, see #26904.

 If you'd like, we could update the bandwidth file spec to say that the
 headers and the file content are public.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-bwauth, 035-triaged-in-20180711  |  Actual Points:
Parent ID:  #25925   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by juga):

 Replying to [comment:40 nickm]:
 > I mean, would we ever want to have a field that would be part of the
 bandwidth file, but _not_ copied into the vote?

 i can not find a reason for that right now. I guess if we need it at some
 point, we would need to change the spec and this code again.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-bwauth, 035-triaged-in-20180711  |  Actual Points:
Parent ID:  #25925   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by juga):

 * status:  needs_revision => merge_ready


Comment:

 Added changes file

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-bwauth, 035-triaged-in-20180711  |  Actual Points:
Parent ID:  #25925   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by nickm):

 Replying to [comment:39 juga]:
 > Replying to [comment:38 nickm]:
 > > Questions, not necessarily requring changes:
 > >
 > >  * Do we envision ever having a private field in the bwauth file?
 >
 > AFAIK, we have not talk about it. What do you mean by "private"?, that
 would be for?

 I mean, would we ever want to have a field that would be part of the
 bandwidth file, but _not_ copied into the vote?

 > >  * And is this "terminator" a change to the existing bandwidth file
 format?
 >
 > No, are you asking that because the name is different?, we changed the
 name cause we thought it was less confussing:
 https://github.com/torproject/tor/pull/194#discussion_r199334483

 Okay, that makes sense.

 > >  * Does anything use MAX_BW_FILE_HEADERS_LINE_LEN?
 >
 > It is used in: https://github.com/torproject/tor/pull/241/files#diff-
 c93ae3ef7d4ec1024de706403d5ab13eR282
 > We thought that we should check not only the length of the headers
 smartlist but also the length of the headers string.
 > Regarding the name, see discussion in
 https://github.com/torproject/tor/pull/194#discussion_r199345734
 >
 > > Necessary changes:
 > >
 > >  * This branch needs a changes file.
 >
 > ok, will add it

 Thanks! Please make this merge_ready again you do.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-bwauth, 035-triaged-in-20180711  |  Actual Points:
Parent ID:  #25925   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by juga):

 Replying to [comment:38 nickm]:
 > Questions, not necessarily requring changes:
 >
 >  * Do we envision ever having a private field in the bwauth file?

 AFAIK, we have not talk about it. What do you mean by "private"?, that
 would be for?

 >  * And is this "terminator" a change to the existing bandwidth file
 format?

 No, are you asking that because the name is different?, we changed the
 name cause we thought it was less confussing:
 https://github.com/torproject/tor/pull/194#discussion_r199334483

 >  * Does anything use MAX_BW_FILE_HEADERS_LINE_LEN?

 It is used in: https://github.com/torproject/tor/pull/241/files#diff-
 c93ae3ef7d4ec1024de706403d5ab13eR282
 We thought that we should check not only the length of the headers
 smartlist but also the length of the headers string.
 Regarding the name, see discussion in
 https://github.com/torproject/tor/pull/194#discussion_r199345734

 > Necessary changes:
 >
 >  * This branch needs a changes file.

 ok, will add it

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-bwauth, 035-triaged-in-20180711  |  Actual Points:
Parent ID:  #25925   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => needs_revision


Comment:

 Questions, not necessarily requring changes:

  * Do we envision ever having a private field in the bwauth file?
  * And is this "terminator" a change to the existing bandwidth file
 format?
  * Does anything use MAX_BW_FILE_HEADERS_LINE_LEN?

 Necessary changes:

  * This branch needs a changes file.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-bwauth, 035-triaged-in-20180711  |  Actual Points:
Parent ID:  #25925   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by teor):

 Appveyor CI was successful. Let's merge!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-bwauth, 035-triaged-in-20180711  |  Actual Points:
Parent ID:  #25925   | Points:
 Reviewer:  teor |Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => merge_ready


Comment:

 Linux CI passed on this branch.
 I opened ​https://github.com/torproject/tor/pull/241 so that Windows CI
 runs on this branch.
 You can set up Windows CI on your GitHub by going to
 https://ci.appveyor.com/

 After it's successful, let's merge the branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-bwauth, 035-triaged-in-20180711  |  Actual Points:
Parent ID:  #25925   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by juga):

 > It looks like the squashed and rebased code is in juga's
 ticket3723_03_squashed_rebased branch.

 It is, i didn't notify here because i wanted first to:

 > run it against a test bandwidth file, and check the vote contents

 i did it, example output:

 {{{
 bandwidth-file-headers timestamp=1531683804 version=1.1.0
 earliest_bandwidth=2018-07-13T12:49:16 file_created=2018-07-17T13:13:03
 generator_started=2018-07-14T15:14:35 latest_bandwidth=2018-07-15T19:43:24
 software=sbws software_version=0.6.1-dev
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-bwauth, 035-triaged-in-20180711  |  Actual Points:
Parent ID:  #25925   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by teor):

 It looks like the squashed and rebased code is in juga's
 ticket3723_03_squashed_rebased branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-bwauth, 035-triaged-in-20180711  |  Actual Points:
Parent ID:  #25925   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by teor):

 Replying to [comment:26 juga]:
 > Rebased to master and continuing on
 ​https://github.com/torproject/tor/pull/195.

 Hi Juga,

 Please see my branch ticket3723_03 on https://github.com/teor2345/tor.git

 I did some small fixups:
 * removed a redundant header,
 * added a missing cast on Windows, and
 * fixed some code that was in the wrong place.

 I also wrote a spec for parsing failures in #26799, and implemented it.

 Please review https://github.com/torproject/tor/pull/231

 If you're happy with the code, please:
 * run it against a test bandwidth file, and check the vote contents
 * squash all your fixups (and my fixups, if you want)
 * rebase to the latest master

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-bwauth, 035-triaged-in-20180711  |  Actual Points:
Parent ID:  #25925   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by teor):

 Replying to [comment:31 juga]:
 > Need to check, but i think that even after all the new tests, there was
 not any with non-NULL routerstatuses in #25947.

 Ok, I opened #26798 for these tests. They are a low priority. Please do
 all the 0.3.5 work first.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-bwauth, 035-triaged-in-20180711  |  Actual Points:
Parent ID:  #25925   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by juga):

 Need to check, but i think that even after all the new tests, there was
 not any with non-NULL routerstatuses in #25947.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
-+-
 Reporter:  mikeperry|  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-bwauth, 035-triaged-in-20180711  |  Actual Points:
Parent ID:  #25925   | Points:
 Reviewer:  teor |Sponsor:
-+-

Comment (by teor):

 Replying to [comment:22 teor]:
 > Are there any unit tests for reading measured bandwidths with non-NULL
 routerststuses?
 > If there aren't, please open a separate ticket, we should write some
 eventually.

 I think this ticket is #25947.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
--+
 Reporter:  mikeperry |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bwauth|  Actual Points:
Parent ID:  #25925| Points:
 Reviewer:  teor  |Sponsor:
--+

Comment (by juga):

 Sorry, there were new commits on master touching parts of that code and i
 thought that you prefered that workflow. Ok, no more rebases on master
 until is finished.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
--+
 Reporter:  mikeperry |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bwauth|  Actual Points:
Parent ID:  #25925| Points:
 Reviewer:  teor  |Sponsor:
--+

Comment (by teor):

 Replying to [comment:26 juga]:
 > Rebased to master and continuing on
 ​https://github.com/torproject/tor/pull/195.

 When I'm reviewing, I find rebases and new pull requests really confusing.
 I lose all my past GitHub comments, and I have to switch between the old
 and new pull requests. (Some people like new pull requests, I've just
 found out that I don't..)

 So can we leave any more rebases until the patch is complete?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
--+
 Reporter:  mikeperry |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bwauth|  Actual Points:
Parent ID:  #25925| Points:
 Reviewer:  teor  |Sponsor:
--+
Changes (by juga):

 * status:  needs_revision => needs_review


Comment:

 Rebased to master and continuing on
 ​https://github.com/torproject/tor/pull/195.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
--+
 Reporter:  mikeperry |  Owner:  (none)
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bwauth|  Actual Points:
Parent ID:  #25925| Points:
 Reviewer:  teor  |Sponsor:
--+

Comment (by teor):

 You'll need to click "see outdated" for the last few comments, because I
 made them on the commit, not the final code.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
--+
 Reporter:  mikeperry |  Owner:  (none)
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bwauth|  Actual Points:
Parent ID:  #25925| Points:
 Reviewer:  teor  |Sponsor:
--+
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Please see my comments on the patch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
--+
 Reporter:  mikeperry |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bwauth|  Actual Points:
Parent ID:  #25925| Points:
 Reviewer:  teor  |Sponsor:
--+
Changes (by juga):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:21 teor]:
 > Please see my comments on the GitHub pull request.

 Rebased to master and continuing on
 https://github.com/torproject/tor/pull/194. Also left comments there.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
--+
 Reporter:  mikeperry |  Owner:  (none)
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bwauth|  Actual Points:
Parent ID:  #25925| Points:
 Reviewer:  teor  |Sponsor:
--+

Comment (by teor):

 Are there any unit tests for reading measured bandwidths with non-NULL
 routerststuses?
 If there aren't, please open a separate ticket, we should write some
 eventually.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
--+
 Reporter:  mikeperry |  Owner:  (none)
 Type:  enhancement   | Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bwauth|  Actual Points:
Parent ID:  #25925| Points:
 Reviewer:  teor  |Sponsor:
--+
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Please see my comments on the GitHub pull request.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
--+
 Reporter:  mikeperry |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bwauth|  Actual Points:
Parent ID:  #25925| Points:
 Reviewer:  teor  |Sponsor:
--+

Comment (by teor):

 The GitHub pull request is:
 https://github.com/torproject/tor/pull/126

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
--+
 Reporter:  mikeperry |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bwauth|  Actual Points:
Parent ID:  #25925| Points:
 Reviewer:  teor  |Sponsor:
--+

Comment (by teor):

 I won't have time to review this ticket until next week, I'm still
 catching up.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
--+
 Reporter:  mikeperry |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-bwauth|  Actual Points:
Parent ID:  #25925| Points:
 Reviewer:|Sponsor:
--+
Changes (by juga):

 * keywords:  tor-dirauth => tor-bwauth


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
--+
 Reporter:  mikeperry |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-dirauth   |  Actual Points:
Parent ID:  #25925| Points:
 Reviewer:|Sponsor:
--+

Comment (by juga):

 Replying to [comment:14 juga]:
 > This code break other tests, hints?.
 solved.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
--+
 Reporter:  mikeperry |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-dirauth   |  Actual Points:
Parent ID:  #25925| Points:
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
--+
 Reporter:  mikeperry |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-dirauth   |  Actual Points:
Parent ID:  #25925| Points:
 Reviewer:|Sponsor:
--+
Changes (by juga):

 * keywords:   => tor-dirauth


Comment:

 Since it is not being backported i based it on master, now in my branch
 `ticket3723`

 After looking more to `dirvote.c` i thought it was better to use
 `smartlist_t` instead of string, and get it converted to string in
 `format_networkstatus_vote`.

 Since `dirserv_read_measured_bandwidths` is call from
 `dirserv_generate_networkstatus_vote_obj`, i don't need a different
 function to obtain the headers.

 Since i didn't found specific tests for
 `dirserv_generate_networkstatus_vote_obj` and `format_networkstatus_vote`,
 i'm not sure how to add tests for the vote document.

 This code break other tests, hints?.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
--+
 Reporter:  mikeperry |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #25925| Points:
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * milestone:  Tor: unspecified => Tor: 0.3.5.x-final


Comment:

 Replying to [comment:12 juga]:
 > To which Tor version should we backport this?, 0.3.2 too since it's the
 ealier version dirauths are running?

 New features do not get backported, they get merged to master.

 Since there is an 0.3.4 alpha release, it is closed to new features.
 So the earliest release this feature will be in is 0.3.5.

 > Would be the place to put the one i'm using in this commit?:
 https://github.com/juga0/tor/commit/dd19df3a042e9b9bbf29fdb73d717a78f7dc5e57
 #diff-141d60fb101694336aa8683a8e2a1541R241

 That is almost the right place.
 Please add the new "bandwidth-file" line to the end of the authority
 header, after the shared random information.
 We add new lines to the end of the section, to avoid merge conflicts.

 > In which structure should the timestamp (and version) be stored so that
 dirvote.c can read it?.

 Please add every header key_value to the bandwidth-file line, not just
 timestamp and version.
 This means that new header lines are automatically added to the vote.

 You can add these key_values to a space-separated string.

 I suggest that you modify dirserv_read_measured_bandwidths() to store the
 headers in a string, add a function that gets that string, and include the
 string in the vote.

 1. Set the bandwidth-file string to NULL at the start of the function,
 freeing it if was not NULL:
 
https://github.com/torproject/tor/blob/1eede00a4bd9a7de2acf77393f2fc57aa3196d08/src/or/dirserv.c#L2584

 2. Once you know the time is a number, read the rest of the header lines,
 and add them to the bandwidth-file string:
 
https://github.com/torproject/tor/blob/1eede00a4bd9a7de2acf77393f2fc57aa3196d08/src/or/dirserv.c#L2615

 3. When voting, add a bandwidth-file line if the bandwidth-file string is
 not NULL:
 https://github.com/juga0/tor/commit/dd19df3a042e9b9bbf29fdb73d717a78f7dc5e57
 #diff-141d60fb101694336aa8683a8e2a1541R210

 You will also need to change the dir-spec. I will open a child ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
--+--
 Reporter:  mikeperry |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #25925| Points:
 Reviewer:|Sponsor:
--+--

Comment (by juga):

 To which Tor version should we backport this?, 0.3.2 too since it's the
 ealier version dirauths are running?

 Would be the place to put the one i'm using in this commit?:
 https://github.com/juga0/tor/commit/dd19df3a042e9b9bbf29fdb73d717a78f7dc5e57
 #diff-141d60fb101694336aa8683a8e2a1541R241

 In which structure should the timestamp (and version) be stored so that
 dirvote.c can read it?.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
--+--
 Reporter:  mikeperry |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #25925| Points:
 Reviewer:|Sponsor:
--+--
Changes (by juga):

 * parent:  25925 => #25925


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
--+--
 Reporter:  mikeperry |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #13630| Points:
 Reviewer:|Sponsor:
--+--

Comment (by teor):

 This is about the format of the *vote* line, not the format of the
 v3bwfile header, which is multiple lines.

 Replying to [comment:8 teor]:
 > Hi juga, this is the ticket for putting the bandwidth authority version
 in votes.
 >
 > We are working on the file format in #25869 and
 https://github.com/torproject/torspec/pull/4
 >
 > I think we should:
 > 1. add a "timestamp=" to the timestamp
 > 2. turn the entire bwfile header into a single line
 > 3. put it all in the vote as a line with a new keyword, "bandwidth-file"
 >
 > For bandwidth file format 1.0.0, the line would be:
 > bandwidth-file timestamp=1234567890
 >
 > For bandwidth file format 1.1.0, the line would be:
 > bandwidth-file timestamp=1234567890 version=1.1.0 software=sbws
 software_version=0.1.0
 >
 > If we implement the feature in this way, then Tor will automatically add
 new fields to the bandwidth-file line.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #3723 [Core Tor/Tor]: Report version of bwscanners in votes

[Tor Bug Tracker & Wiki]

#3723: Report version of bwscanners in votes
--+--
 Reporter:  mikeperry |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #13630| Points:
 Reviewer:|Sponsor:
--+--
Changes (by teor):

 * cc: juga (added)
 * component:  Core Tor/Torflow => Core Tor/Tor
 * milestone:   => Tor: unspecified


Comment:

 Hi juga, this is the ticket for putting the bandwidth authority version in
 votes.

 We are working on the file format in #25869 and
 https://github.com/torproject/torspec/pull/4

 I think we should:
 1. add a "timestamp=" to the timestamp
 2. turn the entire bwfile header into a single line
 3. put it all in the vote as a line with a new keyword, "bandwidth-file"

 For bandwidth file format 1.0.0, the line would be:
 bandwidth-file timestamp=1234567890

 For bandwidth file format 1.1.0, the line would be:
 bandwidth-file timestamp=1234567890 version=1.1.0 software=sbws
 software_version=0.1.0

 If we implement the feature in this way, then Tor will automatically add
 new fields to the bandwidth-file line.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs