Re: [tor-bugs] #4187 [Core Tor/Tor]: A verified unverified-consensus should be renamed to cached-consensus

[Tor Bug Tracker & Wiki]

#4187: A verified unverified-consensus should be renamed to cached-consensus
-+-
 Reporter:  anonym   |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.33
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tor-client, directory, rename, fs,   |  Actual Points:
  easy, 032-unreached|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merging in master!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #4187 [Core Tor/Tor]: A verified unverified-consensus should be renamed to cached-consensus

[Tor Bug Tracker & Wiki]

#4187: A verified unverified-consensus should be renamed to cached-consensus
-+-
 Reporter:  anonym   |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  High |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.33
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, directory, rename, fs,   |  Actual Points:
  easy, 032-unreached|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => merge_ready


Comment:

 This patch looks good to me!  Let's take it once the 0.3.4.x merge window
 is open.

 I think there could still be remaining cases where the file doesn't get
 renamed, but this one at least should get fixed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #4187 [Core Tor/Tor]: A verified unverified-consensus should be renamed to cached-consensus

[Tor Bug Tracker & Wiki]

#4187: A verified unverified-consensus should be renamed to cached-consensus
-+-
 Reporter:  anonym   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.33
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, directory, rename, fs,   |  Actual Points:
  easy, 032-unreached|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  new => needs_review
 * milestone:  Tor: unspecified => Tor: 0.3.4.x-final


Comment:

 Thanks!  We'll have a look soon!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #4187 [Core Tor/Tor]: A verified unverified-consensus should be renamed to cached-consensus

[Tor Bug Tracker & Wiki]

#4187: A verified unverified-consensus should be renamed to cached-consensus
-+-
 Reporter:  anonym   |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.33
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, directory, rename, fs,   |  Actual Points:
  easy, 032-unreached|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by fristonio):

 Thanks for this nickm, it was a great help to reproduce the issue with
 your suggestion. Here is my patch for the ticket.

 https://github.com/fristonio/tor/tree/ticket4187

 Please comment if any other changes are required.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #4187 [Core Tor/Tor]: A verified unverified-consensus should be renamed to cached-consensus

[Tor Bug Tracker & Wiki]

#4187: A verified unverified-consensus should be renamed to cached-consensus
-+-
 Reporter:  anonym   |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.33
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, directory, rename, fs,   |  Actual Points:
  easy, 032-unreached|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 Here's an easier way to see the bug:

 1. Start tor, and let it bootstrap.
 2. Stop tor.
 3. In the DataDirectory, rename `cached-microdesc-consensus` to
 `unverified-microdesc-consensus`.
 4. Start tor again.

 Although Tor will use the unverified-microdesc-consensus file, it will not
 rename it to the proper name once it is verified.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #4187 [Core Tor/Tor]: A verified unverified-consensus should be renamed to cached-consensus

[Tor Bug Tracker & Wiki]

#4187: A verified unverified-consensus should be renamed to cached-consensus
-+-
 Reporter:  anonym   |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.33
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, directory, rename, fs,   |  Actual Points:
  easy, 032-unreached|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by fristonio):

 OK Got it,

 Working on the issue, will update here as soon as I fix it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #4187 [Core Tor/Tor]: A verified unverified-consensus should be renamed to cached-consensus

[Tor Bug Tracker & Wiki]

#4187: A verified unverified-consensus should be renamed to cached-consensus
-+-
 Reporter:  anonym   |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.33
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, directory, rename, fs,   |  Actual Points:
  easy, 032-unreached|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 It's not assigned to anyone. And even if it is, it's always ok to ask if
 you can help out.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #4187 [Core Tor/Tor]: A verified unverified-consensus should be renamed to cached-consensus

[Tor Bug Tracker & Wiki]

#4187: A verified unverified-consensus should be renamed to cached-consensus
-+-
 Reporter:  anonym   |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.33
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, directory, rename, fs,   |  Actual Points:
  easy, 032-unreached|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by fristonio):

 Hey, if no one is assigned to this issue I would really love to work to
 resolve this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #4187 [Core Tor/Tor]: A verified unverified-consensus should be renamed to cached-consensus

[Tor Bug Tracker & Wiki]

#4187: A verified unverified-consensus should be renamed to cached-consensus
-+-
 Reporter:  anonym   |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.33
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, directory, rename, fs,   |  Actual Points:
  easy, 032-unreached|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by teor):

 This ticket is about changing the file name on disk.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #4187 [Core Tor/Tor]: A verified unverified-consensus should be renamed to cached-consensus

[Tor Bug Tracker & Wiki]

#4187: A verified unverified-consensus should be renamed to cached-consensus
-+-
 Reporter:  anonym   |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.33
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, directory, rename, fs,   |  Actual Points:
  easy, 032-unreached|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by aruna1234):

 The code in networkstatus.c regarding
 networkstatus_set_current_consensus(), has an assignment, where it assigns
 a char buff whether it is 'cached consensus' or 'unverified consensus'.
 When Tor is suddenly started and it can verify the unverified consensus,
 maybe we can have a check placed checking whether 'buff' is unverified, if
 it is then we could change it to 'verified consensus'. Is the approach
 feasible?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #4187 [Core Tor/Tor]: A verified unverified-consensus should be renamed to cached-consensus

[Tor Bug Tracker & Wiki]

#4187: A verified unverified-consensus should be renamed to cached-consensus
-+-
 Reporter:  anonym   |  Owner:
 Type:  defect   | Status:
 |  assigned
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.33
 Severity:  Normal   | Resolution:
 Keywords:  tor-client directory rename fs easy  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * priority:  Low => High
 * milestone:  Tor: unspecified => Tor: 0.3.2.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #4187 [Core Tor/Tor]: A verified unverified-consensus should be renamed to cached-consensus

[Tor Bug Tracker & Wiki]

#4187: A verified unverified-consensus should be renamed to cached-consensus
-+-
 Reporter:  anonym   |  Owner:
 Type:  defect   | Status:
 |  assigned
 Priority:  Low  |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.33
 Severity:  Normal   | Resolution:
 Keywords:  tor-client directory rename fs easy  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by arma):

 In retrospect, this bug bit me in #22400, in that it confused me about
 what Tor was doing.

 Also, I wonder if the bug is a bit more than a minor annoyance in that it
 puts a timestamp on disk about a time in the past that I tried to use Tor
 and it didn't bootstrap. Still not a terrible bug, but it introduces a
 minor violation of Tor Browser's disk avoidance policy.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #4187 [Core Tor/Tor]: A verified unverified-consensus should be renamed to cached-consensus

[Tor Bug Tracker & Wiki]

#4187: A verified unverified-consensus should be renamed to cached-consensus
-+-
 Reporter:  anonym   |  Owner:
 Type:  defect   | Status:
 |  assigned
 Priority:  Low  |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.33
 Severity:  Normal   | Resolution:
 Keywords:  tor-client directory rename fs easy  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by Farigon):

 * status:  new => assigned
 * owner:  Farigon =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #4187 [Core Tor/Tor]: A verified unverified-consensus should be renamed to cached-consensus

[Tor Bug Tracker & Wiki]

#4187: A verified unverified-consensus should be renamed to cached-consensus
-+-
 Reporter:  anonym   |  Owner:  Farigon
 Type:  defect   | Status:  new
 Priority:  Low  |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.33
 Severity:  Normal   | Resolution:
 Keywords:  tor-client directory rename fs easy  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by Farigon):

 * status:  assigned => new


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #4187 [Core Tor/Tor]: A verified unverified-consensus should be renamed to cached-consensus

[Tor Bug Tracker & Wiki]

#4187: A verified unverified-consensus should be renamed to cached-consensus
-+-
 Reporter:  anonym   |  Owner:  Farigon
 Type:  defect   | Status:
 |  assigned
 Priority:  Low  |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.33
 Severity:  Normal   | Resolution:
 Keywords:  tor-client directory rename fs easy  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by Farigon):

 * status:  new => assigned
 * owner:   => Farigon


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #4187 [Core Tor/Tor]: A verified unverified-consensus should be renamed to cached-consensus

[Tor Bug Tracker & Wiki]

#4187: A verified unverified-consensus should be renamed to cached-consensus
-+-
 Reporter:  anonym   |  Owner:
 Type:  defect   | Status:  new
 Priority:  Low  |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.33
 Severity:  Normal   | Resolution:
 Keywords:  tor-client directory rename fs easy  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  tor-client => tor-client directory rename fs easy
 * points:   => 1
 * severity:   => Normal


Comment:

 This is a minor annoyance, but not too hard to fix if anybody wants to
 make the attempt.

 The way to do it is probably somewhere inside
 networkstatus_set_current_consensus() or one of its callers.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs