Re: [tor-bugs] #31354 [Core Tor/Tor]: Compiler "note" in test_addr.c: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’

[Tor Bug Tracker & Wiki]

#31354: Compiler "note" in test_addr.c: variable tracking size limit exceeded 
with
‘-fvar-tracking-assignments’
---+---
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  regression, 042-should, asn-merge  |  Actual Points:
Parent ID: | Points:
 Reviewer:  catalyst   |Sponsor:
---+---
Changes (by asn):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31354 [Core Tor/Tor]: Compiler "note" in test_addr.c: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’

[Tor Bug Tracker & Wiki]

#31354: Compiler "note" in test_addr.c: variable tracking size limit exceeded 
with
‘-fvar-tracking-assignments’
---+---
 Reporter:  nickm  |  Owner:  nickm
 Type:  defect | Status:
   |  merge_ready
 Priority:  Medium |  Milestone:  Tor:
   |  0.4.2.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  regression, 042-should, asn-merge  |  Actual Points:
Parent ID: | Points:
 Reviewer:  catalyst   |Sponsor:
---+---
Changes (by nickm):

 * keywords:  regression, 042-should => regression, 042-should, asn-merge


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31354 [Core Tor/Tor]: Compiler "note" in test_addr.c: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’

[Tor Bug Tracker & Wiki]

#31354: Compiler "note" in test_addr.c: variable tracking size limit exceeded 
with
‘-fvar-tracking-assignments’
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  regression|  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+
Changes (by catalyst):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:9 nickm]:
 > wow! Sorry about that-- I honestly don't know what I was working on when
 I left that in.
 >
 > I've added a fixup commit to the branch.
 Looks good. Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31354 [Core Tor/Tor]: Compiler "note" in test_addr.c: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’

[Tor Bug Tracker & Wiki]

#31354: Compiler "note" in test_addr.c: variable tracking size limit exceeded 
with
‘-fvar-tracking-assignments’
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  regression|  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 wow! Sorry about that-- I honestly don't know what I was working on when I
 left that in.

 I've added a fixup commit to the branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31354 [Core Tor/Tor]: Compiler "note" in test_addr.c: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’

[Tor Bug Tracker & Wiki]

#31354: Compiler "note" in test_addr.c: variable tracking size limit exceeded 
with
‘-fvar-tracking-assignments’
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  regression|  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:5 nickm]:
 > I think this is ready for a review.  It's not the long-term solution,
 but it may help.
 Thanks! Mostly looks good. I left a comment on the pull request about an
 extraneous addition.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31354 [Core Tor/Tor]: Compiler "note" in test_addr.c: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’

[Tor Bug Tracker & Wiki]

#31354: Compiler "note" in test_addr.c: variable tracking size limit exceeded 
with
‘-fvar-tracking-assignments’
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  regression|  Actual Points:
Parent ID:| Points:
 Reviewer:  catalyst  |Sponsor:
--+
Changes (by dgoulet):

 * reviewer:  #31354 => catalyst


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31354 [Core Tor/Tor]: Compiler "note" in test_addr.c: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’

[Tor Bug Tracker & Wiki]

#31354: Compiler "note" in test_addr.c: variable tracking size limit exceeded 
with
‘-fvar-tracking-assignments’
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  regression|  Actual Points:
Parent ID:| Points:
 Reviewer:  #31354|Sponsor:
--+
Changes (by dgoulet):

 * reviewer:   => #31354


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31354 [Core Tor/Tor]: Compiler "note" in test_addr.c: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’

[Tor Bug Tracker & Wiki]

#31354: Compiler "note" in test_addr.c: variable tracking size limit exceeded 
with
‘-fvar-tracking-assignments’
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  regression|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  accepted => needs_review


Comment:

 I think this is ready for a review.  It's not the long-term solution, but
 it may help.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31354 [Core Tor/Tor]: Compiler "note" in test_addr.c: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’

[Tor Bug Tracker & Wiki]

#31354: Compiler "note" in test_addr.c: variable tracking size limit exceeded 
with
‘-fvar-tracking-assignments’
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  regression|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 Hm. My basic fix here will not solve #30968, but it might still be useful
 under the theory that we shouldn't acclimate people to ignoring warnings,
 even if the compiler calls those warnings "notes".

 Branch is ticket31354, which adopts a brute-force solution to solving the
 problem (reducing variables and splitting test functions).  I didn't do a
 changes file here, since AFAICT 0.4.1.x doesn't have this problem.

 https://github.com/torproject/tor/pull/1299 is the PR.  I'll put this in
 needs_review once it passes CI.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31354 [Core Tor/Tor]: Compiler "note" in test_addr.c: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’

[Tor Bug Tracker & Wiki]

#31354: Compiler "note" in test_addr.c: variable tracking size limit exceeded 
with
‘-fvar-tracking-assignments’
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  regression|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by catalyst):

 #30968 is related

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31354 [Core Tor/Tor]: Compiler "note" in test_addr.c: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’

[Tor Bug Tracker & Wiki]

#31354: Compiler "note" in test_addr.c: variable tracking size limit exceeded 
with
‘-fvar-tracking-assignments’
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  regression|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * owner:  (none) => nickm
 * status:  new => accepted


Comment:

 This has been bugging me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31354 [Core Tor/Tor]: Compiler "note" in test_addr.c: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’

[Tor Bug Tracker & Wiki]

#31354: Compiler "note" in test_addr.c: variable tracking size limit exceeded 
with
‘-fvar-tracking-assignments’
--+
 Reporter:  nickm |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 Building with GCC 9.1.1, I see these:

 {{{
 src/test/test_addr.c: In function ‘test_addr_parse’:
 src/test/test_addr.c:1167:1: note: variable tracking size limit exceeded
 with ‘-fvar-tracking-assignments’, retrying without
  1167 | test_addr_parse(void *arg)
   | ^~~
 }}}

 This seems to be new in 0.4.2.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs