Re: [tor-bugs] #20148 [Core Tor/Tor]: Add AES256 support to crypto_cipher_t

[Tor Bug Tracker & Wiki]

#20148: Add AES256 support to crypto_cipher_t
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  implemented
 Keywords:  crypto|  Actual Points:  0.2
Parent ID:| Points:  0.2
 Reviewer:  dgoulet   |Sponsor:  SponsorR-can
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 okay. merging and hoping for the best

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20148 [Core Tor/Tor]: Add AES256 support to crypto_cipher_t

[Tor Bug Tracker & Wiki]

#20148: Add AES256 support to crypto_cipher_t
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  crypto|  Actual Points:  0.2
Parent ID:| Points:  0.2
 Reviewer:  dgoulet   |Sponsor:  SponsorR-can
--+
Changes (by dgoulet):

 * status:  needs_review => merge_ready
 * reviewer:   => dgoulet
 * points:  .2 => 0.2
 * actualpoints:  .2 => 0.2


Comment:

 I guess yes, some sort of ticket to "unify" our aes API.

 lgtm;

 actual-review-point: 0.2

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20148 [Core Tor/Tor]: Add AES256 support to crypto_cipher_t

[Tor Bug Tracker & Wiki]

#20148: Add AES256 support to crypto_cipher_t
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  crypto|  Actual Points:  .2
Parent ID:| Points:  .2
 Reviewer:|Sponsor:  SponsorR-can
--+
Changes (by nickm):

 * status:  needs_information => needs_review


Comment:

 Hm. I think that merging the old and new APIs together should probably be
 another ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20148 [Core Tor/Tor]: Add AES256 support to crypto_cipher_t

[Tor Bug Tracker & Wiki]

#20148: Add AES256 support to crypto_cipher_t
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_information
 Priority:  Medium|  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  crypto|  Actual Points:  .2
Parent ID:| Points:  .2
 Reviewer:|Sponsor:  SponsorR-can
--+
Changes (by dgoulet):

 * keywords:   => crypto
 * status:  needs_review => needs_information


Comment:

 Global observation. If the goal is to keep this change as minimal as
 possible, I guess the current code is fine.

 However, I see that we have `crypto_cipher_new()` that only does 128 bits.
 Then we have `crypto_cipher_new_with_iv()` that also only does 128 bits
 and then this new one `crypto_cipher_new_with_bits()` (and the with_iv)
 that we can control the bits.

 Wouldn't be simpler to have all `crypto_cipher_new*` to take a bit size?
 Would make the entire API more symmetric. I see very few callsites of
 those, actually 6 outside of crypto.c.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20148 [Core Tor/Tor]: Add AES256 support to crypto_cipher_t

[Tor Bug Tracker & Wiki]

#20148: Add AES256 support to crypto_cipher_t
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .2
Parent ID:| Points:  .2
 Reviewer:|Sponsor:  SponsorR-can
--+
Changes (by nickm):

 * sponsor:   => SponsorR-can


Comment:

 See branch `aes256` in my public repository. It adds aes256-ctr support,
 and cleans up the surrounding code a bit.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20148 [Core Tor/Tor]: Add AES256 support to crypto_cipher_t

[Tor Bug Tracker & Wiki]

#20148: Add AES256 support to crypto_cipher_t
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .2
Parent ID:| Points:  .2
 Reviewer:|Sponsor:  SponsorR-can
--+
Changes (by nickm):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #20148 [Core Tor/Tor]: Add AES256 support to crypto_cipher_t

[Tor Bug Tracker & Wiki]

#20148: Add AES256 support to crypto_cipher_t
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:  .2|  Parent ID:
   Points:  .2|   Reviewer:
  Sponsor:|
--+
 Proposal 224 specifies the use of AES256 for encrypting hidden service
 descriptors.  We need an aes256 backend.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs