Re: [tor-bugs] #20201 [Core Tor/Tor]: Update docstring for parse_bridge_line() in src/or/config.c

[Tor Bug Tracker & Wiki]

#20201: Update docstring for parse_bridge_line() in src/or/config.c
--+
 Reporter:  isis  |  Owner:
 Type:  defect| Status:  closed
 Priority:  Very Low  |  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Trivial   | Resolution:  fixed
 Keywords:  doc   |  Actual Points:  1
Parent ID:| Points:  1
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 merged; thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20201 [Core Tor/Tor]: Update docstring for parse_bridge_line() in src/or/config.c

[Tor Bug Tracker & Wiki]

#20201: Update docstring for parse_bridge_line() in src/or/config.c
--+
 Reporter:  isis  |  Owner:
 Type:  defect| Status:  needs_review
 Priority:  Very Low  |  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Trivial   | Resolution:
 Keywords:  doc   |  Actual Points:  1
Parent ID:| Points:  1
 Reviewer:|Sponsor:
--+
Changes (by isis):

 * status:  new => needs_review
 * milestone:   => Tor: 0.2.9.x-final


Comment:

 A shiny new description of the actual behaviour is in my `bug20201`
 [https://gitweb.torproject.org/user/isis/tor.git/log/?h=bug20201 branch].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #20201 [Core Tor/Tor]: Update docstring for parse_bridge_line() in src/or/config.c

[Tor Bug Tracker & Wiki]

#20201: Update docstring for parse_bridge_line() in src/or/config.c
--+-
 Reporter:  isis  |  Owner:
 Type:  defect| Status:  new
 Priority:  Very Low  |  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Trivial   |   Keywords:  doc
Actual Points:  1 |  Parent ID:
   Points:  1 |   Reviewer:
  Sponsor:|
--+-
 It's pretty out-of-date.

 {{{
  /** Read the contents of a Bridge line from line. Return 0
   * if the line is well-formed, and -1 if it isn't. If
   * validate_only is 0, and the line is well-formed, then add
   * the bridge described in the line to our internal bridge list.
   *
   * Bridge line format:
   * Bridge [transport] IP:PORT [id-fingerprint] [k=v] [k=v] ...
   */
  /* private */ bridge_line_t *
  parse_bridge_line(const char *line)
 }}}

 The return types are totally different that specified, and the function
 does not add a well-formed bridge line to the internal bridge list as
 stated.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs