Re: [tor-bugs] #20375 [Applications/Tor Browser]: warn users when entering fullscreen

[Tor Bug Tracker & Wiki]

#20375: warn users when entering fullscreen
-+-
 Reporter:  fem  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-usability, tbb-fingerprinting,   |  Actual Points:
  tbb-torbutton, TorBrowserTeam201708R, tbb- |
  backported |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by cypherpunks):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:13 Dbryrtfbcbhgf]:
 > Rhe warning popup is Immediately dismissed when I lick on a link and a
 new page loads.
 :-))) Don't lick the links :-)))
 > example,
 > open tor browser and then right as it pops up click on "Test tor network
 settings" and then maximize tor, the page takes around 5 seconds to load
 so the full screen warning pops up and then is Immediately dismissed when
 the page loads.
 It warned you, but you loaded a new page.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20375 [Applications/Tor Browser]: warn users when entering fullscreen

[Tor Bug Tracker & Wiki]

#20375: warn users when entering fullscreen
-+-
 Reporter:  fem  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  reopened
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-fingerprinting,   |  Actual Points:
  tbb-torbutton, TorBrowserTeam201708R, tbb- |
  backported |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by Dbryrtfbcbhgf):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Rhe warning popup is Immediately dismissed when I lick on a link and a new
 page loads.
 example,
 open tor browser and then right as it pops up click on "Test tor network
 settings" and then maximize tor, the page takes around 5 seconds to load
 so the full screen warning pops up and then is Immediately dismissed when
 the page loads.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20375 [Applications/Tor Browser]: warn users when entering fullscreen

[Tor Bug Tracker & Wiki]

#20375: warn users when entering fullscreen
-+-
 Reporter:  fem  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-usability, tbb-fingerprinting,   |  Actual Points:
  tbb-torbutton, TorBrowserTeam201708R, tbb- |
  backported |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:
 tbb-usability, tbb-fingerprinting, tbb-torbutton,
 TorBrowserTeam201708R, tbb-backport
 =>
 tbb-usability, tbb-fingerprinting, tbb-torbutton,
 TorBrowserTeam201708R, tbb-backported


Comment:

 Picking this up for 1.9.7.7 (commit
 d68d2b68366af9456adf8c152e127ec5c10344c5).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20375 [Applications/Tor Browser]: warn users when entering fullscreen

[Tor Bug Tracker & Wiki]

#20375: warn users when entering fullscreen
-+-
 Reporter:  fem  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-usability, tbb-fingerprinting,   |  Actual Points:
  tbb-torbutton, TorBrowserTeam201708R, tbb- |
  backport   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:
 tbb-usability, tbb-fingerprinting, tbb-torbutton,
 TorBrowserTeam201708R
 =>
 tbb-usability, tbb-fingerprinting, tbb-torbutton,
 TorBrowserTeam201708R, tbb-backport


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20375 [Applications/Tor Browser]: warn users when entering fullscreen

[Tor Bug Tracker & Wiki]

#20375: warn users when entering fullscreen
-+-
 Reporter:  fem  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-usability, tbb-fingerprinting,   |  Actual Points:
  tbb-torbutton, TorBrowserTeam201708R   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 How about fake windowed fullscreen?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20375 [Applications/Tor Browser]: warn users when entering fullscreen

[Tor Bug Tracker & Wiki]

#20375: warn users when entering fullscreen
-+-
 Reporter:  fem  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-usability, tbb-fingerprinting,   |  Actual Points:
  tbb-torbutton, TorBrowserTeam201708R   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_information => closed
 * resolution:   => fixed


Comment:

 I am not sure yet. What I am currently doing is:

 1) If I am sure it should go into the next stable and next alpha I apply
 the patch for both `master` and the proper `maint-` branch.

 2) Once a new stable release is about to get built I
 a) go over the things that are in the alpha but not stable series and
 decide whether they baked enough to get included into the stable or not.
 b) think about whether the things that are scheduled for the next alpha
 but not stable (i.e. on `master` but no `maint-` branch) should be alpha
 only or whether I got convinced that they provide so much benefit that
 they should go into the stable directly as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20375 [Applications/Tor Browser]: warn users when entering fullscreen

[Tor Bug Tracker & Wiki]

#20375: warn users when entering fullscreen
-+-
 Reporter:  fem  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-fingerprinting,   |  Actual Points:
  tbb-torbutton, TorBrowserTeam201708R   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arthuredelstein):

 Sorry -- no new code. I just thought we should somehow mark this ticket as
 a candidate for backporting. Is there a preferred way to do this?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20375 [Applications/Tor Browser]: warn users when entering fullscreen

[Tor Bug Tracker & Wiki]

#20375: warn users when entering fullscreen
-+-
 Reporter:  fem  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-fingerprinting,   |  Actual Points:
  tbb-torbutton, TorBrowserTeam201708R   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => needs_information


Comment:

 What (new) code is here for review? It landed already on `master`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20375 [Applications/Tor Browser]: warn users when entering fullscreen

[Tor Bug Tracker & Wiki]

#20375: warn users when entering fullscreen
-+-
 Reporter:  fem  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-fingerprinting,   |  Actual Points:
  tbb-torbutton, TorBrowserTeam201708R   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * status:  reopened => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20375 [Applications/Tor Browser]: warn users when entering fullscreen

[Tor Bug Tracker & Wiki]

#20375: warn users when entering fullscreen
-+-
 Reporter:  fem  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  reopened
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-fingerprinting,   |  Actual Points:
  tbb-torbutton, TorBrowserTeam201708R   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * status:  closed => reopened
 * resolution:  fixed =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20375 [Applications/Tor Browser]: warn users when entering fullscreen

[Tor Bug Tracker & Wiki]

#20375: warn users when entering fullscreen
-+-
 Reporter:  fem  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-usability, tbb-fingerprinting,   |  Actual Points:
  tbb-torbutton, TorBrowserTeam201708R   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arthuredelstein):

 Replying to [comment:3 gk]:
 > Looks good. Applied to `master` (commit
 f6b52b8d7f26277569211946248307996d12099c). Could be a candidate for
 backporting to the stable series.

 I think backporting would be a good idea, because currently Tor Browser
 does not show a warning at all when the user clicks on the maximize window
 button in the title bar. That's because macOS (at least in the latest
 versions) seems to always use window.STATE_FULLSCREEN instead of
 window.STATE_MAXIMIZE.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20375 [Applications/Tor Browser]: warn users when entering fullscreen

[Tor Bug Tracker & Wiki]

#20375: warn users when entering fullscreen
-+-
 Reporter:  fem  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-usability, tbb-fingerprinting,   |  Actual Points:
  tbb-torbutton, TorBrowserTeam201708R   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good. Applied to `master` (commit
 f6b52b8d7f26277569211946248307996d12099c). Could be a candidate for
 backporting to the stable series.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20375 [Applications/Tor Browser]: warn users when entering fullscreen

[Tor Bug Tracker & Wiki]

#20375: warn users when entering fullscreen
-+-
 Reporter:  fem  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-fingerprinting,   |  Actual Points:
  tbb-torbutton, TorBrowserTeam201708R   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * cc: arthuredelstein (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20375 [Applications/Tor Browser]: warn users when entering fullscreen

[Tor Bug Tracker & Wiki]

#20375: warn users when entering fullscreen
-+-
 Reporter:  fem  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-usability, tbb-fingerprinting,   |  Actual Points:
  tbb-torbutton, TorBrowserTeam201708R   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-usability, tbb-fingerprinting, tbb-torbutton =>
 tbb-usability, tbb-fingerprinting, tbb-torbutton,
 TorBrowserTeam201708R
 * status:  new => needs_review


Comment:

 See:
 
https://github.com/arthuredelstein/torbutton/commit/d2e35dd0177e7314fb223ee0e05b1c33e3119352
 for a patch up for review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #20375 [Applications/Tor Browser]: warn users when entering fullscreen

[Tor Bug Tracker & Wiki]

#20375: warn users when entering fullscreen
-+-
 Reporter:  fem  |  Owner:  tbb-team
 Type:  enhancement  | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  tbb-usability, tbb-
 Severity:  Normal   |  fingerprinting, tbb-torbutton
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Tor Browser will now warn users when they change the window size, but not
 when they enter fullscreen. Until the implementation of #12977 I think
 having a similar warning to the window size changes would help a lot. The
 two warnings could be generalised and used for both (but maybe there are
 translation issues with this)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs