#20400: Unreachable code in rend_service_derive_key_digests()
--------------------------------------+-----------------
Reporter: twim | Owner:
Type: defect | Status: new
Priority: Medium | Milestone:
Component: - Select a component | Version:
Severity: Normal | Keywords:
Actual Points: | Parent ID:
Points: | Reviewer:
Sponsor: |
--------------------------------------+-----------------
`rend_service_derive_key_digests()` calculates service ID before key
digest. But service ID depends on key digest. So if digest calculation
fails it will appear in log as `Internal error: couldn't encode service
ID.` not as `Couldn't compute hash of public key.`.
btw, what's the point of `Internal error: ` prefix?
--
Ticket URL: <https://troodi.torproject.org/projects/tor/ticket/20400>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs
