Re: [tor-bugs] #25255 [Metrics/Website]: Modify top.jsp to allow the inclusion of additional stylesheets

2018-02-16 Thread Tor Bug Tracker & Wiki
#25255: Modify top.jsp to allow the inclusion of additional stylesheets
-+
 Reporter:  irl  |  Owner:  irl
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:  #23518   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by irl):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 This was merged and deployed along with #25258.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25255 [Metrics/Website]: Modify top.jsp to allow the inclusion of additional stylesheets

2018-02-14 Thread Tor Bug Tracker & Wiki
#25255: Modify top.jsp to allow the inclusion of additional stylesheets
-+-
 Reporter:  irl  |  Owner:  irl
 Type:  enhancement  | Status:  merge_ready
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #23518   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by karsten):

 * status:  needs_review => merge_ready


Comment:

 Sounds good. Setting to merge_ready, as this code reads okay to me. I just
 didn't run it. Doing that together with #25258 sounds good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25255 [Metrics/Website]: Modify top.jsp to allow the inclusion of additional stylesheets

2018-02-14 Thread Tor Bug Tracker & Wiki
#25255: Modify top.jsp to allow the inclusion of additional stylesheets
-+--
 Reporter:  irl  |  Owner:  irl
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #23518   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by irl):

 We can merge it together with #25258. I was doing the things that change
 things that already exist first before adding the new things.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25255 [Metrics/Website]: Modify top.jsp to allow the inclusion of additional stylesheets

2018-02-14 Thread Tor Bug Tracker & Wiki
#25255: Modify top.jsp to allow the inclusion of additional stylesheets
-+--
 Reporter:  irl  |  Owner:  irl
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #23518   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by karsten):

 This looks trivially correct. But do we need to merge it now, or can we
 merge it together with the first servlet/JSP making use of it?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25255 [Metrics/Website]: Modify top.jsp to allow the inclusion of additional stylesheets

2018-02-14 Thread Tor Bug Tracker & Wiki
#25255: Modify top.jsp to allow the inclusion of additional stylesheets
-+--
 Reporter:  irl  |  Owner:  irl
 Type:  enhancement  | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #23518   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by irl):

 * status:  accepted => needs_review
 * cc: metrics-team (added)


Comment:

 Please review my branch [[https://gitweb.torproject.org/user/irl/metrics-
 web.git/log/?h=task/25255|task/25255]].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25255 [Metrics/Website]: Modify top.jsp to allow the inclusion of additional stylesheets

2018-02-14 Thread Tor Bug Tracker & Wiki
#25255: Modify top.jsp to allow the inclusion of additional stylesheets
-+--
 Reporter:  irl  |  Owner:  irl
 Type:  enhancement  | Status:  accepted
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #23518   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by irl):

 * status:  new => accepted
 * owner:  metrics-team => irl


Comment:

 Looking at this

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25255 [Metrics/Website]: Modify top.jsp to allow the inclusion of additional stylesheets

2018-02-14 Thread Tor Bug Tracker & Wiki
#25255: Modify top.jsp to allow the inclusion of additional stylesheets
-+--
 Reporter:  irl  |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:  #23518
   Points:   |   Reviewer:
  Sponsor:   |
-+--
 In order to include the stylesheets required by Relay Search, it needs to
 be possible to specify additional stylesheets when including top.jsp.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs