Re: [tor-bugs] #25779 [Applications/Tor Browser]: Ship tor in Tor Browser nightly builds for macOS with Rust enabled

[Tor Bug Tracker & Wiki]

#25779: Ship tor in Tor Browser nightly builds for macOS with Rust enabled
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam201812R,  |  Actual Points:
  GeorgKoppen201812, boklm201811 |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:10 gk]:
 > See: `bug_25779_v4` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_25779_v4&id=54f63e3176ec840e37c283689746b2a0cb419f8c)
 in my public repo for a patch.

 I merged this to master with commit
 `0512b59d0cc4c68952454e85551659742930cb6d`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25779 [Applications/Tor Browser]: Ship tor in Tor Browser nightly builds for macOS with Rust enabled

[Tor Bug Tracker & Wiki]

#25779: Ship tor in Tor Browser nightly builds for macOS with Rust enabled
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201812R,  |  Actual Points:
  GeorgKoppen201812, boklm201811 |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-rbm, TorBrowserTeam201812, GeorgKoppen201812, boklm201811
 => tbb-rbm, TorBrowserTeam201812R, GeorgKoppen201812, boklm201811
 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:11 boklm]:
 >
 > I think we can simplify a little by defining some option like this:

 After discussing this with GeKo on IRC, we are planning to add support for
 Windows or Android soon, so will not need this extra `var`. As it is only
 a minor improvement, I think it's fine not adding it. So the current patch
 looks good to me.

 I am now testing a build of tor for macOS with this patch before merging
 it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25779 [Applications/Tor Browser]: Ship tor in Tor Browser nightly builds for macOS with Rust enabled

[Tor Bug Tracker & Wiki]

#25779: Ship tor in Tor Browser nightly builds for macOS with Rust enabled
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201812,   |  Actual Points:
  GeorgKoppen201812, boklm201811 |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-rbm, TorBrowserTeam201812R, GeorgKoppen201812, boklm201811
 => tbb-rbm, TorBrowserTeam201812, GeorgKoppen201812, boklm201811
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:10 gk]:
 > See: `bug_25779_v4` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_25779_v4&id=54f63e3176ec840e37c283689746b2a0cb419f8c)
 in my public repo for a patch.

 I think we can simplify a little by defining some option like this:
 {{{
 diff --git a/projects/tor/config b/projects/tor/config
 index 4ba18d9..7fba7d0 100644
 --- a/projects/tor/config
 +++ b/projects/tor/config
 @@ -21,6 +21,8 @@ targets:
  version: '[% c("abbrev") %]'
  git_hash: master
  tag_gpg_id: 0
 +var:
 +  tor_rust: '[% c("var/linux") || c("var/osx") %]'

linux:
  var:
 }}}

 And then replacing the various tests using `(c("var/linux") ||
 c("var/osx")) && c("var/nightly")` by `c("var/tor_rust")`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25779 [Applications/Tor Browser]: Ship tor in Tor Browser nightly builds for macOS with Rust enabled

[Tor Bug Tracker & Wiki]

#25779: Ship tor in Tor Browser nightly builds for macOS with Rust enabled
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201812R,  |  Actual Points:
  GeorgKoppen201812, boklm201811 |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm, TorBrowserTeam201804, GeorgKoppen201804, boklm201811
 => tbb-rbm, TorBrowserTeam201812R, GeorgKoppen201812, boklm201811
 * status:  new => needs_review


Comment:

 See: `bug_25779_v4` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_25779_v4&id=54f63e3176ec840e37c283689746b2a0cb419f8c)
 in my public repo for a patch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25779 [Applications/Tor Browser]: Ship tor in Tor Browser nightly builds for macOS with Rust enabled

[Tor Bug Tracker & Wiki]

#25779: Ship tor in Tor Browser nightly builds for macOS with Rust enabled
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201804,   |  Actual Points:
  GeorgKoppen201804, boklm201806 |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * parent:  #25220 =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25779 [Applications/Tor Browser]: Ship tor in Tor Browser nightly builds for macOS with Rust enabled

[Tor Bug Tracker & Wiki]

#25779: Ship tor in Tor Browser nightly builds for macOS with Rust enabled
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff60-esr, boklm201804,  |  Actual Points:
  TorBrowserTeam201804, GeorgKoppen201804|
Parent ID:  #25220   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Similar to Windows we need to split up this task and do the rust compiler
 + the tor work in child tickets. It seems we need explicit rust cross-
 compile support for macOS, too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25779 [Applications/Tor Browser]: Ship tor in Tor Browser nightly builds for macOS with Rust enabled

[Tor Bug Tracker & Wiki]

#25779: Ship tor in Tor Browser nightly builds for macOS with Rust enabled
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, ff60-esr, boklm201804,  |  Actual Points:
  TorBrowserTeam201804, GeorgKoppen201804|
Parent ID:  #25220   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * cc: teor (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25779 [Applications/Tor Browser]: Ship tor in Tor Browser nightly builds for macOS with Rust enabled

[Tor Bug Tracker & Wiki]

#25779: Ship tor in Tor Browser nightly builds for macOS with Rust enabled
-+-
 Reporter:  gk   |  Owner:  tbb-team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Applications/Tor |Version:
  Browser|   Keywords:  tbb-rbm, ff60-esr,
 Severity:  Normal   |  boklm201804, TorBrowserTeam201804,
 |  GeorgKoppen201804
Actual Points:   |  Parent ID:  #25220
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Similar to #25481 we want to start shipping tor with Rust support enabled
 in our nightly builds for macOS.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs