Re: [tor-bugs] #25814 [Core Tor/Tor]: Should Travis use "make distcheck"?

[Tor Bug Tracker & Wiki]

#25814: Should Travis use "make distcheck"?
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  implemented
 Keywords:  tor-ci, 034-roadmap-subtask  |  Actual Points:
Parent ID:  #25550   | Points:
 Reviewer:  isis |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Merged both branches; now travis should distcheck for us

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25814 [Core Tor/Tor]: Should Travis use "make distcheck"?

[Tor Bug Tracker & Wiki]

#25814: Should Travis use "make distcheck"?
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci, 034-roadmap-subtask  |  Actual Points:
Parent ID:  #25550   | Points:
 Reviewer:  isis |Sponsor:
-+-

Comment (by nickm):

 Replying to [comment:5 isis]:
 > I'm sorry, I noticed the Rust breakage with 0.3.1 and 0.3.2 because I
 build .debs for my Qubes sys-tor VM, but I never said anything because I
 don't (want to) understand enough!^Wmore about Debian or its packaging
 system(s) and didn't really want to get into it. In retrospect, I probably
 should have filed a ticket.
 >
 > This patch LGTM!

 Great!  I'll plan to merge it once the team has had a chance to discuss
 the issue below.  Let's either do it at monday meeting, or schedule a time
 then to do it later.

 > Maybe we want to have conversations at some point about what Jenkins'
 function/purpose is (I thought it existed specifically to test packaging
 and more diverse architectures and platforms like arm and win32),

 From my point of view, it's okay if we rely on Jenkins to test packaging
 and diverse architectures, but ''only if we are looking at it and fixing
 the issues''. On the other hand, if we don't treat bugs found by Jenkins
 failures as "must fix", then I think we need to take more patches like
 this that add more configurations to Travis.

 I'm fine with either route: either checking Jenkins more frequently, or
 expanding the scope of what we do with Travis.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25814 [Core Tor/Tor]: Should Travis use "make distcheck"?

[Tor Bug Tracker & Wiki]

#25814: Should Travis use "make distcheck"?
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci, 034-roadmap-subtask  |  Actual Points:
Parent ID:  #25550   | Points:
 Reviewer:  isis |Sponsor:
-+-
Changes (by isis):

 * status:  needs_review => merge_ready
 * reviewer:   => isis


Comment:

 I'm sorry, I noticed the Rust breakage with 0.3.1 and 0.3.2 because I
 build .debs for my Qubes sys-tor VM, but I never said anything because I
 don't (want to) understand enough!^Wmore about Debian or its packaging
 system(s) and didn't really want to get into it. In retrospect, I probably
 should have filed a ticket.

 This patch LGTM!

 Maybe we want to have conversations at some point about what Jenkins'
 function/purpose is (I thought it existed specifically to test packaging
 and more diverse architectures and platforms like arm and win32), and who
 maintains our Debian stuff (we seem to do a lot of bending over backwards
 specifically for Debian when there's also other good distros whom we
 completely ignore)? If so, maybe we should schedule these conversations
 for the Seattle 2018 network-team meeting?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25814 [Core Tor/Tor]: Should Travis use "make distcheck"?

[Tor Bug Tracker & Wiki]

#25814: Should Travis use "make distcheck"?
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci, 034-roadmap-subtask  |  Actual Points:
Parent ID:  #25550   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * cc: isis, catalyst (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25814 [Core Tor/Tor]: Should Travis use "make distcheck"?

[Tor Bug Tracker & Wiki]

#25814: Should Travis use "make distcheck"?
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci, 034-roadmap-subtask  |  Actual Points:
Parent ID:  #25550   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  accepted => needs_review


Comment:

 I have a patch here in a branch called `travis_distcheck_029`.

 We should also make sure that the distributed bundles work with Rust, and
 I have a branch for that as `travis_distcheck_031`.  However, we shouldn't
 merge that branch into 0.3.1: "make distcheck" doesn't work with Rust
 until 0.3.3!  I have merged that branch forward as `travis_distcheck_033`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25814 [Core Tor/Tor]: Should Travis use "make distcheck"?

[Tor Bug Tracker & Wiki]

#25814: Should Travis use "make distcheck"?
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci, 034-roadmap-subtask  |  Actual Points:
Parent ID:  #25550   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  new => accepted
 * owner:  (none) => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25814 [Core Tor/Tor]: Should Travis use "make distcheck"?

[Tor Bug Tracker & Wiki]

#25814: Should Travis use "make distcheck"?
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci, 034-roadmap-subtask  |  Actual Points:
Parent ID:  #25550   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  tor-ci, 034-roadmap-master, 034-triage-20180328,
 034-included-20180328 => tor-ci, 034-roadmap-subtask


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25814 [Core Tor/Tor]: Should Travis use "make distcheck"?

[Tor Bug Tracker & Wiki]

#25814: Should Travis use "make distcheck"?
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  tor-ci, 034-roadmap-master,
 Severity:  Normal   |  034-triage-20180328, 034-included-20180328
Actual Points:   |  Parent ID:  #25550
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 I just noticed that we had broken "make dist" on master, because one of
 the jenkins builders wasn't passing.  I fixed it with 197d1992dba2fe.

 Should our Travis builds be reconfigured to use "make distcheck" instead
 of "make all && make check"?  It takes only a little bit longer, but it
 would help us be sure that we weren't running into any issues like the one
 above, or #25732.

 Instead of passing things to "configure" directly in this case, we would
 need to use the `DISTCHECK_CONFIGURE_FLAGS` flag to set the configuration
 options that distcheck would use.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs