Re: [tor-bugs] #25993 [Core Tor/Tor]: Improve deliberate test coverage for addressmap_get_virtual_address()

[Tor Bug Tracker & Wiki]

#25993: Improve deliberate test coverage for addressmap_get_virtual_address()
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tor-ci, tor-tests-coverage, tor- |  Actual Points:
  tests-unit |
Parent ID:  #25908   | Points:
 Reviewer:  catalyst |Sponsor:
 |  Sponsor3-can
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Thanks for the review! I've added the comment you suggested in a new fixup
 commit on the branch, and then squashed it as `ticket25993_squashed` and
 merged the branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25993 [Core Tor/Tor]: Improve deliberate test coverage for addressmap_get_virtual_address()

[Tor Bug Tracker & Wiki]

#25993: Improve deliberate test coverage for addressmap_get_virtual_address()
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci, tor-tests-coverage, tor- |  Actual Points:
  tests-unit |
Parent ID:  #25908   | Points:
 Reviewer:  catalyst |Sponsor:
 |  Sponsor3-can
-+-
Changes (by catalyst):

 * status:  needs_review => merge_ready


Comment:

 Code change look good to me!  I left a comment on GitHub with some
 suggestions about the wording of a comment.

 I haven't fully confirmed that every new test does what it claims to do,
 but it looks likely that the coverage flapping for the .0 and .255 case is
 gone.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25993 [Core Tor/Tor]: Improve deliberate test coverage for addressmap_get_virtual_address()

[Tor Bug Tracker & Wiki]

#25993: Improve deliberate test coverage for addressmap_get_virtual_address()
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci, tor-tests-coverage, tor- |  Actual Points:
  tests-unit |
Parent ID:  #25908   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor3-can
-+-
Changes (by nickm):

 * sponsor:   => Sponsor3-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25993 [Core Tor/Tor]: Improve deliberate test coverage for addressmap_get_virtual_address()

[Tor Bug Tracker & Wiki]

#25993: Improve deliberate test coverage for addressmap_get_virtual_address()
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci, tor-tests-coverage, tor- |  Actual Points:
  tests-unit |
Parent ID:  #25908   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  assigned => needs_review


Comment:

 Yes, this does seem to cover the lines that were flapping on and off
 before, plus a few more lines as well.
 https://github.com/torproject/tor/pull/72 is a pull request.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25993 [Core Tor/Tor]: Improve deliberate test coverage for addressmap_get_virtual_address()

[Tor Bug Tracker & Wiki]

#25993: Improve deliberate test coverage for addressmap_get_virtual_address()
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-ci, tor-tests-coverage, tor- |  Actual Points:
  tests-unit |
Parent ID:  #25908   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 I have a branch `ticket25993`.  I'm going to wait to see what coveralls
 says about it before I make a PR though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25993 [Core Tor/Tor]: Improve deliberate test coverage for addressmap_get_virtual_address()

[Tor Bug Tracker & Wiki]

#25993: Improve deliberate test coverage for addressmap_get_virtual_address()
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  tor-ci, tor-tests-coverage, tor-
 Severity:  Normal   |  tests-unit
Actual Points:   |  Parent ID:  #25908
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 This function is currently tested indirectly from test_entryconn.c, but
 this results in unreliable coverage for a couple of the features in this
 function.

 Specifically, we don't test whether duplicate addresses are rejected, or
 whether IPv4 addresses ending with .0 or .255 are rejected.

 This is one source of nondeterminism in our test coverage.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs