Re: [tor-bugs] #26121 [Core Tor/Tor]: BUILDTIMEOUT_SET totals are still off

2018-06-02 Thread Tor Bug Tracker & Wiki
#26121: BUILDTIMEOUT_SET totals are still off
-+-
 Reporter:  mikeperry|  Owner:
 |  mikeperry
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  033-backport 034-backport tor-   |  Actual Points:
  client timeouts performance|
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Great; squashed and merged to 0.3.3 and forward!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26121 [Core Tor/Tor]: BUILDTIMEOUT_SET totals are still off

2018-06-01 Thread Tor Bug Tracker & Wiki
#26121: BUILDTIMEOUT_SET totals are still off
-+-
 Reporter:  mikeperry|  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  033-backport 034-backport tor-   |  Actual Points:
  client timeouts performance|
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-

Comment (by asn):

 Replying to [comment:5 nickm]:
 > asn, I can't find this branch in any of your repositories that I have
 links to. Did you push it? Did I forget a repo?
 >

 Oops. Pushed it in my github repo.

 > Can we open another tickets to get some test coverage here?

 Opened #26262 for this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26121 [Core Tor/Tor]: BUILDTIMEOUT_SET totals are still off

2018-05-27 Thread Tor Bug Tracker & Wiki
#26121: BUILDTIMEOUT_SET totals are still off
-+-
 Reporter:  mikeperry|  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  033-backport 034-backport tor-   |  Actual Points:
  client timeouts performance|
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-

Comment (by nickm):

 asn, I can't find this branch in any of your repositories that I have
 links to. Did you push it? Did I forget a repo?

 Can we open another tickets to get some test coverage here?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26121 [Core Tor/Tor]: BUILDTIMEOUT_SET totals are still off

2018-05-22 Thread Tor Bug Tracker & Wiki
#26121: BUILDTIMEOUT_SET totals are still off
-+-
 Reporter:  mikeperry|  Owner:
 |  mikeperry
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  033-backport 034-backport tor-   |  Actual Points:
  client timeouts performance|
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by asn):

 * keywords:   => 033-backport 034-backport tor-client timeouts performance


Comment:

 Marking for possible backports.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26121 [Core Tor/Tor]: BUILDTIMEOUT_SET totals are still off

2018-05-22 Thread Tor Bug Tracker & Wiki
#26121: BUILDTIMEOUT_SET totals are still off
--+
 Reporter:  mikeperry |  Owner:  mikeperry
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  asn   |Sponsor:
--+
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 Logic and code seems sound.

 Would be nice to somehow be able to test these assumptions and logic.

 Moving this to merge_ready because this bug is probs not the right place
 to write such tests.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26121 [Core Tor/Tor]: BUILDTIMEOUT_SET totals are still off

2018-05-21 Thread Tor Bug Tracker & Wiki
#26121: BUILDTIMEOUT_SET totals are still off
--+
 Reporter:  mikeperry |  Owner:  mikeperry
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:  asn   |Sponsor:
--+
Changes (by asn):

 * reviewer:   => asn


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #26121 [Core Tor/Tor]: BUILDTIMEOUT_SET totals are still off

2018-05-17 Thread Tor Bug Tracker & Wiki
#26121: BUILDTIMEOUT_SET totals are still off
--+
 Reporter:  mikeperry |  Owner:  mikeperry
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by mikeperry):

 * status:  assigned => needs_review


Comment:

 https://github.com/torproject/tor/pull/115

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #26121 [Core Tor/Tor]: BUILDTIMEOUT_SET totals are still off

2018-05-17 Thread Tor Bug Tracker & Wiki
#26121: BUILDTIMEOUT_SET totals are still off
--+
 Reporter:  mikeperry |  Owner:  mikeperry
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 While testing and examining onion service timeout rates and trying to
 verify them from a controller script, I realized that our timeout rates
 are still off in the BUILDTIMEOUT_SET event.

 The reason for the discrepancy is that we're double-counting circuits that
 transition into MEASUREMENT_EXPIRED. Every circuit that transitions into
 MEASUREMENT_EXPIRED is first counted as a timeout in
 circuit_build_times_mark_circ_as_measurement_only(). Of those that do not
 complete within the measurement window, we again count as a "closed"
 circuit in circuit_build_times_count_close(). If a measurement circuit
 succeeds, we do *not* count it as a success (see
 circuit_build_times_handle_completed_hop()).

 This means that the total_circuits value in
 cbt_control_event_buildtimeout_set() should be timeouts+succeeded, and not
 timeouts+succeeded+closed. (Again, counting closed in the total there
 double-counts "closed" MEASUREMENT circuits, which were also counted as
 timeout circuits earlier).

 Since this is just a control port stats change, it would be nice to get it
 into 0.3.4 (and maybe 0.3.3) so it is easier to get more accurate data
 about how the circuit build timeout is interacting with vanguards there.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs