Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.4
  diagnostics, 042-should, 041-backport-maybe,   |
  regression, BugSmashFund   |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * keywords:
 consider-backport-after-042-stable, consider-backport-if-needed,
 diagnostics, 042-should, 035-backport-maybe, 040-backport-maybe, 041
 -backport-maybe, regression, BugSmashFund
 =>
 consider-backport-after-042-stable, diagnostics, 042-should, 041
 -backport-maybe, regression, BugSmashFund
 * status:  merge_ready => closed
 * resolution:   => fixed
 * milestone:  Tor: 0.4.0.x-final => Tor: 0.4.1.x-final


Comment:

 Similar code has caused some bugs, and 0.4.0 is obsolete, so I'm going to
 close these tickets without backport.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.4
  consider-backport-if-needed, diagnostics,  |
  042-should, 035-backport-maybe, 040-backport-  |
  maybe, 041-backport-maybe, regression, |
  BugSmashFund   |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-

Comment (by teor):

 This change doesn't seem to make much of a difference, still thinking "no
 backport".

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.4
  consider-backport-if-needed, diagnostics,  |
  042-should, 035-backport-maybe, 040-backport-  |
  maybe, 041-backport-maybe, regression, |
  BugSmashFund   |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-

Comment (by teor):

 I'm leaning towards "no backport" on this ticket, unless we discover a
 specific bug.
 Leaving open, so we check again after 042-stable.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.0.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.4
  consider-backport-if-needed, diagnostics,  |
  042-should, 035-backport-maybe, 040-backport-  |
  maybe, 041-backport-maybe, regression, |
  BugSmashFund   |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * milestone:  Tor: 0.4.1.x-final => Tor: 0.4.0.x-final


Comment:

 Merged to 0.4.1. Marking for consideration for further backport.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.4
  consider-backport-if-needed, diagnostics,  |
  042-should, 035-backport-maybe, 040-backport-  |
  maybe, 041-backport-maybe, regression, |
  BugSmashFund   |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-
Changes (by asn):

 * keywords:
 consider-backport-after-042-stable, consider-backport-if-needed,
 diagnostics, 042-should, 035-backport-maybe, 040-backport-maybe, 041
 -backport-maybe, regression, BugSmashFund, asn-merge
 =>
 consider-backport-after-042-stable, consider-backport-if-needed,
 diagnostics, 042-should, 035-backport-maybe, 040-backport-maybe, 041
 -backport-maybe, regression, BugSmashFund
 * milestone:  Tor: 0.4.2.x-final => Tor: 0.4.1.x-final


Comment:

 Merged. Leaving open for potential backports?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.4
  consider-backport-if-needed, diagnostics,  |
  042-should, 035-backport-maybe, 040-backport-  |
  maybe, 041-backport-maybe, regression, |
  BugSmashFund, asn-merge|
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => merge_ready
 * keywords:
 consider-backport-after-042-stable, consider-backport-if-needed,
 diagnostics, 042-should, 035-backport-maybe, 040-backport-maybe, 041
 -backport-maybe, regression, BugSmashFund
 =>
 consider-backport-after-042-stable, consider-backport-if-needed,
 diagnostics, 042-should, 035-backport-maybe, 040-backport-maybe, 041
 -backport-maybe, regression, BugSmashFund, asn-merge


Comment:

 I think this is okay.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.4
  consider-backport-if-needed, diagnostics,  |
  042-should, 035-backport-maybe, 040-backport-  |
  maybe, 041-backport-maybe, regression, |
  BugSmashFund   |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-

Comment (by teor):

 I also added a comment explaining why it's ok to not destroy the log
 mutex.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.4
  consider-backport-if-needed, diagnostics,  |
  042-should, 035-backport-maybe, 040-backport-  |
  maybe, 041-backport-maybe, regression, |
  BugSmashFund   |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * status:  merge_ready => needs_review


Comment:

 I was wrong about the backtrace buffer mutex: we can't destroy it, because
 it is statically allocated.

 I removed the call to mutex_destroy(), and explained why in a comment.

 All the other commits are unchanged.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.4
  consider-backport-if-needed, diagnostics,  |
  042-should, 035-backport-maybe, 040-backport-  |
  maybe, 041-backport-maybe, regression, |
  BugSmashFund   |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-

Comment (by teor):

 Sure. Apparently that was my opinion about this whole branch 2 weeks ago:
 consider-backport-if-needed

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.4
  consider-backport-if-needed, diagnostics,  |
  042-should, 035-backport-maybe, 040-backport-  |
  maybe, 041-backport-maybe, regression, |
  BugSmashFund   |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-

Comment (by nickm):

 Hm. I think we should hold ourselves ready to do a backport, but not do
 one unless we actually run into problems in practice.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.4
  consider-backport-if-needed, diagnostics,  |
  042-should, 035-backport-maybe, 040-backport-  |
  maybe, 041-backport-maybe, regression, |
  BugSmashFund   |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-

Comment (by teor):

 Nick, do you think we should backport the commit that destroys the
 backtrace signal handler?
 Otherwise we'll trigger undefined behaviour when Tor is re-initialised.
 (But I'm not sure if we should backport, it seems risky.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.4
  consider-backport-if-needed, diagnostics,  |
  042-should, 035-backport-maybe, 040-backport-  |
  maybe, 041-backport-maybe, regression, |
  BugSmashFund   |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.4
  consider-backport-if-needed, diagnostics,  |
  042-should, 035-backport-maybe, 040-backport-  |
  maybe, 041-backport-maybe, regression, |
  BugSmashFund   |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-
Changes (by teor):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.4
  consider-backport-if-needed, diagnostics,  |
  042-should, 035-backport-maybe, 040-backport-  |
  maybe, 041-backport-maybe, regression, |
  BugSmashFund   |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-

Comment (by teor):

 Replying to [comment:15 nickm]:
 > This mostly LGTM.  Before merging, let's think make a conscious decision
 about what we should do about restart testing (see discussion on #31735).

 (I think you meant #31736 - the quick fix mutex ticket.)

 I think we should leave restart testing for #31735 - the eventual fix
 mutex ticket. I'm out of time on this issue, and the changes are smaller
 than I expected.

 > Also, I worry that this could interfere with our sandbox code: I think
 that in order to allow us to call sigaction() on all of these values, we
 might need to add them to sb_rt_sigaction() in sandbox.c.

 Yes, the sandbox would also need to use these values after a re-
 initialise.

 I made the following changes:
 * added the signals to the sandbox
 * rewrote one of the commits based on #31736
 * rebased on the latest maint-0.3.5 to fix a test-stem error

 Here is the PR:
 * 0.3.5: https://github.com/torproject/tor/pull/1302

 The merge forward is clean.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.4
  consider-backport-if-needed, diagnostics,  |
  042-should, 035-backport-maybe, 040-backport-  |
  maybe, 041-backport-maybe, regression, |
  BugSmashFund   |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 This mostly LGTM.  Before merging, let's think make a conscious decision
 about what we should do about restart testing (see discussion on #31xxx).

 Also, I worry that this could interfere with our sandbox code: I think
 that in order to allow us to call sigaction() on all of these values, we
 might need to add them to sb_rt_sigaction() in sandbox.c.

 Please feel free to merge-ready once the above issues are taken care of.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.4
  consider-backport-if-needed, diagnostics,  |
  042-should, 035-backport-maybe, 040-backport-  |
  maybe, 041-backport-maybe, regression, |
  BugSmashFund   |
Parent ID:   | Points:  0.2
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * reviewer:  dgoulet => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.4
  consider-backport-if-needed, diagnostics,  |
  042-should, 035-backport-maybe, 040-backport-  |
  maybe, 041-backport-maybe, regression, |
  BugSmashFund   |
Parent ID:   | Points:  0.2
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by teor):

 * actualpoints:  0.2 => 0.4


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.2
  consider-backport-if-needed, diagnostics,  |
  042-should, 035-backport-maybe, 040-backport-  |
  maybe, 041-backport-maybe, regression, |
  BugSmashFund   |
Parent ID:   | Points:  0.2
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by teor):

 * status:  needs_revision => needs_review


Comment:

 I removed the commit that added undefined behaviour, and edited the
 changes file.

 Please review my PR:
 * 0.3.5: https://github.com/torproject/tor/pull/1302

 The merge forward is clean, the test branches are here:
 * https://github.com/teor2345/tor/branches/all?query=bug31614_

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.2
  consider-backport-if-needed, diagnostics,  |
  042-should, 035-backport-maybe, 040-backport-  |
  maybe, 041-backport-maybe, regression, |
  BugSmashFund   |
Parent ID:   | Points:  0.2
 Reviewer:  dgoulet  |Sponsor:
-+-

Comment (by teor):

 You're right, there are a bunch of nasty race conditions here.

 This is what we need to fix:
 1. Always lock the mutex before using cb_buf (there are some places where
 we don't do this)
 2. Lock the mutex before adding or removing signal handlers (might not be
 strictly required, but it makes reasoning about locks easier)
 3. Abort if destroying the mutex fails (doesn't save us from undefined
 behaviour, but does notify us when it happens)

 We could also
 4. Lock a mutex before logging anywhere in the err module (this could
 cause more issues than it solves)

 The best way to do this might be to put cb_buf in its own file, and use
 accessor functions.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.2
  consider-backport-if-needed, diagnostics,  |
  042-should, 035-backport-maybe, 040-backport-  |
  maybe, 041-backport-maybe, regression, |
  BugSmashFund   |
Parent ID:   | Points:  0.2
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 Question that might result in no change but still there. One tiny nitpick
 also.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.2
  consider-backport-if-needed, diagnostics,  |
  042-should, 035-backport-maybe, 040-backport-  |
  maybe, 041-backport-maybe, regression, |
  BugSmashFund   |
Parent ID:   | Points:  0.2
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by teor):

 * parent:  #31594 =>


Comment:

 This ticket is independent of its parent now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.2
  consider-backport-if-needed, diagnostics,  |
  042-should, 035-backport-maybe, 040-backport-  |
  maybe, 041-backport-maybe, regression, |
  BugSmashFund   |
Parent ID:  #31594   | Points:  0.2
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by dgoulet):

 * reviewer:   => dgoulet


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  BugSmash, consider-backport- |  Actual Points:  0.2
  after-042-stable, consider-backport-if-|
  needed, diagnostics, 042-should, 035   |
  -backport-maybe, 040-backport-maybe, 041   |
  -backport-maybe, regression|
Parent ID:  #31594   | Points:  0.2
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  needs_review => assigned
 * owner:  (none) => teor


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  teor
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  BugSmash, consider-backport- |  Actual Points:  0.2
  after-042-stable, consider-backport-if-|
  needed, diagnostics, 042-should, 035   |
  -backport-maybe, 040-backport-maybe, 041   |
  -backport-maybe, regression|
Parent ID:  #31594   | Points:  0.2
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  BugSmash, consider-backport- |  Actual Points:  0.2
  after-042-stable, consider-backport-if-|
  needed, diagnostics, 042-should, 035   |
  -backport-maybe, 040-backport-maybe, 041   |
  -backport-maybe, regression|
Parent ID:  #31594   | Points:  0.2
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:
 BugSmash, diagnostics, 042-should, 035-backport-maybe, 040-backport-
 maybe, 041-backport-maybe, regression
 =>
 BugSmash, consider-backport-after-042-stable, consider-backport-if-
 needed, diagnostics, 042-should, 035-backport-maybe, 040-backport-
 maybe, 041-backport-maybe, regression


Comment:

 I don't think we should backport this fix, unless the bug is actually
 causing issues in older versions.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  BugSmash, diagnostics, 042-should,   |  Actual Points:  0.2
  035-backport-maybe, 040-backport-maybe, 041|
  -backport-maybe, regression|
Parent ID:  #31594   | Points:  0.2
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:
 BugSmash, diagnostics, 042-should, 035-backport, 040-backport,
 041-backport, regression
 =>
 BugSmash, diagnostics, 042-should, 035-backport-maybe, 040-backport-
 maybe, 041-backport-maybe, regression


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  BugSmash, diagnostics, 042-should,   |  Actual Points:  0.2
  035-backport, 040-backport, 041-backport,  |
  regression |
Parent ID:  #31594   | Points:  0.2
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:
 BugSmash, diagnostics, 042-should, 035-backport, 040-backport,
 041-backport
 =>
 BugSmash, diagnostics, 042-should, 035-backport, 040-backport,
 041-backport, regression


Old description:

> Part of #31594

New description:

 Split off #31594:

 clean_up_backtrace_handler() doesn't do anything, but it should:
 * disable backtrace signal handlers
 * destroy the backtrace mutex (regression to #21788)

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.4.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.5.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  BugSmash, diagnostics, 042-should,   |  Actual Points:  0.2
  035-backport, 040-backport, 041-backport   |
Parent ID:  #31594   | Points:  0.2
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  new => needs_review
 * cc: gaba (removed)
 * version:   => Tor: 0.3.5.1-alpha
 * actualpoints:   => 0.2
 * keywords:
 diagnostics, 042-should, android, macos, 035-backport, 040-backport,
 041-backport
 =>
 BugSmash, diagnostics, 042-should, 035-backport, 040-backport,
 041-backport
 * points:   => 0.2


Comment:

 See my pull request:
 * 0.3.5: https://github.com/torproject/tor/pull/1302

 The merge forward was clean.

 Here are the test branches for merging forwards:
 * ​​https://github.com/teor2345/tor/branches/all?query=bug31614_

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

[Tor Bug Tracker & Wiki]

#31614: Implement clean_up_backtrace_handler()
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.4.2.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  diagnostics, 042-should, android,
 Severity:  Normal   |  macos, 035-backport, 040-backport, 041-backport
Actual Points:   |  Parent ID:  #31594
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Part of #31594

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs