Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, boklm201805,|  Actual Points:
  TorBrowserTeam201805R  |
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Alright, this looks good to me now, woo! I merged the patch to `master`
 with commit 6b4cb8b83c0a52e596db45b64551162ff2fce947.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201805,|  Actual Points:
  TorBrowserTeam201805R  |
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:88 gk]:
 > I've not reviewed the patch rebasing yet. But here come some notes:
 >
 > 1) We are reverting 13e570f80cbfb299a8858ce6830e91a6cb40ab7b and
 suddenly need `texinfo` for that? At least the comment suggest that
 without reverting this patch we would not need it. Is that what you
 intended to say with the comment?

 Yes, that is what I intended to say. Without texinfo installed the build
 fails with:
 {{{
 /var/tmp/tmp.MNtA4ToB92/binutils-2.26.1/missing: 81:
 /var/tmp/tmp.MNtA4ToB92/binutils-2.26.1/missing: makeinfo: not found
 WARNING: 'makeinfo' is missing on your system.
  You should only need it if you modified a '.texi' file, or
  any other file indirectly affecting the aspect of the manual.
  You might want to install the Texinfo package:
  
  The spurious makeinfo call might also be the consequence of
  using a buggy 'make' (AIX, DU, IRIX), in which case you might
  want to install GNU make:
  
 make[3]: *** [bfd.info] Error 127
 Makefile:443: recipe for target 'bfd.info' failed
 }}}

 But it doesn't fail if I disable the patch to revert
 13e570f80cbfb299a8858ce. Maybe the Makefile is looking at the timestamp of
 some files modified by the patch to find if it needs to update
 documentation using makeinfo.

 >
 > 2) Have you checked whether just passing the `no-insert-timestamp` flag
 to `APPEND_CCFLAGS` is enough? Or just to `APPEND_LINKFLAGS`? It seems to
 me either `no-insert-timstamp` is passed on to the linker in which case we
 would not need that extra patch or it is not passed on, in which case I am
 wondering why we add it to `APPEND_CCFLAGS`.

 Yes, passing the `no-insert-timestamp` flag to `APPEND_CCFLAGS` is not
 fixing the issue as it seems it is not passed on to the linker. So indeed
 there is no need to add it `APPEND_CCFLAGS`.

 I removed the `no-insert-timestamp` flag from `APPEND_CCFLAGS` and fixed
 the typo in branch `bug_16472_v16`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_16472_v16=b24500f6880e2c461050e248c0f7e587b5201d51

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201805,|  Actual Points:
  TorBrowserTeam201805R  |
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 I've not reviewed the patch rebasing yet. But here come some notes:

 1) We are reverting 13e570f80cbfb299a8858ce6830e91a6cb40ab7b and suddenly
 need `texinfo` for that? At least the comment suggest that without
 reverting this patch we would not need it. Is that what you intended to
 say with the comment?

 2) Have you checked whether just passing the `no-insert-timestamp` flag to
 `APPEND_CCFLAGS` is enough? Or just to `APPEND_LINKFLAGS`? It seems to me
 either `no-insert-timstamp` is passed on to the linker in which case we
 would not need that extra patch or it is not passed on, in which case I am
 wondering why we add it to `APPEND_CCFLAGS`.

 3) s/Therefor/Therefore/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201805,|  Actual Points:
  TorBrowserTeam201805R  |
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-rbm, boklm201805, TorBrowserTeam201805 => tbb-rbm,
 boklm201805, TorBrowserTeam201805R
 * status:  needs_revision => needs_review


Comment:

 I pushed a new version of the patch in branch `bug_16472_v15`, rebased on
 #25862:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_16472_v15=cd810c6880433cdffe4dc6ae62cd6d9b322c5285

 In this version, we don't add anymore mingw-w64 wrappers in the nsis
 build. Instead we patch nsis to add the `--no-insert-timestamp` flag.

 I checked that the linux and windows builds are still reproducible on 2
 machines, and that the hardening is still good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201805,|  Actual Points:
  TorBrowserTeam201805   |
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * priority:  High => Very High


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201805,|  Actual Points:
  TorBrowserTeam201805   |
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-rbm, boklm201805, TorBrowserTeam201805R => tbb-rbm,
 boklm201805, TorBrowserTeam201805
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:84 boklm]:
 > Commit `d96fc6ca36f6a0b13e8d41749c62fd50c0edab06` in branch
 `bug_16472_v12` is updating binutils to 2.26.1, with the patch from
 binutils commit `13e570f80cbfb299a8858ce6830e91a6cb40ab7b` reverted for
 the Windows builds:
 > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_16472_v12=d96fc6ca36f6a0b13e8d41749c62fd50c0edab06

 This commit is conflicting with the changes from #25862, so I will rebase
 it on #25862.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201805,|  Actual Points:
  TorBrowserTeam201805R  |
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-rbm, boklm201805, TorBrowserTeam201805 => tbb-rbm,
 boklm201805, TorBrowserTeam201805R
 * status:  needs_information => needs_review


Comment:

 Commit `d96fc6ca36f6a0b13e8d41749c62fd50c0edab06` in branch
 `bug_16472_v12` is updating binutils to 2.26.1, with the patch from
 binutils commit `13e570f80cbfb299a8858ce6830e91a6cb40ab7b` reverted for
 the Windows builds:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_16472_v12=d96fc6ca36f6a0b13e8d41749c62fd50c0edab06

 I checked that the Linux and Windows builds are reproducible on 2
 different machines, and that they are running correctly.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201805,|  Actual Points:
  TorBrowserTeam201805   |
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:82 gk]:
 > I am fine using 2.26.1 with the revert for now I think. Anything better
 than 2.24, because we want to have #12968 fixed for Win64 bundles.

 Ok, I think we can use this ticket for the update to binutils 2.26.1, and
 I opened #26148 for the issue with binutils > 2.26.1.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201805,|  Actual Points:
  TorBrowserTeam201805   |
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 I am fine using 2.26.1 with the revert for now I think. Anything better
 than 2.24, because we want to have #12968 fixed for Win64 bundles.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201805,|  Actual Points:
  TorBrowserTeam201805   |
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Reverting `13e570f80cbfb299a8858ce6830e91a6cb40ab7b` on binutils 2.25 or
 2.26.1 is fixing the issue. Reverting it on 2.27 or later is difficult as
 this part of the code has been changed.

 I also did some builds after removing the `enable-reloc-section-ld.patch`
 and `64bit-fixups.patch` patches, and the issue is still present, so it
 seems the issue is not related with those patches.

 I will fill a binutils ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201805,|  Actual Points:
  TorBrowserTeam201805   |
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:79 gk]:
 > Replying to [comment:78 boklm]:
 > > After bisecting, it seems the issue is starting with commit
 `13e570f80cbfb299a8858ce6830e91a6cb40ab7b`:
 > > https://sourceware.org/git/?p=binutils-
 gdb.git;a=commitdiff;h=13e570f80cbfb299a8858ce6830e91a6cb40ab7b
 >
 > Great, can we narrow down which part of the patch is causing that? (and
 does reverting that part fix the issue with more recent binutils
 versions?)

 In case the latter is true I think getting the issue on the radar of the
 binutils folks by filing a ticket would be good (assuming we still have
 this problem with `master`). They (and the author of the patch causing
 this problem) might be able to help with a proper patch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201805,|  Actual Points:
  TorBrowserTeam201805   |
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:78 boklm]:
 > After bisecting, it seems the issue is starting with commit
 `13e570f80cbfb299a8858ce6830e91a6cb40ab7b`:
 > https://sourceware.org/git/?p=binutils-
 gdb.git;a=commitdiff;h=13e570f80cbfb299a8858ce6830e91a6cb40ab7b

 Great, can we narrow down which part of the patch is causing that? (and
 does reverting that part fix the issue with more recent binutils
 versions?)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201805,|  Actual Points:
  TorBrowserTeam201805   |
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 After bisecting, it seems the issue is starting with commit
 `13e570f80cbfb299a8858ce6830e91a6cb40ab7b`:
 https://sourceware.org/git/?p=binutils-
 gdb.git;a=commitdiff;h=13e570f80cbfb299a8858ce6830e91a6cb40ab7b

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201804,|  Actual Points:
  TorBrowserTeam201804   |
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:74 boklm]:
 > When building using binutils 2.27, the files that are different are:
 > {{{
 > Browser/firefox.exe
 > Browser/lgpllibs.dll
 > Browser/libEGL.dll
 > Browser/libGLESv2.dll
 > Browser/mozglue.dll
 > Browser/plugin-container.exe
 > Browser/plugin-hang-ui.exe
 > Browser/TorBrowser/Tor/PluggableTransports/fte.cDFA.pyd
 > Browser/updater.exe
 > Browser/xul.dll
 > }}}

 When doing builds with binutils 2.25.1, the list of files that are
 different is the same. So it seems to be caused by some change between
 2.24 and 2.25.1.

 When running `objdump -x` on 2 versions of the same dll file, we have this
 diff:
 {{{
 2,3c2,3
 < 1/libEGL.dll: file format pei-i386
 < 1/libEGL.dll
 ---
 > 2/libEGL.dll: file format pei-i386
 > 2/libEGL.dll
 39c39
 < CheckSum  003422cf
 ---
 > CheckSum  00342445
 55c55
 < Entry 5 0032c000 00019b70 Base Relocation Directory [.reloc]
 ---
 > Entry 5 0032c000 00019b74 Base Relocation Directory [.reloc]
 27642,27649c27642,27649
 <   reloc 27130 offset  cc3 [30b13cf4] HIGHLOW
 <   reloc 27131 offset  cd0 [30b13d01] HIGHLOW
 <   reloc 27132 offset  cd7 [30b13d08] HIGHLOW
 <   reloc 27133 offset  d81 [30b13db2] HIGHLOW
 <   reloc 27134 offset  dd2 [30b13e03] HIGHLOW
 <   reloc 27135 offset  dd9 [30b13e0a] HIGHLOW
 <   reloc 27136 offset  de0 [30b13e11] HIGHLOW
 <   reloc 27137 offset  e83 [30b13eb4] HIGHLOW
 ---
 >   reloc 27130 offset  cc2 [30b13cf3] HIGHLOW
 >   reloc 27131 offset  cc9 [30b13cfa] HIGHLOW
 >   reloc 27132 offset  cd0 [30b13d01] HIGHLOW
 >   reloc 27133 offset  d73 [30b13da4] HIGHLOW
 >   reloc 27134 offset  dc3 [30b13df4] HIGHLOW
 >   reloc 27135 offset  dd0 [30b13e01] HIGHLOW
 >   reloc 27136 offset  dd7 [30b13e08] HIGHLOW
 >   reloc 27137 offset  e81 [30b13eb2] HIGHLOW
 30163,30166c30163,30166
 <   reloc 29656 offset  d2f [30b13d60] HIGHLOW
 <   reloc 29657 offset  d42 [30b13d73] HIGHLOW
 <   reloc 29658 offset  dbf [30b13df0] HIGHLOW
 <   reloc 29659 offset  dd2 [30b13e03] HIGHLOW
 ---
 >   reloc 29656 offset  cff [30b13d30] HIGHLOW
 >   reloc 29657 offset  d12 [30b13d43] HIGHLOW
 >   reloc 29658 offset  d8f [30b13dc0] HIGHLOW
 >   reloc 29659 offset  da2 [30b13dd3] HIGHLOW
 36415,36416c36415,36416
 <   reloc 35916 offset  dd2 [30b13e03] HIGHLOW
 <   reloc 35917 offset  dda [30b13e0b] HIGHLOW
 }}}
 Followed by many other reloc lines.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201804,|  Actual Points:
  TorBrowserTeam201804   |
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 When building using binutils 2.27, the files that are different are:
 {{{
 Browser/firefox.exe
 Browser/lgpllibs.dll
 Browser/libEGL.dll
 Browser/libGLESv2.dll
 Browser/mozglue.dll
 Browser/plugin-container.exe
 Browser/plugin-hang-ui.exe
 Browser/TorBrowser/Tor/PluggableTransports/fte.cDFA.pyd
 Browser/updater.exe
 Browser/xul.dll
 }}}

 So it seems this issue doesn't affect tor, meek, obfs4proxy. It also does
 not affect all firefox dlls.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_information
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201804,|  Actual Points:
  TorBrowserTeam201804   |
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by cypherpunks):

 * status:  reopened => needs_information


Comment:

 Replying to [comment:54 gk]:
 > Beacuse he is not using ucrtbase yet but plain msvcrt (you are using the
 former with `--with-default-msvcrt=ucrtbase`). See:
 https://bugzilla.mozilla.org/show_bug.cgi?id=1390583#c51 for an unresolved
 issue.
 Did you add `--with-default-msvcrt=ucrtbase` to both headers and crt?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  reopened
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201804,|  Actual Points:
  TorBrowserTeam201804   |
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Replying to [comment:68 gk]:
 > Replying to [comment:67 cypherpunks]:
 > > Where does the work take place, so everybody could participate?
 >
 > Here in this ticket.
 But there is nothing here for at least two weeks?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  reopened
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803,   |  Actual Points:
  boklm201804|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 We need to keep #25584 in mind when coming up with a better patch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  reopened
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803,   |  Actual Points:
  boklm201804|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:67 cypherpunks]:
 > Where does the work take place, so everybody could participate?

 Here in this ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  reopened
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803,   |  Actual Points:
  boklm201804|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Where does the work take place, so everybody could participate?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  reopened
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803,   |  Actual Points:
  boklm201804|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:64 gk]:
 > Replying to [comment:63 boklm]:
 > > After building on `build-sunet-a`, I get a different build than my
 build machine, but the same as
 https://people.torproject.org/~gk/builds/8.0a5-build1/torbrowser-install-8
 .0a5_en-US.exe.
 >
 > Exciting! So, I wonder which commit(s) since 2.24 introduced this new
 reproducible builds problem.

 Or maybe it's just because of our patches we dropped/did not drop?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  reopened
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803,   |  Actual Points:
  boklm201803|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:63 boklm]:
 > After building on `build-sunet-a`, I get a different build than my build
 machine, but the same as
 https://people.torproject.org/~gk/builds/8.0a5-build1/torbrowser-install-8
 .0a5_en-US.exe.

 Exciting! So, I wonder which commit(s) since 2.24 introduced this new
 reproducible builds problem.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  reopened
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803,   |  Actual Points:
  boklm201803|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 After building on `build-sunet-a`, I get a different build than my build
 machine, but the same as
 https://people.torproject.org/~gk/builds/8.0a5-build1/torbrowser-install-8
 .0a5_en-US.exe.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  reopened
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803,   |  Actual Points:
  boklm201803|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 After rebuilding `tbb-8.0a5-build1` on the same machine, I get a matching
 build. So it seems the non-matching build was caused by some difference
 between the build machines.

 I have now started a build on `build-sunet-a` to see if I get a different
 build.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  reopened
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803,   |  Actual Points:
  boklm201803|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm, TorBrowserTeam201803R, boklm201803 => tbb-rbm,
 TorBrowserTeam201803, boklm201803


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  reopened
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803R,  |  Actual Points:
  boklm201803|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Replying to [comment:59 boklm]:
 > We reverted this patch in tbb-8.0a5-build2, as it might be the cause for
 non-reproducible Windows build.
 Details?
 > I was previously able to reproduce a Windows build using binutils 2.30.
 I will check if I can reproduce the build with 2.29.1 on my machine, and
 if not we can look at switching to binutils 2.30 with a patch to fix the
 crash.
 They can do 2.30.1 if you ask.

 BTW, it's now possible to download `xz` instead of `bz2`.
 Also
 {{{
   # XXX: This is needed due to bug 10102.
   sed 's/= extern_rt_rel_d;/= extern_rt_rel_d;\n  memset (extern_rt_rel_d,
 0, PE_IDATA5_SIZE);/' -i ld/pe-dll.c
 }}}
 is not needed since https://sourceware.org/git/?p=binutils-
 gdb.git;a=commit;h=8d5c4b7bfdfa5f2b40fa056132823c8e9497dc72

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  reopened
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803R,  |  Actual Points:
  boklm201803|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 We reverted this patch in tbb-8.0a5-build2, as it might be the cause for
 non-reproducible Windows build.

 I was previously able to reproduce a Windows build using binutils 2.30. I
 will check if I can reproduce the build with 2.29.1 on my machine, and if
 not we can look at switching to binutils 2.30 with a patch to fix the
 crash.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam201803R,  |  Actual Points:
  boklm201803|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:57 boklm]:
 > I filed an upstream bug report:
 > https://sourceware.org/bugzilla/show_bug.cgi?id=22989
 This issue is actually already fixed in git (I should have tried a build
 using master before starting to bisect), so it should be fixed in the next
 binutils release.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam201803R,  |  Actual Points:
  boklm201803|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 I filed an upstream bug report:
 https://sourceware.org/bugzilla/show_bug.cgi?id=22989

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803R,  |  Actual Points:
  boklm201803|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 After bisecting binutils, it seems
 ca6f2be7f6bc638fd4fad48def1fae4ae4d7906e is the first bad commit:
 https://sourceware.org/git/?p=binutils-
 gdb.git;a=commitdiff;h=ca6f2be7f6bc638fd4fad48def1fae4ae4d7906e

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803R,  |  Actual Points:
  boklm201803|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Replying to [comment:54 gk]:
 > Replying to [comment:53 cypherpunks]:
 > > Replying to [comment:52 gk]:
 > > > Replying to [comment:49 cypherpunks]:
 > > > > Replying to [comment:48 boklm]:
 > > > > You can easily back out the above mentioned 3-line patch and test
 the latest binutils. Switching to ucrtbase.dll from your home-made
 msvcrt.dll hack looks better, though.
 > > >
 > > > Yes, but the ucrtbase approach is not ready yet, alas. It's not
 sufficiently mature yet for getting used for our Windows builds.
 > > It has been run on TC for quite some time, and Tom didn't file any
 issue with it. So, could you explain what is missing?
 >
 > Beacuse he is not using ucrtbase yet but plain msvcrt (you are using the
 former with `--with-default-msvcrt=ucrtbase`).
 Oh, he was going to solve some issues by using it, but it didn't happen,
 heh.
 > See: https://bugzilla.mozilla.org/show_bug.cgi?id=1390583#c51 for an
 unresolved issue.
 Weird. Does `--with-default-msvcrt=msvcr100` work for you?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803R,  |  Actual Points:
  boklm201803|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:53 cypherpunks]:
 > Replying to [comment:52 gk]:
 > > Replying to [comment:49 cypherpunks]:
 > > > Replying to [comment:48 boklm]:
 > > > You can easily back out the above mentioned 3-line patch and test
 the latest binutils. Switching to ucrtbase.dll from your home-made
 msvcrt.dll hack looks better, though.
 > >
 > > Yes, but the ucrtbase approach is not ready yet, alas. It's not
 sufficiently mature yet for getting used for our Windows builds.
 > It has been run on TC for quite some time, and Tom didn't file any issue
 with it. So, could you explain what is missing?

 Beacuse he is not using ucrtbase yet but plain msvcrt (you are using the
 former with `--with-default-msvcrt=ucrtbase`). See:
 https://bugzilla.mozilla.org/show_bug.cgi?id=1390583#c51 for an unresolved
 issue.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803R,  |  Actual Points:
  boklm201803|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Replying to [comment:52 gk]:
 > Replying to [comment:49 cypherpunks]:
 > > Replying to [comment:48 boklm]:
 > > You can easily back out the above mentioned 3-line patch and test the
 latest binutils. Switching to ucrtbase.dll from your home-made msvcrt.dll
 hack looks better, though.
 >
 > Yes, but the ucrtbase approach is not ready yet, alas. It's not
 sufficiently mature yet for getting used for our Windows builds.
 It has been run on TC for quite some time, and Tom didn't file any issue
 with it. So, could you explain what is missing?
 Also there is no need to match the versions of binutils in lin and win
 toolchains. So we can benefit of using `-z separate-code` in binutils
 2.30. Generally, earlier tests of newer versions would have helped to find
 selfrando bugs earlier.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803R,  |  Actual Points:
  boklm201803|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:49 cypherpunks]:
 > Replying to [comment:48 boklm]:
 > You can easily back out the above mentioned 3-line patch and test the
 latest binutils. Switching to ucrtbase.dll from your home-made msvcrt.dll
 hack looks better, though.

 Yes, but the ucrtbase approach is not ready yet, alas. It's not
 sufficiently mature yet for getting used for our Windows builds.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803R,  |  Actual Points:
  boklm201803|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Okay, I merged the patch into `master` (with commit
 b8bae5882eac6159c8a6ad466b9dc4a7b18ba27b). boklm: please file an upstream
 bug report once you found the problematic revision and close this ticket
 then.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803R,  |  Actual Points:
  boklm201803|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 I started bisecting binutils to find which commit is causing the error:
 {{{
 git bisect start
 # good: [90276f15379d380761fc499da2ba24cfb3c12a94] Bump version to 2.29.1
 and regenerate configure files
 git bisect good 90276f15379d380761fc499da2ba24cfb3c12a94
 # bad: [8db5daf9efe8a6174d3b10ac7bba8c178836e9ce] Update version number
 and development status for the 2.30 release.
 git bisect bad 8db5daf9efe8a6174d3b10ac7bba8c178836e9ce
 # skip: [55a09eb6df557934bcb7e96d8ab4e9e7ca0670be] Add markers.
 git bisect skip 55a09eb6df557934bcb7e96d8ab4e9e7ca0670be
 # bad: [9192b7decc7256a41502bf68df36f429cceffc89] Make gdb.base/auvx.exp
 work with --target_board=native-extended-gdbserver
 git bisect bad 9192b7decc7256a41502bf68df36f429cceffc89
 # bad: [c9a5e2a5b2b20d83f60026459d3a6b68481566c9] Adjust code generated by
 regformats/regdat.sh
 git bisect bad c9a5e2a5b2b20d83f60026459d3a6b68481566c9
 # good: [206c9c79ee24759c0e0af96e6722298b413f2716] PR21017, microblaze
 missing _GLOBAL_OFFSET_TABLE_ symbol
 git bisect good 206c9c79ee24759c0e0af96e6722298b413f2716
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803R,  |  Actual Points:
  boklm201803|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Replying to [comment:48 boklm]:
 You can easily back out the above mentioned 3-line patch and test the
 latest binutils. Switching to ucrtbase.dll from your home-made msvcrt.dll
 hack looks better, though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803R,  |  Actual Points:
  boklm201803|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 In branch `bug_16472_v8` we are updating to binutils 2.29.1 (instead of
 2.29 in `bug_16472_v7`):
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_16472_v8=35fcafe980c7b86a15ed433fbac31bd143dfa7b3

 The Windows i686 and x86_64 builds are also working for me with this
 branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803R,  |  Actual Points:
  boklm201803|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Replying to [comment:45 gk]:
 > Replying to [comment:44 boklm]:
 > > Replying to [comment:43 cypherpunks]:
 > > > bump mingw-w64 ;)
 > >
 > > Building firefox with `master` from mingw-w64 fails with:
 > > {{{
 > > i686-w64-mingw32-widl:
 /var/tmp/build/mingw-w64-b633824ecafd/mingw-w64-tools/widl/src/typetree.h:274:
 type_alias_get_aliasee: Assertion `type_is_alias(type)' failed.
 > > Aborted
 > > Makefile:109: recipe for target 'typelib_done' failed
 > > }}}
 It can be something recent and close to binutils 2.30 release date, not
 necessary `master`.
 > Yeah, we should not do that right now,
 What about Nightlies?
 > at least not until we found the issue why the crash is happening
 Do you mean https://sourceware.org/git/gitweb.cgi?p=binutils-
 gdb.git;a=commit;h=9d9c67b06c1bf4c4550e3de0eb575c2bfbe96df9 ?
 > (fwiw I notified Jacek about it, see the stylo bug on Mozilla's bug
 tracker as a patch from him is causing that breakage).
 Where?
 > I think picking the latest stable that works
 2.29.1 ?
 > and filing an upstream bug (making sure it is still unfixed) seems like
 a good idea to me.
 Hrm...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803R,  |  Actual Points:
  boklm201803|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-rbm, TorBrowserTeam201803, boklm201803 => tbb-rbm,
 TorBrowserTeam201803R, boklm201803
 * status:  needs_revision => needs_review


Comment:

 In branch `bug_16472_v7` we are using binutils 2.29:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_16472_v7=0897db8e3662ec5d606e6faf27d470915feea975

 The Windows i686 and x86_64 builds from this branch are working for me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803,   |  Actual Points:
  boklm201803|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:44 boklm]:
 > Replying to [comment:43 cypherpunks]:
 > > bump mingw-w64 ;)
 >
 > Building firefox with `master` from mingw-w64 fails with:
 > {{{
 > i686-w64-mingw32-widl:
 /var/tmp/build/mingw-w64-b633824ecafd/mingw-w64-tools/widl/src/typetree.h:274:
 type_alias_get_aliasee: Assertion `type_is_alias(type)' failed.
 > Aborted
 > Makefile:109: recipe for target 'typelib_done' failed
 > }}}

 Yeah, we should not do that right now, at least not until we found the
 issue why the crash is happening (fwiw I notified Jacek about it, see the
 stylo bug on Mozilla's bug tracker as a patch from him is causing that
 breakage). I think picking the latest stable that works and filing an
 upstream bug (making sure it is still unfixed) seems like a good idea to
 me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803,   |  Actual Points:
  boklm201803|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:43 cypherpunks]:
 > bump mingw-w64 ;)

 Building firefox with `master` from mingw-w64 fails with:
 {{{
 i686-w64-mingw32-widl:
 /var/tmp/build/mingw-w64-b633824ecafd/mingw-w64-tools/widl/src/typetree.h:274:
 type_alias_get_aliasee: Assertion `type_is_alias(type)' failed.
 Aborted
 Makefile:109: recipe for target 'typelib_done' failed
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803,   |  Actual Points:
  boklm201803|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Replying to [comment:40 gk]:
 > I made test builds with your patch but both the 32bit and the 64bit
 bundles are crashing for me right on start. In the debugger I see tons of
 messages like
 > {{{
 > warning: 0f64:0944 @ 01846240 - LdrpSnapThunk - WARNING: Hint index
 0x119 for pr
 > ocedure "NtEnumerateKey" in DLL "ntdll.dll" is invalid
 >
 > warning: 0f64:0944 @ 01846256 - LdrpSnapThunk - WARNING: Hint index
 0x3bb for pr
 > ocedure "RtlIntegerToUnicodeString" in DLL "ntdll.dll" is invalid
 >
 > warning: 0f64:0944 @ 01846287 - LdrpSnapThunk - WARNING: Hint index
 0x26e for pr
 > ocedure "RtlAppendUnicodeStringToString" in DLL "ntdll.dll" is invalid
 >
 > warning: 0f64:0944 @ 01846303 - LdrpSnapThunk - WARNING: Hint index
 0x4a7 for pr
 > ocedure "RtlStringFromGUID" in DLL "ntdll.dll" is invalid
 > }}}.
 bump mingw-w64 ;)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803,   |  Actual Points:
  boklm201803|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 A Windows-i686 build (I did not try x86_64 yet) using binutils 2.29 is
 also working fine. So it seems the crash is caused by some change between
 binutils 2.29 and 2.30.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803,   |  Actual Points:
  boklm201803|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Oops, I should have tried to run it before setting the ticket in
 needs_review.

 It is also crashing for me on Windows. However, doing a rebuild using
 binutils 2.28.1 instead of 2.30, the browser is starting fine.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803,   |  Actual Points:
  boklm201803|
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  tbb-rbm, TorBrowserTeam201803R, boklm201803 => tbb-rbm,
 TorBrowserTeam201803, boklm201803


Comment:

 I made test builds with your patch but both the 32bit and the 64bit
 bundles are crashing for me right on start. In the debugger I see tons of
 messages like
 {{{
 warning: 0f64:0944 @ 01846240 - LdrpSnapThunk - WARNING: Hint index 0x119
 for pr
 ocedure "NtEnumerateKey" in DLL "ntdll.dll" is invalid

 warning: 0f64:0944 @ 01846256 - LdrpSnapThunk - WARNING: Hint index 0x3bb
 for pr
 ocedure "RtlIntegerToUnicodeString" in DLL "ntdll.dll" is invalid

 warning: 0f64:0944 @ 01846287 - LdrpSnapThunk - WARNING: Hint index 0x26e
 for pr
 ocedure "RtlAppendUnicodeStringToString" in DLL "ntdll.dll" is invalid

 warning: 0f64:0944 @ 01846303 - LdrpSnapThunk - WARNING: Hint index 0x4a7
 for pr
 ocedure "RtlStringFromGUID" in DLL "ntdll.dll" is invalid
 }}}.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201802,|  Actual Points:
  TorBrowserTeam201803R  |
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * status:  needs_revision => needs_review
 * keywords:  tbb-rbm, boklm201802, TorBrowserTeam201803 => tbb-rbm,
 boklm201802, TorBrowserTeam201803R


Comment:

 Replying to [comment:36 boklm]:
 >
 > Ah, I think we only need `--no-insert-timestamp` and not the other
 options. I will make a new revision of the patch keeping only `--no-
 insert-timestamp`.

 I made a new revision of the patch in branch `bug_16472_v6`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_16472_v6=5a9277e9322117f9c8ebe53f1f447fa69293933a

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201802,|  Actual Points:
  TorBrowserTeam201803   |
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-rbm, boklm201802, TorBrowserTeam201802R => tbb-rbm,
 boklm201802, TorBrowserTeam201803


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201802,|  Actual Points:
  TorBrowserTeam201802R  |
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * status:  needs_information => needs_revision


Comment:

 Replying to [comment:35 gk]:
 >
 > I understand that part and that's not the thing that confuses me. Before
 the patch we had
 > "# remove hardening wrappers" but now we have "# Some of the hardening
 flags are causing the build to fail, so we overwrite the helpers with only
 the flags required to make the build reproducible." So, why do we have
 suddenly the need for the hardening option `-Wl,--enable-reloc-section`?
 Just because we need to deal with `--no-insert-timestamp`?

 Ah, I think we only need `--no-insert-timestamp` and not the other
 options. I will make a new revision of the patch keeping only `--no-
 insert-timestamp`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201802,|  Actual Points:
  TorBrowserTeam201802R  |
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:33 boklm]:
 > Replying to [comment:32 gk]:
 > > Good stuff! I am a bit confused about why the upgrade to binutils 2.30
 suddenly needs all those `nsis` related build changes. I mean the
 hardening flags are not really changing just with the binutils update...
 So, what's up with that?
 >
 > The reason is that binutils 2.25 added this change:
 > {{{
 > * PE binaries now once again contain real timestamps by default.  To
 disable
 >   the inclusion of a timestamp in a PE binary, use the --no-insert-
 timestamp
 >   command line option.
 > }}}
 >
 > So we need to add the `--no-insert-timestamp` flag to make the build
 reproducible, which was not necessary with binutils 2.24.

 I understand that part and that's not the thing that confuses me. Before
 the patch we had
 "# remove hardening wrappers" but now we have "# Some of the hardening
 flags are causing the build to fail, so we overwrite the helpers with only
 the flags required to make the build reproducible." So, why do we have
 suddenly the need for the hardening option `-Wl,--enable-reloc-section`?
 Just because we need to deal with `--no-insert-timestamp`?

 > Alternatively, we could patch `ld/emultempl/pe.em` and change this line
 to make it false by default:
 > {{{
 > static bfd_boolean insert_timestamp = TRUE;
 > }}}

 I think we don't want that.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201802,|  Actual Points:
  TorBrowserTeam201802R  |
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Isn't it better just to upgrade nsis to 3.x version which Tom uses?
 Hardening on Windows is harmless for all programs, except ancient crap.
 But if nsis has problems with ASLR, why do you add `--enable-reloc-
 section`? As you removed SSP, why `-lssp`?
 `+# the nsis build system expect all toolchain binaries to be in the same`
 *expects

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201802,|  Actual Points:
  TorBrowserTeam201802R  |
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:32 gk]:
 > Good stuff! I am a bit confused about why the upgrade to binutils 2.30
 suddenly needs all those `nsis` related build changes. I mean the
 hardening flags are not really changing just with the binutils update...
 So, what's up with that?

 The reason is that binutils 2.25 added this change:
 {{{
 * PE binaries now once again contain real timestamps by default.  To
 disable
   the inclusion of a timestamp in a PE binary, use the --no-insert-
 timestamp
   command line option.
 }}}

 So we need to add the `--no-insert-timestamp` flag to make the build
 reproducible, which was not necessary with binutils 2.24.

 Alternatively, we could patch `ld/emultempl/pe.em` and change this line to
 make it false by default:
 {{{
 static bfd_boolean insert_timestamp = TRUE;
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201802,|  Actual Points:
  TorBrowserTeam201802R  |
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => needs_information


Comment:

 Good stuff! I am a bit confused about why the upgrade to binutils 2.30
 suddenly needs all those `nsis` related build changes. I mean the
 hardening flags are not really changing just with the binutils update...
 So, what's up with that?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-rbm, boklm201802,|  Actual Points:
  TorBrowserTeam201802R  |
Parent ID:  #12968   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * keywords:  tbb-rbm, boklm201802 => tbb-rbm, boklm201802,
 TorBrowserTeam201802R
 * status:  new => needs_review


Comment:

 There is a patch for review in branch `bug_16472_v5`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_16472_v5=f338e127e856d3db876ebe46e62799f0fb63fb78

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm, boklm201802  |  Actual Points:
Parent ID:  #12968| Points:
 Reviewer:|Sponsor:
--+--

Comment (by ahomescu):

 I have created tag selfrando tag tb-v0.4.1 that includes the fix for this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm, boklm201802  |  Actual Points:
Parent ID:  #12968| Points:
 Reviewer:|Sponsor:
--+--

Comment (by boklm):

 Replying to [comment:24 cypherpunks]:
 > `--no-insert-timestamp`?

 This is indeed what was missing. Adding `--no-insert-timestamp` flags made
 the build reproductible.

 The current version patch is in branch `bug_16472_v4`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_16472_v4=13859a052ed60083c43dc913141b66e45ac37afb

 I think the only missing part now is a new selfrando version tagged which
 includes commit d070755.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm, boklm201802  |  Actual Points:
Parent ID:  #12968| Points:
 Reviewer:|Sponsor:
--+--

Comment (by boklm):

 Replying to [comment:27 gk]:
 > boklm, could you test with selfrando d070755 again?

 With commit d070755, this is now building fine.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm, boklm201802  |  Actual Points:
Parent ID:  #12968| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 boklm, could you test with selfrando d070755 again?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm, boklm201802  |  Actual Points:
Parent ID:  #12968| Points:
 Reviewer:|Sponsor:
--+--

Comment (by boklm):

 Replying to [comment:25 gk]:
 > boklm: could you test the selfrando commit
 d2951ac1d3747a4d8a9ef222d38d2d13e5ae2ba9 and report back whether that
 solved our problems? ahomescu said we should be good with that one.

 It seems it fixed the previous error, however we now have a different
 error:
 {{{
 Executing /var/tmp/build/firefox-8ee6fdadea2a/obj-i686-pc-linux-
 gnu/dist/bin/shlibsign -v -o ../../dist/firefox/libsoftokn3.chk -i
 ../../dist/firefox/libsoftokn3.so
 Traceback (most recent call last):
   File "/var/tmp/build/firefox-
 8ee6fdadea2a/toolkit/mozapps/installer/packager.py", line 341, in 
 main()
   File "/var/tmp/build/firefox-
 8ee6fdadea2a/toolkit/mozapps/installer/packager.py", line 337, in main
 copier.copy(args.destination)
   File "/var/tmp/build/firefox-
 8ee6fdadea2a/python/mozbuild/mozpack/copier.py", line 399, in copy
 copy_results.append((destfile, f.copy(destfile, skip_if_older)))
   File "/var/tmp/build/firefox-
 8ee6fdadea2a/toolkit/mozapps/installer/packager.py", line 124, in copy
 errors.fatal('Error while signing %s' % self.path)
   File "/var/tmp/build/firefox-
 8ee6fdadea2a/python/mozbuild/mozpack/errors.py", line 103, in fatal
 self._handle(self.FATAL, msg)
   File "/var/tmp/build/firefox-
 8ee6fdadea2a/python/mozbuild/mozpack/errors.py", line 98, in _handle
 raise ErrorMessage(msg)
 mozpack.errors.ErrorMessage: Error: Error while signing
 ../../dist/firefox/libsoftokn3.so
 make[3]: *** [stage-package] Error 1
 make[3]: Leaving directory `/var/tmp/build/firefox-8ee6fdadea2a/obj-i686
 -pc-linux-gnu/browser/installer'
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm, boklm201802  |  Actual Points:
Parent ID:  #12968| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 boklm: could you test the selfrando commit
 d2951ac1d3747a4d8a9ef222d38d2d13e5ae2ba9 and report back whether that
 solved our problems? ahomescu said we should be good with that one.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm, boklm201802  |  Actual Points:
Parent ID:  #12968| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 `--no-insert-timestamp`?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm, boklm201802  |  Actual Points:
Parent ID:  #12968| Points:
 Reviewer:|Sponsor:
--+--
Changes (by boklm):

 * Attachment "tor-win32.diff" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm, boklm201802  |  Actual Points:
Parent ID:  #12968| Points:
 Reviewer:|Sponsor:
--+--

Comment (by boklm):

 Replying to [comment:15 gk]:

 >
 > Have you checked about the deterministic output of the Windows bundles
 after the switch to the newer  binutils version? That has been the main
 reason for why an update did not happen earlier (see: comment:1).

 It seems it is not deterministic. I did two builds using branch
 `boklm/bug_16472_v3`, and have some differences in the Windows builds. I
 will attach the output of diffoscope on `tor-win32-0.3.3.2-alpha.zip`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm, boklm201802  |  Actual Points:
Parent ID:  #12968| Points:
 Reviewer:|Sponsor:
--+--

Comment (by ahomescu):

 I will investigate this on the selfrando end, should be able to fix it
 shortly.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm, boklm201802  |  Actual Points:
Parent ID:  #12968| Points:
 Reviewer:|Sponsor:
--+--

Comment (by boklm):

 Replying to [comment:20 gk]:
 > boklm: We are using an older tag for selfrando. Could you double-check
 that the issue is still there with the latest code on `master`? That said
 I think it is fine dropping selfrando in a separate patch for this bug if
 that's the only issue blocking the binutils uprade, at least until it is
 fixed upstream (i.e. on selfrando's side).

 I tried a build using selfrando commit
 de95c99364214d631df01364e0e87e6b6c307eba (current master), and it also
 fails with the error from comment:9.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm, boklm201802  |  Actual Points:
Parent ID:  #12968| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 boklm: We are using an older tag for selfrando. Could you double-check
 that the issue is still there with the latest code on `master`? That said
 I think it is fine dropping selfrando in a separate patch for this bug if
 that's the only issue blocking the binutils uprade, at least until it is
 fixed upstream (i.e. on selfrando's side).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm, boklm201802  |  Actual Points:
Parent ID:  #12968| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 Replying to [comment:18 boklm]:
 > Replying to [comment:17 gk]:
 > > Hm. Is that caused by Selfrando? I can't otherwise imagine we are the
 only ones hitting that while compiling Firefox given that binutils 2.27+
 and GCC 6.4.0 is not an esoteric compiler/linker combo.
 >
 > Yes, it seems to be caused by Selfrando. I started a build after
 disabling Selfrando, and the build did not fail in this case.

 Okay, let me get back to the selfrando folks with that.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm, boklm201802  |  Actual Points:
Parent ID:  #12968| Points:
 Reviewer:|Sponsor:
--+--

Comment (by boklm):

 Replying to [comment:17 gk]:
 > Hm. Is that caused by Selfrando? I can't otherwise imagine we are the
 only ones hitting that while compiling Firefox given that binutils 2.27+
 and GCC 6.4.0 is not an esoteric compiler/linker combo.

 Yes, it seems to be caused by Selfrando. I started a build after disabling
 Selfrando, and the build did not fail in this case.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm, boklm201802  |  Actual Points:
Parent ID:  #12968| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 Hm. Is that caused by Selfrando? I can't otherwise imagine we are the only
 ones hitting that while compiling Firefox given that binutils 2.27+ and
 GCC 6.4.0 is not an esoteric compiler/linker combo.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm, boklm201802  |  Actual Points:
Parent ID:  #12968| Points:
 Reviewer:|Sponsor:
--+--

Comment (by boklm):

 Replying to [comment:14 boklm]:
 >
 > However, after updating gcc to 6.4.0, it seems those two patches are not
 needed anymore (and make the build fail). So I think we should update both
 binutils and gcc at the same time.

 It seems I was wrong on that, I had been trying an x86_64 build instead of
 an i686 one, and on i686 the build still fails with gcc 6.4.0 with the
 same error as in comment:9.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm, boklm201802  |  Actual Points:
Parent ID:  #12968| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 Replying to [comment:14 boklm]:
 > In branch `bug_16472_v2` I added a commit updating binutils to 2.30:
 > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_16472_v2=fd2706c19dad44730ef10f8d868ac965d84a65b7
 >
 > I also added a test commit adding two `tor-browser.git` patches fixing
 the build, but I am not sure that they are correct:
 > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_16472_v2=868c0384fa306f51f5be5e16a32b6ef063ade2a9
 >
 > However, after updating gcc to 6.4.0, it seems those two patches are not
 needed anymore (and make the build fail). So I think we should update both
 binutils and gcc at the same time.

 Agreed, bumping both at the same time sounds like a good idea, especially
 if that means we don't need those additional patches.

 Have you checked about the deterministic output of the Windows bundles
 after the switch to the newer  binutils version? That's has been the main
 reason for why an update did not happen earlier (see: comment:1).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm, boklm201802  |  Actual Points:
Parent ID:  #12968| Points:
 Reviewer:|Sponsor:
--+--

Comment (by boklm):

 In branch `bug_16472_v2` I added a commit updating binutils to 2.30:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_16472_v2=fd2706c19dad44730ef10f8d868ac965d84a65b7

 I also added a test commit adding two `tor-browser.git` patches fixing the
 build, but I am not sure that they are correct:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_16472_v2=868c0384fa306f51f5be5e16a32b6ef063ade2a9

 However, after updating gcc to 6.4.0, it seems those two patches are not
 needed anymore (and make the build fail). So I think we should update both
 binutils and gcc at the same time.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm, boklm201802  |  Actual Points:
Parent ID:  #12968| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 gold throws that error instead of generating (potentially exploitable?)
 code which leads to runtime segmentation fault instead of preemptible
 symbol (if it got preempted) in that case. Yes, this is how x86 Linux
 works. To put some light on it: https://software.intel.com/en-
 us/blogs/2010/11/10/limit-performance-impact-of-global-symbols-on-linux/
 It seems, Linux developers are generally
 [https://github.com/opencv/opencv/issues/10229 shocked] and don't know
 what to do with it, even in [https://dxr.mozilla.org/mozilla-
 esr52/source/security/nss/lib/util/templates.c#123 Mozilla].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm, boklm201802  |  Actual Points:
Parent ID:  #12968| Points:
 Reviewer:|Sponsor:
--+--

Comment (by boklm):

 Adding `static` to kLogStrings is indeed fixing the issue.

 The next error is:
 {{{
 + exec /var/tmp/dist/gcc/bin/gcc
 -B/var/tmp/dist/selfrando/Tools/TorBrowser/tc-wrapper -ffunction-sections
 -fdata-sections -fPIC -m32 -std=gnu99 -shared -Wl,--gc-section
 s -Wl,-z,defs -Wl,-soname -Wl,libnssutil3.so -Wl,--version-
 script,/var/tmp/build/firefox-017a7ad9488d/obj-i686-pc-linux-
 gnu/security/nss/lib/util/nssutil.def -o /var/tmp
 /build/firefox-017a7ad9488d/obj-i686-pc-linux-
 gnu/security/nss/lib/util/libnssutil3.so /var/tmp/build/firefox-
 017a7ad9488d/obj-i686-pc-linux-gnu/security/nss/lib/util/qu
 ickder.o /var/tmp/build/firefox-017a7ad9488d/obj-i686-pc-linux-
 gnu/security/nss/lib/util/secdig.o /var/tmp/build/firefox-
 017a7ad9488d/obj-i686-pc-linux-gnu/security/nss/
 lib/util/derdec.o /var/tmp/build/firefox-017a7ad9488d/obj-i686-pc-linux-
 gnu/security/nss/lib/util/derenc.o /var/tmp/build/firefox-
 017a7ad9488d/obj-i686-pc-linux-gnu/secu
 rity/nss/lib/util/dersubr.o /var/tmp/build/firefox-017a7ad9488d/obj-i686
 -pc-linux-gnu/security/nss/lib/util/dertime.o /var/tmp/build/firefox-
 017a7ad9488d/obj-i686-pc-lin
 ux-gnu/security/nss/lib/util/errstrs.o /var/tmp/build/firefox-
 017a7ad9488d/obj-i686-pc-linux-gnu/security/nss/lib/util/nssb64d.o
 /var/tmp/build/firefox-017a7ad9488d/obj-
 i686-pc-linux-gnu/security/nss/lib/util/nssb64e.o /var/tmp/build/firefox-
 017a7ad9488d/obj-i686-pc-linux-gnu/security/nss/lib/util/nssrwlk.o
 /var/tmp/build/firefox-017a7a
 d9488d/obj-i686-pc-linux-gnu/security/nss/lib/util/nssilock.o
 /var/tmp/build/firefox-017a7ad9488d/obj-i686-pc-linux-
 gnu/security/nss/lib/util/oidstring.o /var/tmp/build/
 firefox-017a7ad9488d/obj-i686-pc-linux-
 gnu/security/nss/lib/util/pkcs1sig.o /var/tmp/build/firefox-
 017a7ad9488d/obj-i686-pc-linux-gnu/security/nss/lib/util/portreg.o /va
 r/tmp/build/firefox-017a7ad9488d/obj-i686-pc-linux-
 gnu/security/nss/lib/util/secalgid.o /var/tmp/build/firefox-
 017a7ad9488d/obj-i686-pc-linux-gnu/security/nss/lib/util/s
 ecasn1d.o /var/tmp/build/firefox-017a7ad9488d/obj-i686-pc-linux-
 gnu/security/nss/lib/util/secasn1e.o /var/tmp/build/firefox-
 017a7ad9488d/obj-i686-pc-linux-gnu/security/n
 ss/lib/util/secasn1u.o /var/tmp/build/firefox-017a7ad9488d/obj-i686-pc-
 linux-gnu/security/nss/lib/util/secitem.o /var/tmp/build/firefox-
 017a7ad9488d/obj-i686-pc-linux-gn
 u/security/nss/lib/util/secload.o /var/tmp/build/firefox-
 017a7ad9488d/obj-i686-pc-linux-gnu/security/nss/lib/util/secoid.o
 /var/tmp/build/firefox-017a7ad9488d/obj-i686-p
 c-linux-gnu/security/nss/lib/util/sectime.o /var/tmp/build/firefox-
 017a7ad9488d/obj-i686-pc-linux-gnu/security/nss/lib/util/secport.o
 /var/tmp/build/firefox-017a7ad9488d
 /obj-i686-pc-linux-gnu/security/nss/lib/util/templates.o /var/tmp/build
 /firefox-017a7ad9488d/obj-i686-pc-linux-gnu/security/nss/lib/util/utf8.o
 /var/tmp/build/firefox-01
 7a7ad9488d/obj-i686-pc-linux-gnu/security/nss/lib/util/utilmod.o
 /var/tmp/build/firefox-017a7ad9488d/obj-i686-pc-linux-
 gnu/security/nss/lib/util/utilpars.o -L/var/tmp/bu
 ild/firefox-017a7ad9488d/obj-i686-pc-linux-gnu/dist/lib -L/var/tmp/build
 /firefox-017a7ad9488d/obj-i686-pc-linux-gnu/dist/bin -lplc4 -lplds4
 -lnspr4 -lpthread -ldl -lc
 collect2: fatal error: ld terminated with signal 6 [Aborted]
 compilation terminated.
 /var/tmp/dist/binutils/bin/ld.gold.real: warning: wildcard match appears
 in both version 'NSSUTIL_3.12' and 'NSSUTIL_3.12.3' in script
 /var/tmp/dist/binutils/bin/ld.gold.real: warning: wildcard match appears
 in both version 'NSSUTIL_3.12.3' and 'NSSUTIL_3.12.5' in script
 /var/tmp/dist/binutils/bin/ld.gold.real: warning: wildcard match appears
 in both version 'NSSUTIL_3.12.5' and 'NSSUTIL_3.12.7' in script
 /var/tmp/dist/binutils/bin/ld.gold.real: warning: wildcard match appears
 in both version 'NSSUTIL_3.12.7' and 'NSSUTIL_3.13' in script
 /var/tmp/dist/binutils/bin/ld.gold.real: warning: wildcard match appears
 in both version 'NSSUTIL_3.13' and 'NSSUTIL_3.14' in script
 /var/tmp/dist/binutils/bin/ld.gold.real: warning: wildcard match appears
 in both version 'NSSUTIL_3.14' and 'NSSUTIL_3.15' in script
 /var/tmp/dist/binutils/bin/ld.gold.real: warning: wildcard match appears
 in both version 'NSSUTIL_3.15' and 'NSSUTIL_3.17.1' in script
 /var/tmp/dist/binutils/bin/ld.gold.real: warning: 

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm, boklm201802  |  Actual Points:
Parent ID:  #12968| Points:
 Reviewer:|Sponsor:
--+--

Comment (by cypherpunks):

 Replying to [comment:10 boklm]:
 > After reverting commit ed700649d0607e6509d5bbc51f4617bbae13a543 from
 binutils, firefox builds without error on linux-i686.
 gold [https://sourceware.org/bugzilla/show_bug.cgi?id=16111 started] to
 detect errors as ld. Why to revert that?
 Maybe, adding `static` to [https://dxr.mozilla.org/mozilla-
 esr52/source/dom/media/gmp-plugin-openh264/gmp-fake-openh264.cpp#84
 kLogStrings] could help?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm, boklm201802  |  Actual Points:
Parent ID:  #12968| Points:
 Reviewer:|Sponsor:
--+--

Comment (by boklm):

 After reverting commit ed700649d0607e6509d5bbc51f4617bbae13a543 from
 binutils, firefox builds without error on linux-i686.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm, boklm201802  |  Actual Points:
Parent ID:  #12968| Points:
 Reviewer:|Sponsor:
--+--

Comment (by boklm):

 After updating binutils to 2.30, the Linux x86_64 version builds fine,
 however the Linux i686 one fails while building firefox with:
 {{{
 + exec /var/tmp/dist/gcc/bin/g++
 -B/var/tmp/dist/selfrando/Tools/TorBrowser/tc-wrapper -ffunction-sections
 -fdata-sections -fPIC -std=gnu++11 -Wall -Wc++11-compat -Wempty-body
 -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare
 -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof
 -Wc++14-compat -Wno-error=maybe-uninitialized -Wno-error=deprecated-
 declarations -Wno-error=array-bounds -fno-lifetime-dse -m32 -fno-
 exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-math-errno
 -pthread -pipe -g -freorder-blocks -Os -fomit-frame-pointer -fPIC -shared
 -Wl,-z,defs -Wl,-h,libfakeopenh264.so -o libfakeopenh264.so /var/tmp/build
 /firefox-017a7ad9488d/obj-i686-pc-linux-gnu/dom/media/gmp-plugin-
 openh264/tmpnYmh7y.list -lpthread -m32 -Wl,-z,noexecstack -Wl,-z,text -Wl
 ,--build-id -Wl,-rpath-link,/var/tmp/build/firefox-017a7ad9488d/obj-i686
 -pc-linux-gnu/dist/bin -Wl,-rpath-link,/usr/local/lib
 collect2: fatal error: ld terminated with signal 6 [Aborted]
 compilation terminated.
 /var/tmp/dist/binutils/bin/ld.gold.real: error: /tmp/trapobj-T5OaCF37Jw:
 relocation R_386_GOTOFF against preemptible symbol kLogStrings cannot be
 used when making a shared object
 Linker execution failed, status: 1
 ld: src/Support/posix/Debug.cpp:36: void Error::printf(const char*, ...):
 Assertion `false' failed.
 make[5]: *** [libfakeopenh264.so] Error 1
 make[5]: Leaving directory `/var/tmp/build/firefox-017a7ad9488d/obj-i686
 -pc-linux-gnu/dom/media/gmp-plugin-openh264'
 make[4]: *** [dom/media/gmp-plugin-openh264/target] Error 2
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm, boklm201802  |  Actual Points:
Parent ID:  #12968| Points:
 Reviewer:|Sponsor:
--+--
Changes (by boklm):

 * keywords:  tbb-rbm => tbb-rbm, boklm201802


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:  #12968| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * parent:   => #12968


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-gitian|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 FWIW: Our patch got "upstreamed" with
 https://sourceware.org/bugzilla/show_bug.cgi?id=20634 which is available
 in binutils 2.28.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs