Re: [tor-bugs] #17334 [Applications/Tor Browser]: Move Referrer spoofing for .onion domains out of Torbutton

[Tor Bug Tracker & Wiki]

#17334: Move Referrer spoofing for .onion domains out of Torbutton
-+-
 Reporter:  gk   |  Owner:
 |  arthuredelstein
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-torbutton-conversion,|  Actual Points:
  TorBrowserTeam201609R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-

Comment (by boklm):

 Replying to [comment:9 arthuredelstein]:
 >
 > It would be nice to write an automated test, but I'm not sure what the
 best approach is, as we need to be able to simulate an onion site or
 connect to a real one.

 I opened ticket #20187 for that.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17334 [Applications/Tor Browser]: Move Referrer spoofing for .onion domains out of Torbutton

[Tor Bug Tracker & Wiki]

#17334: Move Referrer spoofing for .onion domains out of Torbutton
-+-
 Reporter:  gk   |  Owner:
 |  arthuredelstein
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-torbutton-conversion,|  Actual Points:
  TorBrowserTeam201609R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good to me. This will go into 6.5a3 as well. Cherry-picked to
 torbutton master (commit 7f7129eb1eac515ca77d9f4b06bbf4b150fcffbe) and
 tor-browser-45.3.0esr-6.5-1 (commit
 5837ac47afae9ca736ec4c4fedf0d83d6a601bc9).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17334 [Applications/Tor Browser]: Move Referrer spoofing for .onion domains out of Torbutton

[Tor Bug Tracker & Wiki]

#17334: Move Referrer spoofing for .onion domains out of Torbutton
-+-
 Reporter:  gk   |  Owner:
 |  arthuredelstein
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton-conversion,|  Actual Points:
  TorBrowserTeam201609R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-

Comment (by arthuredelstein):

 Replying to [comment:8 mcs]:
 > Kathy and I reviewed this and it looks OK. We did not build and run the
 code. How much testing have you done?

 More now. :) I have set up a hidden site that lets us test this feature
 manually:
 http://5oyaubgz5hqruonh.onion/test17334.html

 If you apply only the torbutton patch in comment:5, then referrer spoofing
 is disabled. But if you apply the tor-browser.git patch as well, then
 spoofing works again.

 It would be nice to write an automated test, but I'm not sure what the
 best approach is, as we need to be able to simulate an onion site or
 connect to a real one.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17334 [Applications/Tor Browser]: Move Referrer spoofing for .onion domains out of Torbutton

[Tor Bug Tracker & Wiki]

#17334: Move Referrer spoofing for .onion domains out of Torbutton
-+-
 Reporter:  gk   |  Owner:
 |  arthuredelstein
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton-conversion,|  Actual Points:
  TorBrowserTeam201609R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-

Comment (by mcs):

 Kathy and I reviewed this and it looks OK. We did not build and run the
 code. How much testing have you done?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17334 [Applications/Tor Browser]: Move Referrer spoofing for .onion domains out of Torbutton

[Tor Bug Tracker & Wiki]

#17334: Move Referrer spoofing for .onion domains out of Torbutton
-+-
 Reporter:  gk   |  Owner:
 |  arthuredelstein
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton-conversion,|  Actual Points:
  TorBrowserTeam201609R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-
Changes (by arthuredelstein):

 * status:  accepted => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17334 [Applications/Tor Browser]: Move Referrer spoofing for .onion domains out of Torbutton

[Tor Bug Tracker & Wiki]

#17334: Move Referrer spoofing for .onion domains out of Torbutton
-+-
 Reporter:  gk   |  Owner:
 |  arthuredelstein
 Type:  task | Status:
 |  accepted
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton-conversion,|  Actual Points:
  TorBrowserTeam201609R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-
Changes (by arthuredelstein):

 * owner:  tbb-team => arthuredelstein
 * status:  needs_review => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17334 [Applications/Tor Browser]: Move Referrer spoofing for .onion domains out of Torbutton

[Tor Bug Tracker & Wiki]

#17334: Move Referrer spoofing for .onion domains out of Torbutton
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton-conversion,|  Actual Points:
  TorBrowserTeam201609R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  SponsorU
-+-
Changes (by arthuredelstein):

 * keywords:  tbb-torbutton-conversion, TorBrowserTeam201609 => tbb-
 torbutton-conversion, TorBrowserTeam201609R
 * status:  new => needs_review
 * severity:   => Normal


Comment:

 Here are patches for review:
 https://github.com/arthuredelstein/tor-browser/commit/17334
 https://github.com/arthuredelstein/torbutton/commit/17334

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs