Re: [tor-bugs] #18802 [Tor Browser]: remove Shumway (JS-based Flash VM)

[Tor Bug Tracker & Wiki]

#18802: remove Shumway (JS-based Flash VM)
-+-
 Reporter:  mcs  |  Owner:  mcs
 Type:  defect   | Status:
 Priority:  Medium   |  needs_revision
Component:  Tor Browser  |  Milestone:
 Severity:  Normal   |Version:
 Keywords:  ff45-esr, tbb-6.0a5, | Resolution:
  TorBrowserTeam201604   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arthuredelstein):

 Replying to [comment:4 gk]:
 > It seems you got the nsBrowserGlue.js part wrong. And is there a reason
 to have
 > {{{
 > -browser/fuel/**
 > }}}
 > ?

 Thanks for catching those. I applied a fixup:
 ​https://github.com/arthuredelstein/tor-browser/commits/15197+11
 Hash: c734da3fde70f8818a94a5e3b93d34f0602d2cec

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18802 [Tor Browser]: remove Shumway (JS-based Flash VM)

[Tor Bug Tracker & Wiki]

#18802: remove Shumway (JS-based Flash VM)
-+-
 Reporter:  mcs  |  Owner:  mcs
 Type:  defect   | Status:
 Priority:  Medium   |  needs_revision
Component:  Tor Browser  |  Milestone:
 Severity:  Normal   |Version:
 Keywords:  ff45-esr, tbb-6.0a5, | Resolution:
  TorBrowserTeam201604   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  new => needs_revision


Comment:

 It seems you got the nsBrowserGlue.js part wrong. And is there a reason to
 have
 {{{
 -browser/fuel/**
 }}}
 ?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18802 [Tor Browser]: remove Shumway (JS-based Flash VM)

[Tor Bug Tracker & Wiki]

#18802: remove Shumway (JS-based Flash VM)
-+-
 Reporter:  mcs  |  Owner:  mcs
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Tor Browser  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff45-esr, tbb-6.0a5, |  Actual Points:
  TorBrowserTeam201604   | Points:
Parent ID:   |Sponsor:
 Reviewer:   |
-+-

Comment (by arthuredelstein):

 Replying to [comment:2 mcs]:
 > It looks like Shumway will be included in our nightly builds, which is
 not good (search for shumway inside browser/installer/package-
 manifest.in).
 >
 > Kathy and I think the best solution is to backport the three patches
 that are mentioned here:
 > https://bugzilla.mozilla.org/show_bug.cgi?id=1250046#c8
 >
 > Arthur, is this something you can do?

 Thanks for finding these patches -- I have cherry-picked/backported all
 three to
 https://github.com/arthuredelstein/tor-browser/commits/15197+11
 Hash: 1c110015f724eb69b9d0597aab20c2e43de44479

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18802 [Tor Browser]: remove Shumway (JS-based Flash VM)

[Tor Bug Tracker & Wiki]

#18802: remove Shumway (JS-based Flash VM)
-+-
 Reporter:  mcs  |  Owner:  mcs
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Tor Browser  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff45-esr, tbb-6.0a5, |  Actual Points:
  TorBrowserTeam201604   | Points:
Parent ID:   |Sponsor:
 Reviewer:   |
-+-
Changes (by mcs):

 * cc: arthuredelstein (added)


Comment:

 It looks like Shumway will be included in our nightly builds, which is not
 good (search for shumway inside browser/installer/package-manifest.in).

 Kathy and I think the best solution is to backport the three patches that
 are mentioned here:
 https://bugzilla.mozilla.org/show_bug.cgi?id=1250046#c8

 Arthur, is this something you can do?

 It looks like the patches apply fairly cleanly with the exception of the
 third patch. The problem there is that toolkit/components/telemetry
 /histogram-whitelists.json does not exist in the ESR45 tree; I think that
 part of the patch can just be skipped.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18802 [Tor Browser]: remove Shumway (JS-based Flash VM)

[Tor Bug Tracker & Wiki]

#18802: remove Shumway (JS-based Flash VM)
-+-
 Reporter:  mcs  |  Owner:  mcs
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Tor Browser  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff45-esr, tbb-6.0a5, |  Actual Points:
  TorBrowserTeam201604   | Points:
Parent ID:   |Sponsor:
 Reviewer:   |
-+-

Comment (by mcs):

 After ESR45, the Shumway files were removed from the Mozilla tree. See
 https://bugzilla.mozilla.org/show_bug.cgi?id=1250046

 Kathy and I still need to verify that it is not included in ESR45-based
 browsers.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs