Re: [tor-bugs] #18930 [Core Tor/Tor]: Segmentation fault: entry->parsed->intro_nodes

[Tor Bug Tracker & Wiki]

#18930: Segmentation fault: entry->parsed->intro_nodes
-+
 Reporter:  juha |  Owner:  andrea
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor: 0.3.???
Component:  Core Tor/Tor |Version:  Tor: 0.2.7.1-alpha
 Severity:  Normal   | Resolution:  user disappeared
 Keywords:  tor-hs, tor2web  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:  dgoulet  |Sponsor:
-+
Changes (by dgoulet):

 * status:  needs_information => closed
 * resolution:   => user disappeared


Comment:

 I'll go in user disappeared mode here as 7 months is a long time.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18930 [Core Tor/Tor]: Segmentation fault: entry->parsed->intro_nodes

[Tor Bug Tracker & Wiki]

#18930: Segmentation fault: entry->parsed->intro_nodes
-+
 Reporter:  juha |  Owner:  andrea
 Type:  defect   | Status:  needs_information
 Priority:  Medium   |  Milestone:  Tor: 0.2.???
Component:  Core Tor/Tor |Version:  Tor: 0.2.7.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, tor2web  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:  dgoulet  |Sponsor:
-+
Changes (by dgoulet):

 * keywords:  tor2web, crash, 028-backport => tor-hs, tor2web
 * milestone:  Tor: 0.2.9.x-final => Tor: 0.2.???


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18930 [Core Tor/Tor]: Segmentation fault: entry->parsed->intro_nodes

[Tor Bug Tracker & Wiki]

#18930: Segmentation fault: entry->parsed->intro_nodes
-+-
 Reporter:  juha |  Owner:  andrea
 Type:  defect   | Status:
 Priority:  Medium   |  needs_information
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.9.x-final
 Keywords:  tor2web, crash, TorCoreTeam201605|Version:  Tor:
  028-backport   |  0.2.7.1-alpha
Parent ID:   | Resolution:
 Reviewer:  dgoulet  |  Actual Points:
 | Points:  1
 |Sponsor:
-+-
Changes (by nickm):

 * keywords:  tor2web, crash, TorCoreTeam201605 => tor2web, crash,
 TorCoreTeam201605 028-backport
 * milestone:  Tor: 0.2.8.x-final => Tor: 0.2.9.x-final


Comment:

 we can take this in 0.2.9 and maybe even backport, if we get a fix.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18930 [Core Tor/Tor]: Segmentation fault: entry->parsed->intro_nodes

[Tor Bug Tracker & Wiki]

#18930: Segmentation fault: entry->parsed->intro_nodes
---+---
 Reporter:  juha   |  Owner:  andrea
 Type:  defect | Status:
 Priority:  Medium |  needs_information
Component:  Core Tor/Tor   |  Milestone:  Tor:
 Severity:  Normal |  0.2.8.x-final
 Keywords:  tor2web, crash, TorCoreTeam201605  |Version:  Tor:
Parent ID: |  0.2.7.1-alpha
 Reviewer:  dgoulet| Resolution:
   |  Actual Points:
   | Points:  1
   |Sponsor:
---+---
Changes (by nickm):

 * keywords:  tor2web, crash, must-fix-before-028-rc, TorCoreTeam201605 =>
 tor2web, crash, TorCoreTeam201605


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18930 [Core Tor/Tor]: Segmentation fault: entry->parsed->intro_nodes

[Tor Bug Tracker & Wiki]

#18930: Segmentation fault: entry->parsed->intro_nodes
-+-
 Reporter:  juha |  Owner:  andrea
 Type:  defect   | Status:
 Priority:  Medium   |  needs_information
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Normal   |  0.2.8.x-final
 Keywords:  tor2web, crash, must-fix-|Version:  Tor:
  before-028-rc, TorCoreTeam201605   |  0.2.7.1-alpha
Parent ID:   | Resolution:
 Reviewer:  dgoulet  |  Actual Points:
 | Points:  1
 |Sponsor:
-+-
Changes (by dgoulet):

 * cc: dgoulet (removed)
 * reviewer:   => dgoulet
 * status:  assigned => needs_information
 * severity:  Critical => Normal


Comment:

 We are still waiting on more information from juha here.

 The `i = 32767` value is super high... There is no chance we have that
 amount of usable intro points so probably that
 `entry->parsed->intro_nodes` has never been cleaned or a crazy amount of
 nodes have been added.

 {{{
   i = crypto_rand_int(smartlist_len(usable_nodes));
   intro = smartlist_get(usable_nodes, i);
 }}}

 Also this: `intro = 0x1` is simply not possible... So I think we don't
 have an accurate backtrace here.
 This tor version is not from the tor repository thus no way I can confirm
 anything... Putting this one in `needs_information`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18930 [Core Tor/Tor]: Segmentation fault: entry->parsed->intro_nodes

[Tor Bug Tracker & Wiki]

#18930: Segmentation fault: entry->parsed->intro_nodes
-+-
 Reporter:  juha |  Owner:  andrea
 Type:  defect   | Status:
 Priority:  Medium   |  assigned
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Critical |  0.2.8.x-final
 Keywords:  tor2web, crash, must-fix-|Version:  Tor:
  before-028-rc, TorCoreTeam201605   |  0.2.7.1-alpha
Parent ID:   | Resolution:
 Reviewer:   |  Actual Points:
 | Points:  small
 |Sponsor:
-+-
Changes (by andrea):

 * status:  needs_information => assigned
 * owner:   => andrea


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18930 [Core Tor/Tor]: Segmentation fault: entry->parsed->intro_nodes

[Tor Bug Tracker & Wiki]

#18930: Segmentation fault: entry->parsed->intro_nodes
-+-
 Reporter:  juha |  Owner:
 Type:  defect   | Status:
 Priority:  Medium   |  needs_information
Component:  Core Tor/Tor |  Milestone:  Tor:
 Severity:  Critical |  0.2.8.x-final
 Keywords:  tor2web, crash, must-fix-|Version:  Tor:
  before-028-rc, TorCoreTeam201605   |  0.2.7.1-alpha
Parent ID:   | Resolution:
 Reviewer:   |  Actual Points:
 | Points:  small
 |Sponsor:
-+-
Changes (by nickm):

 * status:  new => needs_information


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18930 [Core Tor/Tor]: Segmentation fault: entry->parsed->intro_nodes

[Tor Bug Tracker & Wiki]

#18930: Segmentation fault: entry->parsed->intro_nodes
-+-
 Reporter:  juha |  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
Component:  Core Tor/Tor |  0.2.8.x-final
 Severity:  Critical |Version:  Tor:
 Keywords:  tor2web, crash, must-fix-|  0.2.7.1-alpha
  before-028-rc, TorCoreTeam201605   | Resolution:
Parent ID:   |  Actual Points:
 Reviewer:   | Points:  small
 |Sponsor:
-+-
Changes (by bugzilla):

 * keywords:
 tor2web, crash, CoreTorTeam201605, must-fix-before-028-rc,
 TorCoreTeam201605
 => tor2web, crash, must-fix-before-028-rc, TorCoreTeam201605


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18930 [Core Tor/Tor]: Segmentation fault: entry->parsed->intro_nodes

[Tor Bug Tracker & Wiki]

#18930: Segmentation fault: entry->parsed->intro_nodes
-+-
 Reporter:  juha |  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
Component:  Core Tor/Tor |  0.2.8.x-final
 Severity:  Critical |Version:  Tor:
 Keywords:  tor2web crash CoreTorTeam201605  |  0.2.7.1-alpha
  must-fix-before-028-rc | Resolution:
Parent ID:   |  Actual Points:
 Reviewer:   | Points:  small
 |Sponsor:
-+-

Comment (by nickm):

 Another question: 605ae665009853bd isn't a version of Tor that's in our
 repository, as far as I know.  Where did you get your Tor?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18930 [Core Tor/Tor]: Segmentation fault: entry->parsed->intro_nodes

[Tor Bug Tracker & Wiki]

#18930: Segmentation fault: entry->parsed->intro_nodes
-+-
 Reporter:  juha |  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
Component:  Core Tor/Tor |  0.2.8.x-final
 Severity:  Critical |Version:  Tor:
 Keywords:  tor2web crash CoreTorTeam201605  |  0.2.7.1-alpha
  must-fix-before-028-rc | Resolution:
Parent ID:   |  Actual Points:
 Reviewer:   | Points:  small
 |Sponsor:
-+-
Changes (by teor):

 * keywords:  tor2web crash CoreTorTeam201605 => tor2web crash
 CoreTorTeam201605 must-fix-before-028-rc


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18930 [Core Tor/Tor]: Segmentation fault: entry->parsed->intro_nodes

[Tor Bug Tracker & Wiki]

#18930: Segmentation fault: entry->parsed->intro_nodes
-+-
 Reporter:  juha |  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
Component:  Core Tor/Tor |  0.2.8.x-final
 Severity:  Critical |Version:  Tor:
 Keywords:  tor2web crash CoreTorTeam201605  |  0.2.7.1-alpha
Parent ID:   | Resolution:
 Reviewer:   |  Actual Points:
 | Points:  small
 |Sponsor:
-+-
Changes (by teor):

 * keywords:  tor2web crash => tor2web crash CoreTorTeam201605


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18930 [Core Tor/Tor]: Segmentation fault: entry->parsed->intro_nodes

[Tor Bug Tracker & Wiki]

#18930: Segmentation fault: entry->parsed->intro_nodes
---+
 Reporter:  juha   |  Owner:
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.2.8.x-final
Component:  Core Tor/Tor   |Version:  Tor: 0.2.7.1-alpha
 Severity:  Critical   | Resolution:
 Keywords:  tor2web crash  |  Actual Points:
Parent ID: | Points:  small
 Reviewer: |Sponsor:
---+
Changes (by teor):

 * version:  Tor: 0.2.7.6 => Tor: 0.2.7.1-alpha


Comment:

 This bug was likely introduced in commit 59f8dced in 0.2.7.1-alpha.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18930 [Core Tor/Tor]: Segmentation fault: entry->parsed->intro_nodes

[Tor Bug Tracker & Wiki]

#18930: Segmentation fault: entry->parsed->intro_nodes
---+
 Reporter:  juha   |  Owner:
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  Tor: 0.2.8.x-final
Component:  Core Tor/Tor   |Version:  Tor: 0.2.7.6
 Severity:  Critical   | Resolution:
 Keywords:  tor2web crash  |  Actual Points:
Parent ID: | Points:  small
 Reviewer: |Sponsor:
---+
Changes (by teor):

 * cc: dgoulet (added)
 * keywords:  tor2web => tor2web crash
 * points:   => small
 * severity:  Normal => Critical
 * milestone:   => Tor: 0.2.8.x-final


Comment:

 '''Further Information'''

 The line numbers in your backtrace don't seem to be the same as the line
 numbers I have for 0.2.7.6. I'm going to assume they're wrong, and work
 off the code listings.

 It might help to provide the last few entries from an info-level or debug-
 level log.

 `query=0x568ea1f0 "oahmssjdnck7ntzx") at src/or/rendclient.c:1217`
 The hidden service in question is oahmssjdnck7ntzx.onion, it appears to be
 down.
 (I've attached a stem script to fetch its descriptor, it says:
 `stem.DescriptorUnavailable: No running hidden service at
 oahmssjdnck7ntzx.onion`.)

 Can you tell us if it's always the same hidden service causing the crash?

 '''Analysis'''

 The calls in this backtrace were removed in 0.2.8.2-alpha by dgoulet to
 fix #15937, a bug where tor over-enthusiastically cancelled connections if
 too many requests happened for the same hidden services in a short period
 of time.

 This bug could cause all sorts of problems for busy tor2web instances
 connecting to busy hidden services. I can't see any obvious issues in the
 code, but I'd like others to have a look at:
 * rend_client_refetch_v2_renddesc (0.2.7.6)
 * rend_client_desc_trynow
 * rend_cache_lookup_entry
 * I wouldn't bother looking in detail at
 rend_client_any_intro_points_usable, as it crashes on the first line that
 tries to use a corrupt or NULL entry.

 I wonder if you've found a race condition or something?

 '''Suggested Solutions'''

 You could try applying that patch from #15937 and see if it fixes your
 issue.
 You could also try running 0.2.8.2-alpha, it should work for Tor2web, but
 it's still a little unstable.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18930 [Core Tor/Tor]: Segmentation fault: entry->parsed->intro_nodes

[Tor Bug Tracker & Wiki]

#18930: Segmentation fault: entry->parsed->intro_nodes
--+--
 Reporter:  juha  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:  Tor: 0.2.7.6
 Severity:  Normal| Resolution:
 Keywords:  tor2web   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by arma):

 * component:  - Select a component => Core Tor/Tor


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs