Re: [tor-bugs] #19552 [Core Tor/Tor]: Provide mechanism to find dirconns associated with a download_status_t, and expose active download attempts in GETINFO response

[Tor Bug Tracker & Wiki]

#19552: Provide mechanism to find dirconns associated with a download_status_t, 
and
expose active download attempts in GETINFO response
-+-
 Reporter:  andrea   |  Owner:  (none)
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-unit-tests tor-control   |  Actual Points:  4
  directory download |
Parent ID:   | Points:  2
 Reviewer:  nickm|Sponsor:
 |  SponsorS-can
-+-
Changes (by dgoulet):

 * status:  new => assigned
 * owner:  andrea => (none)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19552 [Core Tor/Tor]: Provide mechanism to find dirconns associated with a download_status_t, and expose active download attempts in GETINFO response

[Tor Bug Tracker & Wiki]

#19552: Provide mechanism to find dirconns associated with a download_status_t, 
and
expose active download attempts in GETINFO response
-+-
 Reporter:  andrea   |  Owner:  andrea
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-unit-tests tor-control   |  Actual Points:  4
  directory download |
Parent ID:   | Points:  2
 Reviewer:  nickm|Sponsor:
 |  SponsorS-can
-+-
Changes (by nickm):

 * keywords:  tor-unit-tests => tor-unit-tests tor-control directory
   download


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19552 [Core Tor/Tor]: Provide mechanism to find dirconns associated with a download_status_t, and expose active download attempts in GETINFO response

[Tor Bug Tracker & Wiki]

#19552: Provide mechanism to find dirconns associated with a download_status_t, 
and
expose active download attempts in GETINFO response
-+-
 Reporter:  andrea   |  Owner:  andrea
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-unit-tests, TorCoreTeam201608,   |  Actual Points:  4
  review-group-8 |
Parent ID:   | Points:  2
 Reviewer:  nickm|Sponsor:
 |  SponsorS-can
-+-
Changes (by nickm):

 * status:  needs_review => needs_revision
 * reviewer:   => nickm


Comment:

 I've added a bunch of comments at the gitlab.  Many are for issues you
 fixed later; only a few actually need changing.

 Actual-review-points: .1

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19552 [Core Tor/Tor]: Provide mechanism to find dirconns associated with a download_status_t, and expose active download attempts in GETINFO response

[Tor Bug Tracker & Wiki]

#19552: Provide mechanism to find dirconns associated with a download_status_t, 
and
expose active download attempts in GETINFO response
-+-
 Reporter:  andrea   |  Owner:  andrea
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-unit-tests, TorCoreTeam201608,   |  Actual Points:  4
  review-group-8 |
Parent ID:   | Points:  2
 Reviewer:   |Sponsor:
 |  SponsorS-can
-+-

Comment (by nickm):

 I put it at gitlab over here for review:
 https://gitlab.com/nickm_tor/tor/merge_requests/6/commits

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19552 [Core Tor/Tor]: Provide mechanism to find dirconns associated with a download_status_t, and expose active download attempts in GETINFO response

[Tor Bug Tracker & Wiki]

#19552: Provide mechanism to find dirconns associated with a download_status_t, 
and
expose active download attempts in GETINFO response
---+---
 Reporter:  andrea |  Owner:  andrea
 Type:  defect | Status:
   |  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.2.9.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-unit-tests, TorCoreTeam201608  |  Actual Points:  4
Parent ID: | Points:  2
 Reviewer: |Sponsor:  SponsorS-
   |  can
---+---

Comment (by andrea):

 Attaching proposed spec patch

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19552 [Core Tor/Tor]: Provide mechanism to find dirconns associated with a download_status_t, and expose active download attempts in GETINFO response

[Tor Bug Tracker & Wiki]

#19552: Provide mechanism to find dirconns associated with a download_status_t, 
and
expose active download attempts in GETINFO response
---+---
 Reporter:  andrea |  Owner:  andrea
 Type:  defect | Status:
   |  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.2.9.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-unit-tests, TorCoreTeam201608  |  Actual Points:  4
Parent ID: | Points:  2
 Reviewer: |Sponsor:  SponsorS-
   |  can
---+---
Changes (by andrea):

 * status:  assigned => needs_review


Comment:

 Unit-tested and ready for review in my ticket19552_squashed branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19552 [Core Tor/Tor]: Provide mechanism to find dirconns associated with a download_status_t, and expose active download attempts in GETINFO response

[Tor Bug Tracker & Wiki]

#19552: Provide mechanism to find dirconns associated with a download_status_t, 
and
expose active download attempts in GETINFO response
---+---
 Reporter:  andrea |  Owner:  andrea
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:  Tor:
   |  0.2.9.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-unit-tests, TorCoreTeam201608  |  Actual Points:  4
Parent ID: | Points:  2
 Reviewer: |Sponsor:  SponsorS-
   |  can
---+---
Changes (by andrea):

 * actualpoints:  3 => 4


Comment:

 Branch now done except for control-spec-change-requiring bit (i.e.
 outputting info on dirconns for a download on the control port) and unit
 tests, but not yet uploaded since I'm away from my private key.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19552 [Core Tor/Tor]: Provide mechanism to find dirconns associated with a download_status_t, and expose active download attempts in GETINFO response

[Tor Bug Tracker & Wiki]

#19552: Provide mechanism to find dirconns associated with a download_status_t, 
and
expose active download attempts in GETINFO response
---+---
 Reporter:  andrea |  Owner:  andrea
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:  Tor:
   |  0.2.9.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-unit-tests, TorCoreTeam201608  |  Actual Points:  3
Parent ID: | Points:  2
 Reviewer: |Sponsor:  SponsorS-
   |  can
---+---
Changes (by andrea):

 * actualpoints:   => 3


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19552 [Core Tor/Tor]: Provide mechanism to find dirconns associated with a download_status_t, and expose active download attempts in GETINFO response

[Tor Bug Tracker & Wiki]

#19552: Provide mechanism to find dirconns associated with a download_status_t, 
and
expose active download attempts in GETINFO response
---+---
 Reporter:  andrea |  Owner:  andrea
 Type:  defect | Status:  assigned
 Priority:  Medium |  Milestone:  Tor:
   |  0.2.9.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-unit-tests, TorCoreTeam201608  |  Actual Points:
Parent ID: | Points:  2
 Reviewer: |Sponsor:  SponsorS-
   |  can
---+---

Comment (by andrea):

 Status update: mechanism for three out of four query types in my
 ticket19552 branch; still needs cert/signing key dirconn mechanism and to
 be wired up in control.c, and unit tests.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19552 [Core Tor/Tor]: Provide mechanism to find dirconns associated with a download_status_t, and expose active download attempts in GETINFO response

[Tor Bug Tracker & Wiki]

#19552: Provide mechanism to find dirconns associated with a download_status_t, 
and
expose active download attempts in GETINFO response
--+
 Reporter:  andrea|  Owner:  andrea
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor:
Component:  Core Tor/Tor  |  0.2.9.x-final
 Severity:  Normal|Version:
 Keywords:  tor-unit-tests TorCoreTeam201607  | Resolution:
Parent ID:|  Actual Points:
 Reviewer:| Points:  2
  |Sponsor:  SponsorS-
  |  can
--+

Comment (by andrea):

 This is going to end up just reporting how many active dirconns there are,
 I think; I've got the machinery to build lists of them for the download
 status queries, but the right approach to exposing more than a count is a
 way to provide a token usable with a more general connection-status query
 mechanism, and the existing control-port spec is pretty short on those.
 The only connection status query it seems to offer is /orconn-status to
 get a list of orconns.  If we care about this perhaps we should consider
 building a more general-purpose mechanism, but I think adding "
 downloads active" satisfies the original intent of this ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19552 [Core Tor/Tor]: Provide mechanism to find dirconns associated with a download_status_t, and expose active download attempts in GETINFO response

[Tor Bug Tracker & Wiki]

#19552: Provide mechanism to find dirconns associated with a download_status_t, 
and
expose active download attempts in GETINFO response
--+
 Reporter:  andrea|  Owner:  andrea
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor:
Component:  Core Tor/Tor  |  0.2.9.x-final
 Severity:  Normal|Version:
 Keywords:  tor-unit-tests TorCoreTeam201607  | Resolution:
Parent ID:|  Actual Points:
 Reviewer:| Points:  2
  |Sponsor:  SponsorS-
  |  can
--+
Changes (by nickm):

 * status:  new => assigned
 * keywords:   => tor-unit-tests TorCoreTeam201607
 * sponsor:   => SponsorS-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs