Re: [tor-bugs] #19783 [Applications/Tor Browser]: Typo in build helpers: `MAXOSX_DEPLOYEMENT_TARGET`

[Tor Bug Tracker & Wiki]

#19783: Typo in build helpers: `MAXOSX_DEPLOYEMENT_TARGET`
-+-
 Reporter:  dcf  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Minor| Resolution:  fixed
 Keywords:  tbb-gitian, ff52-esr,|  Actual Points:
  TorBrowserTeam201704R  |
Parent ID:  #21328   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 This is commit d744cac29e8df0efaf1a6bb3a626be90e930c118 on `master`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19783 [Applications/Tor Browser]: Typo in build helpers: `MAXOSX_DEPLOYEMENT_TARGET`

[Tor Bug Tracker & Wiki]

#19783: Typo in build helpers: `MAXOSX_DEPLOYEMENT_TARGET`
-+-
 Reporter:  dcf  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Minor| Resolution:
 Keywords:  tbb-gitian, TorBrowserTeam201703R,   |  Actual Points:
  ff52-esr   |
Parent ID:  #21328   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by boklm):

 Replying to [comment:6 gk]:
 > `bug_19783` (https://gitweb.torproject.org/user/gk/tor-browser-
 bundle.git/commit/?h=bug_19783=85693f597f65269daf49d9d93f129f9cabe673ce)
 has a commit that removes those helper scripts. It is on top of the fixes
 for #10369 and #21753.

 This looks good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19783 [Applications/Tor Browser]: Typo in build helpers: `MAXOSX_DEPLOYEMENT_TARGET`

[Tor Bug Tracker & Wiki]

#19783: Typo in build helpers: `MAXOSX_DEPLOYEMENT_TARGET`
-+-
 Reporter:  dcf  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Minor| Resolution:
 Keywords:  tbb-gitian, TorBrowserTeam201703R,   |  Actual Points:
  ff52-esr   |
Parent ID:  #21328   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  new => needs_review
 * keywords:  tbb-gitian, TorBrowserTeam201703, ff52-esr => tbb-gitian,
 TorBrowserTeam201703R, ff52-esr


Comment:

 `bug_19783` (https://gitweb.torproject.org/user/gk/tor-browser-
 bundle.git/commit/?h=bug_19783=85693f597f65269daf49d9d93f129f9cabe673ce)
 has a commit that removes those helper scripts. It is on top of the fixes
 for #10369 and #21753.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19783 [Applications/Tor Browser]: Typo in build helpers: `MAXOSX_DEPLOYEMENT_TARGET`

[Tor Bug Tracker & Wiki]

#19783: Typo in build helpers: `MAXOSX_DEPLOYEMENT_TARGET`
-+-
 Reporter:  dcf  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Minor| Resolution:
 Keywords:  tbb-gitian, TorBrowserTeam201703,|  Actual Points:
  ff52-esr   |
Parent ID:  #21328   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * parent:   => #21328


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19783 [Applications/Tor Browser]: Typo in build helpers: `MAXOSX_DEPLOYEMENT_TARGET`

[Tor Bug Tracker & Wiki]

#19783: Typo in build helpers: `MAXOSX_DEPLOYEMENT_TARGET`
-+-
 Reporter:  dcf  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Minor| Resolution:
 Keywords:  tbb-gitian, TorBrowserTeam201703,|  Actual Points:
  ff52-esr   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 And even better would be to get rid of those helper script in the first
 place by moving the remaining parts to our clang-based cross-compile
 setup. We are close.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19783 [Applications/Tor Browser]: Typo in build helpers: `MAXOSX_DEPLOYEMENT_TARGET`

[Tor Bug Tracker & Wiki]

#19783: Typo in build helpers: `MAXOSX_DEPLOYEMENT_TARGET`
-+-
 Reporter:  dcf  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Minor| Resolution:
 Keywords:  tbb-gitian, TorBrowserTeam201703,|  Actual Points:
  ff52-esr   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-gitian, TorBrowserTeam201703, tbb-7.0-must => tbb-gitian,
 TorBrowserTeam201703, ff52-esr


Comment:

 I am fine with removing that as well. It might actually be the better way
 to handle this bug as 10.7 is the default anyway.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19783 [Applications/Tor Browser]: Typo in build helpers: `MAXOSX_DEPLOYEMENT_TARGET`

[Tor Bug Tracker & Wiki]

#19783: Typo in build helpers: `MAXOSX_DEPLOYEMENT_TARGET`
-+-
 Reporter:  dcf  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Minor| Resolution:
 Keywords:  tbb-gitian, TorBrowserTeam201703,|  Actual Points:
  tbb-7.0-must   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-gitian => tbb-gitian, TorBrowserTeam201703, tbb-7.0-must


Comment:

 That's supposed to be 10.7 since
 https://bugzilla.mozilla.org/show_bug.cgi?id=1269790. We should fix the
 typo and adapt that while transitioning to ESR 52

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19783 [Applications/Tor Browser]: Typo in build helpers: `MAXOSX_DEPLOYEMENT_TARGET`

[Tor Bug Tracker & Wiki]

#19783: Typo in build helpers: `MAXOSX_DEPLOYEMENT_TARGET`
--+--
 Reporter:  dcf   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Minor | Resolution:
 Keywords:  tbb-gitian|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * keywords:   => tbb-gitian


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs