Re: [tor-bugs] #20424 [Core Tor/Tor]: Remove --enable-openbsd-malloc (Tor maxes CPU when --enable-openbsd-malloc is used)

[Tor Bug Tracker & Wiki]

#20424: Remove --enable-openbsd-malloc (Tor maxes CPU when 
--enable-openbsd-malloc
is used)
-+-
 Reporter:  icanhasaccount   |  Owner:  (none)
 Type:  defect   | Status:  closed
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:  fixed
 Keywords:  review-group-31, |  Actual Points:
  034-triage-20180328, fast-fix, 035-triaged-|
  in-20180711|
Parent ID:   | Points:  .2
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 I've merged fix_nonstandard_malloc_029 to 0.2.9 and forward.

 I've squashed with_malloc and merged it to master, then added a commit in
 `5597ddc36047a4` to mark openbsd-malloc as deprecated.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20424 [Core Tor/Tor]: Remove --enable-openbsd-malloc (Tor maxes CPU when --enable-openbsd-malloc is used)

[Tor Bug Tracker & Wiki]

#20424: Remove --enable-openbsd-malloc (Tor maxes CPU when 
--enable-openbsd-malloc
is used)
-+-
 Reporter:  icanhasaccount   |  Owner:  (none)
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  review-group-31, |  Actual Points:
  034-triage-20180328, fast-fix, 035-triaged-|
  in-20180711|
Parent ID:   | Points:  .2
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 - https://github.com/torproject/tor/pull/224 - looks good to me. The
 Travis failure looks like it was an issue that was already fixed.
 - https://github.com/torproject/tor/pull/225 - looks good.
 - https://github.com/torproject/tor/pull/226 - looks good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20424 [Core Tor/Tor]: Remove --enable-openbsd-malloc (Tor maxes CPU when --enable-openbsd-malloc is used)

[Tor Bug Tracker & Wiki]

#20424: Remove --enable-openbsd-malloc (Tor maxes CPU when 
--enable-openbsd-malloc
is used)
-+-
 Reporter:  icanhasaccount   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  review-group-31, |  Actual Points:
  034-triage-20180328, fast-fix, 035-triaged-|
  in-20180711|
Parent ID:   | Points:  .2
 Reviewer:  ahf  |Sponsor:
-+-
Changes (by dgoulet):

 * reviewer:   => ahf


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20424 [Core Tor/Tor]: Remove --enable-openbsd-malloc (Tor maxes CPU when --enable-openbsd-malloc is used)

[Tor Bug Tracker & Wiki]

#20424: Remove --enable-openbsd-malloc (Tor maxes CPU when 
--enable-openbsd-malloc
is used)
-+-
 Reporter:  icanhasaccount   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  review-group-31, |  Actual Points:
  034-triage-20180328, fast-fix, 035-triaged-|
  in-20180711|
Parent ID:   | Points:  .2
 Reviewer:   |Sponsor:
-+-

Comment (by Hello71):

 OK, thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20424 [Core Tor/Tor]: Remove --enable-openbsd-malloc (Tor maxes CPU when --enable-openbsd-malloc is used)

[Tor Bug Tracker & Wiki]

#20424: Remove --enable-openbsd-malloc (Tor maxes CPU when 
--enable-openbsd-malloc
is used)
-+-
 Reporter:  icanhasaccount   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  review-group-31, |  Actual Points:
  034-triage-20180328, fast-fix, 035-triaged-|
  in-20180711|
Parent ID:   | Points:  .2
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 ok, added a squash commit to fix ticket number and credit you in the form
 you prefer.

 (FYI, our house style has been to put pseudonyms that don't look like
 names into quotation marks, since not doing so has caused confusion in the
 past with strings like "patch from randomguessing" or "patch from Some
 Guy".)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20424 [Core Tor/Tor]: Remove --enable-openbsd-malloc (Tor maxes CPU when --enable-openbsd-malloc is used)

[Tor Bug Tracker & Wiki]

#20424: Remove --enable-openbsd-malloc (Tor maxes CPU when 
--enable-openbsd-malloc
is used)
-+-
 Reporter:  icanhasaccount   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  review-group-31, |  Actual Points:
  034-triage-20180328, fast-fix, 035-triaged-|
  in-20180711|
Parent ID:   | Points:  .2
 Reviewer:   |Sponsor:
-+-

Comment (by Hello71):

 Replying to [comment:35 nickm]:
 > Let's try to get this unstuck, by disentangling the various options.
 >
 > I've made a branch `remove_openbsd_malloc` that ports icanhasaccount's
 removal code to master if we decide to do that.  PR at
 https://github.com/torproject/tor/pull/224 . Not my preferred approach.
 >
 > And I've made a branch called `with_malloc` that ports the parts of
 Hello71's patch that I agree with to master: it adds --with-malloc=,
 doesn't change our default, doesn't break old configure options, and keeps
 openbsd malloc as an option.  Works for me, but probably needs more review
 and testing. PR at https://github.com/torproject/tor/pull/225 .
 >
 > The above two branches apply to master only and are mutually exclusive,
 though we could probably combine them into one.
 >
 > For backport purposes, I have a branch `fix_nonstandard_malloc_029` that
 only does the minimum needed to fix the originally supported issue. PR at
 https://github.com/torproject/tor/pull/226 . Works for me.

 Thanks for fixing my patch and giving credit, but I'd appreciate it if you
 called me Alex Xu in changelog, or at least not put my nick in quotation
 marks (looks like scare quotes to me). Also, I think you put too many twos
 in the change file.

 On the patch itself, I did actually test what happens when Rust is linked
 in: it works fine. I think Rust probably uses the system allocator on
 Linux, so replacing the malloc this way in glibc should also replace the
 Rust allocator and everything works fine.

 Also, I'm not sure it's a good idea to leave all of these options in if
 nobody is actually going to test them (as shown by openbsd malloc being
 broken by all this time and nobody really caring that much to fix it).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20424 [Core Tor/Tor]: Remove --enable-openbsd-malloc (Tor maxes CPU when --enable-openbsd-malloc is used)

[Tor Bug Tracker & Wiki]

#20424: Remove --enable-openbsd-malloc (Tor maxes CPU when 
--enable-openbsd-malloc
is used)
-+-
 Reporter:  icanhasaccount   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  review-group-31, |  Actual Points:
  034-triage-20180328, fast-fix, 035-triaged-|
  in-20180711|
Parent ID:   | Points:  .2
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_revision => needs_review
 * reviewer:  nickm =>


Comment:

 Let's try to get this unstuck, by disentangling the various options.

 I've made a branch `remove_openbsd_malloc` that ports icanhasaccount's
 removal code to master if we decide to do that.  PR at
 https://github.com/torproject/tor/pull/224 . Not my preferred approach.

 And I've made a branch called `with_malloc` that ports the parts of
 Hello71's patch that I agree with to master: it adds --with-malloc=,
 doesn't change our default, doesn't break old configure options, and keeps
 openbsd malloc as an option.  Works for me, but probably needs more review
 and testing. PR at https://github.com/torproject/tor/pull/225 .

 The above two branches apply to master only and are mutually exclusive,
 though we could probably combine them into one.

 For backport purposes, I have a branch `fix_nonstandard_malloc_029` that
 only does the minimum needed to fix the originally supported issue. PR at
 https://github.com/torproject/tor/pull/226 . Works for me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20424 [Core Tor/Tor]: Remove --enable-openbsd-malloc (Tor maxes CPU when --enable-openbsd-malloc is used)

[Tor Bug Tracker & Wiki]

#20424: Remove --enable-openbsd-malloc (Tor maxes CPU when 
--enable-openbsd-malloc
is used)
-+-
 Reporter:  icanhasaccount   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  review-group-31, |  Actual Points:
  034-triage-20180328, fast-fix  |
Parent ID:   | Points:  .2
 Reviewer:  nickm|Sponsor:
-+-

Comment (by cypherpunks):

 They use jemalloc for Windows? I was under the impression Windows used the
 system malloc. And yeah I know newer versions of jemalloc are improved
 (redzones, etc), but I'm still a little weary, especially given that
 OpenBSD's malloc is actually really well-designed from a security
 standpoint. Though honestly the Copperhead malloc (a hybrid of bionic and
 OpenBSD's) is even better, but I feel it's unlikely that it would be
 included in Tor.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20424 [Core Tor/Tor]: Remove --enable-openbsd-malloc (Tor maxes CPU when --enable-openbsd-malloc is used)

[Tor Bug Tracker & Wiki]

#20424: Remove --enable-openbsd-malloc (Tor maxes CPU when 
--enable-openbsd-malloc
is used)
-+-
 Reporter:  icanhasaccount   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  review-group-31, |  Actual Points:
  034-triage-20180328, fast-fix  |
Parent ID:   | Points:  .2
 Reviewer:  nickm|Sponsor:
-+-

Comment (by Hello71):

 additionally, starting with 5, jemalloc now uses extent based allocation,
 so from what I understand, ASLR will be just as good as with other
 allocators.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20424 [Core Tor/Tor]: Remove --enable-openbsd-malloc (Tor maxes CPU when --enable-openbsd-malloc is used)

[Tor Bug Tracker & Wiki]

#20424: Remove --enable-openbsd-malloc (Tor maxes CPU when 
--enable-openbsd-malloc
is used)
-+-
 Reporter:  icanhasaccount   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  review-group-31, |  Actual Points:
  034-triage-20180328, fast-fix  |
Parent ID:   | Points:  .2
 Reviewer:  nickm|Sponsor:
-+-

Comment (by Hello71):

 I asked Firefox people and they said that Firefox uses "jemalloc for
 Windows/Mac/Linux/Android, system malloc on iOS".

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20424 [Core Tor/Tor]: Remove --enable-openbsd-malloc (Tor maxes CPU when --enable-openbsd-malloc is used)

[Tor Bug Tracker & Wiki]

#20424: Remove --enable-openbsd-malloc (Tor maxes CPU when 
--enable-openbsd-malloc
is used)
-+-
 Reporter:  icanhasaccount   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.5.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  review-group-31, |  Actual Points:
  034-triage-20180328, fast-fix  |
Parent ID:   | Points:  .2
 Reviewer:  nickm|Sponsor:
-+-

Comment (by cypherpunks):

 I'd like to point out that jemalloc has more issues with security than
 either ptmalloc or OpenBSD's malloc. The large, aligned heaps make ASLR
 less effective (and that's one reason why Firefox on *nix machines is so
 much easier to compromise than on Windows).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20424 [Core Tor/Tor]: Remove --enable-openbsd-malloc (Tor maxes CPU when --enable-openbsd-malloc is used)

[Tor Bug Tracker & Wiki]

#20424: Remove --enable-openbsd-malloc (Tor maxes CPU when 
--enable-openbsd-malloc
is used)
-+-
 Reporter:  icanhasaccount   |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  review-group-31, |  Actual Points:
  034-triage-20180328, fast-fix  |
Parent ID:   | Points:  .2
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * keywords:  review-group-31, 034-triage-20180328, 034-removed-20180328 =>
 review-group-31, 034-triage-20180328, fast-fix


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20424 [Core Tor/Tor]: Remove --enable-openbsd-malloc (Tor maxes CPU when --enable-openbsd-malloc is used)

[Tor Bug Tracker & Wiki]

#20424: Remove --enable-openbsd-malloc (Tor maxes CPU when 
--enable-openbsd-malloc
is used)
-+
 Reporter:  icanhasaccount   |  Owner:  (none)
 Type:  defect   | Status:  needs_revision
 Priority:  Low  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  review-group-31  |  Actual Points:
Parent ID:   | Points:  .2
 Reviewer:  nickm|Sponsor:
-+

Comment (by Hello71):

 I still need to test what happens when rust is linked in.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20424 [Core Tor/Tor]: Remove --enable-openbsd-malloc (Tor maxes CPU when --enable-openbsd-malloc is used)

[Tor Bug Tracker & Wiki]

#20424: Remove --enable-openbsd-malloc (Tor maxes CPU when 
--enable-openbsd-malloc
is used)
-+
 Reporter:  icanhasaccount   |  Owner:  (none)
 Type:  defect   | Status:  needs_revision
 Priority:  Low  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  review-group-31  |  Actual Points:
Parent ID:   | Points:  .2
 Reviewer:  nickm|Sponsor:
-+

Comment (by Hello71):

 I wanted to put all of the allocator-related configure.ac code together. I
 tested at least one of the versions of the patches both with and without
 jemalloc installed, but I only tested on Linux. The plan was to remove
 openbsd malloc first. I see no benefit to using it over jemalloc.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20424 [Core Tor/Tor]: Remove --enable-openbsd-malloc (Tor maxes CPU when --enable-openbsd-malloc is used)

[Tor Bug Tracker & Wiki]

#20424: Remove --enable-openbsd-malloc (Tor maxes CPU when 
--enable-openbsd-malloc
is used)
-+
 Reporter:  icanhasaccount   |  Owner:  (none)
 Type:  defect   | Status:  needs_revision
 Priority:  Low  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  review-group-31  |  Actual Points:
Parent ID:   | Points:  .2
 Reviewer:  nickm|Sponsor:
-+
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 (I'm guessing that the second patch should be applied _without_ the first,
 right?)

 I like this patch, but I'm not so sure about having jemalloc be the
 default right away.  Let's let people test it as an option before we
 decide it's the best choice for everyone. Also, if I'm reading the patch
 right, this code will break on Linux if jemalloc isn't installed, which
 probably isn't what you'd intended?

 Other questions:
   * Why move the mlockall check?
   * Why does the patch move dmalloc?  Have you tested this?  Does it work?
   * Where and how have you tested this patch?

 Other notes:
   * This will need a changes file, explaining to people how to use this
 feature.
   * We'll still want to remove the openbsd_malloc code.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20424 [Core Tor/Tor]: Remove --enable-openbsd-malloc (Tor maxes CPU when --enable-openbsd-malloc is used)

[Tor Bug Tracker & Wiki]

#20424: Remove --enable-openbsd-malloc (Tor maxes CPU when 
--enable-openbsd-malloc
is used)
-+
 Reporter:  icanhasaccount   |  Owner:  (none)
 Type:  defect   | Status:  needs_review
 Priority:  Low  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  review-group-31  |  Actual Points:
Parent ID:   | Points:  .2
 Reviewer:  nickm|Sponsor:
-+
Changes (by nickm):

 * reviewer:   => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20424 [Core Tor/Tor]: Remove --enable-openbsd-malloc (Tor maxes CPU when --enable-openbsd-malloc is used) (was: Tor maxes CPU when --enable-openbsd-malloc is used)

[Tor Bug Tracker & Wiki]

#20424: Remove --enable-openbsd-malloc (Tor maxes CPU when 
--enable-openbsd-malloc
is used)
+
 Reporter:  icanhasaccount  |  Owner:  (none)
 Type:  defect  | Status:  needs_review
 Priority:  Low |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Minor   | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  .2
 Reviewer:  |Sponsor:
+
Changes (by Hello71):

 * Attachment "0001-Add-with-malloc-configure-option.-20424-23777.patch"
 removed.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20424 [Core Tor/Tor]: Remove --enable-openbsd-malloc (Tor maxes CPU when --enable-openbsd-malloc is used)

[Tor Bug Tracker & Wiki]

#20424: Remove --enable-openbsd-malloc (Tor maxes CPU when 
--enable-openbsd-malloc
is used)
+
 Reporter:  icanhasaccount  |  Owner:  (none)
 Type:  defect  | Status:  needs_review
 Priority:  Low |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Minor   | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  .2
 Reviewer:  |Sponsor:
+
Changes (by Hello71):

 * Attachment "0001-Add-with-malloc-configure-option.-20424-23777.patch"
 added.

 so apparently autoconf calls it LIBS

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20424 [Core Tor/Tor]: Remove --enable-openbsd-malloc (Tor maxes CPU when --enable-openbsd-malloc is used)

[Tor Bug Tracker & Wiki]

#20424: Remove --enable-openbsd-malloc (Tor maxes CPU when 
--enable-openbsd-malloc
is used)
+
 Reporter:  icanhasaccount  |  Owner:  (none)
 Type:  defect  | Status:  needs_review
 Priority:  Low |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Minor   | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  .2
 Reviewer:  |Sponsor:
+
Changes (by Hello71):

 * status:  needs_revision => needs_review


Comment:

 so I read what I'm pretty sure is all of the information online about
 replacing malloc, and I'm pretty sure that this is the best global option
 possible. another option that can be explored is to have tor_malloc_ call
 jemalloc, but AFAICT most distros build jemalloc with no prefix, so dlopen
 magic would be needed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20424 [Core Tor/Tor]: Remove --enable-openbsd-malloc (Tor maxes CPU when --enable-openbsd-malloc is used)

[Tor Bug Tracker & Wiki]

#20424: Remove --enable-openbsd-malloc (Tor maxes CPU when 
--enable-openbsd-malloc
is used)
+
 Reporter:  icanhasaccount  |  Owner:  (none)
 Type:  defect  | Status:  needs_revision
 Priority:  Low |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Minor   | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  .2
 Reviewer:  |Sponsor:
+
Changes (by Hello71):

 * Attachment "0001-Add-with-malloc-configure-option.-20424-23777.patch"
 added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20424 [Core Tor/Tor]: Remove --enable-openbsd-malloc (Tor maxes CPU when --enable-openbsd-malloc is used)

[Tor Bug Tracker & Wiki]

#20424: Remove --enable-openbsd-malloc (Tor maxes CPU when 
--enable-openbsd-malloc
is used)
+
 Reporter:  icanhasaccount  |  Owner:  (none)
 Type:  defect  | Status:  needs_revision
 Priority:  Low |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Minor   | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  .2
 Reviewer:  |Sponsor:
+
Changes (by Hello71):

 * Attachment "0001-Add-with-jemalloc.-20424-23777.patch" added.

 patch to add --with-jemalloc

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20424 [Core Tor/Tor]: Remove --enable-openbsd-malloc (Tor maxes CPU when --enable-openbsd-malloc is used)

[Tor Bug Tracker & Wiki]

#20424: Remove --enable-openbsd-malloc (Tor maxes CPU when 
--enable-openbsd-malloc
is used)
+
 Reporter:  icanhasaccount  |  Owner:  (none)
 Type:  defect  | Status:  needs_revision
 Priority:  Low |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Minor   | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  .2
 Reviewer:  |Sponsor:
+
Changes (by Hello71):

 * cc: alex_y_xu@… (added)


Comment:

 proposal: remove tcmalloc and openbsd malloc, add jemalloc and enable by
 default on Linux if installed.

 pros compared to ptmalloc2:

 - moderately decreased CPU usage (#23777)
 - slightly decreased memory usage (fragmentation is much less bad in 0.3.2
 already, but jemalloc still does better by default)

 pros compared to openbsd malloc:

 - remove dead code
 - code path will be actually tested (unlike with openbsd malloc)
 - jemalloc is actually maintained by distributions and -ljemalloc is a
 standard method of overriding glibc. this way will continue to work,
 unlike just defining functions

 cons:

 - if always-on, adds an extra prerequisite. if used only when available,
 might cause more Linux-only bugs
 - glibc does slightly more runtime checks, but AFAIK these are almost
 entirely useless for security
 - might be fingerprintable? seems highly unlikely, and would also apply to
 other OSes

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20424 [Core Tor/Tor]: Remove --enable-openbsd-malloc (Tor maxes CPU when --enable-openbsd-malloc is used)

[Tor Bug Tracker & Wiki]

#20424: Remove --enable-openbsd-malloc (Tor maxes CPU when 
--enable-openbsd-malloc
is used)
+
 Reporter:  icanhasaccount  |  Owner:  (none)
 Type:  defect  | Status:  needs_revision
 Priority:  Low |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Minor   | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  .2
 Reviewer:  |Sponsor:
+

Comment (by Hello71):

 gcc 7 simply deletes the functions, so --enable-openbsd-malloc now instead
 does nothing except slightly increase compilation resources and executable
 size.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20424 [Core Tor/Tor]: Remove --enable-openbsd-malloc (Tor maxes CPU when --enable-openbsd-malloc is used) (was: Tor maxes CPU when --enable-openbsd-malloc is used)

[Tor Bug Tracker & Wiki]

#20424: Remove --enable-openbsd-malloc (Tor maxes CPU when 
--enable-openbsd-malloc
is used)
+
 Reporter:  icanhasaccount  |  Owner:  (none)
 Type:  defect  | Status:  needs_revision
 Priority:  Low |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Minor   | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:  .2
 Reviewer:  |Sponsor:
+
Changes (by nickm):

 * milestone:  Tor: 0.3.2.x-final => Tor: 0.3.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs