Re: [tor-bugs] #21308 [Applications/Tor Browser]: Fix modernizr breakage for TBB/ESR52

[Tor Bug Tracker & Wiki]

#21308: Fix modernizr breakage for TBB/ESR52
-+-
 Reporter:  arthuredelstein  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff52-esr, TorBrowserTeam201703R, |  Actual Points:
  tbb-7.0-must, tbb-no-uplift|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by arthuredelstein):

 * keywords:  ff52-esr, TorBrowserTeam201703R, tbb-7.0-must => ff52-esr,
 TorBrowserTeam201703R, tbb-7.0-must, tbb-no-uplift
 * parent:  #20680 =>


Comment:

 For the record: in #23745 we reverted this patch because it was no longer
 needed. So we also won't need to uplift it.

 Parent was: #20680

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21308 [Applications/Tor Browser]: Fix modernizr breakage for TBB/ESR52

[Tor Bug Tracker & Wiki]

#21308: Fix modernizr breakage for TBB/ESR52
-+-
 Reporter:  arthuredelstein  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff52-esr, TorBrowserTeam201703R, |  Actual Points:
  tbb-7.0-must   |
Parent ID:  #20680   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by arthuredelstein):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:12 gk]:
 > Okay, could you pick that on top of your up-to-date 20680 branch and
 close this ticket then?

 Done. The corresponding Mozilla bug is at
 https://bugzilla.mozilla.org/1192643

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21308 [Applications/Tor Browser]: Fix modernizr breakage for TBB/ESR52

[Tor Bug Tracker & Wiki]

#21308: Fix modernizr breakage for TBB/ESR52
-+-
 Reporter:  arthuredelstein  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, TorBrowserTeam201703R, |  Actual Points:
  tbb-7.0-must   |
Parent ID:  #20680   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by gk):

 Okay, could you pick that on top of your up-to-date 20680 branch and close
 this ticket then?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21308 [Applications/Tor Browser]: Fix modernizr breakage for TBB/ESR52

[Tor Bug Tracker & Wiki]

#21308: Fix modernizr breakage for TBB/ESR52
-+-
 Reporter:  arthuredelstein  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, TorBrowserTeam201703R, |  Actual Points:
  tbb-7.0-must   |
Parent ID:  #20680   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by arthuredelstein):

 * status:  needs_information => needs_review


Comment:

 Replying to [comment:8 gk]:
 > Replying to [ticket:21308 arthuredelstein]:
 > > Our patch for #16528 doesn't work with electrolysis enabled, so we
 need a new patch for TBB/ESR52.
 >
 > Hm. Do you happen to know why that's the case? Because what we do with
 the patch we currently have is just disabling the pref checks and relying
 solely on private browsing mode (PBM) checks. And surely, IndexedDB is
 still disabled in PBM. Thus, those checks should still work as-is.

 The old patch was causing crashes with e10s. I don't know why.

 > Second point, I assume the patch in comment:5 works as well with e10s
 disabled? Because it is still unclear right now how stable e10s will be in
 a Tor Browser ESR52. We might need to disable it or enable it later.

 In my hands it seems to be working OK with e10s enabled or disabled.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21308 [Applications/Tor Browser]: Fix modernizr breakage for TBB/ESR52

[Tor Bug Tracker & Wiki]

#21308: Fix modernizr breakage for TBB/ESR52
-+-
 Reporter:  arthuredelstein  |  Owner:  tbb-team
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, TorBrowserTeam201702R  |  Actual Points:
Parent ID:  #20680   | Points:
 Reviewer:   |Sponsor:  Sponsor4
-+-
Changes (by gk):

 * status:  needs_review => needs_information


Comment:

 Replying to [ticket:21308 arthuredelstein]:
 > Our patch for #16528 doesn't work with electrolysis enabled, so we need
 a new patch for TBB/ESR52.

 Hm. Do you happen to know why that's the case? Because what we do with the
 patch we currently have is just disabling the pref checks and relying
 solely on private browsing mode (PBM) checks. And surely, IndexedDB is
 still disabled in PBM. Thus, those checks should still work as-is.

 Second point, I assume the patch in comment:5 works as well with e10s
 disabled? Because it is still unclear right now how stable e10s will be in
 a Tor Browser ESR52. We might need to disable it or enable it later.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21308 [Applications/Tor Browser]: Fix modernizr breakage for TBB/ESR52

[Tor Bug Tracker & Wiki]

#21308: Fix modernizr breakage for TBB/ESR52
-+-
 Reporter:  arthuredelstein  |  Owner:  tbb-team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, TorBrowserTeam201702R  |  Actual Points:
Parent ID:  #20680   | Points:
 Reviewer:   |Sponsor:  Sponsor4
-+-

Comment (by arthuredelstein):

 Replying to [comment:6 mcs]:
 > r=brade, r=mcs
 > This looks good to us. Nice work!
 > We tested with the Modernizr script (using our own little test page) and
 the right thing seemed to happen.

 Thanks for reviewing this! I added a small mochitest to make sure it's
 working correctly.
 https://github.com/arthuredelstein/tor-browser/commit/21308+2
 I will this add patch to the latest #20680 branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21308 [Applications/Tor Browser]: Fix modernizr breakage for TBB/ESR52

[Tor Bug Tracker & Wiki]

#21308: Fix modernizr breakage for TBB/ESR52
-+-
 Reporter:  arthuredelstein  |  Owner:  tbb-team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, TorBrowserTeam201702R  |  Actual Points:
Parent ID:  #20680   | Points:
 Reviewer:   |Sponsor:  Sponsor4
-+-

Comment (by mcs):

 r=brade, r=mcs
 This looks good to us. Nice work!
 We tested with the Modernizr script (using our own little test page) and
 the right thing seemed to happen.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21308 [Applications/Tor Browser]: Fix modernizr breakage for TBB/ESR52

[Tor Bug Tracker & Wiki]

#21308: Fix modernizr breakage for TBB/ESR52
-+-
 Reporter:  arthuredelstein  |  Owner:  tbb-team
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ff52-esr, TorBrowserTeam201702R  |  Actual Points:
Parent ID:  #20680   | Points:
 Reviewer:   |Sponsor:  Sponsor4
-+-
Changes (by arthuredelstein):

 * keywords:  ff52-esr, TorBrowserTeam201702 => ff52-esr,
 TorBrowserTeam201702R
 * status:  new => needs_review


Comment:

 Here's a patch for review:
 https://github.com/arthuredelstein/tor-browser/tree/21308

 To explain this patch a little:

 In private browsing mode, calling
 {{{
 var req = window.indexedDB.open("anydbname")
 }}}
 returns without throwing an error, but results in
 {{{
 req.name = "InvalidStateError".
 }}}
 Whereas dom.indexeddb.enabled = false, `var req =
 window.indexedDB.open("anydbname")` throws an `InvalidStateError` instead.

 The Modernizr script fails to handle the latter case. So this patch
 changes the behavior of the code when dom.indexedb.enabled = false so that
 no error is thrown, but instead `window.indexedDB = null`. This is
 correctly handled by Modernizr, and also matches the convention where the
 use of a JS API is preceding by checking for its presence, e.g.:
 {{{
 if (window.indexedDB) {
   var req = indexedDB.open(...)
   // More indexedDB usage
 }
 }}}

 I also tested this with Twitter and it appears to get it working properly
 again.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21308 [Applications/Tor Browser]: Fix modernizr breakage for TBB/ESR52

[Tor Bug Tracker & Wiki]

#21308: Fix modernizr breakage for TBB/ESR52
+--
 Reporter:  arthuredelstein |  Owner:  tbb-team
 Type:  defect  | Status:  new
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  ff52-esr, TorBrowserTeam201702  |  Actual Points:
Parent ID:  #20680  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * keywords:  ff52-esr => ff52-esr, TorBrowserTeam201702


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21308 [Applications/Tor Browser]: Fix modernizr breakage for TBB/ESR52

[Tor Bug Tracker & Wiki]

#21308: Fix modernizr breakage for TBB/ESR52
--+--
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ff52-esr  |  Actual Points:
Parent ID:  #20680| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * keywords:  ff52esr => ff52-esr


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21308 [Applications/Tor Browser]: Fix modernizr breakage for TBB/ESR52

[Tor Bug Tracker & Wiki]

#21308: Fix modernizr breakage for TBB/ESR52
--+--
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  ff52esr   |  Actual Points:
Parent ID:  #20680| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * keywords:  tbb-52esr => ff52esr


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs