Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:  fixed
 Keywords:  ff52-esr, tbb-e10s, tbb-crash,   |  Actual Points:
  TorBrowserTeam201706, tbb-7.0-must |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by gk):

 Those tickets are #22471 and #22472.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:  fixed
 Keywords:  ff52-esr, tbb-e10s, tbb-crash,   |  Actual Points:
  TorBrowserTeam201706, tbb-7.0-must |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by gk):

 * status:  needs_revision => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:48 mcs]:
 > We have not found a fix for the pdfjs download problem, but I think the
 reason our earlier fix is ineffective is because a blobURI is used for the
 download, and therefore the channel associated with the download cannot be
 suspended (suspend and resume are only implemented for some channel
 types). So in this case the suspend/resume solution won't work.

 Okay, this makes sense. Let's close this bug and #21886 and file remaining
 issues on new tickets.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-crash,   |  Actual Points:
  TorBrowserTeam201706, tbb-7.0-must |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by mcs):

 We have not found a fix for the pdfjs download problem, but I think the
 reason our earlier fix is ineffective is because a blobURI is used for the
 download, and therefore the channel associated with the download cannot be
 suspended (suspend and resume are only implemented for some channel
 types). So in this case the suspend/resume solution won't work.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-crash,   |  Actual Points:
  TorBrowserTeam201706, tbb-7.0-must |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by gk):

 FWIW: the patch in comment:41 made it into `tor-browser-52.1.1esr-7.0-1`
 as commit 4a4285cbd06a825e5f2277d12a2e5165eab59837 and into `tor-
 browser-52.1.0est-7.0-2` as commit
 1d1fdea85218586354a1294cb94026279e74a0e3. The items mentioned in
 comment:45 could be separate patches.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-crash,   |  Actual Points:
  TorBrowserTeam201706, tbb-7.0-must |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by gk):

 * keywords:  ff52-esr, tbb-e10s, tbb-crash, TorBrowserTeam201705R,
 tbb-7.0-must => ff52-esr, tbb-e10s, tbb-crash, TorBrowserTeam201706,
 tbb-7.0-must
 * status:  needs_information => needs_revision


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-crash,   |  Actual Points:
  TorBrowserTeam201705R, tbb-7.0-must|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by gk):

 I thought about testing #17933 for #20685 and I realized that the former
 is affected by this bug as well: while your patch is working for me when
 downloading the *.dmg mentioned in the description I can't download PDF
 files by clicking on the download button in the PDF viewer. While the tab
 is not crashing it shows the same symptoms as #21886 (but e10s is
 enabled).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-crash,   |  Actual Points:
  TorBrowserTeam201705R, tbb-7.0-must|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by gk):

 Replying to [comment:43 mcs]:
 > Replying to [comment:42 gk]:
 > > Another thought: Do we care about FTP downloads? It seems your patch
 does not address those but they are affected as well (just tested with
 ftp://ftp.gnu.org/gnu/gcc/). Leaving this ticket open for that question
 for now. We can solve this in a fixup commit if needed.
 >
 > I think we should care about FTP, at least a little. So far I cannot
 connect to ftp://ftp.gnu.org/gnu/gcc/ over Tor (I consistently get a "425
 Bad IP Connecting" error).  Kathy and I did test the patch last week with
 a large FTP download (ftp://speedtest.tele2.net/50MB.zip).  Aside from
 sometimes getting a "Bad IP" error with that server as well, it worked
 okay.  But I just tried with a small file
 (ftp://speedtest.tele2.net/1KB.zip) and got an assertion failure while
 running a debug build on OSX:
 > {{{
 > Assertion failure: ((bool)(__builtin_expect(!!(!NS_FAILED_impl(rv)),
 1))) || rv == NS_ERROR_NOT_AVAILABLE, at
 /.../netwerk/protocol/ftp/FTPChannelParent.cpp:646
 > #01:
 
mozilla::net::FTPChannelParent::SuspendForDiversion()[/Users/.../Desktop/tb.app/Contents/MacOS/XUL
 +0x80503e]
 > ...
 > }}}
 >
 > We will need to debug this. Georg, what behavior do you see?

 I had not tested a build with your patch applied. I just encountered a
 crash while testing a 7.0a4 bundle downloading `binutils` via FTP and
 realized that your code is not touching anything in netwerk/protocol/ftp
 while it does in a bunch of other protocols. So, it's more a
 hunch/question I had. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-crash,   |  Actual Points:
  TorBrowserTeam201705R, tbb-7.0-must|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by mcs):

 Replying to [comment:42 gk]:
 > Another thought: Do we care about FTP downloads? It seems your patch
 does not address those but they are affected as well (just tested with
 ftp://ftp.gnu.org/gnu/gcc/). Leaving this ticket open for that question
 for now. We can solve this in a fixup commit if needed.

 I think we should care about FTP, at least a little. So far I cannot
 connect to ftp://ftp.gnu.org/gnu/gcc/ over Tor (I consistently get a "425
 Bad IP Connecting" error).  Kathy and I did test the patch last week with
 a large FTP download (ftp://speedtest.tele2.net/50MB.zip).  Aside from
 sometimes getting a "Bad IP" error with that server as well, it worked
 okay.  But I just tried with a small file
 (ftp://speedtest.tele2.net/1KB.zip) and got an assertion failure while
 running a debug build on OSX:
 {{{
 Assertion failure: ((bool)(__builtin_expect(!!(!NS_FAILED_impl(rv)), 1)))
 || rv == NS_ERROR_NOT_AVAILABLE, at
 /.../netwerk/protocol/ftp/FTPChannelParent.cpp:646
 #01:
 
mozilla::net::FTPChannelParent::SuspendForDiversion()[/Users/.../Desktop/tb.app/Contents/MacOS/XUL
 +0x80503e]
 ...
 }}}

 We will need to debug this. Georg, what behavior do you see?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  needs_information
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-crash,   |  Actual Points:
  TorBrowserTeam201705R, tbb-7.0-must|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by gk):

 * status:  needs_review => needs_information


Comment:

 Another thought: Do we care about FTP downloads? It seems your patch does
 not address those but they are affected as well (just tested with
 ftp://ftp.gnu.org/gnu/gcc/). Leaving this ticket open for that question
 for now. We can solve this in a fixup commit if needed.

 I applied the latest patch to `tor-browser-52.1.1esr-7.0-1` (commit
 4a4285cbd06a825e5f2277d12a2e5165eab59837) and `tor-
 browser-52.1.0esr-7.0-2` (commit
 1d1fdea85218586354a1294cb94026279e74a0e3).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-crash,   |  Actual Points:
  TorBrowserTeam201705R, tbb-7.0-must|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by mcs):

 And here is a revised patch:
 https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug21766-03=4a4285cbd06a825e5f2277d12a2e5165eab59837

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-crash,   |  Actual Points:
  TorBrowserTeam201705R, tbb-7.0-must|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by mcs):

 Replying to [comment:39 gk]:
 > Both sounds good to me. Do we understand why your previous patch
 (`bug21766-01`) was not enough?

 Because the first  test I ran on Linux with that patch was an attempt to
 download a very small file (344 bytes). Basically, comment:32.

 We will create a revised patch that fixes the issues raised in comment:37.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-crash,   |  Actual Points:
  TorBrowserTeam201705R, tbb-7.0-must|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by gk):

 Replying to [comment:38 mcs]:
 > Kathy and I intended to ignore failures when calling `Suspend()` and
 `Resume()`. We had the `rv =` there to make debugging easier, so we will
 try using `Unused <<`.
 >
 > I think we should add restore the `NS_ENSURE_SUCCESS(rv, rv);` after the
 call to `shouldCance()` though; that was removed by mistake.

 Both sounds good to me. Do we understand why your previous patch
 (`bug21766-01`) was not enough?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-crash,   |  Actual Points:
  TorBrowserTeam201705R, tbb-7.0-must|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by mcs):

 Replying to [comment:37 arthuredelstein]:
 > I built and manually tested on Windows (with both large files and very
 small files) and it works! I wasn't able to reproduce the problem seen in
 OSX in comment:36.

 Thanks a lot for testing on Windows.

 > In the patch, I notice there are a few calls in
 `nsExternalAppHandler::OnStartRequest` where you get a return value,
 assign it to `rv` and ignore it. I wonder what should be done if
 `Suspend()` or `ShouldCancel()` or `Resume()` returns an error code? Or
 potentially  the `Unused << Function();` construct could be used instead:
 > https://dxr.mozilla.org/mozilla-esr52/source/mfbt/Unused.h

 Kathy and I intended to ignore failures when calling `Suspend()` and
 `Resume()`. We had the `rv =` there to make debugging easier, so we will
 try using `Unused <<`.

 I think we should add restore the `NS_ENSURE_SUCCESS(rv, rv);` after the
 call to `shouldCance()` though; that was removed by mistake.

 Georg, do you have any comments on the patch?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-crash,   |  Actual Points:
  TorBrowserTeam201705R, tbb-7.0-must|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by arthuredelstein):

 I built and manually tested on Windows (with both large files and very
 small files) and it works! I wasn't able to reproduce the problem seen in
 OSX in comment:36.

 In the patch, I notice there are a few calls in
 `nsExternalAppHandler::OnStartRequest` where you get a return value,
 assign it to `rv` and ignore it. I wonder what should be done if
 `Suspend()` or `ShouldCancel()` or `Resume()` returns an error code? Or
 potentially  the `Unused << Function();` construct could be used instead:
 https://dxr.mozilla.org/mozilla-esr52/source/mfbt/Unused.h

 Otherwise the patch looks good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-crash,   |  Actual Points:
  TorBrowserTeam201705R, tbb-7.0-must|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by mcs):

 This patch seems to fix both this ticket and #21886 on OSX as well. One
 caveat is that sometimes after starting to download a very small file and
 clicking "Cancel" on the Torbutton-provided warning prompt, subsequent
 attempts to download the very small file hang (the page stays in the
 loading state). That could be a different problem though, so for now Kathy
 and I are going to wait for feedback about Windows and for a code review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  needs_review
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-crash,   |  Actual Points:
  TorBrowserTeam201705R, tbb-7.0-must|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by mcs):

 * keywords:  ff52-esr, tbb-e10s, tbb-crash, TorBrowserTeam201705,
 tbb-7.0-must => ff52-esr, tbb-e10s, tbb-crash, TorBrowserTeam201705R,
 tbb-7.0-must
 * status:  assigned => needs_review


Comment:

 Determining when to call Suspend() was a little more difficult than we
 expected, but here is the new patch:
 https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug21766-02=ead6d27079482708ddd3a1c748effe408a817a97

 Kathy and I tested it on Linux64 only. Based on previous experience, I
 expect it to work fine on OSX (we are out of time for today to test it
 there, unfortunately). Windows is the big unknown, but I am optimistic!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  assigned
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-crash,   |  Actual Points:
  TorBrowserTeam201705, tbb-7.0-must |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by arthuredelstein):

 Replying to [comment:32 mcs]:
 > Update: The fix works for Kathy and me on Linux as well, unless the file
 being downloaded is so small that the network traffic is finished before
 we try to call `Suspend()` (Kathy and I happen to have a tiny 344 byte zip
 file that we were testing with among other larger files). We are now
 trying to modify the patch so that it only suspends if necessary.
 >
 > Any takers for testing on Windows, or should we simply wait for a
 nightly build? Kathy and I don't have a good standlone (non-gitian)
 Windows build setup, or at least we have not tried to build an ESR52-based
 browser there. But we should be able to do a gitian-based build if
 necessary.

 I can run a test on Windows today -- let me know when you have the
 modified patch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  assigned
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-crash,   |  Actual Points:
  TorBrowserTeam201705, tbb-7.0-must |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by arthuredelstein):

 Replying to [comment:31 mcs]:

 > > I cherry-picked this patch onto `tor-browser-52.1.1esr-7.0-1-build1`
 (`454a231f2b76a8857748d93f666bb93199f4b963`), built tor-browser.git, and
 added NoScript and torbutton. The patch worked for me (with e10s active)
 -- I saw the confirmation prompt and was able to cancel or download files
 on Linux. I used gdb to check the return values of Suspend() and Resume()
 and they both returned NS_OK.
 >
 > Interesting. Did you test with an optimized build or a debug build?

 This was a debug build. I can try an optimized build, but it sounds like
 you have maybe tracked down the issue in comment:32.

 > I am creating a debug build now with the patch applied to the tip of
 tor-browser-52.1.1esr-7.0-1 (7bbd69956bd1a30051599a1dd4bf615bc40e55e8, aka
 tor-browser-52.1.1esr-7.0-1-build2). I want to be sure to test with the
 #22254 fix in place. But you must have fixed that manually?

 Actually, I didn't. I don't know offhand why I didn't run into that
 problem. But I was able to manually install torbutton and NoScript. I
 didn't do a full rbm build though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  assigned
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-crash,   |  Actual Points:
  TorBrowserTeam201705, tbb-7.0-must |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by mcs):

 Update: The fix works for Kathy and me on Linux as well, unless the file
 being downloaded is so small that the network traffic is finished before
 we try to call `Suspend()` (Kathy and I happen to have a tiny 344 byte zip
 file that we were testing with among other larger files). We are now
 trying to modify the patch so that it only suspends if necessary.

 Any takers for testing on Windows, or should we simply wait for a nightly
 build? Kathy and I don't have a good standlone (non-gitian) Windows build
 setup, or at least we have not tried to build an ESR52-based browser
 there. But we should be able to do a gitian-based build if necessary.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  assigned
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-crash,   |  Actual Points:
  TorBrowserTeam201705, tbb-7.0-must |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by mcs):

 Replying to [comment:30 arthuredelstein]:
 > Replying to [comment:22 mcs]:
 > > see ticket:21886#comment:16 for a patch that tries but fails to fix
 this problem.
 >
 > I cherry-picked this patch onto `tor-browser-52.1.1esr-7.0-1-build1`
 (`454a231f2b76a8857748d93f666bb93199f4b963`), built tor-browser.git, and
 added NoScript and torbutton. The patch worked for me (with e10s active)
 -- I saw the confirmation prompt and was able to cancel or download files
 on Linux. I used gdb to check the return values of Suspend() and Resume()
 and they both returned NS_OK.

 Interesting. Did you test with an optimized build or a debug build?

 I am creating a debug build now with the patch applied to the tip of tor-
 browser-52.1.1esr-7.0-1 (7bbd69956bd1a30051599a1dd4bf615bc40e55e8, aka
 tor-browser-52.1.1esr-7.0-1-build2). I want to be sure to test with the
 #22254 fix in place. But you must have fixed that manually?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  assigned
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, tbb-e10s, tbb-crash,   |  Actual Points:
  TorBrowserTeam201705, tbb-7.0-must |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by arthuredelstein):

 Replying to [comment:22 mcs]:
 > see ticket:21886#comment:16 for a patch that tries but fails to fix this
 problem.

 I cherry-picked this patch onto `tor-browser-52.1.1esr-7.0-1-build1`
 (`454a231f2b76a8857748d93f666bb93199f4b963`), built tor-browser.git, and
 added NoScript and torbutton. The patch worked for me (with e10s active)
 -- I saw the confirmation prompt and was able to cancel or download files.
 I used gdb to check the return values of Suspend() and Resume() and they
 both returned NS_OK.

 So I'm wondering if something might have been patched in the latest
 version of 52ESR? I haven't checked on Windows yet but it seems like this
 patch might actually be OK.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  assigned
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, tbb-7.0-must-alpha, tbb-   |  Actual Points:
  e10s, tbb-crash, TorBrowserTeam201705  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by mcs):

 Replying to [comment:27 gk]:
 > A third one would be...

 3. Move the Tor Browser specific warning text into one of Mozilla's
 existing dialogs. A problem with this is that their dialogs do not pause
 the download, so bytes are being written to temporary files even though
 the user probably thinks everything is paused.

 4. Something else that is more clever.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  assigned
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, tbb-7.0-must-alpha, tbb-   |  Actual Points:
  e10s, tbb-crash, TorBrowserTeam201705  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by gk):

 As time is running short we might want to get creative and think about
 ways to solve this bug by working around this bug.

 One option proposed is to get rid of our external app blocker as it is
 today assuming e10s enabled is more valuable. Another one is to fix #21886
 properly and disable e10s until we find a good solution for this bug. A
 third one would be...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  assigned
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, tbb-7.0-must-alpha, tbb-   |  Actual Points:
  e10s, tbb-crash, TorBrowserTeam201705  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by mcs):

 Another small tidbit of information: this bug occurs even when NoScript is
 disabled (which is not true for #21886).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  assigned
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, tbb-7.0-must-alpha, tbb-   |  Actual Points:
  e10s, tbb-crash, TorBrowserTeam201705  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by mcs):

 Replying to [comment:24 gk]:
 > While pondering #21886 I was wondering whether it would help to just get
 rid of the observer idea and leave the extension out of the picture: could
 we just show a dialog at places where we are currently using the observer
 mechanism?

 We could try that, but I think the main problem is that a modal dialog is
 displayed (as a cypherpunk mentioned somewhere). With e10s enabled, it
 seems that while a modal dialog is open events related to the IPC
 mechanism are not handled correctly. This causes the chrome process to
 kill the content process (to the user, this appears as a tab crash).
 Therefore I think we will still have a problem if we move the dialog into
 the browser/C++ code.

 Mozilla does show dialogs during a download, but they are not modal and
 they do not block the network activity (so, for example, the download
 proceeds while the user is answering the "What would you like to do with
 this file? open/save" prompt. I assume we want to stop the network
 activity as in Tor Browser 6.5.2.

 The most promising approach seems to be to suspend and then resume the
 request, but when e10s is enabled that does not work reliably when we try
 it from any of the obvious locations, e.g., not from `DoContent()` inside
 `uriloader/exthandler/nsExternalHelperAppService.cpp`, not from
 `OnStartRequest()`, not inside the first call to `OnDataAvailable()`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  assigned
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, tbb-7.0-must-alpha, tbb-   |  Actual Points:
  e10s, tbb-crash, TorBrowserTeam201705  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by gk):

 While pondering #21886 I was wondering whether it would help to just get
 rid of the observer idea and leave the extension out of the picture: could
 we just show a dialog at places where we are currently using the observer
 mechanism?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  assigned
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, tbb-7.0-must-alpha, tbb-   |  Actual Points:
  e10s, tbb-crash, TorBrowserTeam201705  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by mcs):

 * cc: torland (added)


Comment:

 #22195 is a duplicate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  assigned
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, tbb-7.0-must-alpha, tbb-   |  Actual Points:
  e10s, tbb-crash, TorBrowserTeam201705  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by mcs):

 see ticket:21886#comment:16 for a patch that tries but fails to fix this
 problem.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  mcs
 Type:  defect   | Status:
 |  assigned
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, TorBrowserTeam201704,  |  Actual Points:
  tbb-7.0-must-alpha, tbb-e10s, tbb-crash|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by mcs):

 * status:  new => assigned
 * owner:  tbb-team => mcs


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, TorBrowserTeam201704,  |  Actual Points:
  tbb-7.0-must-alpha, tbb-e10s, tbb-crash|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by qbi):

 * cc: qbi (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, TorBrowserTeam201704,  |  Actual Points:
  tbb-7.0-must-alpha, tbb-e10s, tbb-crash|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by gk):

 * keywords:  ff52-esr, TorBrowserTeam201704, tbb-7.0-must-alpha, tbb-e10s
 =>
 ff52-esr, TorBrowserTeam201704, tbb-7.0-must-alpha, tbb-e10s, tbb-
 crash


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, TorBrowserTeam201704,  |  Actual Points:
  tbb-7.0-must-alpha, tbb-e10s   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

Comment (by cypherpunks):

 Replying to [ticket:21766 gk]:
 > I tried to download [...] and got the notice that my tab crashed.
 And to get buttons on that page work you need to allow JS on
 `about:tabcrashed`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21766 [Applications/Tor Browser]: Tor Browser based on ESR52 with e10s enabled crashed while trying to download a file (was: Tor Browser based on ESR52 with e10s enabled crashed whle t

[Tor Bug Tracker & Wiki]

#21766: Tor Browser based on ESR52 with e10s enabled crashed while trying to
download a file
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  new
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Critical | Resolution:
 Keywords:  ff52-esr, TorBrowserTeam201704,  |  Actual Points:
  tbb-7.0-must-alpha, tbb-e10s   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs