Re: [tor-bugs] #23149 [Core Tor/Tor]: Refactor buffer.c: split and rename functions.

[Tor Bug Tracker & Wiki]

#23149: Refactor buffer.c: split and rename functions.
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:  implemented
 Keywords:  review-group-22  |  Actual Points:  .2
Parent ID:  #22342   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => implemented


Comment:

 I took a simple approach in c0b9f594b65f410cf219673d53226ed4dc19: I
 decided to make the function not static any more.

 Otherwise, changes look fine -- merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23149 [Core Tor/Tor]: Refactor buffer.c: split and rename functions.

[Tor Bug Tracker & Wiki]

#23149: Refactor buffer.c: split and rename functions.
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-22  |  Actual Points:  .2
Parent ID:  #22342   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by nickm):

 Oh, never mind.  It's GCC only, and clang doesn't object.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23149 [Core Tor/Tor]: Refactor buffer.c: split and rename functions.

[Tor Bug Tracker & Wiki]

#23149: Refactor buffer.c: split and rename functions.
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-22  |  Actual Points:  .2
Parent ID:  #22342   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by nickm):

 I've tried, but I can't reproduce that warning above.  I would have
 thought that the ATTR_UNUSED would have suppressed that warning.  Maybe it
 depends on GCC version?  I'm going to try merging without that fix, to see
 where it breaks, and look for a better way to fix it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23149 [Core Tor/Tor]: Refactor buffer.c: split and rename functions.

[Tor Bug Tracker & Wiki]

#23149: Refactor buffer.c: split and rename functions.
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-22  |  Actual Points:  .2
Parent ID:  #22342   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by catalyst):

 Otherwise, the changes look good to me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23149 [Core Tor/Tor]: Refactor buffer.c: split and rename functions.

[Tor Bug Tracker & Wiki]

#23149: Refactor buffer.c: split and rename functions.
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-22  |  Actual Points:  .2
Parent ID:  #22342   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by catalyst):

 * status:  needs_revision => needs_review
 * reviewer:  catalyst =>


Comment:

 Proposed fixups in the `nickm/refactor_buffers_api` branch in my github
 repo.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23149 [Core Tor/Tor]: Refactor buffer.c: split and rename functions.

[Tor Bug Tracker & Wiki]

#23149: Refactor buffer.c: split and rename functions.
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-22  |  Actual Points:  .2
Parent ID:  #22342   | Points:
 Reviewer:  catalyst |Sponsor:
-+

Comment (by catalyst):

 gcc Travis builds failed (after fixing up two unresolved merge conflicts
 in test_buffers.c):

 {{{
 In file included from src/common/buffers_tls.c:10:0:
 src/common/buffers.h:70:27: error: ‘preferred_chunk_size’ declared
 ‘static’ but never defined [-Werror=unused-function]
  ATTR_UNUSED STATIC size_t preferred_chunk_size(size_t target);
^
 cc1: all warnings being treated as errors
 make: *** [src/common/buffers_tls.o] Error 1
 make: *** Waiting for unfinished jobs
 }}}

 It looks like buffers_tls.c defines `BUFFERS_PRIVATE` but doesn't provide
 a `STATIC` definition of `preferred_chunk_size()`.  (though it would
 probably cause duplicate definitions when built with `-DTOR_UINIT_TESTS`)

 I'm not sure what's best here; maybe a different macro to protect the
 `STATIC` declaration in buffers.h?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23149 [Core Tor/Tor]: Refactor buffer.c: split and rename functions.

[Tor Bug Tracker & Wiki]

#23149: Refactor buffer.c: split and rename functions.
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-22  |  Actual Points:  .2
Parent ID:  #22342   | Points:
 Reviewer:  catalyst |Sponsor:
-+
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 Still looking, but there are currently merge conflicts with master.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23149 [Core Tor/Tor]: Refactor buffer.c: split and rename functions.

[Tor Bug Tracker & Wiki]

#23149: Refactor buffer.c: split and rename functions.
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-22  |  Actual Points:  .2
Parent ID:  #22342   | Points:
 Reviewer:  catalyst |Sponsor:
-+
Changes (by catalyst):

 * reviewer:   => catalyst


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23149 [Core Tor/Tor]: Refactor buffer.c: split and rename functions.

[Tor Bug Tracker & Wiki]

#23149: Refactor buffer.c: split and rename functions.
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-22  |  Actual Points:  .2
Parent ID:  #22342   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by nickm):

 * status:  needs_information => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23149 [Core Tor/Tor]: Refactor buffer.c: split and rename functions.

[Tor Bug Tracker & Wiki]

#23149: Refactor buffer.c: split and rename functions.
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_information
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-22  |  Actual Points:  .2
Parent ID:  #22342   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by nickm):

 That's mostly code movement, but sure!  Here you go:

 https://oniongit.eu/nickm/tor/merge_requests/5

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23149 [Core Tor/Tor]: Refactor buffer.c: split and rename functions.

[Tor Bug Tracker & Wiki]

#23149: Refactor buffer.c: split and rename functions.
-+
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  needs_information
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  review-group-22  |  Actual Points:  .2
Parent ID:  #22342   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by dgoulet):

 * status:  needs_review => needs_information


Comment:

 The git diff I get is: ` 37 files changed, 2676 insertions(+), 2470
 deletions(-)`

 If it's the case, maybe a Gitlab MR ?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23149 [Core Tor/Tor]: Refactor buffer.c: split and rename functions.

[Tor Bug Tracker & Wiki]

#23149: Refactor buffer.c: split and rename functions.
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #22342| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 Please see branch `refactor_buffers_api` in my public repository.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23149 [Core Tor/Tor]: Refactor buffer.c: split and rename functions.

[Tor Bug Tracker & Wiki]

#23149: Refactor buffer.c: split and rename functions.
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .2
Parent ID:  #22342| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  accepted => needs_review
 * actualpoints:   => .2


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23149 [Core Tor/Tor]: Refactor buffer.c: split and rename functions.

[Tor Bug Tracker & Wiki]

#23149: Refactor buffer.c: split and rename functions.
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #22342| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * owner:   => nickm
 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs