Re: [tor-bugs] #23230 [Applications/Tor Browser]: Error building firefox for Windows 64 in media/libcubeb/src/cubeb_wasapi.cpp

[Tor Bug Tracker & Wiki]

#23230: Error building firefox for Windows 64 in
media/libcubeb/src/cubeb_wasapi.cpp
--+
 Reporter:  boklm |  Owner:  boklm
 Type:  task  | Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  TorBrowserTeam201708R |  Actual Points:
Parent ID:  #23229| Points:
 Reviewer:|Sponsor:
--+

Comment (by cypherpunks):

 https://bugzilla.mozilla.org/show_bug.cgi?id=1314514#c15
 It was landed on trunk a week after ESR had been moved to alpha. It is the
 library of Firefox, in fact. The divergence should be minimal. They had to
 update ESR, but preferred cherry-picking :(

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23230 [Applications/Tor Browser]: Error building firefox for Windows 64 in media/libcubeb/src/cubeb_wasapi.cpp

[Tor Bug Tracker & Wiki]

#23230: Error building firefox for Windows 64 in
media/libcubeb/src/cubeb_wasapi.cpp
--+
 Reporter:  boklm |  Owner:  boklm
 Type:  task  | Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  TorBrowserTeam201708R |  Actual Points:
Parent ID:  #23229| Points:
 Reviewer:|Sponsor:
--+

Comment (by gk):

 Replying to [comment:6 cypherpunks]:
 > According to https://bugzilla.mozilla.org/show_bug.cgi?id=1314514#c7,
 they updated in-tree libcubeb to fix security issue, crash and
 incompatibility with Gecko. Why don't you do the same?

 Because we are following esr52 as close as we can to avoid diverting too
 much from it as this is quite risky. Apart from that the security issue is
 fixed in esr52. Not sure which crash and incompatibility you are talking
 about, though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23230 [Applications/Tor Browser]: Error building firefox for Windows 64 in media/libcubeb/src/cubeb_wasapi.cpp

[Tor Bug Tracker & Wiki]

#23230: Error building firefox for Windows 64 in
media/libcubeb/src/cubeb_wasapi.cpp
--+
 Reporter:  boklm |  Owner:  boklm
 Type:  task  | Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  TorBrowserTeam201708R |  Actual Points:
Parent ID:  #23229| Points:
 Reviewer:|Sponsor:
--+

Comment (by cypherpunks):

 According to https://bugzilla.mozilla.org/show_bug.cgi?id=1314514#c7, they
 updated in-tree libcubeb to fix security issue, crash and incompatibility
 with Gecko. Why don't you do the same?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23230 [Applications/Tor Browser]: Error building firefox for Windows 64 in media/libcubeb/src/cubeb_wasapi.cpp

[Tor Bug Tracker & Wiki]

#23230: Error building firefox for Windows 64 in
media/libcubeb/src/cubeb_wasapi.cpp
--+
 Reporter:  boklm |  Owner:  boklm
 Type:  task  | Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  TorBrowserTeam201708R |  Actual Points:
Parent ID:  #23229| Points:
 Reviewer:|Sponsor:
--+
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 That's commit f36d2a2dd30368c97594923092a43dd74c61846c on `tor-
 browser-52.3.0esr-7.5-2` now, thanks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23230 [Applications/Tor Browser]: Error building firefox for Windows 64 in media/libcubeb/src/cubeb_wasapi.cpp

[Tor Bug Tracker & Wiki]

#23230: Error building firefox for Windows 64 in
media/libcubeb/src/cubeb_wasapi.cpp
--+--
 Reporter:  boklm |  Owner:  boklm
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201708R |  Actual Points:
Parent ID:  #23229| Points:
 Reviewer:|Sponsor:
--+--

Comment (by mcs):

 r=mcs
 This looks good to me also.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23230 [Applications/Tor Browser]: Error building firefox for Windows 64 in media/libcubeb/src/cubeb_wasapi.cpp

[Tor Bug Tracker & Wiki]

#23230: Error building firefox for Windows 64 in
media/libcubeb/src/cubeb_wasapi.cpp
--+--
 Reporter:  boklm |  Owner:  boklm
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201708R |  Actual Points:
Parent ID:  #23229| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * cc: mcs, brade (added)


Comment:

 Looks good to me. Let's see what others think.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23230 [Applications/Tor Browser]: Error building firefox for Windows 64 in media/libcubeb/src/cubeb_wasapi.cpp

[Tor Bug Tracker & Wiki]

#23230: Error building firefox for Windows 64 in
media/libcubeb/src/cubeb_wasapi.cpp
--+--
 Reporter:  boklm |  Owner:  boklm
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201708R |  Actual Points:
Parent ID:  #23229| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 FWIW: commit 5abde564516a8557266159bfe25d9e046ea9d318 shows how upstream
 (https://github.com/kinetiknz/cubeb) avoids casting to `int`. It missed
 ESR 52, though, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1314514.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23230 [Applications/Tor Browser]: Error building firefox for Windows 64 in media/libcubeb/src/cubeb_wasapi.cpp

[Tor Bug Tracker & Wiki]

#23230: Error building firefox for Windows 64 in
media/libcubeb/src/cubeb_wasapi.cpp
--+--
 Reporter:  boklm |  Owner:  boklm
 Type:  task  | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201708R |  Actual Points:
Parent ID:  #23229| Points:
 Reviewer:|Sponsor:
--+--
Changes (by boklm):

 * keywords:   => TorBrowserTeam201708R
 * status:  assigned => needs_review


Comment:

 I attached a patch that is fixing this error.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23230 [Applications/Tor Browser]: Error building firefox for Windows 64 in media/libcubeb/src/cubeb_wasapi.cpp

[Tor Bug Tracker & Wiki]

#23230: Error building firefox for Windows 64 in
media/libcubeb/src/cubeb_wasapi.cpp
--+--
 Reporter:  boklm |  Owner:  boklm
 Type:  task  | Status:  assigned
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #23229| Points:
 Reviewer:|Sponsor:
--+--
Changes (by boklm):

 * Attachment "0001-Bug-23230-Fix-build-error-on-Windows-64.patch" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs