Re: [tor-bugs] #24735 [Core Tor/Tor]: Always check for the null address when calling address functions

[Tor Bug Tracker & Wiki]

#24735: Always check for the null address when calling address functions
-+
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, tor-relay  |  Actual Points:
Parent ID:  #24403   | Points:  1
 Reviewer:   |Sponsor:  SponsorV-can
-+
Changes (by teor):

 * status:  new => needs_revision


Comment:

 Would you like to make those changes as well?

 Also, here is a quick review of your branch:

 Don't add an extra space before the fascist_firewall call.
 Don't add chutney as a submodule.

 There are no IPv6 DirPorts. Please replace the entire pref_dirport
 function with a call to prim_dirport.

 Try to only call each function once in pref_orport. It makes for clearer
 logic.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24735 [Core Tor/Tor]: Always check for the null address when calling address functions

[Tor Bug Tracker & Wiki]

#24735: Always check for the null address when calling address functions
-+
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, tor-relay  |  Actual Points:
Parent ID:  #24403   | Points:  1
 Reviewer:   |Sponsor:  SponsorV-can
-+

Comment (by teor):

 It is necessary for all address functions to do this check. We recently
 made the change in master in tickets #23873 and #23874.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24735 [Core Tor/Tor]: Always check for the null address when calling address functions

[Tor Bug Tracker & Wiki]

#24735: Always check for the null address when calling address functions
-+
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ipv6, tor-relay  |  Actual Points:
Parent ID:  #24403   | Points:  1
 Reviewer:   |Sponsor:  SponsorV-can
-+

Comment (by meryemz):

 Here is my patch for this ticket:
 https://github.com/mary-em/torprojet-tor/tree/t-24735

 And I think it is necessary as well for other address functions to check
 for the null address when calling them such as:
  node_get_prim_orport()
  node_get_pref_dirport()

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs