Re: [tor-bugs] #24995 [Applications/Tor Browser]: Truncated git hash not available in the windows expert bundle build for Tor 0.3.2.9

[Tor Bug Tracker & Wiki]

#24995: Truncated git hash not available in the windows expert bundle build for 
Tor
0.3.2.9
+--
 Reporter:  TheDcoder   |  Owner:  tbb-team
 Type:  defect  | Status:  closed
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam201802R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good, thanks. Merged to `master` (commit
 c873b63900021e29f7ac01c92145e91a7cb64fff).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24995 [Applications/Tor Browser]: Truncated git hash not available in the windows expert bundle build for Tor 0.3.2.9

[Tor Bug Tracker & Wiki]

#24995: Truncated git hash not available in the windows expert bundle build for 
Tor
0.3.2.9
+--
 Reporter:  TheDcoder   |  Owner:  tbb-team
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201802R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by boklm):

 * keywords:  tbb-rbm, TorBrowserTeam201801 => tbb-rbm,
   TorBrowserTeam201802R
 * status:  needs_revision => needs_review


Comment:

 There is a new version of the patch in branch `bug_24995_v3`, using
 `abbrev_length` instead of `abbrev_lenght`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_24995_v3=c873b63900021e29f7ac01c92145e91a7cb64fff

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24995 [Applications/Tor Browser]: Truncated git hash not available in the windows expert bundle build for Tor 0.3.2.9

[Tor Bug Tracker & Wiki]

#24995: Truncated git hash not available in the windows expert bundle build for 
Tor
0.3.2.9
---+---
 Reporter:  TheDcoder  |  Owner:  tbb-team
 Type:  defect | Status:
   |  needs_revision
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201801  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by gk):

 * keywords:  tbb-rbm, TorBrowserTeam201801R => tbb-rbm,
   TorBrowserTeam201801


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24995 [Applications/Tor Browser]: Truncated git hash not available in the windows expert bundle build for Tor 0.3.2.9

[Tor Bug Tracker & Wiki]

#24995: Truncated git hash not available in the windows expert bundle build for 
Tor
0.3.2.9
+--
 Reporter:  TheDcoder   |  Owner:  tbb-team
 Type:  defect  | Status:
|  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201801R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by boklm):

 * status:  needs_review => needs_revision


Comment:

 We should fix #25004 first.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24995 [Applications/Tor Browser]: Truncated git hash not available in the windows expert bundle build for Tor 0.3.2.9

[Tor Bug Tracker & Wiki]

#24995: Truncated git hash not available in the windows expert bundle build for 
Tor
0.3.2.9
+--
 Reporter:  TheDcoder   |  Owner:  tbb-team
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201801R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by boklm):

 * keywords:  tbb-rbm => tbb-rbm, TorBrowserTeam201801R
 * status:  new => needs_review


Comment:

 I pushed a patch to fix that in branch `bug_24995_v2`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_24995_v2=ab4a36dc316968cd3f87f4dace6e9983508bebb9

 After building an Expert Bundle with:
 {{{
 ./rbm/rbm build --target alpha --target torbrowser-windows-i686 --target
 expert-bundle tor
 }}}

 The git hash is again in the `tor.exe --version` output.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24995 [Applications/Tor Browser]: Truncated git hash not available in the windows expert bundle build for Tor 0.3.2.9

[Tor Bug Tracker & Wiki]

#24995: Truncated git hash not available in the windows expert bundle build for 
Tor
0.3.2.9
--+--
 Reporter:  TheDcoder |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * keywords:   => tbb-rbm
 * version:  Tor: 0.3.2.9 =>


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24995 [Applications/Tor Browser]: Truncated git hash not available in the windows expert bundle build for Tor 0.3.2.9

[Tor Bug Tracker & Wiki]

#24995: Truncated git hash not available in the windows expert bundle build for 
Tor
0.3.2.9
--+--
 Reporter:  TheDcoder |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:  Tor: 0.3.2.9
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by boklm):

 Ah yes, it is probably because with `rbm/tor-browser-build` the .git
 directory is not available anymore when we do the build.

 I think we could fix that by adding the hash in the file `micro-
 revision.i` during the build.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24995 [Applications/Tor Browser]: Truncated git hash not available in the windows expert bundle build for Tor 0.3.2.9 (was: Truncated git hash not available in the build for Tor 0.3.2.

[Tor Bug Tracker & Wiki]

#24995: Truncated git hash not available in the windows expert bundle build for 
Tor
0.3.2.9
--+--
 Reporter:  TheDcoder |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:  Tor: 0.3.2.9
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs