Re: [tor-bugs] #25116 [Core Tor/Tor]: hs: circuit_log_ancient_one_hop_circuits() should probably not log single onion service rendezvous circuit

[Tor Bug Tracker & Wiki]

#25116: hs: circuit_log_ancient_one_hop_circuits() should probably not log 
single
onion service rendezvous circuit
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.6-rc
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tor-hs, sos, easy, 029-backport, |  Actual Points:
  031-unreached-backport, 032-unreached- |
  backport   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 I merged #25116, #25113, and #24903 into 0.2.9.

 CI passed on:
 * the original branches,
 * each branch merged into the current maint-0.2.9, and
 * all 3 branches merged together into maint-0.2.9, then merged into
 release-0.2.9.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25116 [Core Tor/Tor]: hs: circuit_log_ancient_one_hop_circuits() should probably not log single onion service rendezvous circuit

[Tor Bug Tracker & Wiki]

#25116: hs: circuit_log_ancient_one_hop_circuits() should probably not log 
single
onion service rendezvous circuit
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.9.6-rc
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, sos, easy, 029-backport, |  Actual Points:
  031-unreached-backport, 032-unreached- |
  backport   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * version:  Tor: unspecified => Tor: 0.2.9.6-rc


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25116 [Core Tor/Tor]: hs: circuit_log_ancient_one_hop_circuits() should probably not log single onion service rendezvous circuit

[Tor Bug Tracker & Wiki]

#25116: hs: circuit_log_ancient_one_hop_circuits() should probably not log 
single
onion service rendezvous circuit
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, sos, easy, 029-backport, |  Actual Points:
  031-unreached-backport, 032-unreached- |
  backport   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * version:   => Tor: unspecified


Comment:

 This is a one-line logging fix on an LTS release. It's low risk, and worth
 backporting.

 Since it's an old branch, I opened a pull request to make sure that the
 tests still pass:
 https://github.com/torproject/tor/pull/747

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25116 [Core Tor/Tor]: hs: circuit_log_ancient_one_hop_circuits() should probably not log single onion service rendezvous circuit

[Tor Bug Tracker & Wiki]

#25116: hs: circuit_log_ancient_one_hop_circuits() should probably not log 
single
onion service rendezvous circuit
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, sos, easy, 031-backport  |  Actual Points:
  029-backport 032-backport  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  tor-hs, sos, easy => tor-hs, sos, easy, 031-backport
 029-backport 032-backport
 * status:  needs_review => merge_ready
 * milestone:  Tor: 0.3.3.x-final => Tor: 0.3.2.x-final


Comment:

 great! merging  to 0.3.3, marking for possible backport.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25116 [Core Tor/Tor]: hs: circuit_log_ancient_one_hop_circuits() should probably not log single onion service rendezvous circuit

[Tor Bug Tracker & Wiki]

#25116: hs: circuit_log_ancient_one_hop_circuits() should probably not log 
single
onion service rendezvous circuit
---+
 Reporter:  dgoulet|  Owner:  dgoulet
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs, sos, easy  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by dgoulet):

 Sure, 029 branch: `bug25116_029_01`

 Commit `7ce8d5513ba38825`. Hope that is ok!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25116 [Core Tor/Tor]: hs: circuit_log_ancient_one_hop_circuits() should probably not log single onion service rendezvous circuit

[Tor Bug Tracker & Wiki]

#25116: hs: circuit_log_ancient_one_hop_circuits() should probably not log 
single
onion service rendezvous circuit
---+
 Reporter:  dgoulet|  Owner:  dgoulet
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs, sos, easy  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by nickm):

 Let's have the branch against 0.2.9, so that we can backport it in case
 anybody complains about getting these errors in earlier versions.  It's a
 simple enough fix.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25116 [Core Tor/Tor]: hs: circuit_log_ancient_one_hop_circuits() should probably not log single onion service rendezvous circuit

[Tor Bug Tracker & Wiki]

#25116: hs: circuit_log_ancient_one_hop_circuits() should probably not log 
single
onion service rendezvous circuit
---+
 Reporter:  dgoulet|  Owner:  dgoulet
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs, sos, easy  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by dgoulet):

 Yes goes back to 029 but I wasn't sure this would qualify for a backport.
 If yes, I'm happy to provide an 029 branch.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25116 [Core Tor/Tor]: hs: circuit_log_ancient_one_hop_circuits() should probably not log single onion service rendezvous circuit

[Tor Bug Tracker & Wiki]

#25116: hs: circuit_log_ancient_one_hop_circuits() should probably not log 
single
onion service rendezvous circuit
---+
 Reporter:  dgoulet|  Owner:  dgoulet
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs, sos, easy  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by nickm):

 LGTM.  Is this a bug against some earlier branch, though?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25116 [Core Tor/Tor]: hs: circuit_log_ancient_one_hop_circuits() should probably not log single onion service rendezvous circuit

[Tor Bug Tracker & Wiki]

#25116: hs: circuit_log_ancient_one_hop_circuits() should probably not log 
single
onion service rendezvous circuit
---+
 Reporter:  dgoulet|  Owner:  dgoulet
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs, sos, easy  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by dgoulet):

 * status:  accepted => needs_review


Comment:

 Branch: `bug25116_033_01`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25116 [Core Tor/Tor]: hs: circuit_log_ancient_one_hop_circuits() should probably not log single onion service rendezvous circuit

[Tor Bug Tracker & Wiki]

#25116: hs: circuit_log_ancient_one_hop_circuits() should probably not log 
single
onion service rendezvous circuit
---+
 Reporter:  dgoulet|  Owner:  dgoulet
 Type:  defect | Status:  accepted
 Priority:  Medium |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tor-hs, sos, easy  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by dgoulet):

 * status:  new => accepted
 * owner:  (none) => dgoulet


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs