Re: [tor-bugs] #25188 [Core Tor/Tor]: Spec bug in formal definition of Document in dir-spec.txt

[Tor Bug Tracker & Wiki]

#25188: Spec bug in formal definition of Document in dir-spec.txt
-+-
 Reporter:  witchof0x20  |  Owner:  (none)
 Type:  enhancement  | Status:  closed
 Priority:  Very Low |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Trivial  | Resolution:  fixed
 Keywords:  tor-spec, review-group-32, review-   |  Actual Points:
  group-34   |
Parent ID:   | Points:  0.1
 Reviewer:  nickm|Sponsor:
-+-
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Applied to torspec as 3e533e974b15d0. Thanks again!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25188 [Core Tor/Tor]: Spec bug in formal definition of Document in dir-spec.txt

[Tor Bug Tracker & Wiki]

#25188: Spec bug in formal definition of Document in dir-spec.txt
-+-
 Reporter:  witchof0x20  |  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Very Low |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Trivial  | Resolution:
 Keywords:  tor-spec, review-group-32, review-   |  Actual Points:
  group-34   |
Parent ID:   | Points:  0.1
 Reviewer:  nickm|Sponsor:
-+-

Comment (by nickm):

 Replying to [comment:7 witchof0x20]:
 > I can't immediately think of an ambiguity that would be fixed by this,
 but would it be worth it to also say 'A Keyword cannot be "-END"'?

 I think this change would make the current implementation incorrect, so
 I'm going to leave this part alone.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25188 [Core Tor/Tor]: Spec bug in formal definition of Document in dir-spec.txt

[Tor Bug Tracker & Wiki]

#25188: Spec bug in formal definition of Document in dir-spec.txt
-+-
 Reporter:  witchof0x20  |  Owner:  (none)
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Very Low |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Trivial  | Resolution:
 Keywords:  tor-spec, review-group-32, review-   |  Actual Points:
  group-34   |
Parent ID:   | Points:  0.1
 Reviewer:  nickm|Sponsor:
-+-

Comment (by nickm):

 Sorry for the delay: yes, that looks fine.  I'll apply it to torspec now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25188 [Core Tor/Tor]: Spec bug in formal definition of Document in dir-spec.txt

[Tor Bug Tracker & Wiki]

#25188: Spec bug in formal definition of Document in dir-spec.txt
---+---
 Reporter:  witchof0x20|  Owner:  (none)
 Type:  enhancement| Status:  needs_review
 Priority:  Very Low   |  Milestone:  Tor:
   |  0.3.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Trivial| Resolution:
 Keywords:  tor-spec, review-group-32  |  Actual Points:
Parent ID: | Points:  0.1
 Reviewer:  nickm  |Sponsor:
---+---
Changes (by teor):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25188 [Core Tor/Tor]: Spec bug in formal definition of Document in dir-spec.txt

[Tor Bug Tracker & Wiki]

#25188: Spec bug in formal definition of Document in dir-spec.txt
---+---
 Reporter:  witchof0x20|  Owner:  (none)
 Type:  enhancement| Status:  needs_revision
 Priority:  Very Low   |  Milestone:  Tor:
   |  0.3.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Trivial| Resolution:
 Keywords:  tor-spec, review-group-32  |  Actual Points:
Parent ID: | Points:  0.1
 Reviewer:  nickm  |Sponsor:
---+---

Comment (by witchof0x20):

 I can't immediately think of an ambiguity that would be fixed by this, but
 would it be worth it to also say 'A Keyword cannot be "-END"'?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25188 [Core Tor/Tor]: Spec bug in formal definition of Document in dir-spec.txt

[Tor Bug Tracker & Wiki]

#25188: Spec bug in formal definition of Document in dir-spec.txt
---+---
 Reporter:  witchof0x20|  Owner:  (none)
 Type:  enhancement| Status:  needs_revision
 Priority:  Very Low   |  Milestone:  Tor:
   |  0.3.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Trivial| Resolution:
 Keywords:  tor-spec, review-group-32  |  Actual Points:
Parent ID: | Points:  0.1
 Reviewer:  nickm  |Sponsor:
---+---

Comment (by witchof0x20):

 I attached a potential patch. How does this look?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25188 [Core Tor/Tor]: Spec bug in formal definition of Document in dir-spec.txt

[Tor Bug Tracker & Wiki]

#25188: Spec bug in formal definition of Document in dir-spec.txt
---+---
 Reporter:  witchof0x20|  Owner:  (none)
 Type:  enhancement| Status:  needs_revision
 Priority:  Very Low   |  Milestone:  Tor:
   |  0.3.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Trivial| Resolution:
 Keywords:  tor-spec, review-group-32  |  Actual Points:
Parent ID: | Points:  0.1
 Reviewer:  nickm  |Sponsor:
---+---
Changes (by witchof0x20):

 * Attachment "fix_document_ambiguity.patch" added.

 Patch for this issue

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25188 [Core Tor/Tor]: Spec bug in formal definition of Document in dir-spec.txt

[Tor Bug Tracker & Wiki]

#25188: Spec bug in formal definition of Document in dir-spec.txt
---+---
 Reporter:  witchof0x20|  Owner:  (none)
 Type:  enhancement| Status:  needs_revision
 Priority:  Very Low   |  Milestone:  Tor:
   |  0.3.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Trivial| Resolution:
 Keywords:  tor-spec, review-group-32  |  Actual Points:
Parent ID: | Points:  0.1
 Reviewer:  nickm  |Sponsor:
---+---
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 I think, given the amount of existing code out there,  we'd be better off
 changing the spec to match the implementation.  Is that something you'd be
 able to write a patch for, or would you like somebody else to take this
 over?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25188 [Core Tor/Tor]: Spec bug in formal definition of Document in dir-spec.txt

[Tor Bug Tracker & Wiki]

#25188: Spec bug in formal definition of Document in dir-spec.txt
---+---
 Reporter:  witchof0x20|  Owner:  (none)
 Type:  enhancement| Status:  needs_review
 Priority:  Very Low   |  Milestone:  Tor:
   |  0.3.4.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Trivial| Resolution:
 Keywords:  tor-spec, review-group-32  |  Actual Points:
Parent ID: | Points:  0.1
 Reviewer:  nickm  |Sponsor:
---+---
Changes (by nickm):

 * reviewer:   => nickm


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25188 [Core Tor/Tor]: Spec bug in formal definition of Document in dir-spec.txt

[Tor Bug Tracker & Wiki]

#25188: Spec bug in formal definition of Document in dir-spec.txt
--+
 Reporter:  witchof0x20   |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Very Low  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Trivial   | Resolution:
 Keywords:  tor-spec  |  Actual Points:
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 Hm. I like this change, but it wouldn't match the current implementation.
 We should decide whether or not we like this better than the current
 behavior, and (if we want to change it) how to change it in a maximally
 privacy-friendly way.

 The current implementation is something more like 'a keyword may not be "
 -BEGIN"'.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25188 [Core Tor/Tor]: Spec bug in formal definition of Document in dir-spec.txt

[Tor Bug Tracker & Wiki]

#25188: Spec bug in formal definition of Document in dir-spec.txt
--+
 Reporter:  witchof0x20   |  Owner:  (none)
 Type:  enhancement   | Status:  needs_review
 Priority:  Very Low  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Trivial   | Resolution:
 Keywords:  tor-spec  |  Actual Points:
Parent ID:| Points:  0.1
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  new => needs_review
 * points:   => 0.1
 * milestone:   => Tor: 0.3.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs